[GitHub] groovy pull request #345: GROOVY-7853: o.c.g.r.t.DefaultTypeTransformation d...

2016-06-02 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/345 GROOVY-7853: o.c.g.r.t.DefaultTypeTransformation does not apply the r… …ight toString on primitve arrays when transforming to String You can merge this pull request into a Git repository

[GitHub] groovy pull request #348: Groovy7860

2016-06-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/348 Groovy7860 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7860 Alternatively you can review and apply

[GitHub] groovy pull request #334: GROOVY-7750: @Lazy allows instantiation of abstrac...

2016-06-01 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/334 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #352: GROOVY-7865: Better error message in the presence ...

2016-06-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/352 GROOVY-7865: Better error message in the presence of Generics arity e… …rrors (spike) You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #353: GROOVY-7865: Better error message and earlier dete...

2016-06-23 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/353 GROOVY-7865: Better error message and earlier detection of Generics errors reworked version You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #352: GROOVY-7865: Better error message in the presence ...

2016-06-24 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform

2016-06-25 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/348#discussion_r68484985 --- Diff: src/main/groovy/transform/Undefined.java --- @@ -28,6 +28,10 @@ private Undefined() {} public static final String STRING

[GitHub] groovy pull request: GROOVY-7761: Groovydoc incorrectly rejects do...

2016-02-21 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/268 GROOVY-7761: Groovydoc incorrectly rejects dollar signs and mucks up … …some backslashes during @code tag replacement. (closes #268) You can merge this pull request into a Git repository

[GitHub] groovy pull request: GROOVY-7773: Enum constructor with value thro...

2016-03-03 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/279 GROOVY-7773: Enum constructor with value throws "unexpected token" er… …ror (closes #279) You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request:

2016-03-03 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/120aee1226f8dbe2b7eb42ea77f9239e520c7103#commitcomment-16470689 In src/main/groovy/transform/AnnotationCollector.java: In src/main/groovy/transform/AnnotationCollector.java on line 79

[GitHub] groovy pull request: GROOVY-7841: Assert fails when accessing part...

2016-05-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/338 GROOVY-7841: Assert fails when accessing particular primitive values … …with @CompileStatic You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request: GROOVY-7750: @Lazy allows instantiation of ab...

2016-05-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/334 GROOVY-7750: @Lazy allows instantiation of abstract class You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7750

[GitHub] groovy pull request: GROOVY-7841: Assert fails when accessing part...

2016-05-25 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/338#discussion_r64549052 --- Diff: src/main/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java --- @@ -134,15 +134,19 @@ public void visit(final

[GitHub] groovy pull request #372: GROOVY-7876 - ClassCastException when calling Defa...

2016-07-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/372 GROOVY-7876 - ClassCastException when calling DefaultTypeTransformati… …on#compareEqual (additional refactoring) You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #376: GROOVY-7774: Collection addAll fails CompileStatic...

2016-07-31 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/376#discussion_r72923109 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -5169,12 +5170,13 @@ public static Map groupBy(Object[] self, List

[GitHub] groovy pull request #376: GROOVY-7774: Collection addAll fails CompileStatic...

2016-07-29 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/376 GROOVY-7774: Collection addAll fails CompileStatic type checking when… … adding a collection of subtypes You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #382: GROOVY-7880: Diamond Operator for own class causes...

2016-08-10 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/382 GROOVY-7880: Diamond Operator for own class causes NullPointerExcepti… …on if Static Compilation is enabled You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #383: GROOVY-7905: ListWithDefault DGM methods aren't ty...

2016-08-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/383 GROOVY-7905: ListWithDefault DGM methods aren't type inference friendly You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-13 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70736863 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-13 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70736954 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-13 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70740827 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/366 GROOVY-7877: The Range abstraction could support numeric ranges where… … the items in the range differ by some step size different to 1 You can merge this pull request into a Git repository

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-14 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70777404 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-20 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r71630179 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,603 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #:

2016-07-15 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/a903c9e330af224006380af0f56afa98c0cc6b64#commitcomment-18259964 In src/main/groovy/lang/ObjectRange.java: In src/main/groovy/lang/ObjectRange.java on line 237: You're right

[GitHub] groovy pull request #367: GROOVY-7600: @Immutable support for Optional?

2016-07-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/367 GROOVY-7600: @Immutable support for Optional? You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7600 Alternatively

[GitHub] groovy pull request #368: GROOVY-7876: ClassCastException when calling Defau...

2016-07-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/368 GROOVY-7876: ClassCastException when calling DefaultTypeTransformatio… …n#compareEqual You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-16 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r71063003 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -385,26 +385,23 @@ public void step(int step, Closure closure) { return; // from

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-14 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70920102 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,603 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70927754 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #366: GROOVY-7877: The Range abstraction could support n...

2016-07-14 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/366#discussion_r70920341 --- Diff: src/main/groovy/lang/NumberRange.java --- @@ -0,0 +1,536 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-15 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r71060369 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -385,26 +385,23 @@ public void step(int step, Closure closure) { return; // from

[GitHub] groovy pull request #359: GROOVY-7877: Range step method could work with Num...

2016-07-05 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180330 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -379,32 +379,25 @@ public boolean containsAll(Collection other) { @Override public

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180377 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -493,40 +495,52 @@ public void remove() { /** * Increments by step size

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180474 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -261,16 +260,12 @@ public T get(int index) { @Override public boolean

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180503 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -220,13 +219,15 @@ public boolean equals(ObjectRange that) { } @Override

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180536 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -518,25 +496,41 @@ private T peek() { } /** - * Increments by one

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70180723 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -493,40 +495,52 @@ public void remove() { /** * Increments by step size

[GitHub] groovy pull request #:

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/380ae614ae4d979f00e6e362d210e2dd1295bdce#commitcomment-18187118 In build.gradle: In build.gradle on line 142: I noticed that this broke japicmp. I know we have that disabled

[GitHub] groovy pull request #360: `ObjectRange` and `IntRange` iteration and steppin...

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r70181071 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -537,8 +539,9 @@ protected Object increment(Object value) { * @param value the value

[GitHub] groovy pull request #:

2016-07-10 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/ffc24888098019383272c66d90e746bb4139a74e#commitcomment-18186653 In src/main/groovy/lang/ObjectRange.java: In src/main/groovy/lang/ObjectRange.java on line 384: My preference

[GitHub] groovy pull request #379: GROOVY-6245: @EqualsAndHashCode assumes get style ...

2016-08-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/379 GROOVY-6245: @EqualsAndHashCode assumes get style getters for boolean… … properties You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #380: GROOVY-5752: DelegateASTTransformation#addGetterIf...

2016-08-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/380 GROOVY-5752: DelegateASTTransformation#addGetterIfNeeded doesn't take… … boolean isX accessors into account You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #:

2016-08-07 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18553681 In src/spec/test/SyntaxTest.groovy: In src/spec/test/SyntaxTest.groovy on line 169: I think we should delete

[GitHub] groovy pull request #376: GROOVY-7774: Collection addAll fails CompileStatic...

2016-08-01 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/376#discussion_r73069688 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -5176,7 +5176,9 @@ public static Map groupBy(Object[] self, List closures

[GitHub] groovy pull request #359: GROOVY-7877: Range step method could work with Num...

2016-06-29 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/359 GROOVY-7877: Range step method could work with Number not just int (a… …lternative utility method implementation) You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #385: GROOVY-7907: Cannot assign value of type java.lang...

2016-08-16 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/385 GROOVY-7907: Cannot assign value of type java.lang.Object with vararg… …s, perameterized method and @CompileStatic You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #491: GROOVY-8068: improper logging in groovy.sql.Sql

2017-02-07 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/491 GROOVY-8068: improper logging in groovy.sql.Sql You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8068

[GitHub] groovy pull request #491: GROOVY-8068: improper logging in groovy.sql.Sql

2017-02-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/491#discussion_r99928551 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java --- @@ -578,17 +578,26 @@ public static Sql newInstance(Map<String, Object>

[GitHub] groovy pull request #492: GROOVY-8048: final fields for pre-compiled traits ...

2017-02-07 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/492 GROOVY-8048: final fields for pre-compiled traits aren't processed co… …rrectly You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #488: GROOVY-8030: An unexpected error has occurred when...

2017-02-03 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/488 GROOVY-8030: An unexpected error has occurred when using 'kkk = kkk +… … 12' You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert

[GitHub] groovy pull request #478: GROOVY-8060: @Log annotation does not check loggin...

2017-01-23 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/478 GROOVY-8060: @Log annotation does not check logging enablement inside… … closures which are arguments to methods You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #480: GROOVY-8065: Map created as org.springframework.ht...

2017-01-26 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/480 GROOVY-8065: Map created as org.springframework.http.HttpHeaders is e… …mpty in 2.4.8, works fine in 2.4.7 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #482: GROOVY-8066: protected fields should be disallowed...

2017-01-26 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/482 GROOVY-8066: protected fields should be disallowed in traits You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8066

[GitHub] groovy pull request #479: GROOVY-5318: generic types in fully-qualified clas...

2017-01-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/479 GROOVY-5318: generic types in fully-qualified class names parsing error You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #483: GROOVY-8026: Matcher indexed via IntRange with sta...

2017-01-26 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/483 GROOVY-8026: Matcher indexed via IntRange with startIdx..-1 does not … …return "intermediate" range matches You can merge this pull request into a Git repository by running:

[GitHub] groovy pull request #499: GROOVY-7402: Compiler NPE Related To AST Transform...

2017-02-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/499 GROOVY-7402: Compiler NPE Related To AST Transformations And Traits You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #497: GROOVY-8087: bump log4j2 version

2017-02-14 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/497 GROOVY-8087: bump log4j2 version You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8087 Alternatively you can

[GitHub] groovy pull request #498: GROOVY-8088: For @MapConstructor and @TupleConstru...

2017-02-14 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/498 GROOVY-8088: For @MapConstructor and @TupleConstructor we should prov… …ide a default undefined value for better Java compatibility You can merge this pull request into a Git repository

[GitHub] groovy pull request #495: GROOVY-8082: Groovy sql.rows returns org.postgresq...

2017-02-09 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/495 GROOVY-8082: Groovy sql.rows returns org.postgresql.util.PSQLExceptio… …n: No hstore extension installed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #505: GROOVY-6792: ClassFormatError if a method has dots...

2017-02-27 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/505 GROOVY-6792: ClassFormatError if a method has dots within its name Provide a friendly error message for now - we can remove (some of) the checks if we find a good way to encode special chars

[GitHub] groovy pull request #395: Document error fix

2016-08-25 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/395#discussion_r76236312 --- Diff: src/spec/test/DesignPatternsTest.groovy --- @@ -204,7 +204,7 @@ class DesignPatternsTest extends CompilableTestSupport { // tag

[GitHub] groovy pull request #396: GROOVY-5396: Groovy classes can't see package-loca...

2016-08-25 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/396 GROOVY-5396: Groovy classes can't see package-local properties from a… … super class You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #414: GROOVY-6831: Access to private static fields from ...

2016-09-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/414 GROOVY-6831: Access to private static fields from within inner classe… …s is inconsistent You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #404: GROOVY-6764: Problem Referring To Statically Impor...

2016-08-31 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/404 GROOVY-6764: Problem Referring To Statically Imported Constants You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #405: GROOVY-7497: GroovyDoc reports only last method of...

2016-08-31 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/405 GROOVY-7497: GroovyDoc reports only last method of a script You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7497

[GitHub] groovy pull request #411: GROOVY-7925: 'this' and 'super' as LHS of an assig...

2016-09-11 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/411 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #419: GROOVY-6396: same linkedlist code different behavi...

2016-09-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/419 GROOVY-6396: same linkedlist code different behavior between groovy a… …nd java You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #418: GROOVY-7937: CLONE - same linkedlist code differen...

2016-09-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/418 GROOVY-7937: CLONE - same linkedlist code different behavior between … …groovy and java (fix priority of DGM methods vs actual methods on an object) You can merge this pull request

[GitHub] groovy pull request #437: GROOVY-7958: Incorrect parsing of comma-separated ...

2016-10-05 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/437#discussion_r82088116 --- Diff: src/test/groovy/bugs/Groovy7958Bug.groovy --- @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #436: GROOVY-7952: Property expressions for extension me...

2016-10-05 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/436#discussion_r82111762 --- Diff: src/main/org/codehaus/groovy/classgen/asm/sc/StaticTypesCallSiteWriter.java --- @@ -158,19 +158,24 @@ public void makeGetPropertySite

[GitHub] groovy pull request #437: GROOVY-7958: Incorrect parsing of comma-separated ...

2016-10-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/437 GROOVY-7958: Incorrect parsing of comma-separated variable declaratio… …n as single statement after if/while/for You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #435: GROOVY-7955: Groovydoc fails to parse Java source ...

2016-10-04 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/435 GROOVY-7955: Groovydoc fails to parse Java source files containing th… …e diamond operator You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512017 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512093 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512083 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512068 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512201 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512190 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511934 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511943 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82511988 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512007 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512035 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82512182 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -2829,6 +2829,153 @@ to use the Groovy Console, in particular the AST browser tool, to gain

[GitHub] groovy pull request #371: Serialization options for JsonOutput

2016-10-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/371#discussion_r82374539 --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java --- @@ -601,4 +280,966 @@ public String toString

[GitHub] groovy pull request #371: Serialization options for JsonOutput

2016-10-07 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/371#discussion_r82341071 --- Diff: subprojects/groovy-json/src/main/java/groovy/json/JsonOutput.java --- @@ -492,7 +171,7 @@ private static void writeIterator(Iterator iterator

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-09 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82532117 --- Diff: src/spec/test/metaprogramming/MacroVariableSubstitutionTest.groovy --- @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

[GitHub] groovy pull request #383: GROOVY-7905: ListWithDefault DGM methods aren't ty...

2016-09-18 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #420: GROOVY-7940: @Lazy not generating "is" property ac...

2016-09-17 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/420#discussion_r79292382 --- Diff: src/main/org/codehaus/groovy/transform/LazyASTTransformation.java --- @@ -156,8 +156,11 @@ private static void addNonThreadSafeBody

[GitHub] groovy pull request #423: GROOVY-7942: @Lazy transform creates unneeded gett...

2016-09-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/423 GROOVY-7942: @Lazy transform creates unneeded getter/setter for backi… …ng store field You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #425: GROOVY-6831: Access to static fields/properties fr...

2016-09-18 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/425 GROOVY-6831: Access to static fields/properties from within inner cla… …sses is inconsistent You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #426: GROOVY-7941: MissingMethodException should limit a...

2016-09-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/426 GROOVY-7941: MissingMethodException should limit argument types in ge… …tMessage() You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk

[GitHub] groovy pull request #414: GROOVY-6831: Access to private static fields from ...

2016-09-18 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] groovy pull request #428: GROOVY-7930: @SelfType in hierarchy with an interf...

2016-09-21 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/428 GROOVY-7930: @SelfType in hierarchy with an interface in the middle You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy

[GitHub] groovy pull request #399: GROOVY-7920: Simple getAt example produces a BUG e...

2016-08-26 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/399 GROOVY-7920: Simple getAt example produces a BUG exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy7920

[GitHub] groovy pull request #397: GROOVY-7916: MissingPropertyException when accessi...

2016-08-26 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/397#discussion_r76406515 --- Diff: src/main/org/codehaus/groovy/control/ResolveVisitor.java --- @@ -852,6 +858,21 @@ protected Expression transformPropertyExpression

[GitHub] groovy pull request #392: GROOVY-7912: MissingPropertyException when referen...

2016-08-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/392 GROOVY-7912: MissingPropertyException when referencing a static impor… …t in a closure's optional parameters You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #393: GROOVY-4356: Static members should not be able to ...

2016-08-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/393 GROOVY-4356: Static members should not be able to access class-level … …generic types You can merge this pull request into a Git repository by running: $ git pull https://github.com

  1   2   3   >