Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

alievmirza closed pull request #3422: IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys URL: https://github.com/apache/ignite-3/pull/3422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

alievmirza commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1571989887 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -99,6 +109,8 @@ public class LeaseTracker

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1567664179 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -630,6 +674,57 @@ public CompletableFuture start() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1566928638 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -630,6 +674,57 @@ public CompletableFuture start() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

alievmirza commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565972714 ## modules/placement-driver-api/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriver.java: ## @@ -88,4 +90,24 @@ CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#issuecomment-2057170493 Everything else looks fine for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1566002855 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -416,17 +416,44 @@ private void

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565992323 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1459,12 +1467,6 @@ private CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565949687 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -596,10 +611,18 @@ public class IgniteImpl implements Ignite {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

alievmirza commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565930141 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java: ## @@ -141,6 +152,34 @@ public CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565902483 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -416,17 +416,44 @@ private void

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1565873049 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -596,10 +611,18 @@ public class IgniteImpl implements Ignite {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562422376 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -596,10 +611,18 @@ public class IgniteImpl implements Ignite {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562411807 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1459,12 +1467,6 @@ private CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562411807 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ## @@ -1459,12 +1467,6 @@ private CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562409318 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/Replica.java: ## @@ -141,6 +152,34 @@ public CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562408439 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -630,6 +674,57 @@ public CompletableFuture start() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562402474 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java: ## @@ -444,7 +453,8 @@ private void

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562396154 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -309,7 +311,7 @@ public class IgniteImpl implements Ignite { private

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

alievmirza commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1560850169 ## modules/placement-driver-api/src/main/java/org/apache/ignite/internal/placementdriver/PlacementDriver.java: ## @@ -88,4 +90,23 @@ CompletableFuture

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562396154 ## modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java: ## @@ -309,7 +311,7 @@ public class IgniteImpl implements Ignite { private

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562394152 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java: ## @@ -1832,8 +1850,10 @@ private Set

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562389518 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -630,6 +674,57 @@ public CompletableFuture start() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562386338 ## modules/placement-driver/src/test/java/org/apache/ignite/internal/placementdriver/LeaseTrackerTest.java: ## @@ -73,7 +75,8 @@ public void testLeaseCleanup() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562383712 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/negotiation/LeaseAgreement.java: ## @@ -116,6 +117,19 @@ public String

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562380478 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java: ## @@ -210,11 +223,15 @@ public byte[] bytes() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562380218 ## modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngineTest.java: ## @@ -295,7 +294,7 @@

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562370063 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -131,6 +133,7 @@

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562366972 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/DistributionZoneRebalanceEngine.java: ## @@ -375,72 +362,61 @@

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

vldpyatkov commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562336139 ## modules/client-handler/src/testFixtures/java/org/apache/ignite/client/handler/FakePlacementDriver.java: ## @@ -136,6 +138,25 @@ public HybridTimestamp

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1560663770 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java: ## @@ -131,6 +133,7 @@

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1560620604 ## modules/table/src/integrationTest/java/org/apache/ignite/distributed/ItTxDistributedTestThreeNodesThreeReplicas.java: ## @@ -76,6 +76,9 @@ public void

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1560068384 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java: ## @@ -210,11 +223,15 @@ public byte[] bytes() {

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

JAkutenshi commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1560045650 ## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java: ## @@ -138,8 +140,8 @@ public static