Re: [jclouds/jclouds] Added Virtual Network Gateway Connection API (#1222)

2018-07-06 Thread Ignasi Barrera
Closed #1222. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1222#event-1719716852

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-05 Thread Ignasi Barrera
>RESOURCE_BUSY - Another operation is in progress on an asset. Could >alternatively be mapped to ConcurrentModificationException. But it is not on >the list of exceptions allowed to propagate. Looks like a good candidate to be added to the list. Wanna add it too and use that exception here?

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS initial skeleton (#438)

2018-07-05 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/438#pullrequestreview-134584676

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-05 Thread Ignasi Barrera
Thanks, @FileIOUtility! LGTM >From the discussion about response codes, I've revisited the error handler and >there are some errors we could consider propagating better: ```java case 400: if (message.contains("RESOURCE_NOT_FOUND") || message.contains("OPERATION_NOT_SUPPORTED")) {

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-05 Thread Ignasi Barrera
nacx approved this pull request. > @@ -121,10 +121,9 @@ public void testListServersWithDatacenterFiltering() > throws Exception { return Uris.uriBuilder("/caas/2.4/6ac1e746-b1ea-4da5-a24e-caf1a978789d/server/server"); } - public void testListServers_404() throws Exception { -

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS initial skeleton (#438)

2018-07-04 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -52,15 +52,15 @@ @Consumes(MediaType.APPLICATION_JSON) @RequestFilters(FormSign.class) @QueryParams(keys = {"Version", "Format", "SignatureVersion", "ServiceCode", "SignatureMethod"}, -values = {"2014-05-26", "JSON", "1.0", "ecs",

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-04 Thread Ignasi Barrera
nacx commented on this pull request. Thanks @FileIOUtility! > @@ -68,21 +68,19 @@ @GET @Path("/server") @ResponseParser(ParseServers.class) - @Fallback(Fallbacks.EmptyIterableWithMarkerOnNotFoundOr404.class) This is a behavior change since this method will now fail upon 4xx

[jclouds/jclouds] Fix GCE live tests (#1223)

2018-07-04 Thread Ignasi Barrera
It looks like the zone parameter no longer comes in the responses. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1223 -- Commit Summary -- * Fix GCE live tests -- File Changes -- M

[jclouds/jclouds] Added Virtual Network Gateway Connection API (#1222)

2018-07-04 Thread Ignasi Barrera
Live test results: ``` --- T E S T S --- Running org.jclouds.azurecompute.arm.features.VirtualNetworkGatewayConnectionApiLiveTest Configuring TestNG with: TestNG652Configurator Jul 04, 2018

Re: [jclouds/jclouds-labs] [JCLOUDS-1430] Aliyun ECS initial skeleton (#438)

2018-07-03 Thread Ignasi Barrera
nacx commented on this pull request. > +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the

Re: [jclouds/jclouds] Added Virtual Network Gateway API (#1221)

2018-07-03 Thread Ignasi Barrera
Closed #1221. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1221#event-1713692378

Re: [jclouds/jclouds] Added Virtual Network Gateway API (#1221)

2018-07-03 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ea5b899d) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9705aa7f). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jira] [Commented] (JCLOUDS-1166) Remove uses of the 'com.google.gson.internal' package

2018-07-03 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16531179#comment-16531179 ] Ignasi Barrera commented on JCLOUDS-1166: - There have not been more discussions around

Re: [jclouds/jclouds] Added Virtual Network Gateway API (#1221)

2018-07-02 Thread Ignasi Barrera
Live test output: ``` --- T E S T S --- Running org.jclouds.azurecompute.arm.features.VirtualNetworkGatewayApiLiveTest Configuring TestNG with: TestNG652Configurator Starting test

Re: [jclouds/jclouds] Added Virtual Network Gateway API (#1221)

2018-07-02 Thread Ignasi Barrera
@nacx pushed 1 commit. 9388c50 Fix checkstyle violations -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds/pull/1221/files/ca5cdb6dffac20b210d3c7c2caf83fee0279bcca..9388c501085fbbf93ae8abc7ea0b5d80c179a914

[jclouds/jclouds] Added Virtual Network Gateway API (#1221)

2018-07-02 Thread Ignasi Barrera
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1221 -- Commit Summary -- * Added Virtual Network Gateway API -- File Changes -- M providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/AzureComputeApi.java (11)

[jira] [Commented] (JCLOUDS-1379) incompatible instance types selected in new AWS regions

2018-07-02 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16529542#comment-16529542 ] Ignasi Barrera commented on JCLOUDS-1379: - I also think it is worth trying, but we need to have

Re: [jclouds/jclouds] Implements VirtualMachineAPI deallocate operation (#1220)

2018-06-29 Thread Ignasi Barrera
nacx commented on this pull request. Please, add the corresponding mock test. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1220#pullrequestreview-133397328

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-06-26 Thread Ignasi Barrera
@danielestevez any plans ti implement the cleanup improvements in this PR? If not feel free to close it and open a new one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

2018-06-26 Thread Ignasi Barrera
Closed #1214. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1214#event-1700614179

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-06-26 Thread Ignasi Barrera
Closed #1215. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1215#event-1700613144

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

2018-06-26 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3171e4c7) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d8257ae4). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-06-26 Thread Ignasi Barrera
Squashed and pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/39d770ff) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ff95137f). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

2018-06-26 Thread Ignasi Barrera
Closed #1219. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1219#event-1700612166

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

2018-06-26 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/23e783e0) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/0ae9e5a0). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

[jira] [Commented] (JCLOUDS-1429) Unnecessary logs are coming while connecting to s3 buckets of aws through jcloud.

2018-06-25 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523234#comment-16523234 ] Ignasi Barrera commented on JCLOUDS-1429: - Verbose logs should not be a jclouds issue. Why

[jira] [Commented] (JCLOUDS-693) Support OpenStack Orchestration (Heat) API

2018-06-25 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523231#comment-16523231 ] Ignasi Barrera commented on JCLOUDS-693: Yes you can and please, do it. Being in labs does

Re: [jclouds/jclouds] Adds new Generally Available azure locations for Australia and France (#1219)

2018-06-22 Thread Ignasi Barrera
nacx requested changes on this pull request. > @@ -54,13 +54,17 @@ BRAZIL_SOUTH("Brazil South", "BR"), AUSTRALIA_EAST("Australia East", "AU-NSW"), AUSTRALIA_SOUTH_EAST("Australia Southeast", "AU-VIC"), + AUSTRALIA_CENTRAL("Australia Central", "AU-ACT"), +

[jira] [Resolved] (JCLOUDS-1427) NPE when deserializing Elastic IPs that have tags

2018-06-20 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1427. - Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 > NPE w

Re: [jclouds/jclouds] JCLOUDS-1427: Fix Elastic IP deserialization when IP has tags (#1218)

2018-06-20 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/6b4be0d6) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/ef486984). Thanks @luciaems! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] JCLOUDS-1427: Fix Elastic IP deserialization when IP has tags (#1218)

2018-06-20 Thread Ignasi Barrera
Closed #1218. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1218#event-1691139754

[jira] [Created] (JCLOUDS-1427) NPE when deserializing Elastic IPs that have tags

2018-06-19 Thread Ignasi Barrera (JIRA)
Ignasi Barrera created JCLOUDS-1427: --- Summary: NPE when deserializing Elastic IPs that have tags Key: JCLOUDS-1427 URL: https://issues.apache.org/jira/browse/JCLOUDS-1427 Project: jclouds

Re: [jclouds/jclouds] Fixes/adds fields primary for NetworkInterfaceCard (#1217)

2018-06-15 Thread Ignasi Barrera
Closed #1217. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1217#event-1682744535

Re: [jclouds/jclouds] Fixes/adds fields primary for NetworkInterfaceCard (#1217)

2018-06-15 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e4f1823f) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cace304e). Thanks @danielestevez! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Fixes/adds fields primary for NetworkInterfaceCard (#1217)

2018-06-15 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1217#pullrequestreview-129057528

Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-12 Thread Ignasi Barrera
nacx commented on this pull request. > + // Make sure the resource is fully provisioned before deleting it + waitUntilAvailable(name); + URI uri = api().delete(name); + assertResourceDeleted(uri); + } + + private LocalNetworkGatewayApi api() { + return

Re: [jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-11 Thread Ignasi Barrera
Live test result: ```bash --- T E S T S --- Running org.jclouds.azurecompute.arm.features.LocalNetworkGatewayApiLiveTest Configuring TestNG with: TestNG652Configurator Starting test

[jclouds/jclouds] Added Local Network Gateway API (#1216)

2018-06-11 Thread Ignasi Barrera
This PR adds the Local Gateway Network API and is the first of a set of PRs that will add support for configuring VPNs in Azure ARM: https://docs.microsoft.com/en-us/rest/api/network-gateway/ You can view, comment on, or merge this pull request online at:

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-29 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1215#pullrequestreview-124173143

Re: [jclouds/jclouds] Adds minor improvements to readability (#1215)

2018-05-29 Thread Ignasi Barrera
nacx commented on this pull request. > throw exception(name, "Should start with letter/number"); CharMatcher range = getAcceptableRange(); if (!range.matchesAllOf(name)) - throw exception(name, "Should have lowercase or uppercase ASCII letters, numbers, or

Re: [jclouds/jclouds] Checks network availability before working with created networks (#1214)

2018-05-29 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1214#pullrequestreview-124156894

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-25 Thread Ignasi Barrera
Pushed to master and 2.1.x. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1213#issuecomment-391969708

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-25 Thread Ignasi Barrera
Closed #1213. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1213#event-1646000469

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-25 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1213#pullrequestreview-123270045

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-23 Thread Ignasi Barrera
This PR is about fixing the cleanup. As discussed previously that should be better achieved by tagging the implicit security groups jclouds creates. I'm ok at using this PR to implent this, or to close it and open a follow-up one. Up to you @danielestevez! And thanks for all the recent patches!

Re: [jclouds/jclouds] Adds new more relaxed validator for Azure entities (#1213)

2018-05-23 Thread Ignasi Barrera
Please add unit tests that verify the validator and test the corner cases. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1213#issuecomment-391515264

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-22 Thread Ignasi Barrera
According to [this](http://karaf.922171.n3.nabble.com/compilation-failing-with-karaf-4-2-0-M2-td4052701.html) it looks like that Maven >= 3.3.x is needed for the `karaf-maven-plugin` which we use to validate the features can be installed. I'd suggest configuring the `maven-enforcer-plugin` in

Re: [jclouds/jclouds-karaf] upgrade to java 8 (#108)

2018-05-22 Thread Ignasi Barrera
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/108#issuecomment-391017105

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

2018-05-22 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-122199296

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-22 Thread Ignasi Barrera
Merged t [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/b76a594e) ([labs](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/331fd685)) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3878e6a6)

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-22 Thread Ignasi Barrera
Closed #1210. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1210#event-1639491145

[jira] [Resolved] (JCLOUDS-1421) Images created by the ImageExtension may lack the mandatory default credentials

2018-05-22 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1421. - Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 > Images crea

Re: [jclouds/jclouds] JCLOUDS-1333: Require JDK 1.8 (#1197)

2018-05-18 Thread Ignasi Barrera
That's fantastic. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1197#issuecomment-390352688

[jira] [Updated] (JCLOUDS-1421) Images created by the ImageExtension may lack the mandatory default credentials

2018-05-18 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1421: Summary: Images created by the ImageExtension may lack the mandatory default credentials

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-18 Thread Ignasi Barrera
FTR: [JCLOUDS-1421](https://issues.apache.org/jira/browse/JCLOUDS-1421) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1210#issuecomment-390135482

[jira] [Created] (JCLOUDS-1421) Images created by the ImageExtension may lack teh mandatory default credentials

2018-05-18 Thread Ignasi Barrera (JIRA)
Ignasi Barrera created JCLOUDS-1421: --- Summary: Images created by the ImageExtension may lack teh mandatory default credentials Key: JCLOUDS-1421 URL: https://issues.apache.org/jira/browse/JCLOUDS-1421

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Ignasi Barrera
Well, yes and no :) @danielestevez is working on fixing jclouds to properly support Azure CanadaEast region. The issue is that the Azure API sometimes returns the region name lowercase, sometimes camelcase, etc, and that messes things up when it comes to filter by location and do several

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Ignasi Barrera
>However testImageIsRemovedFromCacheAfterDeletion still fails it >testSpawnNodeFromImage is enabled but that's a different issue. I've just run the `AzureComputeImageExtensionLiveTest` in `northeurope` and with this change all pass: ```bash Running

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-17 Thread Ignasi Barrera
Thanks, @danielestevez. I've just added a comment to your commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1202#issuecomment-389865682

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Ignasi Barrera
nacx commented on this pull request. > + // Otherwise fallback to the image default credentials strategy + if (template instanceof CloneImageTemplate) { + final CloneImageTemplate cloneImageTemplate = (CloneImageTemplate) template; + future = Futures.transform(future,

Re: [jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-17 Thread Ignasi Barrera
@nacx pushed 1 commit. 3d44352 Add default credentials for all ImageTemplate types -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

2018-05-17 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a918550e) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/6edb99c6). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

2018-05-17 Thread Ignasi Barrera
Closed #1209. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1209#event-1631251748

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-17 Thread Ignasi Barrera
Closed #1207. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1207#event-1631249749

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-17 Thread Ignasi Barrera
Cherry-picked to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/889a7f1d). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1205#issuecomment-389768687

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-17 Thread Ignasi Barrera
Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/bdb9a3af) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/45230c87). Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[jira] [Resolved] (JCLOUDS-1418) The Azure ARM provider is missing several statuses for the PowerState enum

2018-05-16 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1418. - Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 > The Azure

Re: [jclouds/jclouds] JCLOUDS-1418: Add missing PowerState values (#1208)

2018-05-16 Thread Ignasi Barrera
And cherry-picked to [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cce23c1f). -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1208#issuecomment-389475531

Re: [jclouds/jclouds] Fixes assert for IpPermissions collection (#1209)

2018-05-16 Thread Ignasi Barrera
Thanks @danielestevez! Can you check and fix the checkstyle violations in the ARM provider? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1209#issuecomment-389469592

[jclouds/jclouds] Add default credentials to images created by the ImageExtension (#1210)

2018-05-16 Thread Ignasi Barrera
By default, when listing images the ComputeServiceAdapter adds the default credentials for each image. This is not done when images are created by the image extension, and NPEs can appear in code that assumes the default credentials are there, as the field is not nullable. This change tries to

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-15 Thread Ignasi Barrera
> does this cover the cases that were discussed in the previous PR? I think so :) Goot to merge @demobox? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1207#issuecomment-389185657

Re: [jclouds/jclouds] Uses default password with conflictive characters (#1207)

2018-05-15 Thread Ignasi Barrera
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1207#pullrequestreview-120256478

[jclouds/jclouds] JCLOUDS-1418: Add missing PowerState values (#1208)

2018-05-15 Thread Ignasi Barrera
https://issues.apache.org/jira/browse/JCLOUDS-1418 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1208 -- Commit Summary -- * JCLOUDS-1418: Add missing PowerState values -- File Changes -- M

[jira] [Created] (JCLOUDS-1418) The Azure ARM provider is missing several statuses for the PowerState enum

2018-05-15 Thread Ignasi Barrera (JIRA)
Ignasi Barrera created JCLOUDS-1418: --- Summary: The Azure ARM provider is missing several statuses for the PowerState enum Key: JCLOUDS-1418 URL: https://issues.apache.org/jira/browse/JCLOUDS-1418

[jira] [Assigned] (JCLOUDS-1418) The Azure ARM provider is missing several statuses for the PowerState enum

2018-05-15 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera reassigned JCLOUDS-1418: --- Assignee: Ignasi Barrera > The Azure ARM provider is missing several statu

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-14 Thread Ignasi Barrera
nacx commented on this pull request. > @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() { expect(sshClient.getUsername()).andReturn("tester"); expect(sshClient.getHostAddress()).andReturn("somewhere.example.com"); expect( -sshClient.exec("sudo -S

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-14 Thread Ignasi Barrera
Closed #216. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#event-1624206074

Re: [jclouds/jclouds-site] JCLOUDS-1414: Keystone authentication improvment (#216)

2018-05-14 Thread Ignasi Barrera
Merged and published. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/216#issuecomment-388736278

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Ignasi Barrera
Closed #1206. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1206#event-1622909006

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Ignasi Barrera
>It should be safe to increase this value in the provider metadata. 5 minutes >looks good but open to discuss Looks like a sane default. Merged to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a08de5b2) and

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Ignasi Barrera
The build failed. It looks like there's a missing static import. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1206#issuecomment-388498018

Re: [jclouds/jclouds] Increases session interval from 60 seconds to a higher value (#1206)

2018-05-11 Thread Ignasi Barrera
>Would be good to add this also to >https://github.com/danielestevez/jclouds/blob/83c0a3c7b255ec744c6150ce76c40e8301280c79/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/internal/AzureLiveTestUtils.java > ? That class just adds *overrides* for default provider properties,

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-11 Thread Ignasi Barrera
Closed #1205. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1205#event-1622778189

Re: [jclouds/jclouds] Fixes Run SSH script for passwords with special characters (#1205)

2018-05-11 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/82289948). @andreaturli I think the change is safe enough to cherry-pick it to 2.1.x, WDYT? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds-site] JCLOUDS-1414: Fix "since" version for PROJECT-DOMAIN-XXX props (#215)

2018-05-10 Thread Ignasi Barrera
Merged and published! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/215#issuecomment-388178634

Re: [jclouds/jclouds-site] JCLOUDS-1414: Fix "since" version for PROJECT-DOMAIN-XXX props (#215)

2018-05-10 Thread Ignasi Barrera
Closed #215. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/215#event-1620659038

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-10 Thread Ignasi Barrera
Often these tiny PRs get more review comments and change requests than thousand lines ones! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#issuecomment-388175880

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-10 Thread Ignasi Barrera
We can change that. As long as the feature does not break backward compat, I see no problem in adding it in the next bugfix release. It will help adoption and facilitate early testing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-10 Thread Ignasi Barrera
Closed #214. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#event-1619360327

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-10 Thread Ignasi Barrera
Changes merged and published to the website. Thanks @axel3rd! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387996647

[jira] [Resolved] (JCLOUDS-1414) OpenStack Keystone V3: Support different "domain" for "identity/user" and "project"

2018-05-10 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera resolved JCLOUDS-1414. - Resolution: Fixed Fix Version/s: 2.1.1 2.2.0 > OpenSt

Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-10 Thread Ignasi Barrera
Pushed to [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/053dfd01) and [2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/93a805ca). Thanks @axel3rd! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-10 Thread Ignasi Barrera
Closed #1204. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1204#event-1619345086

[jira] [Updated] (JCLOUDS-1414) OpenStack Keystone V3: Support different "domain" for "identity/user" and "project"

2018-05-10 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ignasi Barrera updated JCLOUDS-1414: Labels: openstack-keystone (was: keystone openstack) > OpenStack Keystone V3: Supp

Re: [jclouds/jclouds] OpenStack Keystone V3 - different auth "domains" support (JCLOUDS-1414) (#1204)

2018-05-08 Thread Ignasi Barrera
nacx approved this pull request. Just some small comments. Thanks for the contribution @axel3rd! >} else if (DOMAIN.equals(parts[0])) { return DomainScope.create(Name.create(parts[1])); } else { return DomainIdScope.create(Id.create(parts[1])); } } +

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-07 Thread Ignasi Barrera
nacx approved this pull request. Thanks! LGTM. Since you reference a new keystone property I'd hold this and merge once the changes in Keystone are merged and the new property exists. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [jclouds/jclouds] Removes check for group name when deleting (#1202)

2018-05-07 Thread Ignasi Barrera
The DNS one is just a naming convention known to work for most providers. Being restrictive works fine for portability but conflicts when you're trying to use it with pre-existing stuff. In this case I'd say it makes sense to have a custom one for Azure, since it is only used to name things:

[jira] [Commented] (JCLOUDS-1414) OpenStack Keystone V3: Support different "domain" for "identity/user" and "project"

2018-05-07 Thread Ignasi Barrera (JIRA)
[ https://issues.apache.org/jira/browse/JCLOUDS-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465927#comment-16465927 ] Ignasi Barrera commented on JCLOUDS-1414: - {quote} Sorry for my answer delay, but no way to use

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-07 Thread Ignasi Barrera
One minor comment, but it would help readability if you format the generated json auth example. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/214#issuecomment-387061588

Re: [jclouds/jclouds-site] Documentation about Openstack Keystone v2/v3 usage (#214)

2018-05-07 Thread Ignasi Barrera
nacx commented on this pull request. > + +Openstack Keystone (aka: [OpenStack Identity Service](https://docs.openstack.org/keystone/latest/)) has major changes between v2 and v3 (detail. [Identity API v2.0 and v3

<    1   2   3   4   5   6   7   8   9   10   >