Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

Closed #1006. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1006#event-1096914031

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

Superseded by https://github.com/jclouds/jclouds/pull/1106. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1006#issuecomment-303951835

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

@utkarsh-devops This PR has been quiet for some time. Feel free to step in and help with the remaining bits! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

We are waiting for the release of this feature. please expedite. Tx -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1006#issuecomment-301759282

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

@nacx: argh!! the notifications for your reply got lost in my inbox and I did not see them. sorry for the delay! i'll get to it asap. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

They take some time, so I'd recommend that you just run the class where you add the new tests :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1006#issuecomment-249135944

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> How do I configure my local machine to run the live tests The better options is to download your credentials as a JSON file. Once you have them, you can run all live tests as follows: mvn clean install -Plive -Dtest.google-cloud.json-key=/path/to/your/credentials.json Or if you want to

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

nacx commented on this pull request. > /** * This must be within the range specified by IPv4Range, and is typically the first usable address in that range. * If not specified, the default value is the first usable address in IPv4Range. */ @Nullable public abstract

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

@nacx: How do I configure my local machine to run the live tests? I found some documentation that alludes to adding to the m2 settings, but I do not know what that means :-) That's why I did not write the live tests (yet). I was going to do another PR with that, but if you can help me with

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

nelsonjr commented on this pull request. >@SerializedNames({ "network", "accessConfigs" }) static NetworkInterface create(URI network, List accessConfigs) { - return new AutoValue_NewInstance_NetworkInterface(network, accessConfigs); + return new

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

nelsonjr commented on this pull request. > /** * This must be within the range specified by IPv4Range, and is typically the first usable address in that range. * If not specified, the default value is the first usable address in IPv4Range. */ @Nullable public abstract

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

nelsonjr commented on this pull request. > +@Singleton +public class SubnetworkLoader extends CacheLoader { + @Resource + protected Logger logger = Logger.NULL; + + private final Resources resources; + + @Inject + SubnetworkLoader(Resources resources) { +

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

Thanks @nelsonjr! This looks great. Just a couple comments apart from the inline ones: * Add mock tests for the methods added to the aggregated list api. * Add live tests for the subnetworks api and the new methods in the aggregated list api. These ones are specially important, since they warn

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -126,7 +124,7 @@ Operation createInIPv4Range(@PayloadParam("name") String > networkName, > @Transform(NetworkPages.class) > Iterator list(ListOptions options); > > - static final class NetworkPages extends BaseToIteratorOfListPage NetworkPages> { > + final

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -82,6 +83,10 @@ > @Path("/stop") > Operation stopInstance(@EndpointParam URI selfLink); > > + @Named("Subnetworks:get") > + @GET > + @Fallback(NullOnNotFoundOr404.class) @Nullable Subnetwork > subnetwork(@EndpointParam URI selfLink); This method is not used. Remove it? --

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + this.resources = resources; > + } > + > + @Override > + public Subnetwork load(URI key) throws ExecutionException { > + try { > + return resources.subnetwork(key); > + } catch (Exception e) { > + throw new ExecutionException(message(key, e), e); > + }

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + assertSent(server, "DELETE", > "/projects/party/regions/someregion/subnetworks/jclouds-test"); > + } > + > + public void list() throws Exception { > + server.enqueue(jsonResponse("/subnetwork_list.json")); > + > + assertEquals(subnetworkApi().list().next(), new >

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> > /** > * This must be within the range specified by IPv4Range, and is typically > the first usable address in that range. > * If not specified, the default value is the first usable address in > IPv4Range. > */ > @Nullable public abstract String gatewayIPv4(); > > -

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

>@SerializedNames({ "network", "accessConfigs" }) >static NetworkInterface create(URI network, List > accessConfigs) { > - return new AutoValue_NewInstance_NetworkInterface(network, > accessConfigs); > + return new AutoValue_NewInstance_NetworkInterface(network,

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -32,6 +35,7 @@ > private List serviceAccounts; > private String bootDiskType; > private boolean preemptible = false; > + private Set subnetworks; Change to just `URI subnetwork`, as mentioned above? -- You are receiving this because you are subscribed to this thread. Reply to

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> + > + @Inject > + SubnetworkLoader(Resources resources) { > + this.resources = resources; > + } > + > + @Override > + public Subnetwork load(URI key) throws ExecutionException { > + try { > + return resources.subnetwork(key); > + } catch (Exception e) { > +

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> +@Singleton > +public class SubnetworkLoader extends CacheLoader { > + @Resource > + protected Logger logger = Logger.NULL; > + > + private final Resources resources; > + > + @Inject > + SubnetworkLoader(Resources resources) { > + this.resources = resources; > +

Re: [jclouds/jclouds] JCLOUDS-1122: Support subnetworks definitions in Google Compute. (#1006)

> @@ -136,11 +136,17 @@ >URI network = URI.create(networks.next()); >assert !networks.hasNext() : "Error: Options should specify only one > network"; > > + Iterator subnetworks = options.getSubnetworks().iterator(); > + > + URI subnetwork = subnetworks.hasNext() ? >