#1228 FTR
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/commit/c34935dcd3476db7397e7433de6243ec81a09ccf#commitcomment-29663823
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#pullrequestreview-136029939
[
https://issues.apache.org/jira/browse/JCLOUDS-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignasi Barrera resolved JCLOUDS-1433.
-
Resolution: Fixed
Fix Version/s: 2.1.1
2.2.0
>
There are some tests that fail even without my patch:
```
org.jclouds.aws.AWSResponseException: request PUT
https://s3.amazonaws.com/jglick-blobstore-TestBucket HTTP/1.1 failed with code
400, error: AWSError{requestId='…', requestToken='…', code='InvalidBucketName',
message='The specified
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c34935dc) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9f999617). Thanks
@jglick!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1228.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1228#event-1726643033
[
https://issues.apache.org/jira/browse/JCLOUDS-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539277#comment-16539277
]
ASF subversion and git services commented on JCLOUDS-1433:
--
Commit
[
https://issues.apache.org/jira/browse/JCLOUDS-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539275#comment-16539275
]
ASF subversion and git services commented on JCLOUDS-1433:
--
Commit
@jglick pushed 1 commit.
069e109 Allow S3ClientLiveTest (and AWSS3ClientLiveTest) to use a session
token.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I think I figured out that the existing tests just do not support session
credentials (and I cannot access my account without them), so I need to patch
the tests.
> since you are now using the aws-s3 provider there is no need to provide the
> endpoint, as the AWS provider does already know
@alibazlamit pushed 1 commit.
861321b Merge branch 'master' of https://github.com/jclouds/jclouds-labs into
oneandone-baremetal-update
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Removed previous solution and added the optional/nullable resourcegroup
parameter as solution!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#issuecomment-403970005
@andreaturli Can you please take a look at this PR and let me know when can we
move on with it?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/431#issuecomment-403967229
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
nacx commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
I did try running `AWSS3ClientLiveTest` with the arguments you mention, and it
did not work, as noted in the PR description. Of course the failure messages
were pretty opaque for security reasons. Noting that these parameters are
identical to that used by `ContextBuilder` is not particularly
jglick commented on this pull request.
>
@Test(groups = "unit")
public class Strings2Test {
public void testReplaceTokens() {
assertEquals(Strings2.replaceTokens("hello {where}",
ImmutableMap.of("where", "world")), "hello world");
+
[JCLOUDS-1433](https://jira.apache.org/jira/browse/JCLOUDS-1433), a little fix
noticed while testing #1226. @kuisathaverat @carlossg
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1228
-- Commit Summary --
* [JCLOUDS-1433] $ and \ in
[
https://issues.apache.org/jira/browse/JCLOUDS-1433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539130#comment-16539130
]
Jesse Glick commented on JCLOUDS-1433:
--
Filed PR 1228 with a fix.
> IllegalArgumentException from
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
Jesse Glick created JCLOUDS-1433:
Summary: IllegalArgumentException from Strings2.replaceTokens
Key: JCLOUDS-1433
URL: https://issues.apache.org/jira/browse/JCLOUDS-1433
Project: jclouds
Thanks, @jglick!
I'd say before running live tests you could add a small unit test that just
verifies the `createStringToSign` method so we don't break it accidentally in
the future.
You can also add a mock unit test to the
Depends on https://github.com/jclouds/jclouds/pull/1224
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1227
-- Commit Summary --
* Adds ConcurrentModificationException to the list of propagatable types
-- File Changes --
M
nacx commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
@danielestevez pushed 3 commits.
ebf4a1c Addresses comments on tests
4ce685a Removes resourceGroup parameter from NetworkInterfaceCardApi
ca677c6 Removes resourceGroup parameter from PublicIPAddressApi
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
danielestevez commented on this pull request.
> @@ -119,6 +119,16 @@ public void listPublicIPAddresses() {
assertTrue(ipList.size() > 0);
}
+ @Test(groups = "live", dependsOnMethods = "createPublicIPAddress")
+ public void listAllPublicIPAddresses() {
same :)
--
You are
danielestevez commented on this pull request.
> @@ -105,6 +105,12 @@ public void listNetworkInterfaceCards() {
assertTrue(nicList.contains(api().get(nicName)));
}
+ @Test(dependsOnMethods = "createNetworkInterfaceCard")
+ public void listAllNetworkInterfaceCards() {
Good
danielestevez commented on this pull request.
> + String path = String
+
.format("/subscriptions/%s/providers/Microsoft.Network/networkInterfaces?%s",
subscriptionid, apiVersion);
+
+ assertSent(server, "GET", path);
+ assertTrue(nicList.size() == 3);
+
lgtm
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1224#issuecomment-403791422
Closed #437.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437#event-1725278705
merged at
[master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/4a9536b8)
thanks @alibazlamit
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
[
https://issues.apache.org/jira/browse/JCLOUDS-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538428#comment-16538428
]
ASF subversion and git services commented on JCLOUDS-1425:
--
Commit
ok merging now
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437#issuecomment-403787472
Done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437#issuecomment-403784731
kuisathaverat approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1226#pullrequestreview-135736156
@alibazlamit I was talking about `master` in jclouds-labs yet.
Can you please squash the commits into 1? thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Yes, though i am not sure what are the required steps to move out from
jclouds-labs to jclouds. We have been in the labs for a long time and would
like to move forward.
What about the other PR for 1&1. Could you please give it a look and let me
know if it is good too?
--
You are receiving
andreaturli approved this pull request.
lgtm, thanks @alibazlamit
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437#pullrequestreview-135706726
@alibazlamit I assume this will be only merged onto `master` yes?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/437#issuecomment-403731563
andreaturli commented on this pull request.
> +
+@Path("/block_storages")
+@Produces("application/json")
+@Consumes("application/json")
+@RequestFilters(AuthenticateRequest.class)
+public interface BlockStorageApi extends Closeable {
+
+ @Named("blockstorages:list")
+ @GET
+
41 matches
Mail list logo
