Closed #1264.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1264#event-2047757965
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/3d308560) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d621edd7)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1265.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1265#event-2047729700
Thanks again @pimuzzo
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/4c18ca77) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/2d9bb934)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@danielestevez pushed 1 commit.
ce752f83455c19385bc938e0d50c85979b67f5f2 Reorder parameters sku and properties
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
danielestevez approved this pull request.
Good!
I'm not sure if it'd be interesting to add a test to cover this issue of having
no region filter?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1264#issuecomment-448626652
Thanks for the review @nacx !
Finally i added all SKU entities as inner classes so it's easier to reference
them in code.
Also both SKUs have a `SKUName` field similar to what we do at `AvailabilitySet`
I also noticed there is a generic `SKU` entity that should be under Vault and a
@danielestevez pushed 2 commits.
93356e726b3872c179310738439c4ddfcf3a3a66 Changes order in parameters to keep
properties as last parameter
888ad76b12ec86c180a4ad5d6054de556f9506c3 Moves LoadBalancer and PublicAddress
to new package with SKU as inner
--
You are receiving this because you
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
danielestevez commented on this pull request.
> @@ -0,0 +1,44 @@
+/*
Same concern as before keeping the original MS names, but embedding it seems a
good idea.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> +import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+
+@AutoValue
+public abstract class LoadBalancerSKU {
+
+ public static enum LoadBalancerSKUName {
+ Basic, Standard, Unrecognized;
+
+ public static
danielestevez commented on this pull request.
> @@ -68,7 +69,7 @@
@MapBinder(BindToJsonPayload.class)
LoadBalancer createOrUpdate(@PathParam("loadbalancername") String lbName,
@PayloadParam("location") String location, @Nullable
@PayloadParam("tags") Map tags,
-
danielestevez commented on this pull request.
> +import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+
+@AutoValue
+public abstract class PublicAddressSKU {
+
+ public static enum PublicIPAddressSkuName {
+ Basic, Standard, Unrecognized;
+
+ public
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
danielestevez commented on this pull request.
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jclouds.azurecompute.arm.domain;
+
+import
danielestevez commented on this pull request.
> @@ -66,9 +67,9 @@
@MapBinder(BindToJsonPayload.class)
@PUT
PublicIPAddress createOrUpdate(@PathParam("publicipaddressname") String
publicipaddressname,
- @PayloadParam("location")
* Adds SKU field to PublicIPAddress and LoadBalancer
* Adds LiveTests to create these new type of entities
* Modifies existing calls to have default SKU null, which translates to Basic
in Azure deployments. Jclouds will keep creating these Basic SKU IPs when
deploying a VM
Thanks again @kazimazar!
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8dcfd862) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/5916059b)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Closed #1260.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1260#event-2002768423
danielestevez approved this pull request.
Thanks @kazimazar
I noticed a small difference between here
https://aws.amazon.com/blogs/aws/ec2-instance-update-c5-instances-with-local-nvme-storage-c5d/
and some sizes for the c5d instances
Could you please check this info and fix it if needed?
I'll
danielestevez commented on this pull request.
> @@ -171,9 +216,12 @@ public boolean cleanupSecurityGroupIfOrphaned(String
> resourceGroup, String group
logger.debug(">> deleting orphaned security group %s from
%s...", name, resourceGroup);
try {
Closed #1257.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1257#event-1978014074
Merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/38e3535d) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/8e827d59)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Also updates API version for VirtualMachineApi
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1257
-- Commit Summary --
* Adds method listAvailableSizes to VirtualMachineApi
-- File Changes --
M
Pushed to
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/219e2958) and
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e4c99a07)!
Thanks @trentontrees for the contribution!!
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Closed #1245.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#event-1924344216
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#pullrequestreview-167903755
That link looks useful, thanks!
Please squash the commits and we're done
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-432469002
Thanks @trentontrees CPU seem correct now but i'm looking at
```Processsors.speed`` and it don't see the right values.
In AWS doc these new instances have ```up to 3.3``` for t2 and 2.5 for t3
instead of 0.4. Could you check these values too?
Once done, just rebase it and it'll be merged!
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public
rebuild please
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1245#issuecomment-430785426
danielestevez commented on this pull request.
> @@ -429,6 +444,89 @@ public static EC2HardwareBuilder t2_large() {
.processors(ImmutableList.of(new Processor(1.0,
0.4))).rootDeviceType(RootDeviceType.EBS);
}
+ /**
+* @see InstanceType#T2_XLARGE
+*/
+ public
danielestevez commented on this pull request.
> + /**
+* @see InstanceType#T3_MEDIUM
+*/
+ public static EC2HardwareBuilder t3_medium() {
+ return new EC2HardwareBuilder(InstanceType.T3_MEDIUM).t3()
+ .ram(4096)
+ .processors(ImmutableList.of(new
danielestevez approved this pull request.
It's time!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/449#pullrequestreview-164718408
danielestevez commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
Closed #1237.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1237#event-1830625159
Squashed and merged to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/951b6b44) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/a07ab5a9)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@danielestevez pushed 1 commit.
4511cf1 Adds unit test for china oauth endpoint check
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@danielestevez pushed 1 commit.
f1087b6 Adapted Endpoints for APIs GraphRBAC and Vault
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yes, a simple `isChina` is easily implementable as we can parse
`ContextBuilder.endpoint`
Thanks for the tip, i'll try that approach and update the PR since i think we
can suppose this will be the only exception and Microsoft won't be adding other
additional endpoints.
--
You are receiving
- Only one blocker hardcoded was fixed in AzureComputeHttpApiModule.java
- Endpoints for GraphAPI and VaultAPI are also hardcoded but we could deal with
this as separate PRs (i couldn't make this work with Guice)
- Also added two new China regions to keep the plugin up to date.
Just with this
danielestevez commented on this pull request.
> +## Credits
+
+jclouds would like to thank everyone who contributed time and effort in order
to make this release happen:
+
+* [Vikas Rangarajan](https://github.com/VRanga000) for his contribution to the
new instance types supported in the AWS
danielestevez commented on this pull request.
> +1. [Known Issues](#knownissues)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
with several bugfixes and performance improvements.
+You can
@danielestevez pushed 1 commit.
a7a5604 Adds more JIRA issues fixed and mentions contributors
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
danielestevez commented on this pull request.
> +* [JCLOUDS-1410] - SoftLayer cannot provision with private image
+* [JCLOUDS-1422] - LocalBlobStore.list ignores recursive flag when prefix set
+* [JCLOUDS-1427] - NPE when deserializing Elastic IPs that have tags
+* [JCLOUDS-1433] -
danielestevez commented on this pull request.
> +* [JCLOUDS-1410] - SoftLayer cannot provision with private image
+* [JCLOUDS-1422] - LocalBlobStore.list ignores recursive flag when prefix set
+* [JCLOUDS-1427] - NPE when deserializing Elastic IPs that have tags
+* [JCLOUDS-1433] -
danielestevez commented on this pull request.
> +1. [Introduction](#intro)
+1. [Release Highlights](#highlights)
+1. [Known Issues](#knownissues)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
danielestevez commented on this pull request.
> } catch (Exception ex) {
logger.warn(ex, "Error cleaning up resources for node %s",
deadNode);
}
+
+ List securityGroups =
cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),
danielestevez commented on this pull request.
> } catch (Exception ex) {
logger.warn(ex, "Error cleaning up resources for node %s",
deadNode);
}
+
+ List securityGroups =
cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),
danielestevez commented on this pull request.
> +import org.jclouds.rest.annotations.RequestFilters;
+import org.jclouds.rest.annotations.ResponseParser;
+import org.jclouds.rest.annotations.Transform;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
danielestevez commented on this pull request.
> } catch (Exception ex) {
logger.warn(ex, "Error cleaning up resources for node %s",
deadNode);
}
+
+ List securityGroups =
cleanupResources.findOrphanedSecurityGroups(regionAndId.regionId(),
Closed #1233.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#event-1766308008
Pushed to
[2.1.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/e54312aa) and
[master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/cf672337) !!
Thanks @VRanga000 !!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
Closed #1232.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1232#event-1766300928
Pushed to
[master](https://github.com/jclouds/jclouds/commit/982c6bea0252689c23628079ab66998ac2a36aa9)
and
[2.1.x](https://github.com/jclouds/jclouds/commit/0ee68a5f836a654619a5bbf635e19e1d478f058e)!
Thanks @VRanga000 !!
--
You are receiving this because you are subscribed to this thread.
danielestevez approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#pullrequestreview-142542476
Sorry! Got it now.
Please review the checkstyle since it seems to be breaking the build
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1233#issuecomment-409394722
danielestevez approved this pull request.
Thanks @VRanga000 the code looks good for those new profiles!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Isn't this the same PR as https://github.com/jclouds/jclouds/pull/1232 but with
wrong checkstyle?
If i'm right, could you please close this one?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Squashed and ready to merge, thanks @nacx !
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1231#issuecomment-404673071
@danielestevez pushed 1 commit.
e71ce96 Fixed formatter maximum line width. Removed redundantTest
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
danielestevez commented on this pull request.
> + public void checkIpAvailable() throws InterruptedException {
+ server.enqueue(jsonResponse("/ipavailable.json"));
+
+ final VirtualNetworkApi vnApi = api.getVirtualNetworkApi(resourcegroup);
+ IpAddressAvailabilityResult
@danielestevez pushed 1 commit.
37ce4a7 Addresses @nacx comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1231/files/427fcdb34f6e8698e2c0ad218f65aac4a8964ef8..37ce4a7d29ad54d9b9436e668336bed07a998a7f
danielestevez commented on this pull request.
>
VirtualNetwork vn = api().createOrUpdate(virtualNetworkName, LOCATION,
null, virtualNetworkProperties);
+ resourceAvailable.apply(new Supplier() {
+ @Override
+ public Provisionable get() {
+
danielestevez commented on this pull request.
> + */
+package org.jclouds.azurecompute.arm.domain;
+
+import java.util.List;
+
+import org.jclouds.javax.annotation.Nullable;
+import org.jclouds.json.SerializedNames;
+
+import com.google.auto.value.AutoValue;
+import
danielestevez commented on this pull request.
> @@ -73,4 +74,11 @@ VirtualNetwork
> createOrUpdate(@PathParam("virtualnetworkname") String virtualnet
@DELETE
@ResponseParser(FalseOn204.class)
boolean delete(@PathParam("virtualnetworkname") String virtualnetworkname);
+
+
https://docs.microsoft.com/en-us/rest/api/virtualnetwork/virtualnetworks/checkipaddressavailability
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1231
-- Commit Summary --
* Adds method checkIpAvailability to VirtualNetworkApi
--
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1229
-- Commit Summary --
* Adds missing virtualMachine field to NetworkInterfaceCardProperties
-- File Changes --
M
Removed previous solution and added the optional/nullable resourcegroup
parameter as solution!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1225#issuecomment-403970005
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
@danielestevez pushed 3 commits.
ebf4a1c Addresses comments on tests
4ce685a Removes resourceGroup parameter from NetworkInterfaceCardApi
ca677c6 Removes resourceGroup parameter from PublicIPAddressApi
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
danielestevez commented on this pull request.
> @SelectJson("value")
@GET
@Fallback(EmptyListOnNotFoundOr404.class)
List list();
+ @Named("networkinterfacecard:list_all")
+ @Path("/providers/Microsoft.Network/networkInterfaces")
+ @SelectJson("value")
+ @GET
+
danielestevez commented on this pull request.
> @@ -119,6 +119,16 @@ public void listPublicIPAddresses() {
assertTrue(ipList.size() > 0);
}
+ @Test(groups = "live", dependsOnMethods = "createPublicIPAddress")
+ public void listAllPublicIPAddresses() {
same :)
--
You are
danielestevez commented on this pull request.
> @@ -105,6 +105,12 @@ public void listNetworkInterfaceCards() {
assertTrue(nicList.contains(api().get(nicName)));
}
+ @Test(dependsOnMethods = "createNetworkInterfaceCard")
+ public void listAllNetworkInterfaceCards() {
Good
danielestevez commented on this pull request.
> + String path = String
+
.format("/subscriptions/%s/providers/Microsoft.Network/networkInterfaces?%s",
subscriptionid, apiVersion);
+
+ assertSent(server, "GET", path);
+ assertTrue(nicList.size() == 3);
+
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1225
-- Commit Summary --
* Adds listAll to PublicIPAddressAPI
* Adds listAll to NetworkInterfaceCardApi
-- File Changes --
M
Sorry i forgot about the mock test!
Also noticed i changed the returning HTTP codes for start/restart/stop to the
actual values returned by ARM API
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@danielestevez pushed 1 commit.
cb8881b Adds missing mock test
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds/pull/1220/files/b76a2b6ecf997e4214fa7990b3d58d1f1b095043..cb8881bbac7f8fc448acd59772c00891814d7cea
https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/deallocate
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1220
-- Commit Summary --
* Implements VirtualMachineAPI deallocate operation
-- File Changes --
M
danielestevez commented on this pull request.
> @@ -54,13 +54,17 @@
BRAZIL_SOUTH("Brazil South", "BR"),
AUSTRALIA_EAST("Australia East", "AU-NSW"),
AUSTRALIA_SOUTH_EAST("Australia Southeast", "AU-VIC"),
+ AUSTRALIA_CENTRAL("Australia Central", "AU-ACT"),
+
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1219
-- Commit Summary --
* Adds new Generally Available azure locations for Australia and France
-- File Changes --
M
* Field 'primary' was missing in NetworkInterfaceCardProperties
* Field 'primary' was misplaced in IpConfiguration instead of
IpConfigurationProperties
This causes problems when using the provider to configure multiple IPs per NIC
and multiple NICs per VirtualMachine
Check
I think so! I opened the PR against 2.1.x as in the previous one but @nacx will
surely merge it to 2.1.x and master
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
danielestevez commented on this pull request.
> @@ -54,7 +55,7 @@ private CharMatcher getAcceptableRange() {
protected IllegalArgumentException exception(String name, String reason) {
return new IllegalArgumentException(
-String.format("Object '%s' doesn't match Azure
@danielestevez pushed 1 commit.
2fd4f07 changes exception text for readability
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Thanks for the suggestions @demobox, PR was already merged but i added those
improvements here https://github.com/jclouds/jclouds/pull/1215
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Based on suggestions by @demobox in original PR
https://github.com/jclouds/jclouds/pull/1213
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1215
-- Commit Summary --
* Adds minor improvements to readability
-- File Changes --
M
This affected (at least)
[AzureComputeImageExtensionLiveTest](https://github.com/jclouds/jclouds/blob/master/providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/compute/extensions/AzureComputeImageExtensionLiveTest.java)
running in some regions. (worked in North/West Europe but
Added a test! (and fixed an error message by the way) with all the main cases i
could think of @nacx
Also, i added this class under _org.jclouds.azurecompute.arm.config.*_ not sure
if it's the best place so feel free to suggest any other one
--
You are receiving this because you are
This simple validator should work https://github.com/jclouds/jclouds/pull/1213
and we could close this PR
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1202#issuecomment-391501389
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1213
-- Commit Summary --
* Adds new more relaxed validator for Azure entities
-- File Changes --
A
Some context about what @nacx is talking about
https://stackoverflow.com/questions/50068324/azure-arm-api-returns-locations-with-inconsistent-case
It affects also other of the new regions (not only CanadaEast) and working on
it we discovered some unrelated issues like this one with the default
Good to know!
Then i guess it's again another problem with the caseInsensitive feature since
i always try in one of the problematic regions **CanadaEast**
Will investigate further
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
danielestevez commented on this pull request.
> + // Otherwise fallback to the image default credentials strategy
+ if (template instanceof CloneImageTemplate) {
+ final CloneImageTemplate cloneImageTemplate = (CloneImageTemplate)
template;
+ future =
Tried and fixes the issues with the missing credentials in
_testSpawnNodeFromImage_ :+1:
However _testImageIsRemovedFromCacheAfterDeletion_ still fails it
_testSpawnNodeFromImage_ is enabled but that's a different issue.
--
You are receiving this because you are subscribed to this thread.
About this, i started to implement a custom validation for ARM here extending
current interfaces
https://github.com/danielestevez/jclouds/commits/groupNamingValidation
Still not sure about the implementation, and specially naming but there it is
if you want to take a look
--
You are receiving
Fail!... and fixed!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1209#issuecomment-389517489
Azure does not return IpPermissions in order so this test fails randomly
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1209
-- Commit Summary --
* Fixes assert for IpPermissions collection
-- File Changes --
M
1 - 100 of 139 matches
Mail list logo
