[jclouds-pull-requests-java-6
#227](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/227/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60119829
[jclouds-pull-requests
#1316](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1316/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60123539
[jclouds » jclouds
#1828](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1828/) UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
+networktype: Advanced,
+securitygroupsenabled: false,
+tags: []
+},
+{
+id: 2,
+name: Chicago,
+networktype: Advanced,
+securitygroupsenabled: true,
+tags: [
+
@@ -11,7 +11,8 @@
ipaddress: 10.27.27.64,
startport: 22,
endport: 22,
-state: Active
+state: Active,
+
tags:[{account:1,domain:ROOT,domainid:1,key:some-tag,resourceid:66,
resourcetype:PortForwardingRule,
@@ -166,6 +183,13 @@ public static ListSnapshotsOptions volumeId(String
volumeId) {
public static ListSnapshotsOptions projectId(String projectId) {
return new ListSnapshotsOptions().projectId(projectId);
}
+
+ /**
+ * @see
+public interface TagApi {
+
+ /**
+* Lists tags
+*
+* @param options
+* if present, how to constrain the list.
+* @return tags matching query, or empty set, if no tags are found
+*/
+ @Named(listTags)
+ @GET
+ @QueryParams(keys = { command,
+
+ public static ResourceType fromValue(String resourceType) {
+ Integer code = Integer.valueOf(checkNotNull(resourceType,
resourcetype));
+ return INDEX.containsKey(code) ? INDEX.get(code) : UNRECOGNIZED;
+ }
+ }
+
+ public static Builder? builder() {
+
+import com.google.common.base.MoreObjects;
+import com.google.common.base.MoreObjects.ToStringHelper;
+import com.google.common.base.Objects;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Maps;
+import org.jclouds.javax.annotation.Nullable;
+
+/**
+ *
The tags aren't really confusing - they're just overly verbose, as it were. And
yeah, as a copy-paste-coder, I always just use the style in place in the
existing code in the API rather than diverging - maybe not ideal, but makes it
much easier to read and maintain, IMO.
---
Reply to this email
Heh I would clarify that it is read and maintainence neutral. There's
nothing easy to read about ConcreteBuilder :)
Anyways. Thanks and carry-on!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59956593
Ah, but it is easier to maintain an API when the entire API is doing the same
thing, even if that thing is a bit wonky. =)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59957942
It also has a side benefit of making adrian's hands shake just about enough
for him to cleanse the whole api of its sins.. :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59961813
..that too, yes.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59962160
[jclouds-pull-requests-java-6
#218](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/218/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59976074
[jclouds » jclouds
#1819](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1819/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests-java-6
#219](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/219/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59992025
+
+ public static ResourceType fromValue(String resourceType) {
+ Integer code = Integer.valueOf(checkNotNull(resourceType,
resourcetype));
+ return INDEX.containsKey(code) ? INDEX.get(code) : UNRECOGNIZED;
+ }
+ }
+
+ public static Builder? builder() {
+
[jclouds-pull-requests
#1308](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1308/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59995901
[jclouds-pull-requests-java-6
#220](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/220/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-6255
Ok, live tests added and they pass - I think that suffices. Squashing now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-6354
[jclouds » jclouds
#1820](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1820/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests-java-6
#221](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/221/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-6632
LGTM (gripes noted)
Thanks, Andrew!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60001711
[jclouds-pull-requests
#1310](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1310/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60004237
[jclouds-pull-requests
#1309](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1309/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60004238
[jclouds » jclouds
#1821](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1821/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds
#1822](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1822/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests-java-6
#222](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/222/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60017625
[jclouds-pull-requests
#1311](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1311/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60019651
Ok, added the tags/userMetadata to NodeMetadata, ComputeService-driven node
creation, etc. I'm calling this done with another PR to come later on general
live test cleanup/fixes.
---
Reply to this email directly or view it on GitHub:
[jclouds-pull-requests-java-6
#223](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/223/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60019921
[jclouds-pull-requests-java-6
#224](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/224/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60020102
[jclouds-pull-requests
#1312](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1312/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60021601
[jclouds-pull-requests
#1313](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1313/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-60021701
[jclouds » jclouds
#1824](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1824/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
[jclouds » jclouds
#1825](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1825/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
Note - this is just a preliminary PR, not ready for merge yet. I still have to
add a couple more expect tests, update a couple more, add live tests and update
one or two other live tests, but I wanted to throw this up so others could see
it.
Note also that yeah, I went a little nutty and
[jclouds-pull-requests-java-6
#216](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/216/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59858471
[jclouds-pull-requests
#1305](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1305/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/578#issuecomment-59860911
[jclouds » jclouds
#1815](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1815/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
+networktype: Advanced,
+securitygroupsenabled: false,
+tags: []
+},
+{
+id: 2,
+name: Chicago,
+networktype: Advanced,
+securitygroupsenabled: true,
+tags: [
+
@@ -11,7 +11,8 @@
ipaddress: 10.27.27.64,
startport: 22,
endport: 22,
-state: Active
+state: Active,
+
tags:[{account:1,domain:ROOT,domainid:1,key:some-tag,resourceid:66,
resourcetype:PortForwardingRule,
+ }
+
+ /**
+* @param resourceId
+*list by resource ID
+*/
+ public ListTagsOptions resourceId(String resourceId) {
+ this.queryParameters.replaceValues(resourceid,
ImmutableSet.of(resourceId));
+ return this;
+ }
+
+ /**
+* @param
+public interface TagApi {
+
+ /**
+* Lists tags
+*
+* @param options
+* if present, how to constrain the list.
+* @return tags matching query, or empty set, if no tags are found
+*/
+ @Named(listTags)
+ @GET
+ @QueryParams(keys = { command,
+ * @see a
href=http://cloudstack.apache.org/docs/api/apidocs-4.3/TOC_Root_Admin.html;
/
+ */
+@RequestFilters(AuthenticationFilter.class)
+@QueryParams(keys = response, values = json)
+public interface TagApi {
+
+ /**
+* Lists tags
+*
+* @param options
+*
+
+ public static ResourceType fromValue(String resourceType) {
+ Integer code = Integer.valueOf(checkNotNull(resourceType,
resourcetype));
+ return INDEX.containsKey(code) ? INDEX.get(code) : UNRECOGNIZED;
+ }
+ }
+
+ public static Builder? builder() {
+
+import com.google.common.base.MoreObjects;
+import com.google.common.base.MoreObjects.ToStringHelper;
+import com.google.common.base.Objects;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.Maps;
+import org.jclouds.javax.annotation.Nullable;
+
+/**
+ *
Epic. So, I'm expecting that there will be some live test impact, I guess (plus
the mock/expect you mentioned). I'm also assuming you are following convention
of existing codebase to avoid confusing things by porting only this to whatever
latest style is.
I must admit that the tags concept is
49 matches
Mail list logo
