vy commented on code in PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1082265434
##
log4j-api/src/main/java/org/apache/logging/log4j/message/ReusableMessageFactory.java:
##
@@ -89,9 +83,21 @@ public static void release(final Message message) { //
ppkarwasz commented on PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#issuecomment-1398217767
There is one `Recycler` usage case that is not covered by this PR: some
objects like `LogBuilder` must be aware of the recycling lifecycle and be able
to signal the recycler,
dependabot[bot] closed pull request #1089: Bump kafka-clients from 1.1.1 to
3.3.1
URL: https://github.com/apache/logging-log4j2/pull/1089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1089:
URL: https://github.com/apache/logging-log4j2/pull/1089#issuecomment-1398072392
Superseded by #1217.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #1217:
URL: https://github.com/apache/logging-log4j2/pull/1217
Bumps kafka-clients from 1.1.1 to 3.3.2.
[
file needs some updates. E.g. the requirement for "minimal updates" needs to
be more precise:
vy opened a new issue, #19:
URL: https://github.com/apache/logging-log4j-tools/issues/19
As [this failed CI
run](/apache/logging-log4j2/actions/runs/3943007132/jobs/6747337526) indicates:
```
java.lang.RuntimeException: failed exporting release from directory
miracle-tree closed pull request #1215: Fix cron expression get a wrong
previous fire time
URL: https://github.com/apache/logging-log4j2/pull/1215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ppkarwasz commented on PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1386639067
`StackLocator` is a complex feature with several different paths, so maybe
I'll add a cheatsheet for the unity tests:
* the
ppkarwasz commented on code in PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1073100498
##
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java:
##
@@ -85,7 +85,7 @@ static ExtendedStackTraceElement[]
miracle-tree opened a new pull request, #1215:
URL: https://github.com/apache/logging-log4j2/pull/1215
For the method `CronExpression#getPrevFireTime`, currently only the minimum
increment within a cycle is considered, and the cross-cycle situation is not
involved, resulting in differences
swebb2066 merged PR #178:
URL: https://github.com/apache/logging-log4cxx/pull/178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alex-dubrouski commented on code in PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072928929
##
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java:
##
@@ -85,7 +85,7 @@ static ExtendedStackTraceElement[]
alex-dubrouski commented on code in PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072928929
##
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java:
##
@@ -85,7 +85,7 @@ static ExtendedStackTraceElement[]
alex-dubrouski commented on code in PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072914968
##
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java:
##
@@ -85,7 +85,7 @@ static ExtendedStackTraceElement[]
ppkarwasz commented on code in PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#discussion_r1072880845
##
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxyHelper.java:
##
@@ -85,7 +85,7 @@ static ExtendedStackTraceElement[]
sudheerv commented on PR #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214#issuecomment-1385887173
Thanks @alex-dubrouski for finding the bug and providing the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alex-dubrouski opened a new pull request, #1214:
URL: https://github.com/apache/logging-log4j2/pull/1214
Change of data structure from Stack to Deque (LIFO to FIFO) in this commit
https://github.com/apache/logging-log4j2/commit/97f3153b73ab071a69c2e61e0130fd0104d45407
broke cache logic.
ppkarwasz closed issue #18: Og
URL: https://github.com/apache/logging-log4j-tools/issues/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppkarwasz merged PR #1205:
URL: https://github.com/apache/logging-log4j2/pull/1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppkarwasz closed issue #1202: Pattern including PatternLayout Parameter
disableAnsi=false emits a warning
URL: https://github.com/apache/logging-log4j2/issues/1202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
timcoleman opened a new issue, #179:
URL: https://github.com/apache/logging-log4cxx/issues/179
When compiled with -Wpedantic, g++ complains of extra semicolons in
include/log4cxx/pattern/patternconverter.h in this section:
```
jvz commented on code in PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590544
##
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java:
##
@@ -690,22 +726,17 @@ static CharSequence formatTimestamp(final long
jvz commented on code in PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#discussion_r1071590262
##
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/GelfLayout.java:
##
@@ -598,12 +636,22 @@ private StringBuilder toText(final LogEvent event, final
jvz commented on PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#issuecomment-1384566193
@vy care to have a look at my changes to the `Recycler` API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jvz commented on PR #1194:
URL: https://github.com/apache/logging-log4j2/pull/1194#issuecomment-1384562741
Alright, I think I've figured out one key update to `RecyclerFactory` to
make this API natural to use as a replacement for ad hoc
`ThreadLocal`-style object reuse. This is to allow
vy merged PR #1146:
URL: https://github.com/apache/logging-log4j2/pull/1146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vy opened a new issue, #17:
URL: https://github.com/apache/logging-log4j-tools/issues/17
Read `.2.x.x` and `.3.x.x` directories are passed to the changelog template
in `ChangelogExporter` in incorrect order, that is, `.2.x.x` first and then
`.3.x.x`, whereas it should have been the other
vy closed issue #1207: Enforce signed commits
URL: https://github.com/apache/logging-log4j2/issues/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vy commented on issue #1207:
URL:
https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384476018
Fixed in c6019c979ac07c1e664d066d01302561b47d2c72 and
b61fd7b7fb5e9036b915992d5fa5522e72e424ae.
--
This is an automated message from the Apache Git Service.
To respond to the
ppkarwasz commented on issue #1207:
URL:
https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384455056
@vy,
`spotless:check` is part of the build. We should document `spotless:apply`
there so that contributors don't have to wonder why the build failed.
--
This is
vy commented on issue #1207:
URL:
https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1384447513
> * running `spotless:apply`
Is this really necessary given it is part of the build? It sounds like
_"building the sources"_ or am I exaggerating?
--
This is an
vy merged PR #1172:
URL: https://github.com/apache/logging-log4j2/pull/1172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] closed pull request #1161: Bump maven-dependency-plugin from
3.3.0 to 3.4.0
URL: https://github.com/apache/logging-log4j2/pull/1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on PR #1161:
URL: https://github.com/apache/logging-log4j2/pull/1161#issuecomment-1384430985
Superseded by #1212.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1153:
URL: https://github.com/apache/logging-log4j2/pull/1153#issuecomment-1384430982
Superseded by #1213.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #1213:
URL: https://github.com/apache/logging-log4j2/pull/1213
Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from
2.27.2 to 2.30.0.
Changelog
Sourced from
dependabot[bot] closed pull request #1153: Bump spotless-maven-plugin from
2.27.2 to 2.28.0
URL: https://github.com/apache/logging-log4j2/pull/1153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] opened a new pull request, #1212:
URL: https://github.com/apache/logging-log4j2/pull/1212
Bumps
[maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin)
from 3.3.0 to 3.5.0.
Commits
vy merged PR #1166:
URL: https://github.com/apache/logging-log4j2/pull/1166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rm5248 commented on issue #177:
URL:
https://github.com/apache/logging-log4cxx/issues/177#issuecomment-1384126363
> Hence I guess the C++ standard really prohibits this type of template
instantiations, and the issue could resurface later in e.g. future MSVC
versions implementing the
StevenMassaro commented on PR #1193:
URL: https://github.com/apache/logging-log4j2/pull/1193#issuecomment-1384068628
> Rebase/merge from current please? :)
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ppkarwasz commented on PR #1210:
URL: https://github.com/apache/logging-log4j2/pull/1210#issuecomment-1384065955
@wleese,
Sorry, I forgot to comment on your issue report. Anyway, thank you for your
issue report and PR. It is nice to see that someone **does** pay attention to
Log4j2
ppkarwasz commented on PR #1128:
URL: https://github.com/apache/logging-log4j2/pull/1128#issuecomment-1384004494
Will be resubmitted to `logging-log4j-transform`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ppkarwasz closed pull request #1128: [LOG4J2-3581] Provide a JCL to Log4j2 API
binary weaver
URL: https://github.com/apache/logging-log4j2/pull/1128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Deceptio opened a new issue, #1211:
URL: https://github.com/apache/logging-log4j2/issues/1211
It seems that this example is not quite correct?
[Hybrid
Example](https://logging.apache.org/log4j/2.x/manual/customconfig.html#Hybrid)
There is no XMLConfiguration class but only an
wleese commented on PR #1210:
URL: https://github.com/apache/logging-log4j2/pull/1210#issuecomment-1383873097
I see a proper fix was provided in
https://github.com/ppkarwasz/logging-log4j2/commit/5ddac7cd8a1e7ffe944f28086e1726d4818922bd
--
This is an automated message from the Apache Git
wleese closed pull request #1210: fix: Restore previous behavior ignoring
exceptions when translating a…
URL: https://github.com/apache/logging-log4j2/pull/1210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wleese opened a new pull request, #1210:
URL: https://github.com/apache/logging-log4j2/pull/1210
… conversion parameter to an AnsiEscape enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ppkarwasz commented on PR #1148:
URL: https://github.com/apache/logging-log4j2/pull/1148#issuecomment-1383795952
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz commented on PR #503:
URL: https://github.com/apache/logging-log4j2/pull/503#issuecomment-1383515373
I close this, since Liquibase will publish their own plugin (cf. #1193).
@nvoxland, thank You for your contribution.
--
This is an automated message from the Apache Git
ppkarwasz closed pull request #503: Liquibase 4.x Compatibility
URL: https://github.com/apache/logging-log4j2/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ppkarwasz closed pull request #601: LOG4J2-3193 Configuration precedence fix
URL: https://github.com/apache/logging-log4j2/pull/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz commented on PR #601:
URL: https://github.com/apache/logging-log4j2/pull/601#issuecomment-1383514234
I am closing this since #742 refactored the property caching code and also
fixed property priority.
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] merged PR #15:
URL: https://github.com/apache/logging-log4j-tools/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] merged PR #16:
URL: https://github.com/apache/logging-log4j-tools/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dependabot[bot] opened a new pull request, #16:
URL: https://github.com/apache/logging-log4j-tools/pull/16
Bumps [spotless-maven-plugin](https://github.com/diffplug/spotless) from
2.29.0 to 2.30.0.
Changelog
Sourced from
dependabot[bot] opened a new pull request, #15:
URL: https://github.com/apache/logging-log4j-tools/pull/15
Bumps freemarker from 2.3.31 to 2.3.32.
[![Dependabot compatibility
ppkarwasz merged PR #1209:
URL: https://github.com/apache/logging-log4j2/pull/1209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ppkarwasz commented on issue #1207:
URL:
https://github.com/apache/logging-log4j2/issues/1207#issuecomment-1383269679
- running `spotless:apply`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on PR #1185:
URL: https://github.com/apache/logging-log4j2/pull/1185#issuecomment-1383265008
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
dependabot[bot] commented on PR #1184:
URL: https://github.com/apache/logging-log4j2/pull/1184#issuecomment-1383264927
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
dependabot[bot] commented on PR #1180:
URL: https://github.com/apache/logging-log4j2/pull/1180#issuecomment-1383264775
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1185: Bump jetty-bom from 9.4.49.v20220914 to
9.4.50.v20221201
URL: https://github.com/apache/logging-log4j2/pull/1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ppkarwasz closed pull request #1184: Bump netty-bom from 4.1.84.Final to
4.1.86.Final
URL: https://github.com/apache/logging-log4j2/pull/1184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1183:
URL: https://github.com/apache/logging-log4j2/pull/1183#issuecomment-1383264838
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1183: Bump jeromq from 0.5.2 to 0.5.3
URL: https://github.com/apache/logging-log4j2/pull/1183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ppkarwasz closed pull request #1180: Bump activemq-broker from 5.17.2 to 5.17.3
URL: https://github.com/apache/logging-log4j2/pull/1180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #1179:
URL: https://github.com/apache/logging-log4j2/pull/1179#issuecomment-1383264640
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1179: Bump elasticsearch-rest-high-level-client
from 7.17.6 to 7.17.8
URL: https://github.com/apache/logging-log4j2/pull/1179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #1182:
URL: https://github.com/apache/logging-log4j2/pull/1182#issuecomment-1383264553
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1182: Bump groovy-bom from 3.0.13 to 3.0.14
URL: https://github.com/apache/logging-log4j2/pull/1182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ppkarwasz closed pull request #1178: Bump spring-boot.version from 2.7.5 to
2.7.7
URL: https://github.com/apache/logging-log4j2/pull/1178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1178:
URL: https://github.com/apache/logging-log4j2/pull/1178#issuecomment-1383264427
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a
dependabot[bot] commented on PR #1181:
URL: https://github.com/apache/logging-log4j2/pull/1181#issuecomment-1383264339
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1181: Bump spring-framework-bom from 5.3.23 to
5.3.24
URL: https://github.com/apache/logging-log4j2/pull/1181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1177:
URL: https://github.com/apache/logging-log4j2/pull/1177#issuecomment-1383264258
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a
ppkarwasz closed pull request #1177: Bump mockito.version from 4.8.1 to 4.11.0
URL: https://github.com/apache/logging-log4j2/pull/1177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #1160:
URL: https://github.com/apache/logging-log4j2/pull/1160#issuecomment-1383264139
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1160: Bump jackson-bom from 2.13.4.20221013 to
2.14.1
URL: https://github.com/apache/logging-log4j2/pull/1160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1158:
URL: https://github.com/apache/logging-log4j2/pull/1158#issuecomment-1383264035
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1158: Bump wiremock-jre8 from 2.34.0 to 2.35.0
URL: https://github.com/apache/logging-log4j2/pull/1158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #1152:
URL: https://github.com/apache/logging-log4j2/pull/1152#issuecomment-1383263908
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
ppkarwasz closed pull request #1152: Bump spring-ws-core from 3.1.3 to 4.0.0
URL: https://github.com/apache/logging-log4j2/pull/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] commented on PR #1151:
URL: https://github.com/apache/logging-log4j2/pull/1151#issuecomment-1383263829
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a
ppkarwasz closed pull request #1151: Bump jmh.version from 1.35 to 1.36
URL: https://github.com/apache/logging-log4j2/pull/1151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ppkarwasz closed pull request #1134: Bump cassandra.version from 3.11.13 to
3.11.14
URL: https://github.com/apache/logging-log4j2/pull/1134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] commented on PR #1134:
URL: https://github.com/apache/logging-log4j2/pull/1134#issuecomment-1383263737
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a
1 - 100 of 7143 matches
Mail list logo
