[GitHub] logging-log4net issue #17: Save one frame from being accessed twice unnecess...

2017-11-09 Thread shubagarwal
Github user shubagarwal commented on the issue: https://github.com/apache/logging-log4net/pull/17 Update the description in first comment. Please check. ---

[jira] [Comment Edited] (LOG4J2-2106) May blocked when two compress action

2017-11-09 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247031#comment-16247031 ] Ralph Goers edited comment on LOG4J2-2106 at 11/10/17 5:38 AM:

[jira] [Comment Edited] (LOG4J2-2106) May blocked when two compress action

2017-11-09 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247031#comment-16247031 ] Ralph Goers edited comment on LOG4J2-2106 at 11/10/17 5:36 AM:

[jira] [Commented] (LOG4J2-2106) May blocked when two compress action

2017-11-09 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247031#comment-16247031 ] Ralph Goers commented on LOG4J2-2106: - The problem isn't that rollover is synchronize

[jira] [Commented] (LOG4J2-2106) May blocked when two compress action

2017-11-09 Thread skopt (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246928#comment-16246928 ] skopt commented on LOG4J2-2106: --- Reading the code, I find the cause. In the function rol

[jira] [Commented] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246821#comment-16246821 ] Paul Mendoza commented on LOG4NET-573: -- I was able to reproduce the issue. See my pr

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:21 AM: --

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:18 AM: --

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:16 AM: --

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:15 AM: --

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:14 AM: --

[jira] [Comment Edited] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza edited comment on LOG4NET-573 at 11/10/17 12:13 AM: --

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Frank Swanson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246629#comment-16246629 ] Frank Swanson commented on LOG4J2-2072: --- Thank you. Glad that worked out. I have o

[jira] [Created] (LOG4J2-2113) FlumeAppender should be updated to use Builder pattern

2017-11-09 Thread Frank Swanson (JIRA)
Frank Swanson created LOG4J2-2113: - Summary: FlumeAppender should be updated to use Builder pattern Key: LOG4J2-2113 URL: https://issues.apache.org/jira/browse/LOG4J2-2113 Project: Log4j 2 Is

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246603#comment-16246603 ] Matt Sicker commented on LOG4J2-2072: - Yeah, managers don't really need builders. The

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246575#comment-16246575 ] Ralph Goers commented on LOG4J2-2072: - I hadn't really noticed that this only touched

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Frank Swanson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246566#comment-16246566 ] Frank Swanson commented on LOG4J2-2072: --- [~ralph_go...@dslextreme.com] That makes s

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246523#comment-16246523 ] Ralph Goers commented on LOG4J2-2072: - >From past experience, changes to the factory

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Frank Swanson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246493#comment-16246493 ] Frank Swanson commented on LOG4J2-2072: --- I guess I am just a little confused regard

[jira] [Commented] (LOG4NET-573) Appenders Deadlock

2017-11-09 Thread Paul Mendoza (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246231#comment-16246231 ] Paul Mendoza commented on LOG4NET-573: -- I'm having a similar locking issue with log4

[jira] [Commented] (LOG4J2-2109) Add property to disable message pattern converter lookups

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246140#comment-16246140 ] ASF GitHub Bot commented on LOG4J2-2109: Github user cakofony commented on the is

[GitHub] logging-log4j2 issue #127: LOG4J2-2109: Added "log4j.format.msg.nolookups" g...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/127 There wasn't any test coverage for lookups in `MessagePatternConverterTest` so I've added a couple. ---

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246127#comment-16246127 ] Gary Gregory commented on LOG4J2-2072: -- I would welcome a PR to update the Flume app

[jira] [Commented] (LOG4J2-2072) Support TLS configuration through FlumeAppender

2017-11-09 Thread Frank Swanson (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246119#comment-16246119 ] Frank Swanson commented on LOG4J2-2072: --- Thank you for the links, Much appreciated.

[jira] [Commented] (LOG4J2-2109) Add property to disable message pattern converter lookups

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246118#comment-16246118 ] ASF GitHub Bot commented on LOG4J2-2109: Github user cakofony commented on the is

[GitHub] logging-log4j2 issue #127: LOG4J2-2109: Added "log4j.format.msg.nolookups" g...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/127 Updated, thanks for the info @jvz! ---

[jira] [Resolved] (LOG4NET-581) NullReferenceException from log4net.Util.ReadOnlyPropertiesDictionary.GetObjectData

2017-11-09 Thread Dominik Psenner (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Psenner resolved LOG4NET-581. - Resolution: Fixed Thanks for providing the patch. I committed the fix as 68aaff9a4cd8ad6

[jira] [Assigned] (LOG4NET-581) NullReferenceException from log4net.Util.ReadOnlyPropertiesDictionary.GetObjectData

2017-11-09 Thread Dominik Psenner (JIRA)
[ https://issues.apache.org/jira/browse/LOG4NET-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Psenner reassigned LOG4NET-581: --- Assignee: Dominik Psenner > NullReferenceException from > log4net.Util.ReadOnlyProp

[jira] [Commented] (LOG4J2-2109) Add property to disable message pattern converter lookups

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246002#comment-16246002 ] ASF GitHub Bot commented on LOG4J2-2109: Github user jvz commented on the issue:

[GitHub] logging-log4j2 issue #127: LOG4J2-2109: Added "log4j.format.msg.nolookups" g...

2017-11-09 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/logging-log4j2/pull/127 Could you rename this option to `log4j2.formatMsgNoLookups` or something similar? We have a new naming scheme in 2.10.0+ which follows `log4j2.camelCasePropertyName`. ---

[jira] [Commented] (LOG4J2-2107) MapMessage should support both StringBuilderFormattable and MultiformatMessage

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245995#comment-16245995 ] ASF GitHub Bot commented on LOG4J2-2107: Github user cakofony commented on the is

[jira] [Commented] (LOG4J2-2102) MapMessage JSON encoding should escape keys and values

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245996#comment-16245996 ] ASF GitHub Bot commented on LOG4J2-2102: Github user cakofony commented on the is

[jira] [Commented] (LOG4J2-2107) MapMessage should support both StringBuilderFormattable and MultiformatMessage

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245998#comment-16245998 ] ASF GitHub Bot commented on LOG4J2-2107: Github user cakofony commented on the is

[GitHub] logging-log4j2 issue #125: LOG4J2-2102: MapMessage Json encoding escapes key...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/125 Feel free to close this in favor of #129 if you prefer to iterate there. ---

[GitHub] logging-log4j2 issue #126: LOG4J2-2107: MapMessage allocation-free pattern c...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/126 Feel free to close this in favor of #129 if you prefer to iterate there. ---

[GitHub] logging-log4j2 issue #126: LOG4J2-2107: MapMessage allocation-free pattern c...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/126 Feel free to close this in favor of #129 if you prefer to iterate there. ---

[jira] [Commented] (LOG4J2-2101) non-string value MapMessage ClassCastException

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245988#comment-16245988 ] ASF GitHub Bot commented on LOG4J2-2101: GitHub user cakofony opened a pull reque

[GitHub] logging-log4j2 pull request #129: LOG4J2-2101: LOG4J2-2102: LOG4J2-2107: LOG...

2017-11-09 Thread cakofony
GitHub user cakofony opened a pull request: https://github.com/apache/logging-log4j2/pull/129 LOG4J2-2101: LOG4J2-2102: LOG4J2-2107: LOG4J2-2112: MapMessage Improvements This branch/pr combines #124 #125 #126 as well as a commit resolving LOG4J2-2112. The previous sep

[jira] [Created] (LOG4J2-2112) MapMessage should use deep toString for values

2017-11-09 Thread Carter Douglas Kozak (JIRA)
Carter Douglas Kozak created LOG4J2-2112: Summary: MapMessage should use deep toString for values Key: LOG4J2-2112 URL: https://issues.apache.org/jira/browse/LOG4J2-2112 Project: Log4j 2

[GitHub] logging-log4net issue #17: Save one frame from being accessed twice unnecess...

2017-11-09 Thread dpsenner
Github user dpsenner commented on the issue: https://github.com/apache/logging-log4net/pull/17 Would you please explain the changeset more verbosely? ---

[jira] [Created] (LOG4J2-2111) MongoDB appender - support for multiple servers connection URI

2017-11-09 Thread Mircea Gaceanu (JIRA)
Mircea Gaceanu created LOG4J2-2111: -- Summary: MongoDB appender - support for multiple servers connection URI Key: LOG4J2-2111 URL: https://issues.apache.org/jira/browse/LOG4J2-2111 Project: Log4j 2

[GitHub] logging-log4j2 issue #124: LOG4J2-2101: MapMessage correctly handles non-str...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/124 I would like to update MapMessage to take advantage of `PatternFormatter.recursiveDeepToString` for more efficient value handling, but I think that makes sense in a follow up commit.

[jira] [Commented] (LOG4J2-2101) non-string value MapMessage ClassCastException

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245691#comment-16245691 ] ASF GitHub Bot commented on LOG4J2-2101: Github user cakofony commented on the is

[jira] [Commented] (LOG4J2-2101) non-string value MapMessage ClassCastException

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245688#comment-16245688 ] ASF GitHub Bot commented on LOG4J2-2101: Github user cakofony commented on a diff

[GitHub] logging-log4j2 pull request #124: LOG4J2-2101: MapMessage correctly handles ...

2017-11-09 Thread cakofony
Github user cakofony commented on a diff in the pull request: https://github.com/apache/logging-log4j2/pull/124#discussion_r149968256 --- Diff: log4j-api/src/main/java/org/apache/logging/log4j/message/MapMessage.java --- @@ -200,7 +200,7 @@ public void put(final String key, final S

[jira] [Commented] (LOG4J2-2110) Log4jServletContextListener skips initialization and thusly never calls stop()

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245647#comment-16245647 ] ASF GitHub Bot commented on LOG4J2-2110: GitHub user thomasbeauvais opened a pull

[jira] [Commented] (LOG4J2-2105) ClassLoaderContextSelector should key based on log4j classes

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245646#comment-16245646 ] ASF GitHub Bot commented on LOG4J2-2105: Github user cakofony commented on the is

[GitHub] logging-log4j2 pull request #128: LOG4J2-2110 adding a ServletContext parame...

2017-11-09 Thread thomasbeauvais
GitHub user thomasbeauvais opened a pull request: https://github.com/apache/logging-log4j2/pull/128 LOG4J2-2110 adding a ServletContext parameter to allow the contextIni… Please refer to https://issues.apache.org/jira/browse/LOG4J2-2110 You can merge this pull request into a

[GitHub] logging-log4j2 issue #113: LOG4J2-2105: ClassLoaderContextSelector more resi...

2017-11-09 Thread cakofony
Github user cakofony commented on the issue: https://github.com/apache/logging-log4j2/pull/113 It's possible that this is undesirable if we expect containers to provide log4j libraries to child contexts. ---

[jira] [Commented] (LOG4J2-2109) Add property to disable message pattern converter lookups

2017-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245643#comment-16245643 ] ASF GitHub Bot commented on LOG4J2-2109: GitHub user cakofony opened a pull reque

[GitHub] logging-log4j2 pull request #127: LOG4J2-2109: Added "log4j.format.msg.noloo...

2017-11-09 Thread cakofony
GitHub user cakofony opened a pull request: https://github.com/apache/logging-log4j2/pull/127 LOG4J2-2109: Added "log4j.format.msg.nolookups" global configuration This allows applications to globally disable message pattern from looking up replacements without specifying "%m{nolo

[jira] [Created] (LOG4J2-2110) Log4jServletContextListener skips initialization and thusly never calls stop()

2017-11-09 Thread Thomas Beauvais (JIRA)
Thomas Beauvais created LOG4J2-2110: --- Summary: Log4jServletContextListener skips initialization and thusly never calls stop() Key: LOG4J2-2110 URL: https://issues.apache.org/jira/browse/LOG4J2-2110

[jira] [Created] (LOG4J2-2109) Add property to disable message pattern converter lookups

2017-11-09 Thread Carter Douglas Kozak (JIRA)
Carter Douglas Kozak created LOG4J2-2109: Summary: Add property to disable message pattern converter lookups Key: LOG4J2-2109 URL: https://issues.apache.org/jira/browse/LOG4J2-2109 Project: Log

[GitHub] logging-log4net pull request #17: Save one frame from being accessed twice u...

2017-11-09 Thread shubagarwal
GitHub user shubagarwal opened a pull request: https://github.com/apache/logging-log4net/pull/17 Save one frame from being accessed twice unnecessarily in ctor of LocationInfo The last frame in stack with declaringType as callerStackBoundaryDeclaringType was being accessed in both