[GitHub] lkishalmi opened a new pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled.
lkishalmi opened a new pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled. URL: https://github.com/apache/incubator-netbeans/pull/1138 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled.
jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not
dump ambiguous output when a build is cancelled.
URL:
https://github.com/apache/incubator-netbeans/pull/1138#discussion_r257491682
##
File path:
groovy/gradle/src/org/netbeans/modules/gradle/execute/EscapeProcessingOutputStream.java
##
@@ -29,9 +29,10 @@
* @author Laszlo Kishalmi
*/
class EscapeProcessingOutputStream extends OutputStream {
-
+
boolean esc;
boolean csi;
+boolean closed = false;
Review comment:
I wonder if some kind of synchronization is needed for the field? (Maybe
AtomicBoolean instead of plain boolean?)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled.
jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled. URL: https://github.com/apache/incubator-netbeans/pull/1138#discussion_r257491636 ## File path: groovy/gradle/src/org/netbeans/modules/gradle/execute/GradleDaemonExecutor.java ## @@ -69,6 +69,9 @@ private static final Logger LOGGER = Logger.getLogger(GradleDaemonExecutor.class.getName()); private final ProgressHandle handle; +private OutputStream outStream; Review comment: So, assuming the cancel can be asynchronous, I wonder if there's a need for synchronization for these fields? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not dump ambiguous output when a build is cancelled.
jlahoda commented on a change in pull request #1138: [NETBEANS-2038] Do not
dump ambiguous output when a build is cancelled.
URL:
https://github.com/apache/incubator-netbeans/pull/1138#discussion_r257491644
##
File path:
groovy/gradle/src/org/netbeans/modules/gradle/execute/GradleDaemonExecutor.java
##
@@ -167,12 +168,15 @@ public void run() {
buildLauncher.run();
StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_SUCCESS(getProjectName()));
} catch (BuildCancelledException ex) {
-try {
-IOColorPrint.print(io, "\nBUILD ABORTED\n",
IOColors.getColor(io, IOColors.OutputType.ERROR)); //NOI18N
-} catch (IOException iex) {
-}
+showAbort();
} catch (UncheckedException | BuildException ex) {
-
StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_FAILED(getProjectName()));
+if (!cancelling) {
+
StatusDisplayer.getDefault().setStatusText(Bundle.BUILD_FAILED(getProjectName()));
+} else {
+// This can happen if cancelling a Gradle build which is
running
+// an external aplication
+showAbort();
+}
//TODO: Handle Cancelled builds
Review comment:
Nit: these comments are probably obsolete now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] matthiasblaesing merged pull request #1137: fix editor hint typo in java/java ee/jpa
matthiasblaesing merged pull request #1137: fix editor hint typo in java/java ee/jpa URL: https://github.com/apache/incubator-netbeans/pull/1137 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] jlahoda opened a new pull request #1139: [NETBEANS-2120] Placing synthetically generated classes in spi.java.h…
jlahoda opened a new pull request #1139: [NETBEANS-2120] Placing synthetically generated classes in spi.java.h… URL: https://github.com/apache/incubator-netbeans/pull/1139 …ints into an accessible package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] iapostolidis opened a new pull request #1137: fix editor hint typo in java/java ee/jpa
iapostolidis opened a new pull request #1137: fix editor hint typo in java/java ee/jpa URL: https://github.com/apache/incubator-netbeans/pull/1137 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] iajn commented on issue #1048: NETBEANS-1774 Use fragment host instead of fragment bundle for class loading in Netigso
iajn commented on issue #1048: NETBEANS-1774 Use fragment host instead of fragment bundle for class loading in Netigso URL: https://github.com/apache/incubator-netbeans/pull/1048#issuecomment-464350428 Sorry, I haven't had time to look into the tests yet. I'll try to get them done during the next couple of weeks now that our product release is over and done with. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] matthiasblaesing commented on issue #1137: fix editor hint typo in java/java ee/jpa
matthiasblaesing commented on issue #1137: fix editor hint typo in java/java ee/jpa URL: https://github.com/apache/incubator-netbeans/pull/1137#issuecomment-464351085 Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
