[jira] [Commented] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709379#comment-16709379 ] Mathieu Lirzin commented on OFBIZ-10691: I have included a series of patches to improve the

[jira] [Updated] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10691: --- Attachment: OFBIZ-10691_0001-Remove-EntityConditionBase-class.patch

[jira] [Created] (OFBIZ-10691) Refactoring ‘EntityCondition’

2018-12-04 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10691: -- Summary: Refactoring ‘EntityCondition’ Key: OFBIZ-10691 URL: https://issues.apache.org/jira/browse/OFBIZ-10691 Project: OFBiz Issue Type: Improvement

[jira] [Comment Edited] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708481#comment-16708481 ] Jacques Le Roux edited comment on OFBIZ-10689 at 12/4/18 9:45 AM: -- Also

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708481#comment-16708481 ] Jacques Le Roux commented on OFBIZ-10689: - Also there are some (hopefully rare) cases where it

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708475#comment-16708475 ] Jacques Le Roux commented on OFBIZ-10689: - Not quite, from {{ObjectTypeTests.java}} List, Map,

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708413#comment-16708413 ] Deepak Dixit commented on OFBIZ-10689: -- I think simpleTypeConvert is the right name. > function

[jira] [Commented] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708403#comment-16708403 ] Jacques Le Roux commented on OFBIZ-10689: - I can't find any bq.

[jira] [Updated] (OFBIZ-10689) function parseBigDecimalForEntity is in wrong location

2018-12-04 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-10689: Attachment: OFBIZ-10689-simpleTypeOrObjectConvert.patch > function