[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Taher Alkhateeb commented on OFBIZ-9182 Re: create a separate svn repository for OFBiz official plugins Hello Nicolas and Jacques, I will answer both your questions / comments here since they are related. This is my proposition for how the plugin mechanism works (nothing concrete yet, just ideas): All OFBiz future releases would have equivalent plugin releases. So for example, if we have say .. release 18.04, we can have a plugin with the same version that is guaranteed to be compatible. You download the plugin using the ./gradlew pullPlugin, and NOT the ./gradlew pullPluginSource OFBiz trunk, on the other hand, is not a released code. So, in order to install and test plugins for Trunk, you use the ./gradlew pullPluginSource So published plugins exist only for releases (NOT for trunk). In my opinion this would greatly simplify the release process and it would give us independence from the underlying source code revision system. In other words, it does not make a lot of sense to go down to revision-by-revision tracking of what works with that, that's just too much work. Instead, it's much easier to just have releases (with matching numbers) between released framework and plugins, and to have source-code to source-code compatibility between the ofbiz source code and the plugins source code. So the next question is, how do we make sure that trunk always works with plugins? Well, the simplest answer that I can come up with is automated builds. We can have one buildbot script for OFBiz, and another buildbot script for Plugins. This way we can always catch problems while maintaining separate repositories. So these are my thoughts, you're welcome to modify or start discussing on ML for more Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Taher Alkhateeb updated an issue OFBiz / OFBIZ-9182 create a separate svn repository for OFBiz official plugins Change By: Taher Alkhateeb This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order)# Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml# Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server serve "Trunk" because it always needs the latest source code of the plugins.# delete plugins/component-load.xml# move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins# move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework# fix buildbot to point to the new framework location# update documentation where applicable including README.md Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15849796#comment-15849796 ] Taher Alkhateeb commented on OFBIZ-9182: Hi Nicolas, What would be the purpose of getting the latest plugin form version control to a release? > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852737#comment-15852737 ] Taher Alkhateeb commented on OFBIZ-9182: We can have a task, for example, called pullPluginSourceAll to pull everything in the plugins repository. The reason I am making a recommendation to stick with gradle tasks as opposed to depending on the underlying version control system is to reduce complexity. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852726#comment-15852726 ] Taher Alkhateeb commented on OFBIZ-9182: all mentioned types of users above can use pullPluginSource. I'm missing the exact point of added value of of using a different solution to pull the source code in multiple different ways. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852717#comment-15852717 ] Taher Alkhateeb commented on OFBIZ-9182: I agree with Nicolas, why introduce two solutions? Let's take it one step at a time. I see no benefit to confusing users with two ways of achieving the same thing. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852742#comment-15852742 ] Taher Alkhateeb commented on OFBIZ-9182: Well, svn externals could be an implementation detail then embedded inside pullPluginSourceAll. Anway, I'm tired of going over this painful level of detail when we did not restructure yet. I would really rather postpone this discussion until we get the pieces working first, and I really think this discussion should go in the ML given its broad scope and impact > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851242#comment-15851242 ] Taher Alkhateeb commented on OFBIZ-9182: I don't think you got what I said about the two ways to pull (externals is not related here). I'll try to explain some more the benefits of the approach in the patch. - First of all, the pullPluginSource won't stop you from using subversion if you want to. It's just a convenience task - In the first implementation way I described above, you need svn installed, in the second you don't - also using my patch we do not rely on a specific version control system. We can change it by changing implementation of pullPluginSource - with pullPluginSource we can easily add the logic to pull dependencies which we cannot do with raw subversion. The implementation is already there in "pullPlugin". - activating / deactivating plugins (or any component) can be done using ofbiz-component.xml. I don't understand why component-load.xml is needed in your argument above. Anyway, If you want to change the implementation then open this discussion in the ML > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Taher Alkhateeb commented on OFBIZ-9182 Re: create a separate svn repository for OFBiz official plugins removed activate / deactivate plugin in r1780828. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title
Taher Alkhateeb updated an issue
OFBiz / OFBIZ-9182
create a separate svn repository for OFBiz official plugins
There are two ways to pull a plugin from source: Either have subversion installed on the machine and use exec {...}
OR use an embedded subversion based on Java and hence avoid dependence on environment.
Attached is a solution that is independent of the environment, it pulls extra dependencies which is why I share here before committing to see if we can improve this.
Change By:
Taher Alkhateeb
Attachment:
OFBIZ-9182-subversion-embedded.patch
Add Comment
This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Commented] (OFBIZ-9176) PDF print with English and Arabic words
[ https://issues.apache.org/jira/browse/OFBIZ-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839398#comment-15839398 ] Taher Alkhateeb commented on OFBIZ-9176: Hello Bahaaldin, If the issue is resolved, then I suggest to provide exactly how you solved it (what font, where did you get it from, where did you place it) so that it can be used in future reference and then close this JIRA > PDF print with English and Arabic words > --- > > Key: OFBIZ-9176 > URL: https://issues.apache.org/jira/browse/OFBIZ-9176 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release, Release Branch 16.11 > Environment: windows , with jdk 1.8 >Reporter: bahaaldin Alamood >Priority: Minor > Labels: language > Attachments: ARCI30(2).pdf > > > Arabic words a disjointed and treated them like English print and this is > not the way Arabic works because Arabic is written like a script and the > letters join in a word > When using NotoSans fonts the arabic characters appear as ## ### -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Taher Alkhateeb commented on OFBIZ-9182 Re: create a separate svn repository for OFBiz official plugins First commit delivered in r1780790 which enables plugins to load without component-load.xml. Most of the work went into the build scripts. The next step is to create "pullPluginSource" gradle task to handle pulling plugins into the code base. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Commented] (OFBIZ-9182) Create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875667#comment-15875667 ] Taher Alkhateeb commented on OFBIZ-9182: Disabled the gradle daemon in the embedded plugins API in r1783852. This would help tackle any memory issues. Next, I am designing the pullAllPluginSource hopefully with an efficient algorithm in preparation for creating two buildbot scripts (one for framework and one for plugins). > Create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch, pluginsList.txt, > pullAllPluginsSource.log > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9219) Delete obsolete branches
[ https://issues.apache.org/jira/browse/OFBIZ-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873606#comment-15873606 ] Taher Alkhateeb commented on OFBIZ-9219: Hmm, I doubt we'll salvage much work out of it. But if you feel it has value, then we can keep it. Any problem with dropping the other two? > Delete obsolete branches > > > Key: OFBIZ-9219 > URL: https://issues.apache.org/jira/browse/OFBIZ-9219 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > > At https://s.apache.org/k7pD in relation with INFRA-13497 we discussed the > opportunity to clean the branches in OFBiz: > bq. I think we should remove a lot of useless and old confusing branches in > svn > Here is a list of branches. In a first pass, I checked the branches I propose > to remove, please comment, thanks. > |Branch |To drop | > |2013_RemoveJavolution| x| > |2015ScreenWidgetRedesign |x | > |20111205EmailHandling| x| > |20120209RemoveBsh| x| > |20120329_portletWidget | x| > |Dojo1.4 | x| > |OFBIZ-4098-make-cache-pluggable | | > |OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23| x| > |OFBIZ-6270 | x| > |OFBIZ-6271 | x| > |OFBIZ-6275 | x| > |Webhelp-2012-12-07 | | > |addBirt | x| > |addbirt | x| > |boostrap_theme | | > |dojo1.4 | x| > |executioncontext20090716 | x| > |executioncontext20090812 | x| > |executioncontext20091231 | x| > |framework-api-cleanup| x| > |frontendNewTheme2013-05-10 | | > |htmlfive_20110529| | > |improved-entityengine-features-20120528 | | > |jackrabbit20100709 | x| > |jackrabbit20120501 | | > |jquery | x| > |json-integration-refactoring | | > |multitenant20100310 | | > |new_branch | x| > |release4.0 | | > |release09.04 | | > |release10.04 | | > |release11.04 | | > |release12.04 | | > |release13.07 | | > |release14.12 | | > |release15.12 | | > |release16.11 | | > |trunk| | > |typecheckcleanup200810 | x| > |webhelp-2012-12-07 | | > |beforejQuery | x| > |beforeSvnRestructuring | | > |beforeGradle | | > |RemovingPOS | | > |REL-16.11.01 | | > |REL-13.07.03 | | > |REL-13.07.02 | | > |REL-13.07.01 | | > |REL-12.04.06 | | > |REL-12.04.05 | | > |REL-12.04.04 | | > |REL-12.04.03 | | > |REL-12.04.02 | | > |REL-12.04.01 | | > |REL-11.04.06 | | > |REL-11.04.05 | | > |REL-11.04.04 | | > |REL-11.04.03 | | > |REL-11.04.02 | | > |REL-11.04.01 | | > |REL-10.04.06 | | > |REL-10.04.05 | | > |REL-10.04.04 | | > |REL-10.04.03 | | > |REL-10.04.02 | | > |REL-10.04| | > |REL-09.04.02 | | > |REL-09.04.01 | | > |REL-09.04| | > |REL-4.0 | | > I also wrote in the same email: > bq. document the fact in GitHub that the ofbiz-framework/trunk is the new > trunk. But how I'm still unsure, I guess at top of the README.MD ? > Please comment on this aspect too, and create a new Jira if you feel the need. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9219) Delete obsolete branches
[ https://issues.apache.org/jira/browse/OFBIZ-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873592#comment-15873592 ] Taher Alkhateeb commented on OFBIZ-9219: Why not also delete jackrabbit20120501, htmlfive_20110529 and webhelp-2012-12-07 . Let's clean up while we're at it. > Delete obsolete branches > > > Key: OFBIZ-9219 > URL: https://issues.apache.org/jira/browse/OFBIZ-9219 > Project: OFBiz > Issue Type: Improvement >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > > At https://s.apache.org/k7pD in relation with INFRA-13497 we discussed the > opportunity to clean the branches in OFBiz: > bq. I think we should remove a lot of useless and old confusing branches in > svn > Here is a list of branches. In a first pass, I checked the branches I propose > to remove, please comment, thanks. > |Branch |To drop | > |2013_RemoveJavolution| x| > |2015ScreenWidgetRedesign |x | > |20111205EmailHandling| x| > |20120209RemoveBsh| x| > |20120329_portletWidget | x| > |Dojo1.4 | x| > |OFBIZ-4098-make-cache-pluggable | | > |OFBIZ-5312-ofbiz-ecommerce-seo-2013-10-23| x| > |OFBIZ-6270 | x| > |OFBIZ-6271 | x| > |OFBIZ-6275 | x| > |Webhelp-2012-12-07 | | > |addBirt | x| > |addbirt | x| > |boostrap_theme | | > |dojo1.4 | x| > |executioncontext20090716 | x| > |executioncontext20090812 | x| > |executioncontext20091231 | x| > |framework-api-cleanup| x| > |frontendNewTheme2013-05-10 | | > |htmlfive_20110529| | > |improved-entityengine-features-20120528 | | > |jackrabbit20100709 | x| > |jackrabbit20120501 | | > |jquery | x| > |json-integration-refactoring | | > |multitenant20100310 | | > |new_branch | x| > |release4.0 | | > |release09.04 | | > |release10.04 | | > |release11.04 | | > |release12.04 | | > |release13.07 | | > |release14.12 | | > |release15.12 | | > |release16.11 | | > |trunk| | > |typecheckcleanup200810 | x| > |webhelp-2012-12-07 | | > |beforejQuery | x| > |beforeSvnRestructuring | | > |beforeGradle | | > |RemovingPOS | | > |REL-16.11.01 | | > |REL-13.07.03 | | > |REL-13.07.02 | | > |REL-13.07.01 | | > |REL-12.04.06 | | > |REL-12.04.05 | | > |REL-12.04.04 | | > |REL-12.04.03 | | > |REL-12.04.02 | | > |REL-12.04.01 | | > |REL-11.04.06 | | > |REL-11.04.05 | | > |REL-11.04.04 | | > |REL-11.04.03 | | > |REL-11.04.02 | | > |REL-11.04.01 | | > |REL-10.04.06 | | > |REL-10.04.05 | | > |REL-10.04.04 | | > |REL-10.04.03 | | > |REL-10.04.02 | | > |REL-10.04| | > |REL-09.04.02 | | > |REL-09.04.01 | | > |REL-09.04| | > |REL-4.0 | | > I also wrote in the same email: > bq. document the fact in GitHub that the ofbiz-framework/trunk is the new > trunk. But how I'm still unsure, I guess at top of the README.MD ? > Please comment on this aspect too, and create a new Jira if you feel the need. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) Create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873126#comment-15873126 ] Taher Alkhateeb commented on OFBIZ-9182: I'm already working on this task Jacques. There is no need to rush > Create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch, pluginsList.txt, > pullAllPluginsSource.log > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862739#comment-15862739 ] Taher Alkhateeb commented on OFBIZ-9182: Not yet done, we still have buildbot and making sure the API works correctly > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) Create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863764#comment-15863764 ] Taher Alkhateeb commented on OFBIZ-9182: why for what purpose? > Create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862399#comment-15862399 ] Taher Alkhateeb commented on OFBIZ-9182: Committed the implementation of pullPluginSource and also updated README.md in r1782605 > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9182: --- Description: This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order) # Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml # Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server "Trunk" because it always needs the latest source code of the plugins. # delete plugins/component-load.xml # move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins # move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework # fix buildbot to point to the new framework location # update README.md was: This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order) # Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml # Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server "Trunk" because it always needs the latest source code of the plugins. # delete plugins/component-load.xml # move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins # move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework # update README.md > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly server "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update README.md -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9182: --- Description: This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order) # Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml # Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server "Trunk" because it always needs the latest source code of the plugins. # delete plugins/component-load.xml # move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins # move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework # fix buildbot to point to the new framework location # update documentation where applicable including README.md was: This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order) # Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml # Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server "Trunk" because it always needs the latest source code of the plugins. # delete plugins/component-load.xml # move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins # move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework # fix buildbot to point to the new framework location # update README.md > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly server "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Taher Alkhateeb created OFBIZ-9182: -- Summary: create a separate svn repository for OFBiz official plugins Key: OFBIZ-9182 URL: https://issues.apache.org/jira/browse/OFBIZ-9182 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Release Reporter: Taher Alkhateeb Priority: Minor This issue is related to the discussion found in [this thread|https://s.apache.org/aohk] in which the community approved restructuring our repositories. To achieve this task the following needs to be done (in this order) # Update the gradle scripts to assume that no plugins exist in the plugins directory by default and no component-load.xml exists. It should follow the same logic in loading the components as found in the ComponentContainer class. Also the activation and deactivation of plugins happens in ofbiz-component.xml, not in component-load.xml # Add a new task to gradle called pullPluginSource that retrieves a plugin from subversion and defaults to the official plugins repository of Apache OFBiz. This task mostly server "Trunk" because it always needs the latest source code of the plugins. # delete plugins/component-load.xml # move all plugins to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins # move the core framework to a new repository called http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework # update README.md -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9176) PDF print with English and Arabic words
[ https://issues.apache.org/jira/browse/OFBIZ-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824400#comment-15824400 ] Taher Alkhateeb commented on OFBIZ-9176: Hello, to ease the investigation and save time, would it be possible to write down the repeat steps and location from which the report is generated? > PDF print with English and Arabic words > --- > > Key: OFBIZ-9176 > URL: https://issues.apache.org/jira/browse/OFBIZ-9176 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release, Release Branch 16.11 > Environment: windows , with jdk 1.8 >Reporter: bahaaldin Alamood >Priority: Minor > Labels: language > Attachments: ARCI30(2).pdf > > > Arabic words a disjointed and treated them link English print and this is > not the way Arabic works because Arabic is written like a script and the > letters join in a word > When using NotoSans fonts the arabic characters appear as ## ### -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-9176) PDF print with English and Arabic words
[ https://issues.apache.org/jira/browse/OFBIZ-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-9176: --- Affects Version/s: Upcoming Release > PDF print with English and Arabic words > --- > > Key: OFBIZ-9176 > URL: https://issues.apache.org/jira/browse/OFBIZ-9176 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Upcoming Release, Release Branch 16.11 > Environment: windows , with jdk 1.8 >Reporter: bahaaldin Alamood >Priority: Minor > Labels: language > Attachments: ARCI30(2).pdf > > > Arabic words a disjointed and treated them link English print and this is > not the way Arabic works because Arabic is written like a script and the > letters join in a word > When using NotoSans fonts the arabic characters appear as ## ### -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7962) Migrate the patch management Ant targets
[ https://issues.apache.org/jira/browse/OFBIZ-7962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428565#comment-15428565 ] Taher Alkhateeb commented on OFBIZ-7962: Hi Jacques, FYI I am working on a PoC for the plugin system. The idea that I have in mind is for each plugin to contain a task called "install". This task executes custom logic such as applying patches or whatever is needed for the plugin to be operational in the system. Looking at these older tasks, I would suggest that we do not implement them, but instead unify the process in the plugin "install" and possibly "uninstall" tasks. Here are the reasons for my suggestions: - First of all, these older tasks only apply patches, preparing a test/dev/production environment involves much more than just patching. There is database setup and other environment factors to consider. Hence the solution is not really complete nor is it preparing the system for test/dev/production (or doing it only partially). - They are fragile because there is no dependency management. Thus one component could override / conflict with other components. - They are dependent on the version control system and external tools (patch) which is perhaps not the best idea. We can instead deploy java-based diff libraries or other solutions that are independent of surrounding environment. Code so far is still a WIP but I thought I'd note it here to avoid conflicting targets. > Migrate the patch management Ant targets > > > Key: OFBIZ-7962 > URL: https://issues.apache.org/jira/browse/OFBIZ-7962 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux > Fix For: Upcoming Branch > > > We need to migrate the patch management Ant targets which are documented at > https://cwiki.apache.org/confluence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz#AddressingCustomRequirementsInOFBiz-PatchManagementUsingGradleTargets -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7534) Migrate OFBiz from Apache Ant to Gradle build system
[ https://issues.apache.org/jira/browse/OFBIZ-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7534: --- Attachment: OFBIZ_DEPENDENCIES_BEFORE_REFACTORING OFBIZ_DEPENDENCIES_AFTER_REFACTORING I have removed 42 libraries not needed (redundant) in r1757074 from the master build.gradle script as they are pulled automatically from dependencies. This makes the script nicer and a little cleaner. Attached are two files to show the dependency graph before and after > Migrate OFBiz from Apache Ant to Gradle build system > > > Key: OFBIZ-7534 > URL: https://issues.apache.org/jira/browse/OFBIZ-7534 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: ant, build-tools, gradle > Attachments: ANT_GRADLE_COMPARISON.txt, OFBIZ-7534.patch, > OFBIZ-7534.patch, OFBIZ-7534.patch, OFBIZ-7534.patch, > OFBIZ_DEPENDENCIES_AFTER_REFACTORING, OFBIZ_DEPENDENCIES_BEFORE_REFACTORING, > OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, OFBizRemoteJarList.csv, > OFBizRemoteJarList.csv, gradle-wrapper.jar > > > This is a major refactoring task referring to the [email > thread|http://ofbiz.markmail.org/message/vstt3wxuubmjgmqj?q=Important+Changes+to+Trunk+and+Use+of+Ant+%26+Gradle] > in which the community voted for the switch after a proposal from the PMC > The purpose of this JIRA is to achieve the following objectives > - Fully implement a working compiling system in Gradle that passes all tests > - Remove all ant and maven build scripts from the system > - update the documentation of the system to reflect these changes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7963) Create a Gradle Sonar task
[ https://issues.apache.org/jira/browse/OFBIZ-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429259#comment-15429259 ] Taher Alkhateeb commented on OFBIZ-7963: Hi Jacques, Is this necessary at this point in time? Sonar requires first a lot of code cleanup which we did not yet complete. Perhaps we can put this in your backlog or wiki for ideas on what to do? > Create a Gradle Sonar task > -- > > Key: OFBIZ-7963 > URL: https://issues.apache.org/jira/browse/OFBIZ-7963 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > As ever the devil is in details. There is no longer a Sonar plugin available > https://docs.gradle.org/current/userguide/sonar_plugin.htmland we should > rather refer to > http://docs.sonarqube.org/display/SCAN/Analyzing+with+SonarQube+Scanner+for+Gradle > Anyway the most important part is to revivify INFRA-3590 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434622#comment-15434622 ] Taher Alkhateeb commented on OFBIZ-7918: Also I could be wrong, but my understanding for Assignee is the person who will commit the code, to avoid conflict with other committers who might want to help and commit the work. When you put yourself as the assignee, then it becomes confusing who is going to commit. > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434618#comment-15434618 ] Taher Alkhateeb commented on OFBIZ-7918: Then these keys do not belong in this JIRA and should be submitted together with the report improvements. Otherwise, again we add to the mess. The labels in OFBiz are one area with a big mess and many keys that are not used anywhere and should be deleted. > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434658#comment-15434658 ] Taher Alkhateeb commented on OFBIZ-7918: A little help with the reference please? > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7783) External library files are not in the OFBiz folder structure.
[ https://issues.apache.org/jira/browse/OFBIZ-7783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434644#comment-15434644 ] Taher Alkhateeb commented on OFBIZ-7783: To my understanding, and as per your feedback, a binary release is one which you do not need to compile. So what would it be useful for? It would be things like: - A desktop application that you just want to download and run - A server application with complex setup requirements What are the requirements in OFBiz? - Install Java - ./gradlew loadDefault ofbiz So I would think that such releases are unnecessary because: - There is very little required for OFBiz to run, just install java - The type of adopters for this kind of software are more than capable of running gradle commands. - You can't ship a binary with the correct requirements. Do you load default data? Do you load minimal seed data? And what do you do with the build tools? Strip them away? That does not sound suitable as is the case with Desktop applications for example. Too much complexity for no added value in my opinion. > External library files are not in the OFBiz folder structure. > - > > Key: OFBIZ-7783 > URL: https://issues.apache.org/jira/browse/OFBIZ-7783 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > With the implementation of the external library download feature of > gradle/gradlew, the external libraries (jar files) are not in the folder > structure any more. > They should reside there, like before. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434571#comment-15434571 ] Taher Alkhateeb commented on OFBIZ-7918: Hello, I note there are "new" keys in this patch. Why? > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7918) Improve Dutch labels regarding accounting reports
[ https://issues.apache.org/jira/browse/OFBIZ-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434693#comment-15434693 ] Taher Alkhateeb commented on OFBIZ-7918: This statement is not called for. Here we are interacting with you based on your email to ML, we are also checking the quality of your work and making comments on what is wrong with it (twice so far) > Improve Dutch labels regarding accounting reports > - > > Key: OFBIZ-7918 > URL: https://issues.apache.org/jira/browse/OFBIZ-7918 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Attachments: OFBIZ-7918-AccountingUiLabels.xml-v2.patch, > OFBIZ-7918-AccountingUiLabels.xml.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
Taher Alkhateeb created OFBIZ-7972: -- Summary: Create a (PoC) plugin system for OFBiz based on Gradle Key: OFBIZ-7972 URL: https://issues.apache.org/jira/browse/OFBIZ-7972 Project: OFBiz Issue Type: Improvement Affects Versions: Upcoming Branch Reporter: Taher Alkhateeb Assignee: Taher Alkhateeb This JIRA houses the attempt to create a plugin system for OFBiz based on gradle. The plugin system should have the following features: - It is independent of the version control system, file system, operating system and any other environment tools surrounding OFBiz. Instead, it should be fully integrated with OFBiz. - It should unify the way OFBiz is extended, both for official supported plugins and for third party plugins - The plugin system takes advantage of the concept of a "component" in OFBiz and utilize it as the building block for plugins - The plugin system supports the concepts of "Repository" and "Dependency Management". If possible, the plugin system will utilize these concepts directly from Gradle instead of writing them from scratch. The initial API for the plugin system will be small and expands as needed. The API should include the following gradle tasks: - createPlugin: creates a new plugin based on templates and place it in the plugins directory - activatePlugin: Make an inactive plugin active (compile and start with the system). - deactivatePlugin: Make an active plugin inactive (does not compile nor start with the system) - installPlugin: either install an existing plugin in the filesystem, or download and install the plugin from a remote repository. Installation happens by running the install script which is designed by the plugin author. By default installPlugin also activates the plugin. - uninstallPlugin: Uninstall an already installed plugin by running its uninstall script. By default uninstallPlugin also deactivates the plugin, but does not delete it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7782) Duplicates of .properties and Label files appear in build/libs.ofbiz.jar
[ https://issues.apache.org/jira/browse/OFBIZ-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436816#comment-15436816 ] Taher Alkhateeb commented on OFBIZ-7782: Would you kindly elaborate on what you mean by this point and what is it that we should do? > Duplicates of .properties and Label files appear in build/libs.ofbiz.jar > > > Key: OFBIZ-7782 > URL: https://issues.apache.org/jira/browse/OFBIZ-7782 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits > Attachments: OFBIZ-7782-build.gradle.patch, Screen Shot 2016-07-13 at > 10.05.43.png > > > With the switch to gradle/gradlew .properties and the label definition files > get duplicated into the build folder. See attached screenshot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7973) Add standard services for WorkEffortAttribute creation
[ https://issues.apache.org/jira/browse/OFBIZ-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436898#comment-15436898 ] Taher Alkhateeb commented on OFBIZ-7973: Thank you for your work Leila, your patch is submitted in r1757689. I tested all services and they work on my machine, nice work. It would be great if you can help us out on the user interface level by designing the attributes entry screens as well. > Add standard services for WorkEffortAttribute creation > -- > > Key: OFBIZ-7973 > URL: https://issues.apache.org/jira/browse/OFBIZ-7973 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Leila Mekika >Assignee: Taher Alkhateeb >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7973.patch > > > This patch add entity-auto services for WorkEffortAttribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (OFBIZ-7973) Add standard services for WorkEffortAttribute creation
[ https://issues.apache.org/jira/browse/OFBIZ-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb reassigned OFBIZ-7973: -- Assignee: Taher Alkhateeb > Add standard services for WorkEffortAttribute creation > -- > > Key: OFBIZ-7973 > URL: https://issues.apache.org/jira/browse/OFBIZ-7973 > Project: OFBiz > Issue Type: Improvement > Components: workeffort >Affects Versions: Trunk >Reporter: Leila Mekika >Assignee: Taher Alkhateeb >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-7973.patch > > > This patch add entity-auto services for WorkEffortAttribute -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8119) Character encoding issue found in file build.gradle
[ https://issues.apache.org/jira/browse/OFBIZ-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460472#comment-15460472 ] Taher Alkhateeb commented on OFBIZ-8119: hello, gradle encoding is already UTF-8 by default. I think some of your files are not in compliance. I can't tell for sure because the screenshot is in chinese. > Character encoding issue found in file build.gradle > --- > > Key: OFBIZ-8119 > URL: https://issues.apache.org/jira/browse/OFBIZ-8119 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Window10 > java version "1.8.0_101" >Reporter: fumiyoshi.to >Priority: Minor > Attachments: OFBIZ-8119_CharacterEncodingInBuildFile.patch, > build-error.png > > > I cann't build ofbiz when I run gradlew. > I found utf-8 should be the default character encoding used by the comipiling > work. > eg. > def defaultEncoding = 'UTF-8' > tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding > tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8119) Character encoding issue found in file build.gradle
[ https://issues.apache.org/jira/browse/OFBIZ-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460476#comment-15460476 ] Taher Alkhateeb commented on OFBIZ-8119: Also why are you adding groovy compile options? The groovy plugin is not used. How did you come up with this fix? > Character encoding issue found in file build.gradle > --- > > Key: OFBIZ-8119 > URL: https://issues.apache.org/jira/browse/OFBIZ-8119 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Window10 > java version "1.8.0_101" >Reporter: fumiyoshi.to >Priority: Minor > Attachments: OFBIZ-8119_CharacterEncodingInBuildFile.patch, > build-error.png > > > I cann't build ofbiz when I run gradlew. > I found utf-8 should be the default character encoding used by the comipiling > work. > eg. > def defaultEncoding = 'UTF-8' > tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding > tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8119) Character encoding issue found in file build.gradle
[ https://issues.apache.org/jira/browse/OFBIZ-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460625#comment-15460625 ] Taher Alkhateeb commented on OFBIZ-8119: Yeah my total ignorance is showing :) > Character encoding issue found in file build.gradle > --- > > Key: OFBIZ-8119 > URL: https://issues.apache.org/jira/browse/OFBIZ-8119 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Window10 > java version "1.8.0_101" >Reporter: fumiyoshi.to >Priority: Minor > Attachments: OFBIZ-8119_CharacterEncodingInBuildFile.patch, > build-error.png > > > I cann't build ofbiz when I run gradlew. > I found utf-8 should be the default character encoding used by the comipiling > work. > eg. > def defaultEncoding = 'UTF-8' > tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding > tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464863#comment-15464863 ] Taher Alkhateeb edited comment on OFBIZ-7930 at 9/5/16 12:10 PM: - Oh okay good idea. We have libraries already in build.gradle that I think should be deleted (guava among others for example). You might want to start over there. was (Author: taher): Oh okay good idea. We have a lost of libraries already in build.gradle that I think should be deleted (guava among others for example). You might want to start over there. > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7534.patch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464830#comment-15464830 ] Taher Alkhateeb commented on OFBIZ-7930: That might be an overkill Jacques. This would substantially complicate the script for something which very few people would actually use. Also, the plugin is reliant on mavenCentral, not jcenter. So all that you need to do is delete $HOME/.m2 and you're done (unless you have other things that depend on mavenCentral). But even if not the case, I think what you are trying to accomplish would be a lot of work for little value. > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7534.patch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464863#comment-15464863 ] Taher Alkhateeb commented on OFBIZ-7930: Oh okay good idea. We have a lost of libraries already in build.gradle that I think should be deleted (guava among others for example). You might want to start over there. > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-7534.patch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7798) Translate the svn and git info footers
[
https://issues.apache.org/jira/browse/OFBIZ-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467157#comment-15467157
]
Taher Alkhateeb commented on OFBIZ-7798:
Hi Jacques,
This JIRA already has a solution and a patch (Might need to update it). All
that we need here is to reuse some existing labels in uiLabelMap, or create new
ones and add them. The Patch shows how this can be done (even if outdated).
So if you are interested in working on this, then it is quite minor to
accomplish. I'm just not sure which ui labels best to use from which XML file.
> Translate the svn and git info footers
> --
>
> Key: OFBIZ-7798
> URL: https://issues.apache.org/jira/browse/OFBIZ-7798
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7798.patch
>
>
> We slightly changed the old format of the footer. The old format used only
> the translated words _uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_.
> On the other hand, the new format contains the words Branch, Revision, Built
> On and Java Version.
> We need to translate all four words in the CommonUiLabels.xml and then
> incorporate them
> old version:
> {code}
> " - Release-revision : ${releasePath}-r${info.entry.commit(revision)},
> ${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} Java
> ${java.version}
> {code}
> new version:
> {code}
> "Branch: ${info.entry.url.text()}" + System.lineSeparator()
> "Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
> "Built on: ${timestamp}" + System.lineSeparator()
> "Java Version: ${org.gradle.internal.jvm.Jvm.current()}"
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8098) CREATE TABLE PRODUCT_PROMO_CODE_EMAIL generate error during tenant creation
[
https://issues.apache.org/jira/browse/OFBIZ-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454656#comment-15454656
]
Taher Alkhateeb commented on OFBIZ-8098:
Hi Hani,
Some help would be great from your side, can you please:
# provide exact steps to repeat, including gradle command and database setup
# Can you confirm that this behavior _does not_ happen in a standard Derby
database?
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL generate error during tenant creation
> ---
>
> Key: OFBIZ-8098
> URL: https://issues.apache.org/jira/browse/OFBIZ-8098
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
> Environment: windows / MYSQL
>Reporter: Hani Hankir
>
> Hi Team,
> During tenant creation ( and I think during the defaut laod) , Mysql is
> throwinf this:
> {code}
> 2016-08-31 15:41:49,279 |pool-5-thread-1 |DatabaseUtil
> |E| Could not create table [PRODUCT_PROMO_CODE_EMAIL]: SQL Exception while
> executing the following:
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL (PRODUCT_PROMO_CODE_ID VARCHAR(20)
> CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL, EMAIL_ADDRESS
> VARCHAR(320) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
> LAST_UPDATED_STAMP DATETIME, LAST_UPDATED_TX_STAMP DATETIME, CREATED_STAMP
> DATETIME, CREATED_TX_STAMP DATETIME, CONSTRAINT PK_PRODUCT_PROMO_CODE_EMAIL
> PRIMARY KEY (PRODUCT_PROMO_CODE_ID, EMAIL_ADDRESS)) ENGINE InnoDB CHARACTER
> SET utf8 COLLATE utf8_general_ci
> Error was: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
> Specified key was too long; max key length is 767 bytes
> 2016-08-31 15:42:11,169 |pool-3-thread-1 |DatabaseUtil
> |E| Could not create table [PRODUCT_PROMO_CODE_EMAIL]: SQL Exception while
> executing the following:
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL (PRODUCT_PROMO_CODE_ID VARCHAR(20)
> CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL, EMAIL_ADDRESS
> VARCHAR(320) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
> LAST_UPDATED_STAMP DATETIME, LAST_UPDATED_TX_STAMP DATETIME, CREATED_STAMP
> DATETIME, CREATED_TX_STAMP DATETIME, CONSTRAINT PK_PRODUCT_PROMO_CODE_EMAIL
> PRIMARY KEY (PRODUCT_PROMO_CODE_ID, EMAIL_ADDRESS)) ENGINE InnoDB CHARACTER
> SET utf8 COLLATE utf8_general_ci
> Error was: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
> Specified key was too long; max key length is 767 bytes
> 2016-08-31 15:42:43,160 |pool-7-thread-1 |DatabaseUtil
> |E| Could not create table [PRODUCT_PROMO_CODE_EMAIL]: SQL Exception while
> executing the following:
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL (PRODUCT_PROMO_CODE_ID VARCHAR(20)
> CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL, EMAIL_ADDRESS
> VARCHAR(320) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
> LAST_UPDATED_STAMP DATETIME, LAST_UPDATED_TX_STAMP DATETIME, CREATED_STAMP
> DATETIME, CREATED_TX_STAMP DATETIME, CONSTRAINT PK_PRODUCT_PROMO_CODE_EMAIL
> PRIMARY KEY (PRODUCT_PROMO_CODE_ID, EMAIL_ADDRESS)) ENGINE InnoDB CHARACTER
> SET utf8 COLLATE utf8_general_ci
> Error was: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
> Specified key was too long; max key length is 767 bytes
> 2016-08-31 15:51:46,356 |pool-3-thread-1 |DatabaseUtil
> |E| Could not create table [PRODUCT_PROMO_CODE_EMAIL]: SQL Exception while
> executing the following:
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL (PRODUCT_PROMO_CODE_ID VARCHAR(20)
> CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL, EMAIL_ADDRESS
> VARCHAR(320) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
> LAST_UPDATED_STAMP DATETIME, LAST_UPDATED_TX_STAMP DATETIME, CREATED_STAMP
> DATETIME, CREATED_TX_STAMP DATETIME, CONSTRAINT PK_PRODUCT_PROMO_CODE_EMAIL
> PRIMARY KEY (PRODUCT_PROMO_CODE_ID, EMAIL_ADDRESS)) ENGINE InnoDB CHARACTER
> SET utf8 COLLATE utf8_general_ci
> Error was: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException:
> Specified key was too long; max key length is 767 bytes
> 2016-08-31 15:51:57,493 |pool-7-thread-1 |DatabaseUtil
> |E| Could not create table [PRODUCT_PROMO_CODE_EMAIL]: SQL Exception while
> executing the following:
> CREATE TABLE PRODUCT_PROMO_CODE_EMAIL (PRODUCT_PROMO_CODE_ID VARCHAR(20)
> CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL, EMAIL_ADDRESS
> VARCHAR(320) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL,
> LAST_UPDATED_STAMP DATETIME, LAST_UPDATED_TX_STAMP DATETIME, CREATED_STAMP
> DATETIME, CREATED_TX_STAMP DATETIME, CONSTRAINT PK_PRODUCT_PROMO_CODE_EMAIL
> PRIMARY KEY (PRODUCT_PROMO_CODE_ID, EMAIL_ADDRESS)) ENGINE InnoDB CHARACTER
> SET utf8 COLLATE utf8_general_ci
> Error was:
[jira] [Commented] (OFBIZ-6880) Boostrap Basic Theme freezed FireFox 44
[ https://issues.apache.org/jira/browse/OFBIZ-6880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457787#comment-15457787 ] Taher Alkhateeb commented on OFBIZ-6880: is this still relevant? Why is it a blocking task? This does not qualify even as critical > Boostrap Basic Theme freezed FireFox 44 > --- > > Key: OFBIZ-6880 > URL: https://issues.apache.org/jira/browse/OFBIZ-6880 > Project: OFBiz > Issue Type: Sub-task > Components: themes >Affects Versions: Bootstrap theme >Reporter: Jacques Le Roux >Priority: Blocker > Attachments: Image 089.png, Image 090.png > > > On my momentum after trying Rainbow Stone, I just tried Boostrap themes, and > got FF 44 freezed. I could not stop the failing script, nor stop FF, but > debuging it stopped the freeze. I stopped there and I will attach the > screenshoots which will, I hope, explain better than me what happened > I was wondering why we did not merge this branch. This is clearly a blocker > !Image 089.png! > !Image 090.png! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7096) Inventory received are not getting reserved based on set Est. Delivery Date over Sales Order
[ https://issues.apache.org/jira/browse/OFBIZ-7096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457809#comment-15457809 ] Taher Alkhateeb commented on OFBIZ-7096: priority is minor here. The order and inventory systems are operational otherwise. > Inventory received are not getting reserved based on set Est. Delivery Date > over Sales Order > > > Key: OFBIZ-7096 > URL: https://issues.apache.org/jira/browse/OFBIZ-7096 > Project: OFBiz > Issue Type: Bug >Reporter: Swapnil Shah >Assignee: Divesh Dutta >Priority: Critical > Attachments: SO1002.png, SO1003.png, SO1004.png > > > Generally system would carry multiple sales order for a SKU with different > Est.Delivery Date(EDD) and inventory might not be available that time when > orders were created/approved. > Once we start receiving the inventory then reservations gets auto-triggered > and allocated based on created/approved date by overlooking the EDD > altogether. > A simple scenario could be that we have 3 different orders created in system > at 3 different time stamps as follows and all 3 are backordered: > Order A>> Created on 05/21 10 AM >> EDD: 5/25 > Order B>> Created on 05/21 11 AM >> EDD: 5/27 > Order C>> Created on 05/21 12 AM >> EDD: 5/23 > As soon as inventory is received it first get allocated to Order A whereas > Order C is supposed to ship first even though it got approved later. > Expected Behavior: System should first honor the EDD and if its not set then > use the existing criteria of honoring Created/Approved time stamp for > allocating the reservations > Please refer to attached screenshots for reference -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6066) Tenant specific components are visible/accessible in any tenant instance
[ https://issues.apache.org/jira/browse/OFBIZ-6066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457784#comment-15457784 ] Taher Alkhateeb commented on OFBIZ-6066: This is not a blocking task, at most it would be major, probably more minor. Also references to ant make it probably outdated and should be closed > Tenant specific components are visible/accessible in any tenant instance > > > Key: OFBIZ-6066 > URL: https://issues.apache.org/jira/browse/OFBIZ-6066 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Trunk >Reporter: Pierre Smits >Priority: Blocker > Labels: component, tenant > > Tenant specific components should only be visible/accessible by users of the > specified tenant. > However, because data of the tenant specific component can be loaded into any > tenant (including the master rmdbs) through ./ant load-data or via the import > function of webtools, the tenant specific component is exposed to all -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7741) Address scope peculiarities within search/find functionality of projectmgr
[ https://issues.apache.org/jira/browse/OFBIZ-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457796#comment-15457796 ] Taher Alkhateeb commented on OFBIZ-7741: I believe this should be minor or trivial.. Definitely not critical > Address scope peculiarities within search/find functionality of projectmgr > -- > > Key: OFBIZ-7741 > URL: https://issues.apache.org/jira/browse/OFBIZ-7741 > Project: OFBiz > Issue Type: Improvement > Components: specialpurpose/projectmgr >Reporter: Pierre Smits >Priority: Critical > > Currently the search/find functions in the projectmgr component also > retrieves projects a user is not a participant in. This is especially > critical regarding projects with scope 'WES_PRIVATE - private' or > 'WES_CONFIDENTIAL - confidential'. > These project may only be search for/found by users that are exlicit > participants of the projects. This over ruless the generic permissions of > 'PROJECTMGR_ADMIN' or 'PROJECTMGR_VIEW'. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6645) order confirmation via ecommerce (request-uri="emailorder"
[ https://issues.apache.org/jira/browse/OFBIZ-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457813#comment-15457813 ] Taher Alkhateeb commented on OFBIZ-6645: I would classify this as minor. Just a bunch of errors in the log. > order confirmation via ecommerce (request-uri="emailorder" > -- > > Key: OFBIZ-6645 > URL: https://issues.apache.org/jira/browse/OFBIZ-6645 > Project: OFBiz > Issue Type: Bug > Components: order, specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Critical > Labels: ecommerce, order_confirmation > Attachments: error.log > > > When completing an order via ecommerce, the confirmation of order is to be > sent out via request-uri="emailorder". > This generates in a lot of errors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6065) Data of tenant specific component gets loaded in all instances
[ https://issues.apache.org/jira/browse/OFBIZ-6065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457780#comment-15457780 ] Taher Alkhateeb commented on OFBIZ-6065: This is not a blocking task and no longer relevant. Please close > Data of tenant specific component gets loaded in all instances > -- > > Key: OFBIZ-6065 > URL: https://issues.apache.org/jira/browse/OFBIZ-6065 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 14.12, Trunk, 14.12.01 >Reporter: Pierre Smits >Priority: Blocker > Labels: component, data, tenant > > When performing a ./ant load-data variant or using the import function in > webtools data of tenant specific component gets loaded into any tenant > (including master) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7166) Return process fails on receiving
[ https://issues.apache.org/jira/browse/OFBIZ-7166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457801#comment-15457801 ] Taher Alkhateeb commented on OFBIZ-7166: The priority of this jira should be minor at best. Setting Jiras with high priority means a serious affect on the system which I think is not the case here > Return process fails on receiving > - > > Key: OFBIZ-7166 > URL: https://issues.apache.org/jira/browse/OFBIZ-7166 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Nameet Jain >Assignee: Deepak Dixit >Priority: Critical > Attachments: OFBIZ-7166.patch, ReturnPage.png > > > This issue will not regenerate with the test processors. > I actually tried with test account of Authorize.net and setup > "ProductStorePaymentSetting" with aimCCAuth, aimCCCapture, aimCCRefund etc. > Steps to Regenerate: > 1. Create order and quick ship entire order. > 2. Create return from order screen. > 3. Accept Return. > 4. Try to Receive return. > Issue: > Page is broken with error message > "Error in Service [aimCCRefund]: No authorization transaction found; cannot > refund". Also see the attach screenshot -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6625) EcomSEO generates an error when used in multi-tenancy setup
[
https://issues.apache.org/jira/browse/OFBIZ-6625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457820#comment-15457820
]
Taher Alkhateeb commented on OFBIZ-6625:
I recommend classifyingthis Jira as minor
> EcomSEO generates an error when used in multi-tenancy setup
> ---
>
> Key: OFBIZ-6625
> URL: https://issues.apache.org/jira/browse/OFBIZ-6625
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Critical
> Labels: multi-tenant
> Fix For: Upcoming Branch
>
> Attachments: seocontextfilter.patch
>
>
> When using the ecomseo application of the ecommerce component in a tenant the
> tenant entity can't be accessed, and the following error is returned.
> {code} [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8
> |GenericDelegator |I| Can't access entity of entityGroup =
> org.ofbiz.tenant using tenant delegator default#enantId, use base delegator
> instead
> [java] 2015-09-17 22:44:33,906 |http-bio-8443-exec-8 |GenericDelegator
>|E| Failure in findByCondition operation for entity [Tenant]:
> org.ofbiz.entity.GenericEntityException: There is no datasource (Helper)
> configured for the entity-group [org.ofbiz.tenant]; was trying to find
> datasource (helper) for entity [Tenant]. Rolling back transaction.
> [java] org.ofbiz.entity.GenericEntityException: There is no datasource
> (Helper) configured for the entity-group [org.ofbiz.tenant]; was trying to
> find datasource (helper) for entity [Tenant]
> [java] at
> org.ofbiz.entity.GenericDelegator.getEntityHelper(GenericDelegator.java:544)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1774)
> ~[ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.entity.GenericDelegator.findList(GenericDelegator.java:1811)
> [ofbiz-entity.jar:?]
> [java] at
> org.ofbiz.product.category.SeoContextFilter.doFilter(SeoContextFilter.java:300)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.SeoContentUrlFilter.doFilter(SeoContentUrlFilter.java:105)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.ofbiz.product.category.CatalogUrlFilter.doFilter(CatalogUrlFilter.java:338)
> [ofbiz-product.jar:?]
> [java] at
> org.ofbiz.product.category.CatalogUrlSeoFilter.doFilter(CatalogUrlSeoFilter.java:68)
> [ofbiz-product.jar:?]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:421)
> [tomcat-7.0.59-catalina.jar:7.0.59]
> [java] at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1074)
> [tomcat-7.0.59-tomcat-coyote.jar:7.0.59]
> [java] at
>
[jira] [Commented] (OFBIZ-7728) Removal of jars lead to build errors
[ https://issues.apache.org/jira/browse/OFBIZ-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1545#comment-1545 ] Taher Alkhateeb commented on OFBIZ-7728: please close. Not an issue. > Removal of jars lead to build errors > > > Key: OFBIZ-7728 > URL: https://issues.apache.org/jira/browse/OFBIZ-7728 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS, framework >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Blocker > > When executing the changes proposed in OFBIZ-7534 and deleting all external > libraries, the build process fails. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6433) Unable to Export PDF from Jasper in Ofbiz
[ https://issues.apache.org/jira/browse/OFBIZ-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457825#comment-15457825 ] Taher Alkhateeb commented on OFBIZ-6433: Also this request is minor, and probably no longer relevant. > Unable to Export PDF from Jasper in Ofbiz > - > > Key: OFBIZ-6433 > URL: https://issues.apache.org/jira/browse/OFBIZ-6433 > Project: OFBiz > Issue Type: Bug > Environment: Ubuntu >Reporter: Sachin Manjule >Priority: Critical > > Unable to Export PDF from Jasper in Ofbiz, > Please provide step how to export PDF from Ofbiz, I am getting error > Attribute "uuid" must be declared for element type "jasperReport". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470413#comment-15470413 ] Taher Alkhateeb commented on OFBIZ-8156: I would recommend setting priority as minor as per [JIRA guidelines|https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+for+Using+Jira] which are under development. I think nothing qualifies beyond Minor for Trunk given its expected instability. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Critical > Labels: 3rdParty, integration, shipment > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7415) Move 3rd party payment integrations from accounting application to sepcialpurpose
[ https://issues.apache.org/jira/browse/OFBIZ-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469910#comment-15469910 ] Taher Alkhateeb commented on OFBIZ-7415: Hi Pierre, I started a [thread|http://markmail.org/message/3knavbe7sm55pxrs] to propose deleting stale Java files but people had concerns and wanted to keep them to be moved later to specialpurpose components. I need a solution _now_ that works while we discuss what to do with these files. You are correct in the fact that renaming the files is not a very nice solution, but a worse solution is to exclude these java files in the master build.gradle file (what is happening now). So I am proposing something quick and clean(er) solution than excluding these java files in the master build.gradle script. Feel free to start a thread or continue discussing in the above mentioned thread. > Move 3rd party payment integrations from accounting application to > sepcialpurpose > - > > Key: OFBIZ-7415 > URL: https://issues.apache.org/jira/browse/OFBIZ-7415 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Mridul Pathak > > This is a placeholder issue to capture all sub tasks for removing 3rd party > payment integrations from accounting application and moving to a new > component in special purpose. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8138) $ gradlew testIntegration produces exceptions
[ https://issues.apache.org/jira/browse/OFBIZ-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473106#comment-15473106 ] Taher Alkhateeb commented on OFBIZ-8138: I agree with Scott since the build succeeds. However, this is one area ripe for refactoring, our logs spit out too much information and we have a verbosity issue on all levels (error, warn, info and lower levels). So I suggest to close this task (too broad) and focus on one thing at a time. Try to find a place where exceptions are leaking to the console and try to hide them, handle warnings better, etc ... > $ gradlew testIntegration produces exceptions > - > > Key: OFBIZ-8138 > URL: https://issues.apache.org/jira/browse/OFBIZ-8138 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk > Environment: Development platform: lubuntu 16.04 > Java environment: > java version "1.8.0_92" > Java(TM) SE Runtime Environment (build 1.8.0_92-b14) > Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode) > database: postgreSQL >Reporter: Wai > Attachments: test-results.tar.bz2 > > > run 'gradlew testIntegration' produces many exceptions > console output... > ... > 2016-09-04 15:50:21,539 |main |TestRunContainer > |I| [JUNIT] : testClassNotFound starting... > 2016-09-04 15:50:21,541 |main |TestRunContainer > |I| [JUNIT] : testClassNotFound finished. > 2016-09-04 15:50:21,541 |main |TestRunContainer > |I| [JUNIT] : testArray starting... > 2016-09-04 15:50:21,542 |main |Converters > |W| *** No converter found, converting from [Ljava.lang.Object; to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,542 |main |Converters > |W| *** No converter found, converting from [Ljava.lang.Object; to > java.util.Map. Please report this message to the developer community so a > suitable converter can be created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to java.util.ArrayList. Please > report this message to the developer community so a suitable converter can be > created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to java.util.Map. Please > report this message to the developer community so a suitable converter can be > created. *** > 2016-09-04 15:50:21,543 |main |TestRunContainer > |I| [JUNIT] : testArray finished. > 2016-09-04 15:50:21,543 |main |TestRunContainer > |I| [JUNIT] : testString starting... > 2016-09-04 15:50:21,561 |main |Converters > |W| *** No converter found, converting from java.lang.String to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,608 |main |UtilMisc > |W| Do not know what to do with the localeString [o], should be length 2, 5, > or greater than 6, returning null > 2016-09-04 15:50:21,608 |main |ObjectType > |W| Exception thrown while converting type: > org.apache.ofbiz.base.conversion.ConversionException: Could not convert o to > Locale: > at > org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:238) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:228) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.base.util.ObjectType.simpleTypeConvert(ObjectType.java:550) > [ofbiz.jar:?] > at > org.apache.ofbiz.base.util.test.ObjectTypeTests.simpleTypeConvert(ObjectTypeTests.java:99) > [ofbiz.jar:?] > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15462916#comment-15462916 ] Taher Alkhateeb commented on OFBIZ-7930: okay, started a thread on -> http://markmail.org/message/xnl2lw3pix2sm5q3 If no one objects I will commit. > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15462903#comment-15462903 ] Taher Alkhateeb commented on OFBIZ-7930: Yeah, it is better to discuss it in ML just to be extra sure. The work is ready to be committed without any problems. I'll start a thread and we can get lazy consensus if no one replies. > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-235) POS Z report
[ https://issues.apache.org/jira/browse/OFBIZ-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15462893#comment-15462893 ] Taher Alkhateeb commented on OFBIZ-235: --- I recently started a thread on problems we face in JIRA. Many of the JIRAs we have should be closed IMHO. I think this JIRA qualifies as one of those problematic JIRAs because: - The title is not clear and does not make sense. What are you trying to do? I don't know? - It is 10 years old!! If something is 10 years old, when will we close it? This is exactly the kind of thing we suffer from in JIRA. We have too many JIRAs that are abandoned, poorly documented, and do not make much sense. JIRAs are a place where we all work, not a personal TODO application. Keeping place holders just adds to the confusion unless you really want to work on it and have done proper planning and documented what needs to be done. So in my opinion, unless you are really going to work on this, my recommendation is to close it and move on. We still have a mountain of work to do elsewhere. > POS Z report > > > Key: OFBIZ-235 > URL: https://issues.apache.org/jira/browse/OFBIZ-235 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/webpos >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > This is generally used as a daily report but should still take a date range > to be really useful. > show total sales by tender type, with VAT breakdown by rates > transaction count (number of sales) > number of items sold / average per customer > average spend per customer > totals of discounts > This issue was initially created by Ray Barlow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8119) Character encoding issue found in file build.gradle
[ https://issues.apache.org/jira/browse/OFBIZ-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15462807#comment-15462807 ] Taher Alkhateeb commented on OFBIZ-8119: Thank you also for taking the time to research this, the code snippet you provided helped me in forging the committed solution, and it was also useful for me to learn some new notation. > Character encoding issue found in file build.gradle > --- > > Key: OFBIZ-8119 > URL: https://issues.apache.org/jira/browse/OFBIZ-8119 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk > Environment: Window10 > java version "1.8.0_101" >Reporter: fumiyoshi.to >Assignee: Taher Alkhateeb >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8119_CharacterEncodingInBuildFile.patch, > build-error.png > > > I cann't build ofbiz when I run gradlew. > I found utf-8 should be the default character encoding used by the comipiling > work. > eg. > def defaultEncoding = 'UTF-8' > tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding > tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8138) $ gradlew testIntegration produces exceptions
[ https://issues.apache.org/jira/browse/OFBIZ-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463425#comment-15463425 ] Taher Alkhateeb commented on OFBIZ-8138: Hi Wai .. thank you for reporting this. Questions: - does the build fail? - Are these errors new? - What is your environment? > $ gradlew testIntegration produces exceptions > - > > Key: OFBIZ-8138 > URL: https://issues.apache.org/jira/browse/OFBIZ-8138 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Wai > > run 'gradlew testIntegration' produces many exceptions > console output... > ... > 2016-09-04 15:50:21,539 |main |TestRunContainer > |I| [JUNIT] : testClassNotFound starting... > 2016-09-04 15:50:21,541 |main |TestRunContainer > |I| [JUNIT] : testClassNotFound finished. > 2016-09-04 15:50:21,541 |main |TestRunContainer > |I| [JUNIT] : testArray starting... > 2016-09-04 15:50:21,542 |main |Converters > |W| *** No converter found, converting from [Ljava.lang.Object; to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,542 |main |Converters > |W| *** No converter found, converting from [Ljava.lang.Object; to > java.util.Map. Please report this message to the developer community so a > suitable converter can be created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to java.util.ArrayList. Please > report this message to the developer community so a suitable converter can be > created. *** > 2016-09-04 15:50:21,543 |main |Converters > |W| *** No converter found, converting from [I to java.util.Map. Please > report this message to the developer community so a suitable converter can be > created. *** > 2016-09-04 15:50:21,543 |main |TestRunContainer > |I| [JUNIT] : testArray finished. > 2016-09-04 15:50:21,543 |main |TestRunContainer > |I| [JUNIT] : testString starting... > 2016-09-04 15:50:21,561 |main |Converters > |W| *** No converter found, converting from java.lang.String to > org.apache.ofbiz.base.util.GeneralException. Please report this message to > the developer community so a suitable converter can be created. *** > 2016-09-04 15:50:21,608 |main |UtilMisc > |W| Do not know what to do with the localeString [o], should be length 2, 5, > or greater than 6, returning null > 2016-09-04 15:50:21,608 |main |ObjectType > |W| Exception thrown while converting type: > org.apache.ofbiz.base.conversion.ConversionException: Could not convert o to > Locale: > at > org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:238) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.base.conversion.MiscConverters$StringToLocale.convert(MiscConverters.java:228) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.base.util.ObjectType.simpleTypeConvert(ObjectType.java:550) > [ofbiz.jar:?] > at > org.apache.ofbiz.base.util.test.ObjectTypeTests.simpleTypeConvert(ObjectTypeTests.java:99) > [ofbiz.jar:?] > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8139) gradlew 'ofbiz --test' failures
[ https://issues.apache.org/jira/browse/OFBIZ-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464059#comment-15464059 ] Taher Alkhateeb commented on OFBIZ-8139: I suggest to close one of them as duplicated by the other and continue your focus on whichever one is more relevant. > gradlew 'ofbiz --test' failures > --- > > Key: OFBIZ-8139 > URL: https://issues.apache.org/jira/browse/OFBIZ-8139 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk > Environment: Development platform: lubuntu 16.04 > Java environment: > java version "1.8.0_92" > Java(TM) SE Runtime Environment (build 1.8.0_92-b14) > Java HotSpot(TM) 64-Bit Server VM (build 25.92-b14, mixed mode) > database: postgreSQL >Reporter: Wai > Attachments: test-results.tar.bz2 > > > run 'gradlew test' > contains errors and failtures -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[
https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464106#comment-15464106
]
Taher Alkhateeb edited comment on OFBIZ-7930 at 9/5/16 5:06 AM:
Hi Jacques. In order to test things I am attaching my work for your review.
Essentially, you just have to pass a flag to enable the plugin. The
dependencies for OWASP will only download if you pass the flag, otherwise it
will not recognize any OWASP tasks.
To test it, run an OWASP task from the command line: e.g.
{code}
./gradlew -PenableOwasp dependencyCheck
{code}
was (Author: taher):
Hi Jacques. In order to test things I am attaching my work for your review.
Essentially, you just have to pass a flag to enable the plugin. The
dependencies for OWASP will only download if you pass the flag, otherwise it
will not recognize any OWASP tasks.
To test it, run an OWASP task from the command line: e.g.
{code:bash}
./gradlew -PenableOwasp dependencyCheck
{code}
> Load the OWASP dependency checker Gradle plugin efficiently
> ---
>
> Key: OFBIZ-7930
> URL: https://issues.apache.org/jira/browse/OFBIZ-7930
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7534.patch
>
>
> As I warned at
> https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check
> it's currently difficult to separate the OFBiz jars from other jars in the
> .gradle\caches contains which may contain jars unrelated to OFBiz. Notably
> Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle
> for other reasons than OFBiz.
> I did not find yet a way to avoid to have all external jars in .gradle\caches
> and I wonder if it's even possible. What I would like to have is the external
> jars mandatory for OFBiz to work in an isolated place. For instance a sub
> folder of the main Gradle build folder. I picked $buildDir/externalJars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[
https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-7930:
---
Attachment: OFBIZ-7534.patch
Hi Jacques. In order to test things I am attaching my work for your review.
Essentially, you just have to pass a flag to enable the plugin. The
dependencies for OWASP will only download if you pass the flag, otherwise it
will not recognize any OWASP tasks.
To test it, run an OWASP task from the command line: e.g.
{code:bash}
./gradlew -PenableOwasp dependencyCheck
{code}
> Load the OWASP dependency checker Gradle plugin efficiently
> ---
>
> Key: OFBIZ-7930
> URL: https://issues.apache.org/jira/browse/OFBIZ-7930
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7534.patch
>
>
> As I warned at
> https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check
> it's currently difficult to separate the OFBiz jars from other jars in the
> .gradle\caches contains which may contain jars unrelated to OFBiz. Notably
> Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle
> for other reasons than OFBiz.
> I did not find yet a way to avoid to have all external jars in .gradle\caches
> and I wonder if it's even possible. What I would like to have is the external
> jars mandatory for OFBiz to work in an isolated place. For instance a sub
> folder of the main Gradle build folder. I picked $buildDir/externalJars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8119) Character encoding issue found in file build.gradle
[
https://issues.apache.org/jira/browse/OFBIZ-8119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460686#comment-15460686
]
Taher Alkhateeb commented on OFBIZ-8119:
Okay after a little of investigation I realized what you were trying to do with
your patch:
{code}
def defaultEncoding = 'UTF-8'
tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding
tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding
{code}
AbstractCompile is the parent of JavaCompile, GroovyCompile and other compile
tasks, and so this code snippet iterates through this compilation syntax to try
to enforce the character encoding on all compile tasks.
GroovyCompile has an additional field for GroovyCompileOptions which extends
from AbstractCompileOptions. But CompileOptions (java) also extends from
AbstractCompileOptions. So the two separate classes need to set the encoding.
Now, I think the following errors are present in the code:
- The default encoding is already UTF-8, not sure that we need to enforce it
unless something is wrong in your default encoding options on the OS?
- GroovyCompileOptions setting for encoding is not needed because we aren't
running any gradle plugins or compile tasks.
There are two code snippets which you can try, and please tell me if either one
works for you. I am listing the two so that if the first one does not work,
then we know the problem is OS related in config settings:
{code}
// try this first, if it works, then ignore the second one
tasks.withType(JavaCompile) {
options.encoding = System.getProperty('file.encoding')
}
// if the above does not work, try this
tasks.withType(JavaCompile) {
options.encoding = 'UTF-8'
}
{code}
> Character encoding issue found in file build.gradle
> ---
>
> Key: OFBIZ-8119
> URL: https://issues.apache.org/jira/browse/OFBIZ-8119
> Project: OFBiz
> Issue Type: Bug
> Components: ALL APPLICATIONS
>Affects Versions: Trunk
> Environment: Window10
> java version "1.8.0_101"
>Reporter: fumiyoshi.to
>Priority: Minor
> Attachments: OFBIZ-8119_CharacterEncodingInBuildFile.patch,
> build-error.png
>
>
> I cann't build ofbiz when I run gradlew.
> I found utf-8 should be the default character encoding used by the comipiling
> work.
> eg.
> def defaultEncoding = 'UTF-8'
> tasks.withType(AbstractCompile)*.options*.encoding = defaultEncoding
> tasks.withType(GroovyCompile)*.groovyOptions*.encoding = defaultEncoding
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8097) gradlew createTenant generate error before GenerateFileFromTemplate
[ https://issues.apache.org/jira/browse/OFBIZ-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453020#comment-15453020 ] Taher Alkhateeb commented on OFBIZ-8097: Hello Hani, Thank you for reporting this issue. I looked at it and realized it has to do with groovy gstring evaluation. I fixed the issue in r1758662. Please update and confirm. If all is good please close this JIRA > gradlew createTenant generate error before GenerateFileFromTemplate > --- > > Key: OFBIZ-8097 > URL: https://issues.apache.org/jira/browse/OFBIZ-8097 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk > Environment: Windows , Mysql , AnyDB used >Reporter: Hani Hankir > > HI Team, > when trying to run this : > gradlew createTenant -PtenantId=XSIDON -PtenantName="XSIDON" > -PtenantReaders=seed,seed-initial -PdbPlatform=M -PdbIp=127.0.0.1 > -PdbUser=ofbiz -PdbPassword=ofbiz > getting this error: > FAILURE: Build failed with an exception. > * Where: > Build file 'C:\ofbizlatesttrunk\build.gradle' line: 804 > * What went wrong: > Execution failed for task ':generateDatabaseTemplateFile'. > > Could not copy file > > 'C:\ofbizlatesttrunk\framework\resources\templates\AdminNe > wTenantData-MySQL.xml' to > 'C:\ofbizlatesttrunk\runtime\tmp\tmpFilteredTenantData > .xml'. > I debugged , and it seemed there is somehting wrong during the filtertokens... > Thanks > Hani -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7930) Load the OWASP dependency checker Gradle plugin efficiently
[ https://issues.apache.org/jira/browse/OFBIZ-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15448784#comment-15448784 ] Taher Alkhateeb commented on OFBIZ-7930: Hi Jacques, You made a comment about being stuck in this JIRA, so I'll try to help. So I think the solution to your problem here is to avoid loading the plugin except when the proper task is activated. So you need to have a condition to check whether it is appropriate, and if yes, load the plugin and activate the security task. This way, normal users do not worry about downloading the extra dependencies while at the same time you can activate the OWASP plugin. So, to help you in implementing this, there are a few questions first: - Can you please provide the code snippet which activated the plugin, I forgot it. We can use that as a starting point - What is the purpose here and who calls this task? is it committers, is it everyone? this makes it relevant to which script does it belong to (master or /tools perhaps) - What do you do with the output? just display it? > Load the OWASP dependency checker Gradle plugin efficiently > --- > > Key: OFBIZ-7930 > URL: https://issues.apache.org/jira/browse/OFBIZ-7930 > Project: OFBiz > Issue Type: Sub-task > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > As I warned at > https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check > it's currently difficult to separate the OFBiz jars from other jars in the > .gradle\caches contains which may contain jars unrelated to OFBiz. Notably > Eclipse jars if you use the Gradle Eclipse task and more if you use Gradle > for other reasons than OFBiz. > I did not find yet a way to avoid to have all external jars in .gradle\caches > and I wonder if it's even possible. What I would like to have is the external > jars mandatory for OFBiz to work in an isolated place. For instance a sub > folder of the main Gradle build folder. I picked $buildDir/externalJars. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7972: --- Description: This JIRA houses the attempt to create a plugin system for OFBiz based on gradle. The plugin system should have the following features: - It is independent of the version control system, file system, operating system and any other environment tools surrounding OFBiz. Instead, it should be fully integrated with OFBiz. - It should unify the way OFBiz is extended, both for official supported plugins and for third party plugins - The plugin system takes advantage of the concept of a "component" in OFBiz and utilize it as the building block for plugins - The plugin system supports the concepts of "Repository" and "Dependency Management". If possible, the plugin system will utilize these concepts directly from Gradle instead of writing them from scratch. The initial API for the plugin system will be small and expands as needed. The API should include the following gradle tasks: - createPlugin: creates a new plugin based on templates and place it in the plugins directory - installPlugin: Activate a plugin and run Install. Plugin must exist in /specialpurpose - uninstallPlugin: Deactivate a plugin and run its uninstall script - publishPlugin: publish a plugin to local maven repository - pullPlugin: download a plugin with its dependencies (plugins) from a repository and install them was: This JIRA houses the attempt to create a plugin system for OFBiz based on gradle. The plugin system should have the following features: - It is independent of the version control system, file system, operating system and any other environment tools surrounding OFBiz. Instead, it should be fully integrated with OFBiz. - It should unify the way OFBiz is extended, both for official supported plugins and for third party plugins - The plugin system takes advantage of the concept of a "component" in OFBiz and utilize it as the building block for plugins - The plugin system supports the concepts of "Repository" and "Dependency Management". If possible, the plugin system will utilize these concepts directly from Gradle instead of writing them from scratch. The initial API for the plugin system will be small and expands as needed. The API should include the following gradle tasks: - createPlugin: creates a new plugin based on templates and place it in the plugins directory - activatePlugin: Make an inactive plugin active (compile and start with the system). - deactivatePlugin: Make an active plugin inactive (does not compile nor start with the system) - installPlugin: either install an existing plugin in the filesystem, or download and install the plugin from a remote repository. Installation happens by running the install script which is designed by the plugin author. By default installPlugin also activates the plugin. - uninstallPlugin: Uninstall an already installed plugin by running its uninstall script. By default uninstallPlugin also deactivates the plugin, but does not delete it. > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: plugin, proof-of-concept, system > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent
[jira] [Updated] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[
https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taher Alkhateeb updated OFBIZ-7972:
---
Attachment: OFBIZ-7972.patch
This is an intial PoC patch that shows the plugin system. All help appreciated
in testing and providing feedback. To test you can apply the following steps:
{code}
./gradlew createPlugin -PpluginId=myplugin
./gradlew publishPlugin -PpluginId=myplugin
rm -Rf specialpurpose/myplugin
svn revert specialpurpose/component-load.xml
./gradlew pullPlugin
-PdependencyId=org.apache.ofbiz.plugin:myplugin:0.1.0-SNAPSHOT
{code}
I have also provided documentation in README.md for the plugin commands. And
naturally, this removes the "createComponent" task since it will be replaced by
the plugin system
> Create a (PoC) plugin system for OFBiz based on Gradle
> --
>
> Key: OFBIZ-7972
> URL: https://issues.apache.org/jira/browse/OFBIZ-7972
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
> Labels: plugin, proof-of-concept, system
> Attachments: OFBIZ-7972.patch
>
>
> This JIRA houses the attempt to create a plugin system for OFBiz based on
> gradle. The plugin system should have the following features:
> - It is independent of the version control system, file system, operating
> system and any other environment tools surrounding OFBiz. Instead, it should
> be fully integrated with OFBiz.
> - It should unify the way OFBiz is extended, both for official supported
> plugins and for third party plugins
> - The plugin system takes advantage of the concept of a "component" in OFBiz
> and utilize it as the building block for plugins
> - The plugin system supports the concepts of "Repository" and "Dependency
> Management". If possible, the plugin system will utilize these concepts
> directly from Gradle instead of writing them from scratch.
> The initial API for the plugin system will be small and expands as needed.
> The API should include the following gradle tasks:
> - createPlugin: creates a new plugin based on templates and place it in the
> plugins directory
> - installPlugin: Activate a plugin and run Install. Plugin must exist in
> /specialpurpose
> - uninstallPlugin: Deactivate a plugin and run its uninstall script
> - publishPlugin: publish a plugin to local maven repository
> - pullPlugin: download a plugin with its dependencies (plugins) from a
> repository and install them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490053#comment-15490053 ] Taher Alkhateeb commented on OFBIZ-8156: Hello, In reviewing the patch for this work, I notice that you only focus on removing Fedex. Why only Fedex? The system supports DHL, UPS, USPS but all the removal I'm seeing is only for Fedex. I also note that this does not look like a disentanglement to me (no redesign) but rather just removal of Fedex specific data, labels, widgets and code. So my questions are: - Why only fedex, and leaving other shipment methods intact? - What do you mean by disentanglement? > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8179) Enhance DBCPConnectionFactory to implement a TransactionFactory and remove the geronimo component
[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477916#comment-15477916 ] Taher Alkhateeb commented on OFBIZ-8179: Hi Jacopo, Great work! Why comment out the transaction-factory and not delete instead? Or do you want to do that in one shot while deleting the geronimo component and libs from build.gradle as well (which would be great I might add) > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > - > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacopo Cappellato >Assignee: Jacopo Cappellato >Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488344#comment-15488344 ] Taher Alkhateeb commented on OFBIZ-7972: Hi Gil, thank you :) I hesitated in making the uninstallPlugin task delete the folder, and I like your idea of remove plugin being equal to uninstall+delete. Maybe we should call it deletePlugin because there is a function in the script called removePlugin that removes it from component-load.xml. I also discovered a few more typos in README.md so I'll fix those in addition to the copy-paste one you caught. I'll patch again soon. There is a lot more to discuss but I'll wait for you to explore some more. Thank you for all the help. > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7972: --- Priority: Minor (was: Major) > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489589#comment-15489589 ] Taher Alkhateeb commented on OFBIZ-7972: Hi Michael, thank you for the help, I will update the patch soon with your feedback as well as that of Gil's You asked me a difficult question on versioning which I was thinking about a lot. In my current design I made OFBiz plugins themselves versioned using [Semantic Versioning 2.0.0|http://semver.org/] and you can have a very complex dependency tree with versions without a problem and it will all be resolved automatically. This is just good old maven combined with the power of Gradle that makes this whole system seamless. OFBiz itself, however, is not versioned, so I do not have at the moment a solution to say that this plugin only works with OFBiz 16 and that plugin works with 15 and so on. The reasons for this problem: - There is no file in OFBiz that tells us what is the current version of OFBiz - Using subversion to keep track of versions in my opinion is a bad idea because it makes the solution brittle and dependent on tools instead of being part of the OFBiz solution. If we switch the version control system in the future then our solution breaks down. - What about trunk? It's hard to make plugins dependent on trunk because trunk is this constantly changing thing. So, I have no clear solution in my mind at the moment, but I am sharing my ideas to brainstorm together > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489681#comment-15489681 ] Taher Alkhateeb edited comment on OFBIZ-7972 at 9/14/16 7:31 AM: - Okay this new patch delivers the following: - Fix the documentation in README.md - Renamed removePlugin and addPlugin to deactivatePlugin and activatePlugin as per Michael's suggestion - Introduce a task called removePlugin that in addition to uninstalling a plugin also deletes it from the filesystem as recommended by Michael and Gil. - Make the componentResourceName capitalized (Thank you Gil for the code snippet) was (Author: taher): Okay this new patch delivers the following: - Fix the documentation in README.md - Renamed removePlugin and addPlugin to deactivatePlugin and activatePlugin as per Michael's suggestion - Introduce a task called removePlugin that in addition to uninstalling a plugin also deletes it from the filesystem as recommended by Miachael and Gil. - Make the componentResourceName capitalized (Thank you Gil for the code snippet) > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490013#comment-15490013 ] Taher Alkhateeb commented on OFBIZ-7972: Good catch Jacopo, yeah I deleted 'org.apache.ant:ant-junit4:1.9.7' as it is duplicated and the system works without it. Thank you Jacopo, Michael and Gil for the vote to push the experimental code to Trunk. I'll wait for a while for feedback from others before proceeding. > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-7972: --- Attachment: OFBIZ-7972.patch Newest version attached, minor formatting and improvements in documentation > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492823#comment-15492823 ] Taher Alkhateeb commented on OFBIZ-8156: I gave you an explanation below of the meaning of the word, so I won't repeat myself here. Now, with respect to the comments above, what I can see is that the API for fedex is deprecated, but the bulk of your patch is removing settings, labels and standard services. In my opinion, this is not a clean approach, and a redesign should be favoured over blunt removal. the parts that are deprecated can be removed (I still need to study the code, but I think most of it is not related) and other parts need to be refactored. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492497#comment-15492497 ] Taher Alkhateeb commented on OFBIZ-7972: Hi Folks, I just had a new idea before committing. I would like to rename publishPlugin to pushPlugin. This way we have a nice consistent naming i.e. pulling from or pushing to a maven Repository. WDYT > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500809#comment-15500809 ] Taher Alkhateeb commented on OFBIZ-8250: Hi Jacques. Michael discovered that by default on a clean checkout of OFBiz the files SvnInfo.ftl and GitInfo.ftl are not generated (but they used to be generated during the days of Ant). So this means, on a new checkout doing ./gradlew cleanAll loadDefault "ofbiz --start" would yield exceptions at the bottom of the page because of missing footer files. The purpose of the patch designed by Michael as far as I see is to generate these files (empty) if they are missing to avoid this exception stack-trace in the user interface, and he also added a clean task to remove the files when calling cleanAll. So what Michael did is make things nice and automatic so that users don't have to worry or intentionally call svnInfoFooter and gitInfoFooter. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500910#comment-15500910 ] Taher Alkhateeb commented on OFBIZ-8250: Hmmm, we are still left with the problem of generated files from svnInfoFooter and gitInfoFooter not cleaned up. Anyway, I leave this discussion for you and Michael to continue to devise a solution. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500847#comment-15500847 ] Taher Alkhateeb commented on OFBIZ-8250: Unless you caught an error, I don't think you need to slow down this JIRA with a review. Michael checked it, I checked it, it runs, it works. You said yourself that your objective is to understand the _reason_ not correctness of the patch which I explained above (maybe Michael can add more). This patch is simply a bug fix for not generating the footer files. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7788) Update to 'OFBiz Contributors Best Practices'
[
https://issues.apache.org/jira/browse/OFBIZ-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15500753#comment-15500753
]
Taher Alkhateeb commented on OFBIZ-7788:
+1
> Update to 'OFBiz Contributors Best Practices'
> -
>
> Key: OFBIZ-7788
> URL: https://issues.apache.org/jira/browse/OFBIZ-7788
> Project: OFBiz
> Issue Type: Improvement
> Components: Confluence
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Trivial
>
> Please add the following to the *When to create a Jira issue* section of the
> document:
> {quote}
> When you find a duplicate of a JIRA issue, please close the newer one with
> the resolution 'Duplicate', and state what the original issue is. Closing the
> older issue is not respectful to the creator of the first issue, and can be
> perceived as an insult with respect to his/her good intentions.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OFBIZ-8156) Disentangle Fedex solution from current integrated state
[ https://issues.apache.org/jira/browse/OFBIZ-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492832#comment-15492832 ] Taher Alkhateeb commented on OFBIZ-8156: Oh and for completeness, this is an area ripe for good refactoring, we can perhaps remove ALL shipment methods outside the framework into specialized plugins. So we can move Fedex, USPS, UPS and DHL each as a separate OFBiz plugin that hides away the implementation details. This, in my opinion, is a much cleaner and more modular approach that allows thriving and even adding more shipment methods without complexity at the framework level. > Disentangle Fedex solution from current integrated state > > > Key: OFBIZ-8156 > URL: https://issues.apache.org/jira/browse/OFBIZ-8156 > Project: OFBiz > Issue Type: Sub-task > Components: commonext, datamodel, order, product, > specialpurpose/ecommerce, specialpurpose/oagis, specialpurpose/webpos >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Minor > Labels: 3rdParty, integration, shipment > Attachments: OFBIZ-8156-FedexRemoval.patch > > > Disentanglement of the 3rd party shipment integration for FedEx gives the > OFBiz adopter more flexibility, reduces the default code base and offers the > project more opportunities with respect to attracting product specific > contributors, better code and faster release cycles. > Requirements of the disentangled solution: > * should not need a separate entity to capture configuration elements > * configuration should be contained in the component. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-7972) Create a (PoC) plugin system for OFBiz based on Gradle
[ https://issues.apache.org/jira/browse/OFBIZ-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493045#comment-15493045 ] Taher Alkhateeb commented on OFBIZ-7972: First commit in r1760917 with minor modifications and fixing of typos. > Create a (PoC) plugin system for OFBiz based on Gradle > -- > > Key: OFBIZ-7972 > URL: https://issues.apache.org/jira/browse/OFBIZ-7972 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Branch >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Labels: plugin, proof-of-concept, system > Attachments: OFBIZ-7972.patch, OFBIZ-7972.patch, OFBIZ-7972.patch > > > This JIRA houses the attempt to create a plugin system for OFBiz based on > gradle. The plugin system should have the following features: > - It is independent of the version control system, file system, operating > system and any other environment tools surrounding OFBiz. Instead, it should > be fully integrated with OFBiz. > - It should unify the way OFBiz is extended, both for official supported > plugins and for third party plugins > - The plugin system takes advantage of the concept of a "component" in OFBiz > and utilize it as the building block for plugins > - The plugin system supports the concepts of "Repository" and "Dependency > Management". If possible, the plugin system will utilize these concepts > directly from Gradle instead of writing them from scratch. > The initial API for the plugin system will be small and expands as needed. > The API should include the following gradle tasks: > - createPlugin: creates a new plugin based on templates and place it in the > plugins directory > - installPlugin: Activate a plugin and run Install. Plugin must exist in > /specialpurpose > - uninstallPlugin: Deactivate a plugin and run its uninstall script > - publishPlugin: publish a plugin to local maven repository > - pullPlugin: download a plugin with its dependencies (plugins) from a > repository and install them -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8290) Disentangle unused Accounting labels
[ https://issues.apache.org/jira/browse/OFBIZ-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501410#comment-15501410 ] Taher Alkhateeb commented on OFBIZ-8290: The correct title is remove, not disentangle, this was pointed out to you repeatedly. Also the priority of this ticket is trivial Also, I wish you'd be more careful with the quality of your patches so we don't have to worry about every patch you provide. For example GlAccountTrialBalanceReport.fo.ftl and GlAccountTrialBalanceReport.ftl uses AccountingAccountTransactionId which you want to remove in your patch. > Disentangle unused Accounting labels > > > Key: OFBIZ-8290 > URL: https://issues.apache.org/jira/browse/OFBIZ-8290 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: labels, refactoring > Attachments: OFBIZ-8290-AccountingUiLabels.xml.patch > > > Disentanglement of unused labels from the accounting component makes the > component better. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8290) Disentangle unused Accounting labels
[ https://issues.apache.org/jira/browse/OFBIZ-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15501428#comment-15501428 ] Taher Alkhateeb commented on OFBIZ-8290: Okay ... my apology I just noticed that AccountingAccountTransactionId is not removed but is added as context. I'll check the rest of the document > Disentangle unused Accounting labels > > > Key: OFBIZ-8290 > URL: https://issues.apache.org/jira/browse/OFBIZ-8290 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: labels, refactoring > Attachments: OFBIZ-8290-AccountingUiLabels.xml.patch > > > Disentanglement of unused labels from the accounting component makes the > component better. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8250) SvnInfo.ftl and GitInfo.ftl are not generated by default
[ https://issues.apache.org/jira/browse/OFBIZ-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502479#comment-15502479 ] Taher Alkhateeb commented on OFBIZ-8250: Hi Jacques, thank you for the commit. I think it would be more appropriate in the future to let committers commit their own work. Michael added the patch in this JIRA for feedback and help, not committing, as he is the assignee of this JIRA. > SvnInfo.ftl and GitInfo.ftl are not generated by default > > > Key: OFBIZ-8250 > URL: https://issues.apache.org/jira/browse/OFBIZ-8250 > Project: OFBiz > Issue Type: Bug > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image 014.png, OFBIZ-8250-2.patch, OFBIZ-8250.patch > > > The two files are not generated which results in an FTL stacktrace in the > footer of the backend applications. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8293) Remove redundant backend themes
[ https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505450#comment-15505450 ] Taher Alkhateeb commented on OFBIZ-8293: Hello .. RTL guy here :) I used flatgray because it is the most well supported RTL theme. However, it would be great at some point to reduce themes and make them all RTL enabled. As I mentioned elsewhere the widgets and themes are in need of a major overhaul. > Remove redundant backend themes > --- > > Key: OFBIZ-8293 > URL: https://issues.apache.org/jira/browse/OFBIZ-8293 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > We already already discussed several times on dev ML to reduce the number of > OOTB backend themes and we globally agreed about doing so. > These themes are still working so we will move them to Attic from where > (using svn history) they can be fetch to create expected plugins (tough I'm > not sure we can yet create theme-plugins but this is expected) > If nobody disagree I'll do so in few days... > BTW the themes I expect to remove in a 1st phase are: > # bizzness time, still not complete after several years see OFBIZ-2398 > # BlueLight, it's subsumed by Tomahawk which is the last variant of this > group and more complete > # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of > this group and more complete > # 3 instances of Rainbow Stone, we need to collectively decide which ones -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-8293) Remove redundant backend themes
[ https://issues.apache.org/jira/browse/OFBIZ-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505450#comment-15505450 ] Taher Alkhateeb edited comment on OFBIZ-8293 at 9/20/16 3:26 AM: - Hello .. RTL guy here :) I used flatgrey because it is the most well supported RTL theme. However, it would be great at some point to reduce themes and make them all RTL enabled. As I mentioned elsewhere the widgets and themes are in need of a major overhaul. was (Author: taher): Hello .. RTL guy here :) I used flatgray because it is the most well supported RTL theme. However, it would be great at some point to reduce themes and make them all RTL enabled. As I mentioned elsewhere the widgets and themes are in need of a major overhaul. > Remove redundant backend themes > --- > > Key: OFBIZ-8293 > URL: https://issues.apache.org/jira/browse/OFBIZ-8293 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Branch > > > We already already discussed several times on dev ML to reduce the number of > OOTB backend themes and we globally agreed about doing so. > These themes are still working so we will move them to Attic from where > (using svn history) they can be fetch to create expected plugins (tough I'm > not sure we can yet create theme-plugins but this is expected) > If nobody disagree I'll do so in few days... > BTW the themes I expect to remove in a 1st phase are: > # bizzness time, still not complete after several years see OFBIZ-2398 > # BlueLight, it's subsumed by Tomahawk which is the last variant of this > group and more complete > # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of > this group and more complete > # 3 instances of Rainbow Stone, we need to collectively decide which ones -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8229) Don't load demo data by default
[ https://issues.apache.org/jira/browse/OFBIZ-8229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506006#comment-15506006 ] Taher Alkhateeb commented on OFBIZ-8229: The patch removes the ability to ever load demo data in the system unless explicitly added by hand in the readers list. I don't think this is a proper solution. > Don't load demo data by default > --- > > Key: OFBIZ-8229 > URL: https://issues.apache.org/jira/browse/OFBIZ-8229 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits > Labels: data, operations, refactoring > Attachments: OFBIZ-8229-entityengine.xml.patch > > > Demo data loading should be a specific action. It should be loaded per > special request, not by default. In order to have adopters start with a > working OFBiz implementation, it is enough to start with loading seed and > seed-initial data only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6243) Have a readme in every component
[ https://issues.apache.org/jira/browse/OFBIZ-6243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512707#comment-15512707 ] Taher Alkhateeb commented on OFBIZ-6243: The most important and valuable work is the actual documentation of the components. Right now what we have is just a skeleton of README files that point to empty wiki pages, there is no value in that and these wiki pages could be ignored for years. So all this work end up being confusing First we must construct good documentation and agree on its contents through proper discussion, then we can start to wire things together. What we have right now is just noise. So I also believe a revert is necessary > Have a readme in every component > > > Key: OFBIZ-6243 > URL: https://issues.apache.org/jira/browse/OFBIZ-6243 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > A readme should be the first starting point of each component for developers > have references to the placeholder in the wiki, in jira and in svn/viewvc -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-8251) Create a Gradle task to use Xlint arguments when building
[ https://issues.apache.org/jira/browse/OFBIZ-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15498305#comment-15498305 ] Taher Alkhateeb edited comment on OFBIZ-8251 at 9/17/16 6:18 AM: - Attached is a simple and clean fix. Essentially, it's better to just use Xlint which is equal to Xlint:all to show everything and you can dig through it for whatever you want. What this fix requires is only passing a project property called Xlint. So .. the syntax is ./gradlew -PXlint build For the record, I'm not very convinced of adding both Xlint and OWASP to the master build.gradle. I am busy at the moment but I do wish to remove both (even though I helped in implementing both) because I was just trying to help Jacques to implement it properly was (Author: taher): Attached is a simple and clean fix. Essentially, it's better to just use Xlint which is equal to Xlint:all to show everything and you can dig through it for whatever you want. What this fix requires is only passing a project property called Xlint. So .. the syntax is ./gradlew -PXlint build For the record, I'm not very convinced of adding both Xlint and OWASP to the master build.gradle. I am buys at the moment but I do wish to remove both (even though I helped in implementing both) because I was just trying to help Jacques to implement it properly > Create a Gradle task to use Xlint arguments when building > - > > Key: OFBIZ-8251 > URL: https://issues.apache.org/jira/browse/OFBIZ-8251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8251.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8251) Create a Gradle task to use Xlint arguments when building
[ https://issues.apache.org/jira/browse/OFBIZ-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-8251: --- Attachment: OFBIZ-8251.patch Attached is a simple and clean fix. Essentially, it's better to just use Xlint which is equal to Xlint:all to show everything and you can dig through it for whatever you want. What this fix requires is only passing a project property called Xlint. So .. the syntax is ./gradlew -PXlint build For the record, I'm not very convinced of adding both Xlint and OWASP to the master build.gradle. I am buys at the moment but I do wish to remove both (even though I helped in implementing both) because I was just trying to help Jacques to implement it properly > Create a Gradle task to use Xlint arguments when building > - > > Key: OFBIZ-8251 > URL: https://issues.apache.org/jira/browse/OFBIZ-8251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8251.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-8251) Create a Gradle task to use Xlint arguments when building
[ https://issues.apache.org/jira/browse/OFBIZ-8251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Taher Alkhateeb updated OFBIZ-8251: --- Attachment: OFBIZ-8251.patch Attaching a newer patch that also updated the README.md file for both xlint and owasp > Create a Gradle task to use Xlint arguments when building > - > > Key: OFBIZ-8251 > URL: https://issues.apache.org/jira/browse/OFBIZ-8251 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-8251.patch, OFBIZ-8251.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6556) Have the means to create a cmssite component in the hot-deploy folder
[ https://issues.apache.org/jira/browse/OFBIZ-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499427#comment-15499427 ] Taher Alkhateeb commented on OFBIZ-6556: This issue is adding an ant build script to the main directory structure and for a component that resides in specialpurpose. The logic in the ant script is not automatable (interactive, we discussed this at length) and it has multiple design flaws and repeats a lot of code needlessly > Have the means to create a cmssite component in the hot-deploy folder > - > > Key: OFBIZ-6556 > URL: https://issues.apache.org/jira/browse/OFBIZ-6556 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Pierre Smits > Attachments: OFBIZ-6556-CmsSiteCreator.patch > > > The create-component functionality enables a quick start to create hot-deploy > components for developers. > We should have the same kind of functionality to create cmssite components in > the hot-deploy folder. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443216#comment-15443216 ] Taher Alkhateeb commented on OFBIZ-5776: This is an area too big for me to tackle at the moment, but in my opinion web resources should be in fact completely outside of the framework. Perhaps a better place is the themes directory. Here are a few thoughts on why this should be the case: - The widget system is designed to be technology independent (is not specific to html). So the skinning, UI behavior and layout, should as much as possible be a deferred decision (right before painting). For example If I want a button to glow upon hovering, I should add that to the widget DSL and translate it at the very last second. - Even if we introduce a non-pure widget (...) then the translation of that UI is also a last minute decision happening in the templates / rendering engine. So in summary, nothing "Web-specific UI" should reside in the framework. The framework is the infrastructure tools and low level components (servlets, entity engine, service engine, scripting, DSLs, widget engine, routing, etc ...) and never things like UI. If we are going to go through the pain of renaming, refactoring, and fixing all the links, we might as well do this properly by keeping the framework lean, and anything that gets painted should go IMO to /themes somewhere. Perhaps we can have a base theme that holds all the things that other themes extend from. > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5776) Move static resources from framework/images to framework/resources webapp
[ https://issues.apache.org/jira/browse/OFBIZ-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15443252#comment-15443252 ] Taher Alkhateeb commented on OFBIZ-5776: Agreed, I am not sure how much work is involved in doing that, but this is a very critical area for the success of OFBiz (i.e. cleaning the UI mess). So I think we should not work too much on this JIRA and instead create an umbrella JIRA with perhaps the title "Move all UI web assets from the framework to a common shared theme" and branch out tasks such as "Refactor the themes to share a common base" and "Refactor the widgets in components to be independent of the theme designs" and similar tasks. So, it's big work, but necessary. UI is unfortunately one of the biggest areas of Chaos and we need to tackle it, and the very first step in my opinion is to keep the "mess" in one pile (/themes) and take it from there. > Move static resources from framework/images to framework/resources webapp > - > > Key: OFBIZ-5776 > URL: https://issues.apache.org/jira/browse/OFBIZ-5776 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit >Priority: Minor > Attachments: OFBIZ-5776.patch > > > Move all the static resources form images webapp to resources webapp, as they > all are more related to resources rather then images. > Also we need to rearrange these resources based on their purpose, like > - Move all js related files and plugins under resources/js > - Move all the css related files and plugins under resources/css > - Move all the images related to js and css under resources/images or > resources/img -- This message was sent by Atlassian JIRA (v6.3.4#6332)
