[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138882#comment-16138882 ] Taher Alkhateeb commented on OFBIZ-9441: I updated the code to remove any conflicts and committed in r1805947. Thank you for your help in review and testing > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: log with errors.txt, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[
https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115845#comment-16115845
]
Jacques Le Roux commented on OFBIZ-9441:
BTW for the point 4, about the syntax
{code}
-l,--load-data
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115838#comment-16115838 ] Jacques Le Roux commented on OFBIZ-9441: Just an idea (did not check) could it not be a transaction issue? > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: log with errors.txt, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115834#comment-16115834 ] Taher Alkhateeb commented on OFBIZ-9441: Hi Jacques, thank you for the review. Replying: 1- yeah .. that sucks :( it's because of the time delay in committing this stuff. I will merge the conflicts and reattach 2- Thank you .. will take care of it 3- To remain consistent with the rest of the framework. Anyway, it makes almost no difference given the very small sizes of the data structures 4- every "key=value" needs its own --load-data or -l. So the syntax should be ./gradlew "ofbiz -l readers=seed,demo,ext -l delegator=default -l group=org.apache.ofbiz" 5- Why are using java -jar? just use ./gradlew and execute your commands to avoid confusion or misspelling of things. Anyway, it seems like the errors are not related to my work but rather improperly configured data. It's just a bunch of foreign key violations and things like that. > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: log with errors.txt, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115829#comment-16115829 ] Jacques Le Roux commented on OFBIZ-9441: bq. g cleanAll eclipse build loadAll works perfectly > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: log with errors.txt, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[
https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115824#comment-16115824
]
Jacques Le Roux commented on OFBIZ-9441:
Hi Taher,
I continued the review,
# I could not completely apply the changes README.md. I guess you need to
update?
# found a typo :)
bq. Debug.logImportant("Creating foreign key indcies...", module);
# A question: in few places, why did you prefer ArrayList over LinkedList?
# Among
{code}
-l,--load-data
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114080#comment-16114080 ] Taher Alkhateeb commented on OFBIZ-9441: Thank you for your help, I'll wait for your review before committing. It's good to have a fresh pair of eyes. > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114065#comment-16114065 ] Jacques Le Roux commented on OFBIZ-9441: 1st, I like the README.md rewriting, I'll continue later... > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114050#comment-16114050 ] Jacques Le Roux commented on OFBIZ-9441: Oops, got it now, one name is not right. It should not be OFBIZ-9411.patch ;) OK remains the last question :) > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114052#comment-16114052 ] Jacques Le Roux commented on OFBIZ-9441: Ah we crossed on wire, good to know, thanks! > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114047#comment-16114047 ] Taher Alkhateeb commented on OFBIZ-9441: Ignore all the patches, they are for illustration only. the latest patch does everything > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114045#comment-16114045 ] Jacques Le Roux commented on OFBIZ-9441: HI Taher, I remember now, what refrained me to review is that it's not clear which is the last patch version. I understand there are 2 different patches # OFBIZ-9411.patch # OFBIZ-9441-fix-continue-on-failure.patch And that the last OFBIZ-9411.patch is from 21/Jul/17 16:14. But patches are weirdly grayed so I'm (a bit) unsure and especially I'd like to understand why it's so. Also is now the OFBIZ-9441-fix-continue-on-failure.patch included in the last OFBIZ-9411.patch? Thanks! > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch, > OFBIZ-9441-fix-continue-on-failure.patch, OFBIZ-9441.patch, OFBIZ-9441.patch, > OFBIZ-9441.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9441) Refactor OFBiz containers and remove StartupCommandToArgsAdapter
[ https://issues.apache.org/jira/browse/OFBIZ-9441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080634#comment-16080634 ] Taher Alkhateeb commented on OFBIZ-9441: Okay, so with this patch, the failure to load a data file does not crash the system. My investigation so far is showing that an exception is swallowed REALLY DEEP in the call stack. So I have to roll my sleeves and figure this out > Refactor OFBiz containers and remove StartupCommandToArgsAdapter > > > Key: OFBIZ-9441 > URL: https://issues.apache.org/jira/browse/OFBIZ-9441 > Project: OFBiz > Issue Type: Improvement >Reporter: Taher Alkhateeb >Assignee: Taher Alkhateeb >Priority: Minor > Attachments: OFBIZ-9411.patch > > > We have already refactored the ComponentContainer and CatalinaContainer in > OFBIZ-8337 and OFBIZ-9392. The objective of this JIRA is to apply the > following: > - Refactor EntityDataLoadContainer to simplify the code and remove > dependencies on "args" and convert instead the logic to use StartupCommands > - Refactor TestRunContainer the same way > - Delete the class StartupCommandToArgsAdapter > - Update README.md to reflect the changes and updates and cleanup old > references. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
