[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor URL: https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335544976 ## File path:

[GitHub] [incubator-shardingsphere] qixiaobo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node

2019-10-16 Thread GitBox
qixiaobo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542760093 ```java public final class MasterSlaveRouter { private final

[GitHub] [incubator-shardingsphere] wu-sheng merged pull request #3298: Add sharding + encrypt test engine

2019-10-16 Thread GitBox
wu-sheng merged pull request #3298: Add sharding + encrypt test engine URL: https://github.com/apache/incubator-shardingsphere/pull/3298 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
terrymanu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542772833 > @terrymanu a test relate to zk failed > > >

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3279: Shardingjdbc execute update exception

2019-10-16 Thread GitBox
terrymanu closed issue #3279: Shardingjdbc execute update exception URL: https://github.com/apache/incubator-shardingsphere/issues/3279 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
terrymanu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542772833 > @terrymanu a test relate to zk failed > > >

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
terrymanu merged pull request #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335554538 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335561212 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335561157 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu closed pull request #3284: Fix assignmentValueNode get error index

2019-10-16 Thread GitBox
terrymanu closed pull request #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3299: Finish parameterized test engine and test cases

2019-10-16 Thread GitBox
coveralls commented on issue #3299: Finish parameterized test engine and test cases URL: https://github.com/apache/incubator-shardingsphere/pull/3299#issuecomment-542818930 ## Pull Request Test Coverage Report for [Build 674](https://coveralls.io/builds/26354836) * **0** of **0**

[GitHub] [incubator-shardingsphere] dongzl commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
dongzl commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542539196 I'm dealing with the the Integration Tests problem, Please wait a moment.

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 656](https://coveralls.io/builds/26340644) * **0**

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
coveralls commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542538562 ## Pull Request Test Coverage Report for [Build 655](https://coveralls.io/builds/26340590) * **18** of **20**

[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #3291: add test forr GroupByContextEngine

2019-10-16 Thread GitBox
betterjava opened a new pull request #3291: add test forr GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291 Fixes #ISSUSE_ID. Changes proposed in this pull request: - Add GroupByContextEngineTest

[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3284: Fix assignmentValueNode get error index

2019-10-16 Thread GitBox
yanickxia commented on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542537054 use always get index 2, base on new g4 This is an

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
coveralls commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 654](https://coveralls.io/builds/26340561) * **0** of

[GitHub] [incubator-shardingsphere] qixiaobo commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
qixiaobo commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336254 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3138: Add more unit test cases for sharding-core-preprocessor module

2019-10-16 Thread GitBox
terrymanu closed issue #3138: Add more unit test cases for sharding-core-preprocessor module URL: https://github.com/apache/incubator-shardingsphere/issues/3138 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #3293: add test for OrderByContextEngine

2019-10-16 Thread GitBox
betterjava opened a new pull request #3293: add test for OrderByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3293 Fixes #3138. Changes proposed in this pull request: - Add OrderByContextEngineTest

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3291: add test for GroupByContextEngine

2019-10-16 Thread GitBox
terrymanu merged pull request #3291: add test for GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu opened a new issue #3138: Add more unit test cases for sharding-core-preprocessor module

2019-10-16 Thread GitBox
terrymanu opened a new issue #3138: Add more unit test cases for sharding-core-preprocessor module URL: https://github.com/apache/incubator-shardingsphere/issues/3138 sharding-core-preprocessor module is decouple with Sharding & encrypt. The codes has already stable. Should Add more

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 663](https://coveralls.io/builds/26343986) * **0**

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3291: add test forr GroupByContextEngine

2019-10-16 Thread GitBox
coveralls commented on issue #3291: add test forr GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291#issuecomment-542551463 ## Pull Request Test Coverage Report for [Build 658](https://coveralls.io/builds/26341254) * **0** of **0** changed or

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3284: Fix assignmentValueNode get error index

2019-10-16 Thread GitBox
terrymanu commented on issue #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284#issuecomment-542581832 > > The modification may cause problem. > > Right now we just can recognize 2 model: > > ``` > > 1. xxx = xxx > >

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #289: Add document contributor guide and sharding-ui and sharding-secure#284

2019-10-16 Thread GitBox
terrymanu merged pull request #289: Add document contributor guide and sharding-ui and sharding-secure#284 URL: https://github.com/apache/incubator-shardingsphere-doc/pull/289 This is an automated message from the Apache

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #288: Add document contributor guide#284

2019-10-16 Thread GitBox
terrymanu merged pull request #288: Add document contributor guide#284 URL: https://github.com/apache/incubator-shardingsphere-doc/pull/288 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] Myshiner opened a new issue #3294: How to compute the max pool size of sharding-proxy ?

2019-10-16 Thread GitBox
Myshiner opened a new issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294 Project: Sharding-proxy Version: v3.1.0 & v4.x ## Question How can i count the total connections of sharding-proxy ? should I

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #287: add benchmark folder

2019-10-16 Thread GitBox
terrymanu merged pull request #287: add benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/287 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336771 ## File path:

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335336757 ## File path:

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335336109 ## File path:

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
KomachiSion commented on a change in pull request #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#discussion_r335335594 ## File path:

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
coveralls commented on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 661](https://coveralls.io/builds/26343342) * **0** of

[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3289: jdbcType=LONGVARCHAR insert into table fail

2019-10-16 Thread GitBox
yanickxia commented on issue #3289: jdbcType=LONGVARCHAR insert into table fail URL: https://github.com/apache/incubator-shardingsphere/issues/3289#issuecomment-542604685 this a mybatis bug ? ```java Caused by: java.io.NotSerializableException: java.io.StringReader at

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542549370 @terrymanu This is an automated message from

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
coveralls commented on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542556682 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] dongzl removed a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
dongzl removed a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542539196 I'm dealing with the the Integration Tests problem, Please wait a moment.

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3291: add test for GroupByContextEngine

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3291: add test for GroupByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3291#issuecomment-542551463 ## Pull Request Test Coverage Report for [Build 660](https://coveralls.io/builds/26342477) * **0** of **0**

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3271: #3247, support left/right function parse

2019-10-16 Thread GitBox
terrymanu merged pull request #3271: #3247, support left/right function parse URL: https://github.com/apache/incubator-shardingsphere/pull/3271 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3247: concat() nest left() function-->>can not find the logic table name

2019-10-16 Thread GitBox
terrymanu closed issue #3247: concat() nest left() function-->>can not find the logic table name URL: https://github.com/apache/incubator-shardingsphere/issues/3247 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
tristaZero commented on a change in pull request #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r335343151 ## File path:

[GitHub] [incubator-shardingsphere] jingshanglu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
jingshanglu edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542592442 > That maybe not enough because the expression may `values(xx) + values(xx)`. > So `VALUES` should be

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542592442 > That maybe not enough because the expression may `values(xx) + values(xx)`. > So `VALUES` should be a part

[GitHub] [incubator-shardingsphere] haetao opened a new pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
haetao opened a new pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292 Add test case Case1: insert_with_duplicate_key_way_1 Case2: insert_with_duplicate_key_way_2 Case3:

[GitHub] [incubator-shardingsphere-doc] tristaZero opened a new pull request #290: Update build.sh

2019-10-16 Thread GitBox
tristaZero opened a new pull request #290: Update build.sh URL: https://github.com/apache/incubator-shardingsphere-doc/pull/290 add benchmark This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3294: How to compute the max pool size of sharding-proxy ?

2019-10-16 Thread GitBox
yanickxia commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542606379 try [SCTL (Sharding-Proxy control

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3293: add test for OrderByContextEngine

2019-10-16 Thread GitBox
terrymanu merged pull request #3293: add test for OrderByContextEngine URL: https://github.com/apache/incubator-shardingsphere/pull/3293 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new pull request #291: add performance monitoring page

2019-10-16 Thread GitBox
wqzwh opened a new pull request #291: add performance monitoring page URL: https://github.com/apache/incubator-shardingsphere-doc/pull/291 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 665](https://coveralls.io/builds/26345472) *

[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new issue #293: Performance monitoring page supports mobile terminal

2019-10-16 Thread GitBox
wqzwh opened a new issue #293: Performance monitoring page supports mobile terminal URL: https://github.com/apache/incubator-shardingsphere-doc/issues/293 Project source address:https://github.com/apache/incubator-shardingsphere-benchmark

[GitHub] [incubator-shardingsphere] TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node

2019-10-16 Thread GitBox
TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu Any progress on this issue? 4.0.0.RC2 still has select for update

[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335378743 ## File path:

[GitHub] [incubator-shardingsphere] gufengwyx8 commented on a change in pull request #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
gufengwyx8 commented on a change in pull request #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#discussion_r335395946 ## File path:

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 664](https://coveralls.io/builds/26345375) *

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542537631 ## Pull Request Test Coverage Report for [Build 666](https://coveralls.io/builds/26345511) * **0**

[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3024: proxy-4.0.0-RC2 process blob data error

2019-10-16 Thread GitBox
yanickxia commented on issue #3024: proxy-4.0.0-RC2 process blob data error URL: https://github.com/apache/incubator-shardingsphere/issues/3024#issuecomment-542659474 @xriqyu i try 4 different way to reappear it , but without success. RAW - JDBC Direct to Mysql RAW - JDBC By

[GitHub] [incubator-shardingsphere] TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node

2019-10-16 Thread GitBox
TonyLuo edited a comment on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu why close this issue? 4.0.0.RC2 still has select for update

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?

2019-10-16 Thread GitBox
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542621408 I got the result. mysql> sctl:show cached_connections; ++ | CACHED_CONNECTIONS |

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #291: add performance monitoring page

2019-10-16 Thread GitBox
terrymanu merged pull request #291: add performance monitoring page URL: https://github.com/apache/incubator-shardingsphere-doc/pull/291 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere-doc] tristaZero closed pull request #290: Update build.sh

2019-10-16 Thread GitBox
tristaZero closed pull request #290: Update build.sh URL: https://github.com/apache/incubator-shardingsphere-doc/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542640668 @terrymanu a test relate to zk failed >

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?

2019-10-16 Thread GitBox
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542623052 Actually now many applications connected to proxy, the proxy port is 3306, and result is 113 by running

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542538562 ## Pull Request Test Coverage Report for [Build 667](https://coveralls.io/builds/26345969) * **18** of

[GitHub] [incubator-shardingsphere] TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node

2019-10-16 Thread GitBox
TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542659096 @terrymanu why close this issue? 4.0.0.RC2 still has select for update issue

[GitHub] [incubator-shardingsphere] TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node

2019-10-16 Thread GitBox
TonyLuo commented on issue #1496: Read write splitter for `Select ... for update` should route to master data node URL: https://github.com/apache/incubator-shardingsphere/issues/1496#issuecomment-542663211 or could you pls advise which java files should be focused on to help to fix this

[GitHub] [incubator-shardingsphere] xiyelife opened a new pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
xiyelife opened a new pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295 Fixes #ISSUSE_ID. Changes proposed in this pull request: - fixed #3234 for more than 2

[GitHub] [incubator-shardingsphere] jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index

2019-10-16 Thread GitBox
jingshanglu commented on issue #3290: fix g4 for assignmentValueNode get error by index URL: https://github.com/apache/incubator-shardingsphere/pull/3290#issuecomment-542627489 > Are you sure the keyword `VALUES` in the rule expr? I cannot found it, if remove `VALUES` from set assignment

[GitHub] [incubator-shardingsphere] yanickxia commented on issue #3178: The INSERT statement with

2019-10-16 Thread GitBox
yanickxia commented on issue #3178: The INSERT statement with https://github.com/apache/incubator-shardingsphere/issues/3178#issuecomment-542629195 ![image](https://user-images.githubusercontent.com/6848593/66909707-c9c13880-f03f-11e9-96e9-c375eb3ec04b.png) i use demo-example to reapet

[GitHub] [incubator-shardingsphere-doc] wqzwh opened a new pull request #292: delete benchmark folder

2019-10-16 Thread GitBox
wqzwh opened a new pull request #292: delete benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere-doc] terrymanu merged pull request #292: delete benchmark folder

2019-10-16 Thread GitBox
terrymanu merged pull request #292: delete benchmark folder URL: https://github.com/apache/incubator-shardingsphere-doc/pull/292 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ?

2019-10-16 Thread GitBox
Myshiner commented on issue #3294: How to compute the max pool size of sharding-proxy ? URL: https://github.com/apache/incubator-shardingsphere/issues/3294#issuecomment-542647387 And sharding-proxy dont support "sctl:hint show status" and "sctl:hint show table status;" mysql>

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
terrymanu commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335470036 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml

[GitHub] [incubator-shardingsphere] sluk3r commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor

2019-10-16 Thread GitBox
sluk3r commented on a change in pull request #3281: #3138 improved coverage for sharding core preprocessor URL: https://github.com/apache/incubator-shardingsphere/pull/3281#discussion_r335497199 ## File path:

[GitHub] [incubator-shardingsphere] tuohai666 opened a new issue #3296: Enhancement about the benchmark site

2019-10-16 Thread GitBox
tuohai666 opened a new issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296 Our benchmark site is available right now: https://shardingsphere.apache.org/benchmark/ Great progress has been made in presentation than the

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
coveralls commented on issue #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#issuecomment-542683827 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] gaoguanghai commented on issue #3154: Data masking: the name of logicColumn is case sensitive

2019-10-16 Thread GitBox
gaoguanghai commented on issue #3154: Data masking: the name of logicColumn is case sensitive URL: https://github.com/apache/incubator-shardingsphere/issues/3154#issuecomment-542714247 Hi @skyoxZ ,I'm not sure what problems you encountered, could you describe them in more detail?

[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335497672 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #3298: Add sharding + encrypt test engine

2019-10-16 Thread GitBox
terrymanu opened a new pull request #3298: Add sharding + encrypt test engine URL: https://github.com/apache/incubator-shardingsphere/pull/3298 For #1548. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] beiwangnull opened a new issue #3297: select for update syntax route to slave datasource

2019-10-16 Thread GitBox
beiwangnull opened a new issue #3297: select for update syntax route to slave datasource URL: https://github.com/apache/incubator-shardingsphere/issues/3297 ## Bug Report Please answer these questions before submitting your issue. Thanks! ### Which version of ShardingSphere

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3296: Enhancement about the benchmark site

2019-10-16 Thread GitBox
terrymanu commented on issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296#issuecomment-542693801 Maybe we should move this issue to https://github.com/apache/incubator-shardingsphere-benchmark

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
terrymanu merged pull request #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3262: Table owner is lost for logic encrypt column

2019-10-16 Thread GitBox
terrymanu closed issue #3262: Table owner is lost for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/issues/3262 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
haetao commented on a change in pull request #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#discussion_r335496237 ## File path: sharding-sql-test/src/main/resources/sql/sharding/dml/insert.xml

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3299: Finish parameterized test engine and test cases

2019-10-16 Thread GitBox
terrymanu merged pull request #3299: Finish parameterized test engine and test cases URL: https://github.com/apache/incubator-shardingsphere/pull/3299 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335788763 ## File path:

[GitHub] [incubator-shardingsphere-doc] terrymanu closed issue #284: Add guide for how to contribute document

2019-10-16 Thread GitBox
terrymanu closed issue #284: Add guide for how to contribute document URL: https://github.com/apache/incubator-shardingsphere-doc/issues/284 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value.

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3288: fixes QueryResultUtil#getValueByColumnType unsigned int & bigint return value. URL: https://github.com/apache/incubator-shardingsphere/pull/3288#issuecomment-542556682 ## Pull Request Test Coverage Report for [Build

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3284: Fix assignmentValueNode get error index

2019-10-16 Thread GitBox
terrymanu merged pull request #3284: Fix assignmentValueNode get error index URL: https://github.com/apache/incubator-shardingsphere/pull/3284 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3165: Support time server database for issues 1497

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3165: Support time server database for issues 1497 URL: https://github.com/apache/incubator-shardingsphere/pull/3165#issuecomment-537458903 ## Pull Request Test Coverage Report for [Build 485](https://coveralls.io/builds/26064069) * **0** of

[GitHub] [incubator-shardingsphere] alterhu2020 commented on issue #3257: java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Intege

2019-10-16 Thread GitBox
alterhu2020 commented on issue #3257: java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Intege URL: https://github.com/apache/incubator-shardingsphere/issues/3257#issuecomment-542982739 @dongzl when this new version been release? It affects current project? thanks

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3296: Enhancement about the benchmark site

2019-10-16 Thread GitBox
tuohai666 commented on issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296#issuecomment-542982233 Yes, you are right. The issues module for incubator-shardingsphere-benchmark is not available for now, I have asked

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #3296: Enhancement about the benchmark site

2019-10-16 Thread GitBox
tuohai666 closed issue #3296: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere/issues/3296 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3276: Add table owner for logic encrypt column

2019-10-16 Thread GitBox
tristaZero commented on issue #3276: Add table owner for logic encrypt column URL: https://github.com/apache/incubator-shardingsphere/pull/3276#issuecomment-542967941 @gufengwyx8 Hi, good job. :) This is an automated message

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test

2019-10-16 Thread GitBox
coveralls edited a comment on issue #3292: add SQL test case to moudle sql-test and parse-test URL: https://github.com/apache/incubator-shardingsphere/pull/3292#issuecomment-542594012 ## Pull Request Test Coverage Report for [Build 677](https://coveralls.io/builds/26364395) *

[GitHub] [incubator-shardingsphere-benchmark] tuohai666 opened a new issue #9: Enhancement about the benchmark site

2019-10-16 Thread GitBox
tuohai666 opened a new issue #9: Enhancement about the benchmark site URL: https://github.com/apache/incubator-shardingsphere-benchmark/issues/9 Our benchmark site is available right now: https://shardingsphere.apache.org/benchmark/ Great progress has been made in presentation than

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #2925: Sharding-proxy v4.0.0-RC2 can't config multi-users

2019-10-16 Thread GitBox
Myshiner commented on issue #2925: Sharding-proxy v4.0.0-RC2 can't config multi-users URL: https://github.com/apache/incubator-shardingsphere/issues/2925#issuecomment-542961487 Yesterday I run with dev branch and multi-user didn't work if run with zk, but it's ok without zk config.

[GitHub] [incubator-shardingsphere] xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns

2019-10-16 Thread GitBox
xiyelife commented on a change in pull request #3295: fixed for #3234 and add the encrypted test case for more than four cipher coloumns URL: https://github.com/apache/incubator-shardingsphere/pull/3295#discussion_r335787166 ## File path:

[GitHub] [incubator-shardingsphere-doc] beckhampu closed issue #280: Add document for Sharding-UI

2019-10-16 Thread GitBox
beckhampu closed issue #280: Add document for Sharding-UI URL: https://github.com/apache/incubator-shardingsphere-doc/issues/280 This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >