nikitap492 commented on issue #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380692320
Yes, sure
This is an automated message from the Ap
nikitap492 closed pull request #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL: https://github.com/apache/incubator-skywalking/pull/1069
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenanc
coveralls commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516
[](https://coveralls.io/builds/16475338)
Coverage increased (+0.03%) t
wu-sheng commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380671097
@weenyaimac And this document is already inside
`quick-start/deploy-cluster/deploy-ui`, the link is
https://github.com/apache/incubator-
wu-sheng commented on issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？
URL:
https://github.com/apache/incubator-skywalking/issues/1065#issuecomment-380670103
Closing this.
This is an automated message from the Apache Git Service.
To
wu-sheng closed issue #1065: agent_gRPC这里是不是得配置成自己的外网IP？
URL: https://github.com/apache/incubator-skywalking/issues/1065
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHu
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380667733
#1070 has been merged. Please adjust, recheck and rerun the tests. @ascrutae
After this is done, post the test report here.
---
wu-sheng closed pull request #1070: add ContextManager.isActive()
URL: https://github.com/apache/incubator-skywalking/pull/1070
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
coveralls commented on issue #1070: add ContextManager.isActive()
URL:
https://github.com/apache/incubator-skywalking/pull/1070#issuecomment-380662810
[](https://coveralls.io/builds/16474320)
Coverage decreased (-0.00
coveralls commented on issue #1070: add ContextManager.isActive()
URL:
https://github.com/apache/incubator-skywalking/pull/1070#issuecomment-380662810
[](https://coveralls.io/builds/16474298)
Coverage decreased (-0.00
coveralls commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516
[](https://coveralls.io/builds/16474274)
Coverage increased (+0.04%) t
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521
thank for your suggestion, remove redundant LocalSpan in parent thread looks
all right in skywalking-ui .
http /case/cross-thread-->mult
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521
thank for your suggestion, remove redundant LocalSpan in parent thread looks
all right in skywalking-ui .
http /case/corss-thread-->mult
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380658521
thank for your suggestion, remove redundant LocalSpan in parent thread looks
all right in skywalking-ui .
-
carlvine500 opened a new pull request #1070: add ContextManager.isActive()
URL: https://github.com/apache/incubator-skywalking/pull/1070
___
### New feature or improvement
add ContextManager.isActive()
This is an aut
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380654667
> meaningless but a little useful .
span created once in parent span, cost is limited .
if we skip trace when there is no active context ,
coveralls commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516
[](https://coveralls.io/builds/16473742)
Coverage increased (+0.04%) t
wu-sheng commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380648224
@weenyaimac Yes, I am aware that shell. Do you mean other people don't know
that, they should change the shell when they deploy the webap
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380648218
meaningless but a little useful .
span created once in parent span, cost is limited .
if we skip trace when there is no active context
weenyaimac commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380647368
@wu-sheng Hi, morning, yesterday I've solved this problem, through the ways
which the collector.ribbon.listOfServers in the webappServi
wu-sheng commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380646976
@peng-yongsheng Yes. 1 hours is most likely the largest duration
(considering result points). Look like a performance issue.
---
peng-yongsheng commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380646714
Exception is `Read timed out`, maybe the query performance is poor with 1
hour data of application function.
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380646202
> do you think a EntrySpan is better than LocalSpan in parent thread ?
in main method , first time before calling child thread will generate a
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380645075
do you think a EntrySpan is better than LocalSpan in parent thread ?
in main method , first time before calling child thread will generate
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380643676
And please put `ContextManager.isActive()` into another pr. If I am right,
`ContextManager` didn't have this method for now.
--
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380643444
> we expect to create a span in parent thread when I run a main method ,
and parent thread's globalTraceId will join the children thread Local
wu-sheng commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380643161
@peng-yongsheng I am wondering, whether this is a problem about too much
data in single one query for ElasticSearch or Collector? `500` s
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380643087
1. I agree with your idea
2. we expect to create a span in parent thread when I run a main method ,
and parent thread's globalTraceId w
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects
methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380493664
@nikitap492 For better and easier review and further merge, I recommend you
close this pr, and open several separated
wu-sheng commented on a change in pull request #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#discussion_r180792253
##
File path:
apm-collector/apm-collector-analysis/analysis-register/register-provider/src/
wu-sheng commented on a change in pull request #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#discussion_r180793789
##
File path:
apm-collector/apm-collector-cache/collector-cache-caffeine-provider/src/main/
wu-sheng commented on a change in pull request #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#discussion_r180792550
##
File path:
apm-collector/apm-collector-cache/collector-cache-caffeine-provider/src/main/
coveralls commented on issue #1068: GraphQL for Thermodynamic in overview page.
URL:
https://github.com/apache/incubator-skywalking/pull/1068#issuecomment-380394610
[](https://coveralls.io/builds/16462847)
Coverage re
nikitap492 commented on issue #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380488126
Right.
I understood that and didn't change any method signature
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects
methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104
@nikitap492 Thanks. That is better to understand your pr. Then I will focus
on codes only for this pr.
At lea
coveralls commented on issue #1069: Replaced ObjectUtils for java.utils.Objects
methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480149
[](https://coveralls.io/builds/16462524)
Co
wu-sheng commented on issue #1069: Replaced ObjectUtils for java.utils.Objects
methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380484104
@nikitap492 Thanks. That is better to understand your pr. Then I will focus
on codes only for this pr.
At lea
nikitap492 commented on issue #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480827
There is no defference between these two methods. It is just a good practice
to use already written methods, becaus
nikitap492 commented on issue #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480827
There is no defference between these two methods. It is just a good practice
to use already written methods, becaus
coveralls commented on issue #1069: Replaced ObjectUtils for java.utils.Objects
methods
URL:
https://github.com/apache/incubator-skywalking/pull/1069#issuecomment-380480149
[](https://coveralls.io/builds/16462289)
Co
coveralls commented on issue #1067: add doc for TraceCrossThread
URL:
https://github.com/apache/incubator-skywalking/pull/1067#issuecomment-380388288
[](https://coveralls.io/builds/16459153)
Coverage remained the same
coveralls commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516
[](https://coveralls.io/builds/16458762)
Coverage increased (+0.05%) t
coveralls commented on issue #1067: add doc for TraceCrossThread
URL:
https://github.com/apache/incubator-skywalking/pull/1067#issuecomment-380388288
[](https://coveralls.io/builds/16457290)
Coverage remained the same
coveralls commented on issue #1068: GraphQL for Thermodynamic in overview page.
URL:
https://github.com/apache/incubator-skywalking/pull/1068#issuecomment-380394610
[](https://coveralls.io/builds/16457150)
Coverage re
nikitap492 opened a new pull request #1069: Replaced ObjectUtils for
java.utils.Objects methods
URL: https://github.com/apache/incubator-skywalking/pull/1069
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New fea
coveralls commented on issue #1067: add doc for TraceCrossThread
URL:
https://github.com/apache/incubator-skywalking/pull/1067#issuecomment-380388288
[](https://coveralls.io/builds/16456822)
Coverage remained the same
wu-sheng opened a new pull request #1068: GraphQL for Thermodynamic in overview
page.
URL: https://github.com/apache/incubator-skywalking/pull/1068
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provi
wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380382159
@ascrutae
https://github.com/SkywalkingTest/skywalking-agent-testcases/pull/15 is still
open. Please feedback the status, thanks.
carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL:
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-380381521
test is ok now
carlvine500 opened a new pull request #1067: add doc for TraceCrossThread
URL: https://github.com/apache/incubator-skywalking/pull/1067
### New feature or improvement
- add doc for TraceCrossThread
This is an automa
wu-sheng closed pull request #1066: Update README.md
URL: https://github.com/apache/incubator-skywalking/pull/1066
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
weenyaimac commented on issue #940: [skywalking-ui]Request Error 500
URL:
https://github.com/apache/incubator-skywalking/issues/940#issuecomment-380352597
Which version of SkyWalking, OS and JRE?
SkyWalking：5.0.0-alpha
JRE: 1.8.0_131
OS: RedHatEnterpriseServer 6.5 x64
Storage: e
52 matches
Mail list logo
