[GitHub] [skywalking] codecov-io commented on issue #4363: Fix non-atomic operations on volatile variables

codecov-io commented on issue #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363#issuecomment-586558394 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4363?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 closed pull request #4363: Fix non-atomic operations on volatile variables

kezhenxu94 closed pull request #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables

wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363#discussion_r379748470 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables

wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363#discussion_r379748997 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables

wu-sheng commented on a change in pull request #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363#discussion_r379749532 ## File path:

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4363: Fix non-atomic operations on volatile variables

kezhenxu94 opened a new pull request #4363: Fix non-atomic operations on volatile variables URL: https://github.com/apache/skywalking/pull/4363 ### Motivation: Fix non-atomic operations on `volatile` variables. ### Modifications: Replace `int`, `long` with

[skywalking] branch master updated (ae33ac8 -> 5fed153)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ae33ac8 Adjust Armeria plugin to adapt 0.98.0 (#4362) add 5fed153 Add Armeria 0.98.0 to the supported

[GitHub] [skywalking] kezhenxu94 merged pull request #4328: Add Armeria 0.98.0 to the supported version list

kezhenxu94 merged pull request #4328: Add Armeria 0.98.0 to the supported version list URL: https://github.com/apache/skywalking/pull/4328 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379715955 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@ -64,15

[GitHub] [skywalking] kezhenxu94 merged pull request #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 merged pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch master updated (ae442e3 -> ae33ac8)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ae442e3 More comments for important classes (#4361) add ae33ac8 Adjust Armeria plugin to adapt 0.98.0

[GitHub] [skywalking] wu-sheng commented on issue #4362: Adapt Armeria plugin to version 0.98.0

wu-sheng commented on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586549638 Go for that. It is fine. This is an automated message from the Apache Git

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 edited a comment on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586549323 The failure is due to network issue and I had re-run it several times, I'll merge this after the running tests finished, instead of

[GitHub] [skywalking] kezhenxu94 commented on issue #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 commented on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586549323 The failure is due to network issue and I had re-run it several times, I'll merge this instead of re-running over and over

[GitHub] [skywalking] codecov-io commented on issue #4362: Adapt Armeria plugin to version 0.98.0

codecov-io commented on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586545936 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4362?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4362: Adapt Armeria plugin to version 0.98.0

wu-sheng commented on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586542152 Tests seem passed, please continue. This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379514119 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0

wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#discussion_r379510143 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379509831 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@ -64,15

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379504306 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379502634 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#discussion_r379497366 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0

wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#discussion_r379493454 ## File path: test/plugin/scenarios/armeria-0.96plus-scenario/support-version.list ## @@ -14,5 +14,6 @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0

wu-sheng commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#discussion_r379491221 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on issue #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 commented on issue #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#issuecomment-586335019 here are the changes between 0.97.0 and 0.98.0 that breaks the plugin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 commented on a change in pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362#discussion_r379488858 ## File path: test/plugin/scenarios/armeria-0.96plus-scenario/support-version.list ## @@ -14,5 +14,6 @@

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4362: Adapt Armeria plugin to version 0.98.0

kezhenxu94 opened a new pull request #4362: Adapt Armeria plugin to version 0.98.0 URL: https://github.com/apache/skywalking/pull/4362 ### Motivation: Support Armeria 0.98.0 in its plugin. ### Modifications: Add an intercept point that is refactored in Armeria 0.98.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379436664 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379435243 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@ -64,15

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379416559 ## File path: test/e2e/e2e-browser/e2e-browser-es/src/test/java/org/apache/skywalking/e2e/ESWithBrowserPerfITCase.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379416071 ## File path: test/e2e/e2e-base/src/main/java/org/apache/skywalking/e2e/metrics/MetricsMatcher.java ## @@

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379413452 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379412514 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379420025 ## File path: .github/workflows/e2e.yaml ## @@ -118,3 +118,19 @@ jobs: run: export E2E_VERSION=jdk8-1.3

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379413621 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379407019 ## File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal ## @@ -0,0 +1,56 @@ +/* +*

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379404093 ## File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal ## @@ -0,0 +1,49 @@ +/* +*

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379404199 ## File path: docs/en/setup/README.md ## @@ -25,6 +25,12 @@ You can go to their project repositories for

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379404115 ## File path: dist-material/application.yml ## @@ -151,6 +151,17 @@ receiver-jvm: default: receiver-clr:

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379404246 ## File path: docs/en/setup/README.md ## @@ -25,6 +25,12 @@ You can go to their project repositories for

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379403998 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379381981 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379375965 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379373679 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379366744 ## File path: dist-material/application.yml ## @@ -151,6 +151,17 @@ receiver-jvm: default: receiver-clr:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379368921 ## File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal ## @@ -0,0 +1,49 @@ +/* +*

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379369588 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379366583 ## File path: README.md ## @@ -27,6 +27,7 @@ The core features are following. - Distributed tracing and context

[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379368436 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379341010 ## File path: docs/en/setup/README.md ## @@ -25,6 +25,12 @@ You can go to their project repositories for

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP

wu-sheng commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r379339284 ## File path: docs/en/setup/README.md ## @@ -25,6 +25,12 @@ You can go to their project repositories for

[skywalking] branch master updated (5f4b566 -> ae442e3)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 5f4b566 Fix missing mysql index for profile entities (#4360) add ae442e3 More comments for important

[GitHub] [skywalking] kezhenxu94 merged pull request #4361: More comments for important classes

kezhenxu94 merged pull request #4361: More comments for important classes URL: https://github.com/apache/skywalking/pull/4361 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586151116 Before doing code level deep dive, please read my comments, we should set the target clear about this

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379287530 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379290950 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379285619 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379294683 ## File path:

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379286512 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

wu-sheng commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586150036 `allow_no_indices` and `ignore_unavailable` should be good choices. Could you try to use these? And check

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

kezhenxu94 commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#discussion_r379290165 ## File path:

[GitHub] [skywalking] aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket

aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586144859 @wu-sheng Worried about the problem of error in log( `index_not_found` exception ), I checked the relevant

[GitHub] [skywalking] aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket

aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586144859 @wu-sheng Worried about the problem of error in log( `index_not_found` exception ), I checked the relevant

[GitHub] [skywalking] aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket

aderm edited a comment on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586144859 @wu-sheng Worried about the problem of error in log( `index_not_found` exception ), I checked the relevant

[GitHub] [skywalking] aderm commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket

aderm commented on issue #4353: Optimizing performance reduces es index queries scope by timebucket URL: https://github.com/apache/skywalking/pull/4353#issuecomment-586144859 @wu-sheng Worried about the problem of error in log( `index_not_found` exception ), I checked the relevant

[GitHub] [skywalking] wu-sheng closed issue #4359: Add MySQL index for profile entities

wu-sheng closed issue #4359: Add MySQL index for profile entities URL: https://github.com/apache/skywalking/issues/4359 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated (6be3e99 -> 5f4b566)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6be3e99 Help people to read source codes of core module. (#4357) add 5f4b566 Fix missing mysql index for

[skywalking] branch comments updated (e3c61af -> 9989afe)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch comments in repository https://gitbox.apache.org/repos/asf/skywalking.git. from e3c61af Fix format. add 5f4b566 Fix missing mysql index for profile entities (#4360) add 9989afe

[GitHub] [skywalking] wu-sheng merged pull request #4360: Fix missing mysql index for profile entities

wu-sheng merged pull request #4360: Fix missing mysql index for profile entities URL: https://github.com/apache/skywalking/pull/4360 This is an automated message from the Apache Git Service. To respond to the message,