[GitHub] codecov-io commented on issue #5181: [Fix] Formula type annotation no showing up

2018-06-11 Thread GitBox
codecov-io commented on issue #5181: [Fix] Formula type annotation no showing up URL: https://github.com/apache/incubator-superset/pull/5181#issuecomment-396466526 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5181?src=pr=h1) Report > Merging

[GitHub] graceguo-supercat opened a new pull request #5181: [Fix] Formula type annotation no showing up

2018-06-11 Thread GitBox
graceguo-supercat opened a new pull request #5181: [Fix] Formula type annotation no showing up URL: https://github.com/apache/incubator-superset/pull/5181 it seems related to change in #4630. This is an automated message

[GitHub] john-bodley commented on issue #5175: boto3 and botocore version mismatch

2018-06-11 Thread GitBox
john-bodley commented on issue #5175: boto3 and botocore version mismatch URL: https://github.com/apache/incubator-superset/issues/5175#issuecomment-396444621 @mistercrunch @timifasubaa found a similar issue with Celery and had to pin the `kombu` subcomponent in

[GitHub] michellethomas opened a new pull request #5179: Adding column only if it doesn't already exist

2018-06-11 Thread GitBox
michellethomas opened a new pull request #5179: Adding column only if it doesn't already exist URL: https://github.com/apache/incubator-superset/pull/5179 If you run load_examples multiple times, it will create multiple columns called `num_california`. This is a change to add it only if

[GitHub] john-bodley opened a new pull request #5178: John bodley sql percent sign

2018-06-11 Thread GitBox
john-bodley opened a new pull request #5178: John bodley sql percent sign URL: https://github.com/apache/incubator-superset/pull/5178 This PR came about due to an error when exporting a SQL Lab result to CSV. For example in Presto one can successfully run the following query: ```

[GitHub] lynch0227 closed issue #5169: How to disable preview data feature?

2018-06-11 Thread GitBox
lynch0227 closed issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] lynch0227 commented on issue #5169: How to disable preview data feature?

2018-06-11 Thread GitBox
lynch0227 commented on issue #5169: How to disable preview data feature? URL: https://github.com/apache/incubator-superset/issues/5169#issuecomment-396436689 OK, I got it. Thanks for your explanation. This is an automated

[GitHub] kirankumarpv commented on issue #3690: URL Prefix Superset Flask

2018-06-11 Thread GitBox
kirankumarpv commented on issue #3690: URL Prefix Superset Flask URL: https://github.com/apache/incubator-superset/issues/3690#issuecomment-396435448 Hi, I am also having the same issue. I tried to fix it using Blurprints but superset doesn't seem to take into consideration

[GitHub] neshkatrapati commented on issue #5168: am unable to find stacked bars feature in the upgraded superset. I can't find chart options as it was before I am finding it difficult to use breakdown

2018-06-11 Thread GitBox
neshkatrapati commented on issue #5168: am unable to find stacked bars feature in the upgraded superset. I can't find chart options as it was before I am finding it difficult to use breakdowns. URL: https://github.com/apache/incubator-superset/issues/5168#issuecomment-396433147 I dont

[GitHub] codecov-io commented on issue #5174: Gantt Chart visualization

2018-06-11 Thread GitBox
codecov-io commented on issue #5174: Gantt Chart visualization URL: https://github.com/apache/incubator-superset/pull/5174#issuecomment-396386176 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=h1) Report > Merging

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-11 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-396430715 I found and resolved an issue where the `dynamic-import-node` babel transpilation plugin broke webpack's bundle

[GitHub] williaster closed pull request #5055: Fixing tooltip displaying metrics in heatmap

2018-06-11 Thread GitBox
williaster closed pull request #5055: Fixing tooltip displaying metrics in heatmap URL: https://github.com/apache/incubator-superset/pull/5055 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

2018-06-11 Thread GitBox
williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-395911509 These are the final set of 3x empirical tests per example dashboard before and after, on non-minimized code with

[GitHub] mistercrunch closed pull request #5108: Fix bullet chart rendering

2018-06-11 Thread GitBox
mistercrunch closed pull request #5108: Fix bullet chart rendering URL: https://github.com/apache/incubator-superset/pull/5108 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396419762 How about bringing it into our staging and then production for a while and revisiting?

[GitHub] betodealmeida commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
betodealmeida commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396419569 I'm committed to maintain the Python version. Last week I added support for Python 3, published it to PyPI with the name "prison", and

[GitHub] codecov-io commented on issue #5177: Time shift difference

2018-06-11 Thread GitBox
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5177: Time shift difference

2018-06-11 Thread GitBox
codecov-io commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396419443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5177?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #5177: Time shift difference

2018-06-11 Thread GitBox
mistercrunch commented on issue #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177#issuecomment-396417805 I think this is effectively the same as a superior `Period Ratio` isn't it? If so we should `db migrate` to translate the slices. I know

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
codecov-io commented on issue #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176#issuecomment-396417232 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5176?src=pr=h1) Report > Merging

[GitHub] betodealmeida opened a new pull request #5177: Time shift difference

2018-06-11 Thread GitBox
betodealmeida opened a new pull request #5177: Time shift difference URL: https://github.com/apache/incubator-superset/pull/5177 I added a new control to allow comparing comparing the main time series with time shifts. In addition to showing the time shift as individual lines, it's now

[GitHub] mistercrunch commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
mistercrunch commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396416232 @williaster the main driver is mostly readable, and maybe hackable urls. I really wish Rison was more popular / supported. Note that we

[GitHub] mistercrunch commented on issue #4961: Deprecate database attribute allow_run_sync

2018-06-11 Thread GitBox
mistercrunch commented on issue #4961: Deprecate database attribute allow_run_sync URL: https://github.com/apache/incubator-superset/pull/4961#issuecomment-396414622 @john-bodley this was done on purpose as db migrations have been a huge plague and should be avoided whenever possible. A

[GitHub] mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe URL: https://github.com/apache/incubator-superset/pull/4726#discussion_r194572936 ## File path: superset/viz.py ## @@ -170,11 +170,21 @@ def get_df(self,

[GitHub] mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics

2018-06-11 Thread GitBox
mistercrunch opened a new pull request #5176: Introduce class attr BaseViz.enforce_numerical_metrics URL: https://github.com/apache/incubator-superset/pull/5176 This is an automated message from the Apache Git Service. To

[GitHub] mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #5122: Bump FAB and a bunch of JS libs URL: https://github.com/apache/incubator-superset/pull/5122#discussion_r194571227 ## File path: superset/assets/package.json ## @@ -150,13 +152,15 @@ "react-addons-test-utils":

[GitHub] mistercrunch commented on a change in pull request #5099: Dashboard level access control

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #5099: Dashboard level access control URL: https://github.com/apache/incubator-superset/pull/5099#discussion_r194570629 ## File path: superset/migrations/versions/76a4d742cf04_dashboard_role_many_to_many.py ## @@ -0,0

[GitHub] john-bodley commented on issue #4961: Deprecate database attribute allow_run_sync

2018-06-11 Thread GitBox
john-bodley commented on issue #4961: Deprecate database attribute allow_run_sync URL: https://github.com/apache/incubator-superset/pull/4961#issuecomment-396402315 Thanks for simplifying this logic. One concern is that we shouldn't augment existing migrations but simply create a new

[GitHub] williaster commented on a change in pull request #5122: Bump FAB and a bunch of JS libs

2018-06-11 Thread GitBox
williaster commented on a change in pull request #5122: Bump FAB and a bunch of JS libs URL: https://github.com/apache/incubator-superset/pull/5122#discussion_r194561637 ## File path: superset/assets/package.json ## @@ -150,13 +152,15 @@ "react-addons-test-utils":

[GitHub] codecov-io commented on issue #5174: Gantt Chart visualization

2018-06-11 Thread GitBox
codecov-io commented on issue #5174: Gantt Chart visualization URL: https://github.com/apache/incubator-superset/pull/5174#issuecomment-396386176 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5174?src=pr=h1) Report > Merging

[GitHub] boorad opened a new pull request #5174: Gantt Chart visualization

2018-06-11 Thread GitBox
boorad opened a new pull request #5174: Gantt Chart visualization URL: https://github.com/apache/incubator-superset/pull/5174 Here's my cut at a Gantt chart visualization. There are some new components in there, to map column values to styles/colors for the chart. This should be useful

[GitHub] john-bodley commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
john-bodley commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396363096 @betodealmeida/@mistercruch my concern with [Rison](https://github.com/Nanonid/rison) is possibly migrating to a system which is

[GitHub] williaster commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
williaster commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396362724 adding a third way of encoding urls seems particularly risky given our conversation from the last meetup that there are already multiple

[GitHub] graceguo-supercat commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
graceguo-supercat commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396355510 https://user-images.githubusercontent.com/27990562/4125-5863aae4-6d71-11e8-98ae-ee9665c9abcb.png;> for url in iframe, i

[GitHub] williaster commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
williaster commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396357377 Can you just elaborate on the pain points you're trying to solve with this? Is it for users or for devs? wasn't grace's PR for moving

[GitHub] graceguo-supercat commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
graceguo-supercat commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-396355510 https://user-images.githubusercontent.com/27990562/4125-5863aae4-6d71-11e8-98ae-ee9665c9abcb.png;> for url in iframe, i

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5152: Use Rison for the explore URL

2018-06-11 Thread GitBox
codecov-io commented on issue #5152: Use Rison for the explore URL URL: https://github.com/apache/incubator-superset/pull/5152#issuecomment-395258925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5152?src=pr=h1) Report > Merging

[GitHub] jasnovak opened a new issue #5173: Metrics not saved when datasource changed

2018-06-11 Thread GitBox
jasnovak opened a new issue #5173: Metrics not saved when datasource changed URL: https://github.com/apache/incubator-superset/issues/5173 Make sure these boxes are checked before submitting your issue - thank you! - [ x] I have checked the superset logs for python stacktraces and

[GitHub] jasnovak opened a new issue #5172: Filters not saved when visualization changed

2018-06-11 Thread GitBox
jasnovak opened a new issue #5172: Filters not saved when visualization changed URL: https://github.com/apache/incubator-superset/issues/5172 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and

[GitHub] michellethomas commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe

2018-06-11 Thread GitBox
michellethomas commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe URL: https://github.com/apache/incubator-superset/pull/4726#discussion_r194508236 ## File path: superset/viz.py ## @@ -170,11 +170,21 @@ def get_df(self,

[GitHub] mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe

2018-06-11 Thread GitBox
mistercrunch commented on a change in pull request #4726: [bugfix] convert metrics to numeric in dataframe URL: https://github.com/apache/incubator-superset/pull/4726#discussion_r194490570 ## File path: superset/viz.py ## @@ -170,11 +170,21 @@ def get_df(self,

[GitHub] rohanagg commented on issue #3027: Timestamp columns now displayed as epoch time

2018-06-11 Thread GitBox
rohanagg commented on issue #3027: Timestamp columns now displayed as epoch time URL: https://github.com/apache/incubator-superset/issues/3027#issuecomment-396321494 Is the issue is resolved ? This is an automated message

[GitHub] mistercrunch commented on issue #3428: Sweden added as country option

2018-06-11 Thread GitBox
mistercrunch commented on issue #3428: Sweden added as country option URL: https://github.com/apache/incubator-superset/pull/3428#issuecomment-396312591 Please fix the error described here: https://travis-ci.org/apache/incubator-superset/jobs/390361534

[GitHub] brylie commented on issue #4193: Init docker for local development environment.

2018-06-11 Thread GitBox
brylie commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396311715 Cool, I am really eager to try Superset. I have been waiting for several months for some relatively easy packaging, since the

[GitHub] williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-11 Thread GitBox
williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#discussion_r194469018 ## File path:

[GitHub] williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height

2018-06-11 Thread GitBox
williaster commented on a change in pull request #5165: [dash builder fix] combine markdown and slice name, slice picker height URL: https://github.com/apache/incubator-superset/pull/5165#discussion_r194469736 ## File path:

[GitHub] codecov-io commented on issue #5154: [bugfix] add support for numeric nodes in Sankey

2018-06-11 Thread GitBox
codecov-io commented on issue #5154: [bugfix] add support for numeric nodes in Sankey URL: https://github.com/apache/incubator-superset/pull/5154#issuecomment-396298920 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5154?src=pr=h1) Report > Merging

[GitHub] mistercrunch commented on issue #5170: Missing Metric names that were created on Superset

2018-06-11 Thread GitBox
mistercrunch commented on issue #5170: Missing Metric names that were created on Superset URL: https://github.com/apache/incubator-superset/issues/5170#issuecomment-396290220 I can't think of any piece of logic or database migration that would delete metrics.

[GitHub] mistercrunch commented on issue #5043: [Filter Box] [Bug] The filter doesn’t spread on the second level filter data

2018-06-11 Thread GitBox
mistercrunch commented on issue #5043: [Filter Box] [Bug] The filter doesn’t spread on the second level filter data URL: https://github.com/apache/incubator-superset/issues/5043#issuecomment-396289451 `multi` as well as metrics and ordering should be per-filter configuration

[GitHub] mistercrunch commented on issue #5125: Attempt at fixing migrations on some Postgres versions

2018-06-11 Thread GitBox
mistercrunch commented on issue #5125: Attempt at fixing migrations on some Postgres versions URL: https://github.com/apache/incubator-superset/pull/5125#issuecomment-396286215 The error described in the issue seems to be related to session management `current transaction is aborted,

[GitHub] john-bodley commented on issue #4631: Fix flower broker configuration

2018-06-11 Thread GitBox
john-bodley commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-396282289 @leorocheal the reason the documentation suggests using the sql_lab over cli is the cli one is an import from sql_lab and solely exists

[GitHub] AnupKumarSaha opened a new issue #5171: World map is not working for me ....

2018-06-11 Thread GitBox
AnupKumarSaha opened a new issue #5171: World map is not working for me URL: https://github.com/apache/incubator-superset/issues/5171 Traceback (most recent call last): File "/usr/local/lib/python3.5/site-packages/superset/viz.py", line 329, in get_df_payload df =

[GitHub] leorochael commented on issue #4631: Fix flower broker configuration

2018-06-11 Thread GitBox
leorochael commented on issue #4631: Fix flower broker configuration URL: https://github.com/apache/incubator-superset/pull/4631#issuecomment-396261329 Ok so, #4451 is merged deprecating the `superset flower` command, but in it's place it recommends: celery flower

[GitHub] xzGithu closed issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function

2018-06-11 Thread GitBox
xzGithu closed issue #5142: when try the Sankey visualization --An error occurred while rendering the visualization: TypeError: n.replace is not a function URL: https://github.com/apache/incubator-superset/issues/5142 This

[GitHub] brylie commented on issue #4193: Init docker for local development environment.

2018-06-11 Thread GitBox
brylie commented on issue #4193: Init docker for local development environment. URL: https://github.com/apache/incubator-superset/pull/4193#issuecomment-396151873 When I try to run this via `docker-compose up`, I get the following error: ``` Pulling superset