[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680562 ## File path: superset/assets/src/dashboard/reducers/dashboardState.js ## @@ -14,13 +14,13 @@ import {

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680390 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -138,15 +112,15 @@ class SaveModal

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680285 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -138,15 +112,15 @@ class SaveModal

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680138 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -59,37 +64,7 @@ class SaveModal

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680024 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -161,44 +197,63 @@ class Header extends

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189679922 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -1,36 +1,40 @@ /* eslint-env browser

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189679344 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -1,12 +1,18 @@ +/* eslint-env browser */

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187451398 ## File path: superset/assets/src/dashboard/stylesheets/dashboard.less ## @@ -38,6 +38,22 @@ } }

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187449295 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -88,6 +100,36 @@ class Header extends

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187451281 ## File path: superset/assets/src/dashboard/stylesheets/dashboard.less ## @@ -38,6 +38,22 @@ } }

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187451493 ## File path: superset/assets/src/dashboard/stylesheets/dashboard.less ## @@ -38,6 +38,22 @@ } }

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187449702 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -88,6 +100,36 @@ class Header extends

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r187451651 ## File path: superset/assets/src/dashboard/stylesheets/dashboard.less ## @@ -63,7 +79,7 @@ padding: 0 16px;