[GitHub] yamyamyuo closed issue #5002: superset presto database support editing `X-Presto-Source`

2018-05-17 Thread GitBox
yamyamyuo closed issue #5002: superset presto database support editing `X-Presto-Source` URL: https://github.com/apache/incubator-superset/issues/5002 This is an automated message from the Apache Git Service. To respond to

[GitHub] codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError

2018-05-17 Thread GitBox
codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError

2018-05-17 Thread GitBox
codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report > Merging

[GitHub] zhaoyongjie commented on issue #5026: Fix percent_metrics ZeroDivisionError

2018-05-17 Thread GitBox
zhaoyongjie commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390079873 @michellethomas According to your suggestion, I made a change. if there's a divsion by 0, return None.

[GitHub] JulieRossi closed issue #5006: ImportError: No module named 'flask.exthook'

2018-05-17 Thread GitBox
JulieRossi closed issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()

2018-05-17 Thread GitBox
hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE() URL: https://github.com/apache/incubator-superset/issues/4857#issuecomment-387708899 Not fixed in 0.25.4 release with SQLalchemy 1.2.2

[GitHub] tianlinzx opened a new issue #5024: feature request: keycloak support

2018-05-17 Thread GitBox
tianlinzx opened a new issue #5024: feature request: keycloak support URL: https://github.com/apache/incubator-superset/issues/5024 feature request: keycloak support - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-17 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389813616 @TianyangLi How to check this? And more important, how to solve it?

[GitHub] zhaoyongjie commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz

2018-05-17 Thread GitBox
zhaoyongjie commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz URL: https://github.com/apache/incubator-superset/issues/4931#issuecomment-389818436 +1 This is an automated message from the

[GitHub] JulieRossi commented on issue #5006: ImportError: No module named 'flask.exthook'

2018-05-17 Thread GitBox
JulieRossi commented on issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006#issuecomment-389783573 Thanks !! This is an automated message from the Apache

[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-17 Thread GitBox
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389809339 @miloradkrstevski Are you sure you're in the right virtual venv? have you deployed your venv in a python3

[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-17 Thread GitBox
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389809339 @miloradkrstevski Are you sure you're in the right virtual venv? have you deployed your venv in a python3

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-17 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389804470 @mistercrunch Can you please reopen the issue so someone could help me? Anyone any solution: @xrmx ,

[GitHub] alexjacquot commented on issue #1901: Bypassing the login for Supreset iframe in Webpage

2018-05-17 Thread GitBox
alexjacquot commented on issue #1901: Bypassing the login for Supreset iframe in Webpage URL: https://github.com/apache/incubator-superset/issues/1901#issuecomment-389855859 Any news on this ? This is an automated message

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-17 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389824942 Thank you very much @TianyangLi. That was the problem. I install all in python3, pip3, and venv is correct

[GitHub] alexjacquot commented on issue #2488: How to authenticate with REST API

2018-05-17 Thread GitBox
alexjacquot commented on issue #2488: How to authenticate with REST API URL: https://github.com/apache/incubator-superset/issues/2488#issuecomment-389877666 Is there a documentation of the rest api ? This is an automated

[GitHub] neilsoncarlos commented on issue #3729: Added multi-tenancy support.

2018-05-17 Thread GitBox
neilsoncarlos commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-389882062 this was built on top of a deprecated endpoint (update_role). https://github.com/apache/incubator-superset/pull/4041 See the commit

[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'

2018-05-17 Thread GitBox
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389893609 > I think this fixes it #4914 the bug in pivot table have not been fixed in #4914 the viz still not work, so I

[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'

2018-05-17 Thread GitBox
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389892505 > I think this fixes it #4914 the bug in pivot have not been fixed in #4914,so I put a new PR @mistercrunch @xrmx

[GitHub] zhaoyongjie opened a new pull request #5026: Fix percent_metrics ZeroDivisionError

2018-05-17 Thread GitBox
zhaoyongjie opened a new pull request #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026 Fix percent_metrics ZeroDivisionError and can not get metrics with label issue

[GitHub] gangh opened a new pull request #5025: [bugfix]fix metrics type error in pivot table viz

2018-05-17 Thread GitBox
gangh opened a new pull request #5025: [bugfix]fix metrics type error in pivot table viz URL: https://github.com/apache/incubator-superset/pull/5025 to fix this bug in pivot table viz @xrmx @mistercrunch https://github.com/apache/incubator-superset/issues/4984 - transfer

[GitHub] thakur00mayank commented on issue #3729: Added multi-tenancy support.

2018-05-17 Thread GitBox
thakur00mayank commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-389885637 Thanks, @neilsoncarlos for pointing out the new changes. I will soon do the required changes. and update the pull request.

[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'

2018-05-17 Thread GitBox
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389892505 > I think this fixes it #4914 the bug in pivot have not been fixed in #4914,so I put a new PR @mistercrunch @xrmx

[GitHub] ladys1728 commented on issue #4317: [SLICE][RIGHT ISSUE] Problems with restricted rights role

2018-05-17 Thread GitBox
ladys1728 commented on issue #4317: [SLICE][RIGHT ISSUE] Problems with restricted rights role URL: https://github.com/apache/incubator-superset/issues/4317#issuecomment-389917508 Hi yoyos26, I have exactly the same problem. Have you fixed your issue? Regards,

[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389933718 Can we change the error message to something like "The data source associated with this chart no longer exists"? Also,

[GitHub] abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF

2018-05-17 Thread GitBox
abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043405 ## File path: superset/sql_lab.py ## @@ -171,6 +171,7 @@ def

[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-17 Thread GitBox
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389936762 All examples get executed as integration test, so if you add a new example chart that cover this use

[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3

2018-05-17 Thread GitBox
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389931667 Seems like a data engineering / data preparation would be best in this case. You'd ETL your user conf

[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189029978 ## File path: superset/sql_lab.py ## @@ -185,7 +186,8 @@ def

[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189029182 ## File path: superset/sql_lab.py ## @@ -171,6 +171,7 @@ def

[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389934250 About cascading, I think that would be the desired behavior as long as there's clarity on what is happening. There should be a

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043307 ## File path: superset/sql_lab.py ## @@ -185,7 +186,8 @@ def

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all dependent slices before

[GitHub] codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-17 Thread GitBox
codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390067823 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=h1)

[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189075550 ## File path: superset/utils.py ## @@ -841,3 +841,17 @@ def

[GitHub] mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2'

2018-05-17 Thread GitBox
mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389988449 Fixed in `0.25.5` release This is an

[GitHub] abowden-spotx opened a new pull request #5029: [WiP] email subscriptions

2018-05-17 Thread GitBox
abowden-spotx opened a new pull request #5029: [WiP] email subscriptions URL: https://github.com/apache/incubator-superset/pull/5029 Building email subscription service. Will store subscription related data in superset.db and will run on Airflow. To get it up and running will use

[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-17 Thread GitBox
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user is not the owner of a dashboard, we used to allow user `save-as` a new

[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-17 Thread GitBox
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user is not the owner of a dashboard, we used to allow user `save-as` a new

[GitHub] mistercrunch commented on issue #4921: [bufix] filtered column was removed

2018-05-17 Thread GitBox
mistercrunch commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-389983851 Yes there should be a validator on the `FiltersControl` that would raise a flag and prevent the query from running.

[GitHub] mistercrunch closed issue #5004: db upgrade importError:No module named 'contextlib2'

2018-05-17 Thread GitBox
mistercrunch closed issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004 This is an automated message from the Apache Git Service. To respond to

[GitHub] john-bodley commented on issue #5027: Add missing dep on contextlib2

2018-05-17 Thread GitBox
john-bodley commented on issue #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027#issuecomment-390031606 @mistercrunch that's a good suggestion. I can try looking into a CI check which ensures these files are consistent.

[GitHub] mistercrunch opened a new pull request #5027: Add missing dep on contextlib2

2018-05-17 Thread GitBox
mistercrunch opened a new pull request #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027 @john-bodley community contributed https://github.com/apache/incubator-superset/pull/4927 added dep in `requirements.txt` but not in `setup.py` causing

[GitHub] john-bodley opened a new pull request #5028: [druid] Fixing Druid version check

2018-05-17 Thread GitBox
john-bodley opened a new pull request #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028 While investigation another issue with @GabeLoins we realized that the Druid version check was invalid, i.e., per the comment on line #626 this issue

[GitHub] codecov-io commented on issue #5028: [druid] Fixing Druid version check

2018-05-17 Thread GitBox
codecov-io commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-390011234 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5028: [druid] Fixing Druid version check

2018-05-17 Thread GitBox
codecov-io commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-390011234 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5027: Add missing dep on contextlib2

2018-05-17 Thread GitBox
codecov-io commented on issue #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027#issuecomment-389990658 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=h1) Report > Merging

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @john-bodley @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1.

[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all other dependent slices

[GitHub] michellethomas commented on issue #4897: Heatmap improvements

2018-05-17 Thread GitBox
michellethomas commented on issue #4897: Heatmap improvements URL: https://github.com/apache/incubator-superset/pull/4897#issuecomment-390059989 hey @mistercrunch it looks like this causes an issue with heatmaps that use `Value Bounds` with normalized turned off. The legend seems to

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189134922 ## File path: superset/utils.py ## @@ -841,3 +841,17 @@ def

[GitHub] john-bodley commented on a change in pull request #5019: fix missing datasource error message

2018-05-17 Thread GitBox
john-bodley commented on a change in pull request #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#discussion_r189138119 ## File path: superset/views/core.py ## @@ -1229,6 +1229,12 @@ def

[GitHub] codecov-io commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
codecov-io commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389645443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=h1) Report > Merging

[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-17 Thread GitBox
GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032 Previously to this PR, when adding/viewing a simple filter with number of comparators this could