Re: [PR] build(deps): bump dompurify from 2.4.9 to 3.0.11 in /superset-frontend/plugins/legacy-preset-chart-nvd3 [superset]

2024-04-02 Thread via GitHub
rusackas merged PR #27816: URL: https://github.com/apache/superset/pull/27816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]

2024-04-02 Thread via GitHub
geido commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-2031171927 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] refactor: add "button" role to clickable UI elements for improved accessibility [superset]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #26602: URL: https://github.com/apache/superset/pull/26602#issuecomment-2031185277 @geido Ephemeral environment spinning up at http://34.218.74.195:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup. --

Re: [PR] feat(db): Adding DB_ENGINE_URI_VALIDATOR [superset]

2024-04-02 Thread via GitHub
dpgaspar commented on code in PR #27847: URL: https://github.com/apache/superset/pull/27847#discussion_r1547514948 ## superset/config.py: ## @@ -1206,6 +1206,17 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( # pylint: disable=invalid-name DB_CONNECTION_MUTATOR = None +# A

[PR] feat(reports): allowing the email mutator to update recipients [superset]

2024-04-02 Thread via GitHub
SkinnyPigeon opened a new pull request, #27851: URL: https://github.com/apache/superset/pull/27851 ### SUMMARY We use the `EMAIL_HEADER_MUTATOR` to detect errors in reports sent to our external clients. Currently, when an error is detected we send an alert to an internal Slack

Re: [I] auto-refresh not working in standalone mode [superset]

2024-04-02 Thread via GitHub
Stefan781 commented on issue #25970: URL: https://github.com/apache/superset/issues/25970#issuecomment-2031345359 > Hi! > > I found half-solution. With standalone=1 autorefresh is working. We use that query params `=1_filters=0_filters=0"`. And add css, in dashboard level, to hide

Re: [I] auto-refresh not working in standalone mode [superset]

2024-04-02 Thread via GitHub
gilazat commented on issue #25970: URL: https://github.com/apache/superset/issues/25970#issuecomment-2031233211 I have the same problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] auto-refresh not working in standalone mode [superset]

2024-04-02 Thread via GitHub
andrejs82git commented on issue #25970: URL: https://github.com/apache/superset/issues/25970#issuecomment-2031291187 Hi! I found half-solution. With standalone=1 autorefresh is working. We use that query params `=1_filters=0_filters=0"`. And add css, in dashboard level, to

Re: [PR] fix: alembic's 'superset db migrate' fails with CompileError [superset]

2024-04-02 Thread via GitHub
dpgaspar commented on code in PR #27846: URL: https://github.com/apache/superset/pull/27846#discussion_r1547547335 ## superset/connectors/sqla/models.py: ## @@ -2055,7 +2055,10 @@ class RowLevelSecurityFilter(Model, AuditMixinNullable): name = Column(String(255),

Re: [PR] Fix/remove hardcode of admin role [superset]

2024-04-02 Thread via GitHub
Always-prog commented on code in PR #27779: URL: https://github.com/apache/superset/pull/27779#discussion_r1547782190 ## superset/config.py: ## @@ -314,8 +314,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | None: # AUTH_REMOTE_USER : Is for using REMOTE_USER

Re: [PR] fix: alembic's 'superset db migrate' fails with CompileError [superset]

2024-04-02 Thread via GitHub
mistercrunch merged PR #27846: URL: https://github.com/apache/superset/pull/27846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] test: 4.0 test environment - DO NOT MERGE [superset]

2024-04-02 Thread via GitHub
michael-s-molina commented on PR #27174: URL: https://github.com/apache/superset/pull/27174#issuecomment-203118 /testenv up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] test: 4.0 test environment - DO NOT MERGE [superset]

2024-04-02 Thread via GitHub
michael-s-molina commented on PR #27174: URL: https://github.com/apache/superset/pull/27174#issuecomment-2032539444 /testenv FEATURE_ALERT_REPORTS=True FEATURE_TAGGING_SYSTEM=True -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] test: 4.0 test environment - DO NOT MERGE [superset]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #27174: URL: https://github.com/apache/superset/pull/27174#issuecomment-2032569164 @michael-s-molina Ephemeral environment spinning up at http://18.246.209.142:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [PR] feat(viz picker): Remove some tags, refactor Recommended section [superset]

2024-04-02 Thread via GitHub
kasiazjc commented on PR #27708: URL: https://github.com/apache/superset/pull/27708#issuecomment-2032313541 > > My only non-blocking comment would be to replace the Featured icon with a ⭐ > > @yousoph @kasiazjc wdyt? @michael-s-molina also thought about ⭐️ at first, but we

Re: [PR] docs: small cleanup [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27791: URL: https://github.com/apache/superset/pull/27791#issuecomment-2032349741 `pre-commit` seems to be complaining. You might want to try `pre-commit run --all-files` also `pre-commit install` might prevent this and save some cycles. -- This is an

Re: [I] [SIP-120] Enhanced Time Comparisons on Bar and Line Charts [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27617: URL: https://github.com/apache/superset/issues/27617#issuecomment-2032450371 +1 on bifurcating the discussion into two topics: configuration and display. It would be ideal to have the controls/config be a consistent interface between all plugins that use

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1548161070 ## superset/db_engine_specs/README.md: ## @@ -542,6 +543,70 @@ The method `get_url_for_impersonation` updates the SQLAlchemy URI before every q

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-04-02 Thread via GitHub
betodealmeida commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1548180924 ## superset/db_engine_specs/README.md: ## @@ -542,6 +543,70 @@ The method `get_url_for_impersonation` updates the SQLAlchemy URI before every q

Re: [PR] fix: alembic's 'superset db migrate' fails with CompileError [superset]

2024-04-02 Thread via GitHub
john-bodley commented on PR #27846: URL: https://github.com/apache/superset/pull/27846#issuecomment-2032506995 @mistercrunch why is this an issue with Docker but not with global CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat(db): Adding DB_SQLA_URI_VALIDATOR [superset]

2024-04-02 Thread via GitHub
john-bodley commented on PR #27847: URL: https://github.com/apache/superset/pull/27847#issuecomment-2032510731 @craig-rueda out of interest why is this surfacing as an issue now? Did we not gracefully handle SQLAlchemy URI errors in the past? -- This is an automated message from the

Re: [PR] test: 4.0 test environment - DO NOT MERGE [superset]

2024-04-02 Thread via GitHub
michael-s-molina commented on PR #27174: URL: https://github.com/apache/superset/pull/27174#issuecomment-2032544587 /testenv up FEATURE_ALERT_REPORTS=True FEATURE_TAGGING_SYSTEM=True -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] chore: Bump to Python3.10 [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #24112: URL: https://github.com/apache/superset/pull/24112#issuecomment-2032568608 UPDATE YOUR VENVs EVERYONE! :) ![giphy](https://github.com/apache/superset/assets/487433/b1bfb87f-6c1f-408c-b709-bfa302317b41) Or just use docker-compose for your

Re: [PR] feat(viz picker): Remove some tags, refactor Recommended section [superset]

2024-04-02 Thread via GitHub
kgabryje commented on PR #27708: URL: https://github.com/apache/superset/pull/27708#issuecomment-2032341352 The first one looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat(SIP-85): OAuth2 for databases [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on code in PR #27631: URL: https://github.com/apache/superset/pull/27631#discussion_r1548140505 ## superset/utils/oauth2.py: ## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] feat(db): Adding DB_SQLA_URI_VALIDATOR [superset]

2024-04-02 Thread via GitHub
craig-rueda merged PR #27847: URL: https://github.com/apache/superset/pull/27847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(viz picker): Remove some tags, refactor Recommended section [superset]

2024-04-02 Thread via GitHub
michael-s-molina commented on PR #27708: URL: https://github.com/apache/superset/pull/27708#issuecomment-2032504984 @kasiazjc The first one works. There's also: https://github.com/apache/superset/assets/70410625/41b0782d-6be9-437f-b3fa-bf16603293dc;>

Re: [PR] fix(dashboard): missing null check in error extra [superset]

2024-04-02 Thread via GitHub
justinpark merged PR #27845: URL: https://github.com/apache/superset/pull/27845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(reports): allowing the email mutator to update recipients [superset]

2024-04-02 Thread via GitHub
john-bodley commented on code in PR #27851: URL: https://github.com/apache/superset/pull/27851#discussion_r1548198947 ## superset/utils/core.py: ## @@ -902,6 +902,8 @@ def send_email_smtp( # pylint: disable=invalid-name,too-many-arguments,too-many msg_mutator =

Re: [PR] chore: Bump to Python3.10 [superset]

2024-04-02 Thread via GitHub
mistercrunch merged PR #24112: URL: https://github.com/apache/superset/pull/24112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore: Move fetchTimeRange to core package [superset]

2024-04-02 Thread via GitHub
kgabryje opened a new pull request, #27852: URL: https://github.com/apache/superset/pull/27852 ### SUMMARY Move `fetchTimeRange` function and all its dependencies to `superset-ui/core` to make it reusable in components defined in `core` and `chart-controls` packages. Also, sync

Re: [PR] build(deps): bump actions/github-script from 5 to 7 [superset]

2024-04-02 Thread via GitHub
mistercrunch merged PR #27802: URL: https://github.com/apache/superset/pull/27802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[I] Sqllab stuck executing a query [superset]

2024-04-02 Thread via GitHub
aavanzyl opened a new issue, #27850: URL: https://github.com/apache/superset/issues/27850 ### Bug description When using SQL Lab to execute a query such as `SELECT * from claims.claim limit 1`, the UI shows `Pending` and never starts increasing the execution time. The

Re: [PR] fix: set columns numeric datatypes when exporting to excel [superset]

2024-04-02 Thread via GitHub
squalou commented on PR #27229: URL: https://github.com/apache/superset/pull/27229#issuecomment-2031479036 should I try a rebase or is it useless ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Unable to use Group by with multiple entries with TIME-SERIES TABLE [superset]

2024-04-02 Thread via GitHub
Aset-21 commented on issue #12066: URL: https://github.com/apache/superset/issues/12066#issuecomment-2031501712 It would be cool to fix this error in the time-series table chart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Bar chart does not emit cross-filter if dimension is not set [superset]

2024-04-02 Thread via GitHub
sfirke commented on issue #25334: URL: https://github.com/apache/superset/issues/25334#issuecomment-2032093778 I think the ideal fix would be: bar charts without dimension emit cross-filters as if the series was a dimension. That seems to be the behavior people expect. I have no idea how

[PR] [DO NOT MERGE] DEMO fix(time_comparison):Use Join queries when using time comparison [superset]

2024-04-02 Thread via GitHub
Antonio-RiveroMartnez opened a new pull request, #27853: URL: https://github.com/apache/superset/pull/27853 ### SUMMARY To facilitate the discussion related our experimental feature for time comparison, we're extracting out form [the original

Re: [PR] test: 4.0 test environment - DO NOT MERGE [superset]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #27174: URL: https://github.com/apache/superset/pull/27174#issuecomment-2031913998 @michael-s-molina Ephemeral environment spinning up at http://34.222.38.113:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [PR] feat(viz picker): Remove some tags, refactor Recommended section [superset]

2024-04-02 Thread via GitHub
kasiazjc commented on PR #27708: URL: https://github.com/apache/superset/pull/27708#issuecomment-2032695811 > @kasiazjc The first one works. There's also: > >

[PR] fix: pkg-config dependency in Dockerfile [superset]

2024-04-02 Thread via GitHub
mistercrunch opened a new pull request, #27855: URL: https://github.com/apache/superset/pull/27855 ### SUMMARY Trying to take over https://github.com/apache/superset/pull/27841 as CI is glitching as we altered the matrix / required checks in another

Re: [I] Can't connect to Oracle DB [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #20371: URL: https://github.com/apache/superset/issues/20371#issuecomment-2032877359 it seems `cx_oracle` has been moved and renamed to `python-oracledb` - has anyone tried this to make sure it works? If it does, someone should probably update the

Re: [PR] fix: corrects some inaccuracies zh translation [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27794: URL: https://github.com/apache/superset/pull/27794#issuecomment-2032893200 @zhaoyongjie would you be able to make sure the translations are all accurate? Seems fine to me otherwise. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27835: URL: https://github.com/apache/superset/pull/27835#issuecomment-2032946920 @mistercrunch I'm still stumped why the actions don't have permissions to push to the branch. Curious if you have any theories. -- This is an automated message from the Apache Git

Re: [PR] feat(reports): allowing the email mutator to update recipients [superset]

2024-04-02 Thread via GitHub
SkinnyPigeon commented on code in PR #27851: URL: https://github.com/apache/superset/pull/27851#discussion_r1548502540 ## superset/utils/core.py: ## @@ -902,6 +902,8 @@ def send_email_smtp( # pylint: disable=invalid-name,too-many-arguments,too-many msg_mutator =

Re: [PR] fix(maps): Rename Ukrainian City to Ukrainian format and deccomunization [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27415: URL: https://github.com/apache/superset/pull/27415#issuecomment-2032594644 One bit of technical feedback here: This geojson will be overwritten whenever anyone runs the Jupyter Notebook, and pulls new data from Natural Earth. So if you want to make changes

Re: [PR] feat: [SIP-114] [WIP] Google Sheets Export [superset]

2024-04-02 Thread via GitHub
eschutho commented on code in PR #26391: URL: https://github.com/apache/superset/pull/26391#discussion_r1548305032 ## superset/sqllab/api.py: ## @@ -236,6 +240,7 @@ def format_sql(self) -> FlaskResponse: return self.response_400(message=error.messages)

Re: [PR] feat(plugin): color option for table with time comparison [superset]

2024-04-02 Thread via GitHub
Antonio-RiveroMartnez commented on code in PR #27716: URL: https://github.com/apache/superset/pull/27716#discussion_r1548463091 ## superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx: ## @@ -520,41 +598,41 @@ const config: ControlPanelConfig = { ],

Re: [PR] docs: small cleanup [superset]

2024-04-02 Thread via GitHub
rusackas commented on code in PR #27791: URL: https://github.com/apache/superset/pull/27791#discussion_r1548478514 ## docs/docs/installation/installing-superset-using-docker-compose.mdx: ## @@ -10,8 +10,8 @@ version: 1 **DO NOT USE THIS FOR PRODUCTION!** The fastest way to

Re: [PR] fix: pkg-config dependency in Dockerfile [superset]

2024-04-02 Thread via GitHub
mistercrunch closed pull request #27855: fix: pkg-config dependency in Dockerfile URL: https://github.com/apache/superset/pull/27855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore: Fix/remove hardcode of admin role [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27779: URL: https://github.com/apache/superset/pull/27779#issuecomment-2032909342 > @supersetbot orglabel > How I can add orglabel?) @mistercrunch can probably help. Not sure if there's documentation for all this somewhere... we should probably add a

Re: [PR] fix: row limits & row count labels are confusing [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27700: URL: https://github.com/apache/superset/pull/27700#issuecomment-2032941233 Yeah I wasn't sure either and there was not clear pattern established for me to follow. Looked that the person who wrote the code before went out of their way to go flat-case

Re: [PR] fix: alembic's 'superset db migrate' fails with CompileError [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27846: URL: https://github.com/apache/superset/pull/27846#issuecomment-2032726520 @john-bodley this is an issue with `superset db migrate` (not `superset db upgrade`) which auto-creates new migration. AFAIK this is done manually when there's a need to create

Re: [I] Can't connect to Oracle DB [superset]

2024-04-02 Thread via GitHub
mayasirode commented on issue #20371: URL: https://github.com/apache/superset/issues/20371#issuecomment-2032827022 i had the same issue connecting a docker based superset to a oracle database. with [this](https://github.com/shantanukhond/YT-Assets/tree/main/Superset/installation)

Re: [PR] build(deps): bump @algolia/client-search from 4.22.1 to 4.23.2 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27824: URL: https://github.com/apache/superset/pull/27824#issuecomment-2032972322 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat(plugin): color option for table with time comparison [superset]

2024-04-02 Thread via GitHub
lilykuang merged PR #27716: URL: https://github.com/apache/superset/pull/27716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] feat(dashboard): Add metadata bar to the header [superset]

2024-04-02 Thread via GitHub
justinpark opened a new pull request, #27857: URL: https://github.com/apache/superset/pull/27857 ### SUMMARY As the dashboard currently lacks metadata information such as owners and last modified time, users have to navigate to edit mode and click "edit properties" to access this

Re: [PR] build: fixed pkg-config dependency in Dockerfile [superset]

2024-04-02 Thread via GitHub
mistercrunch closed pull request #27841: build: fixed pkg-config dependency in Dockerfile URL: https://github.com/apache/superset/pull/27841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] build(deps-dev): bump @tsconfig/docusaurus from 2.0.2 to 2.0.3 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27823: URL: https://github.com/apache/superset/pull/27823#issuecomment-2033113358 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] build(deps-dev): bump @tsconfig/docusaurus from 2.0.2 to 2.0.3 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas merged PR #27823: URL: https://github.com/apache/superset/pull/27823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: make supersetbot do what dependabot should do [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27647: URL: https://github.com/apache/superset/pull/27647#issuecomment-2033140495 I decided to move the bot out of this repo and onto here -> https://github.com/apache-superset/supersetbot -- This is an automated message from the Apache Git Service. To

Re: [PR] build(deps-dev): bump react-test-renderer from 16.9.0 to 16.14.0 in /superset-frontend [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27808: URL: https://github.com/apache/superset/pull/27808#issuecomment-2033140272 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore: Provide more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
john-bodley commented on code in PR #27858: URL: https://github.com/apache/superset/pull/27858#discussion_r1548658251 ## superset/sql_parse.py: ## @@ -752,11 +752,21 @@ def _extract_tables_from_sql(self) -> set[Table]: statements = parse(self.stripped(),

Re: [I] Error on embedded dashboard after upgrading to 3.1.1: "Guest user cannot modify chart payload" [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27177: URL: https://github.com/apache/superset/issues/27177#issuecomment-2033191603 > Downgrading to 3.1.0 worked for me as well. Waiting for 3.2.0 or 3.1.2 to be released. Do we have any dates on that?  3.1.2 is up for testing/voting now (as is 4.0,

Re: [I] [SIP] Proposal replacement of data table components with ag-grid [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27645: URL: https://github.com/apache/superset/issues/27645#issuecomment-2033196143 I've sent an email to the AG Grid team just to confirm that there won't be any licensing/EULA issues to contend with in our project, which might be used for commercial or

Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #24263: URL: https://github.com/apache/superset/pull/24263#issuecomment-2033216389 Running CI. Fingers crossed! 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] chore(node): bumping Superset to Node 18 [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27198: URL: https://github.com/apache/superset/pull/27198#issuecomment-2033229374 ![cleaning](https://github.com/apache/superset/assets/487433/47e72c26-cb15-4cc1-9a8f-91fa65d9cc61) -- This is an automated message from the Apache Git Service. To respond

Re: [I] Snowflake connection is not working [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27703: URL: https://github.com/apache/superset/issues/27703#issuecomment-2033267280 CC @sadpandajoe @john-bodley who might know more about the current state of the `cryptography` bump saga. -- This is an automated message from the Apache Git Service. To

Re: [PR] chore: Provide a more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
john-bodley commented on PR #27858: URL: https://github.com/apache/superset/pull/27858#issuecomment-2033268240 @mistercrunch that was the other option I considered and had discussed internally, i.e., the error being somewhat context aware. Rather than `SQLGlot`'s error being wrapped in a

Re: [PR] fix: pkg-config dependency in Dockerfile [superset]

2024-04-02 Thread via GitHub
mistercrunch merged PR #27855: URL: https://github.com/apache/superset/pull/27855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: row limits & row count labels are confusing [superset]

2024-04-02 Thread via GitHub
mistercrunch merged PR #27700: URL: https://github.com/apache/superset/pull/27700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: row limits & row count labels are confusing [superset]

2024-04-02 Thread via GitHub
github-actions[bot] commented on PR #27700: URL: https://github.com/apache/superset/pull/27700#issuecomment-2033088866 Ephemeral environment shutdown and build artifacts deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] build(deps): bump @ant-design/icons from 5.3.1 to 5.3.6 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27819: URL: https://github.com/apache/superset/pull/27819#issuecomment-2033141873 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] chore(node): bumping Superset to Node 18 [superset]

2024-04-02 Thread via GitHub
rusackas commented on code in PR #27198: URL: https://github.com/apache/superset/pull/27198#discussion_r1548648097 ## .github/workflows/tech-debt.yml: ## @@ -32,7 +32,8 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: -

Re: [PR] chore(node): bumping Superset to Node 18 [superset]

2024-04-02 Thread via GitHub
rusackas commented on code in PR #27198: URL: https://github.com/apache/superset/pull/27198#discussion_r1548647354 ## .github/workflows/tech-debt.yml: ## @@ -32,8 +32,8 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: -

Re: [I] Pivot Table show columns total question [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #23560: URL: https://github.com/apache/superset/issues/23560#issuecomment-2033161466 I'm not sure if @ETselikov is planning to contribute this or not, but surely it would be a much-welcomed PR :) -- This is an automated message from the Apache Git Service. To

Re: [PR] chore: Provide a more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
john-bodley commented on code in PR #27858: URL: https://github.com/apache/superset/pull/27858#discussion_r1548680139 ## superset/sql_parse.py: ## @@ -752,11 +752,21 @@ def _extract_tables_from_sql(self) -> set[Table]: statements = parse(self.stripped(),

Re: [PR] build(deps-dev): bump @docusaurus/module-type-aliases from 3.1.1 to 3.2.0 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas merged PR #27818: URL: https://github.com/apache/superset/pull/27818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore: Provide a more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
john-bodley commented on code in PR #27858: URL: https://github.com/apache/superset/pull/27858#discussion_r1548658251 ## superset/sql_parse.py: ## @@ -752,11 +752,21 @@ def _extract_tables_from_sql(self) -> set[Table]: statements = parse(self.stripped(),

[PR] feat: setup a pyproject.toml [superset]

2024-04-02 Thread via GitHub
mistercrunch opened a new pull request, #27859: URL: https://github.com/apache/superset/pull/27859 Decomposing a previous PR into smaller parts. Using a pyproject.toml will enable us to use `supersetbot` to replace dependabot in managing/bumping our python libraries. The fact that

Re: [PR] build(deps-dev): bump typescript from 5.3.3 to 5.4.3 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas merged PR #27814: URL: https://github.com/apache/superset/pull/27814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: move supersetbot out of repo [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27647: URL: https://github.com/apache/superset/pull/27647#issuecomment-2033221502 Just curious, is this out of necessity, or just easier to work on it? It might be nice to move it back into Superset/ASF control once the dust settles if it's just to make it easier

Re: [I] mapbox does not load datapoints [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27562: URL: https://github.com/apache/superset/issues/27562#issuecomment-2033225172 @Vitor-Avila @yousoph do you know if we've heard complaints of this? Curious if @michael-s-molina @justinpark have run into this as well. Seems like we'd hear more outcry about

Re: [PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-02 Thread via GitHub
mistercrunch closed pull request #27835: build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table URL: https://github.com/apache/superset/pull/27835 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-02 Thread via GitHub
dependabot[bot] commented on PR #27835: URL: https://github.com/apache/superset/pull/27835#issuecomment-2033253734 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27835: URL: https://github.com/apache/superset/pull/27835#issuecomment-2033258110 > @mistercrunch I'm still stumped why the actions don't have permissions to push to the branch. Curious if you have any theories Do you mean this? -> looks ok to me.

Re: [PR] build(deps): update xss requirement from ^1.0.14 to ^1.0.15 in /superset-frontend/plugins/plugin-chart-table [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27835: URL: https://github.com/apache/superset/pull/27835#issuecomment-2033262448 It seems for some reason like the action can't push the commit until one of us humanoids commits or force-pushes the thing. Previously I was pulling the branch, doing `npm

Re: [PR] refactor: Move fetchTimeRange to core package [superset]

2024-04-02 Thread via GitHub
eschutho commented on code in PR #27852: URL: https://github.com/apache/superset/pull/27852#discussion_r1548732061 ## superset-frontend/packages/superset-ui-core/test/tsconfig.json: ## @@ -1,9 +1,9 @@ { "compilerOptions": { -"composite": false, -

Re: [I] No option to download a pivoted CSV from dashboard view for a pivot table chart [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #26142: URL: https://github.com/apache/superset/issues/26142#issuecomment-2033273944 Nope... it's come up on a few other Issues, so we should consolidate those. We might also consider moving this to a Discussion since it's more of a feature request than a bug

Re: [PR] build(deps-dev): bump @tsconfig/docusaurus from 2.0.2 to 2.0.3 in /docs [superset]

2024-04-02 Thread via GitHub
rusackas commented on PR #27823: URL: https://github.com/apache/superset/pull/27823#issuecomment-2032994884 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] build: fixed pkg-config dependency in Dockerfile [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27841: URL: https://github.com/apache/superset/pull/27841#issuecomment-2033091296 Fixed CI and merged this PR -> https://github.com/apache/superset/pull/27855, thank you for contributing the solution -- This is an automated message from the Apache Git

Re: [I] Pivot Table show columns total question [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #23560: URL: https://github.com/apache/superset/issues/23560#issuecomment-2033162620 ...or @TechAuditBI for that matter... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] chore: Provide more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
john-bodley opened a new pull request, #27858: URL: https://github.com/apache/superset/pull/27858 ### SUMMARY https://github.com/apache/superset/pull/26767 replaced the non-validating `sqlparse` parser with the pseudo-validating `SQLGlot` parser to aid with SQL parsing. The

Re: [I] Some permission on Dashboard seem unnecessary because they are associated with essential functions [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27767: URL: https://github.com/apache/superset/issues/27767#issuecomment-2033218467 I think @yousoph and others were looking into revamping/documenting some groups of permissions, so this may come into play with that effort. -- This is an automated message

Re: [PR] feat: setup a pyproject.toml [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on code in PR #27859: URL: https://github.com/apache/superset/pull/27859#discussion_r1548702503 ## requirements/development.in: ## @@ -17,26 +17,4 @@ # under the License. # -r base.in --e

Re: [I] Not accepting `*` in a database account password [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #27764: URL: https://github.com/apache/superset/issues/27764#issuecomment-2033219660 Pinging @dpgaspar @betodealmeida in case there's good reason for not accepting that particular character. -- This is an automated message from the Apache Git Service. To

Re: [PR] feat: move supersetbot out of repo [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27647: URL: https://github.com/apache/superset/pull/27647#issuecomment-2033223776 Yes the main reason is it doesn't require the same level of scrutiny and rigor as the main repo, and it can have it's own CI/release cycles/tests, . -- This is an automated

Re: [PR] chore: Provide a more meaningful SQLGlot error [superset]

2024-04-02 Thread via GitHub
mistercrunch commented on PR #27858: URL: https://github.com/apache/superset/pull/27858#issuecomment-2033227973 It feels to me that the SQL IDE should really just pass the SQL to the underlying connection and return the results or error message in most cases, and not get in the way of

Re: [PR] chore(node): bumping Superset to Node 18 [superset]

2024-04-02 Thread via GitHub
rusackas merged PR #27198: URL: https://github.com/apache/superset/pull/27198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] chore(explore): Hide non-droppable metric and column list [superset]

2024-04-02 Thread via GitHub
justinpark commented on PR #27717: URL: https://github.com/apache/superset/pull/27717#issuecomment-2033242316 @michael-s-molina If you are interested in considering feedback, this proposal suggests adopting a Gmail-style approach.

Re: [I] Make line chart support non-temporal variable for x-axis [superset]

2024-04-02 Thread via GitHub
rusackas commented on issue #6568: URL: https://github.com/apache/superset/issues/6568#issuecomment-2033247240 > Is this feature implemented today ? Yep! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

  1   2   3   >