GAlexeyV commented on code in PR #27144:
URL: https://github.com/apache/superset/pull/27144#discussion_r1574490487
##
superset/charts/data/api.py:
##
@@ -327,12 +327,7 @@ def _run_async(
"""
Execute command as an async query.
"""
-# First,
kushalmraut opened a new issue, #28168:
URL: https://github.com/apache/superset/issues/28168
## Version
apache-superset==3.1.1
## Screenshot
https://github.com/apache/superset/assets/101991799/d144d231-8223-4eac-8f3b-b0c386c17104;>
## Description
Hi I am embedding
dpgaspar commented on code in PR #28135:
URL: https://github.com/apache/superset/pull/28135#discussion_r1574293815
##
superset-websocket/src/index.ts:
##
@@ -94,8 +94,17 @@ export const statsd = new StatsD({
});
// enforce JWT secret length
-if (startServer &&
mounikagancheeri opened a new issue, #28172:
URL: https://github.com/apache/superset/issues/28172
I have embedded a superset dashboard in my system, but I don't want users to
see the "edit chart", "view SQL" buttons. What should I do? What role
permissions need to be modified?
aaron-manning opened a new issue, #28170:
URL: https://github.com/apache/superset/issues/28170
### Bug description
There appears to be a bug in SuperSet in the way it generates the output
used by 'Percentage Metrics' in Table charts when a Postgres 'Decimal' datatype
is part of the
bestlong opened a new pull request, #28169:
URL: https://github.com/apache/superset/pull/28169
### SUMMARY
Add Traditional Chinese translation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
frassinier opened a new issue, #28173:
URL: https://github.com/apache/superset/issues/28173
## Screenshot
https://github.com/apache/superset/assets/18534166/61143b5a-ecd4-4070-ab54-a536e74ed5ac;>
## Description
>After setting
vikashrajgupta commented on issue #28141:
URL: https://github.com/apache/superset/issues/28141#issuecomment-2069192574
@rusackas - I checked my code and I was generating access_token from admin
credentials that have all of the permissions.
Then passing the access token to the below
vikashrajgupta commented on issue #28141:
URL: https://github.com/apache/superset/issues/28141#issuecomment-2069194838
@rusackas - Do let me know if I'm doing anything wrong in this process,
waiting for your valuable response
--
This is an automated message from the Apache Git Service.
kgabryje commented on PR #27995:
URL: https://github.com/apache/superset/pull/27995#issuecomment-2069681858
@michael-s-molina @geido Following our discussion from last week, I opted
for "low effort" solution for now, which is using Antd Select for
ColorSchemeControl instead of our custom
frassinier opened a new pull request, #28171:
URL: https://github.com/apache/superset/pull/28171
### SUMMARY
As described here Echarts can be more inclusive and can generate
aria-description
```tsx
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
john-bodley commented on PR #28169:
URL: https://github.com/apache/superset/pull/28169#issuecomment-2070342213
Thanks @bestlong for the PR. Generally this looks ok to me, but hopefully
@zhaoyongjie could take a look as well.
--
This is an automated message from the Apache Git Service.
To
josedurigon commented on issue #28166:
URL: https://github.com/apache/superset/issues/28166#issuecomment-2070701120
> Something that worked for me to for now fix this was to change what the
env_file variable received, looks like the format they used to represent the
paths is
eschutho commented on code in PR #28164:
URL: https://github.com/apache/superset/pull/28164#discussion_r1575030641
##
superset/databases/schemas.py:
##
@@ -1116,12 +1116,6 @@ class CSVUploadPostSchema(BaseUploadPostSchema):
"description": "DD/MM format dates,
badf007 commented on issue #28166:
URL: https://github.com/apache/superset/issues/28166#issuecomment-2069849597
Something that worked for me to for now fix this was to change what the
env_file variable received, looks like the format they used to represent the
paths is not working
mistercrunch commented on PR #28158:
URL: https://github.com/apache/superset/pull/28158#issuecomment-2070279154
Hey I should have written more originally when submitting this draft, but
this is meant as an experiment around whether it would make sense to add this
package as part of the
rscarborough1996 opened a new issue, #28174:
URL: https://github.com/apache/superset/issues/28174
### Bug description
Users are allowed to enter values into a filter that do not exist in the
dropdown. As they type in their value, it will appear in the drop down for them
to select.
josedurigon commented on issue #28166:
URL: https://github.com/apache/superset/issues/28166#issuecomment-2070663475
> Something that worked for me to for now fix this was to change what the
env_file variable received, looks like the format they used to represent the
paths is not working
mistercrunch commented on PR #28137:
URL: https://github.com/apache/superset/pull/28137#issuecomment-2070773277
I think turning this on as pre-commit is a clear win if we're going to
enforce pylint in CI. It's a bit slow, but pre-commit is a good place to pay
the cost of verification (CI
dpgaspar commented on issue #28146:
URL: https://github.com/apache/superset/issues/28146#issuecomment-2070073070
Hi,
What database engine are you using? Also can you share your connection string
--
This is an automated message from the Apache Git Service.
To respond to the message,
rusackas merged PR #28085:
URL: https://github.com/apache/superset/pull/28085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eschutho commented on code in PR #28164:
URL: https://github.com/apache/superset/pull/28164#discussion_r1575030641
##
superset/databases/schemas.py:
##
@@ -1116,12 +1116,6 @@ class CSVUploadPostSchema(BaseUploadPostSchema):
"description": "DD/MM format dates,
rtexelm opened a new pull request, #28175:
URL: https://github.com/apache/superset/pull/28175
### SUMMARY
Adding a test to check the currency isn't applied to a percent column
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
mistercrunch commented on issue #26395:
URL: https://github.com/apache/superset/issues/26395#issuecomment-2070642836
Hey, loving the designs here! I wanted to bring up the topic of caching and
autocomplete and make sure they're somewhat in-scope for this SIP.
Around caching, the
mistercrunch commented on code in PR #28135:
URL: https://github.com/apache/superset/pull/28135#discussion_r1575250590
##
superset-websocket/src/index.ts:
##
@@ -94,8 +94,17 @@ export const statsd = new StatsD({
});
// enforce JWT secret length
-if (startServer &&
dpgaspar commented on PR #28008:
URL: https://github.com/apache/superset/pull/28008#issuecomment-2069896295
> @john-bodley Certainly. I've previously dedicated some time to exploring
the optimal location for writing unit tests, yet I was unable to identify an
appropriate spot within the
csummers commented on code in PR #27921:
URL: https://github.com/apache/superset/pull/27921#discussion_r1574985142
##
docs/docs/installation/configuring-superset.mdx:
##
@@ -99,6 +99,10 @@ SECRET_KEY = 'YOUR_OWN_RANDOM_GENERATED_SECRET_KEY'
You can generate a strong secure
dpgaspar commented on code in PR #28164:
URL: https://github.com/apache/superset/pull/28164#discussion_r1575051139
##
superset/databases/schemas.py:
##
@@ -1116,12 +1116,6 @@ class CSVUploadPostSchema(BaseUploadPostSchema):
"description": "DD/MM format dates,
Woellchen commented on PR #28110:
URL: https://github.com/apache/superset/pull/28110#issuecomment-2070271693
Hey @rusackas and @john-bodley, I have tried to address your issues. Could
you please another look at it? :)
--
This is an automated message from the Apache Git Service.
To
Vitor-Avila opened a new pull request, #28176:
URL: https://github.com/apache/superset/pull/28176
### SUMMARY
It's currently possible to create alerts and reports configured to be
executed every minute. While it might be a suitable implementation for some
use-cases, some users might
geido commented on code in PR #28046:
URL: https://github.com/apache/superset/pull/28046#discussion_r1575085804
##
superset-frontend/src/explore/actions/saveModalActions.ts:
##
@@ -173,10 +221,14 @@ const addToasts = (isNewSlice, sliceName,
addedToDashboard) => {
return
betodealmeida commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1575165854
##
tests/integration_tests/migrations/87d38ad83218_migrate_can_view_and_drill_permission__tests.py:
##
@@ -34,28 +36,28 @@
downgrade =
rusackas merged PR #28082:
URL: https://github.com/apache/superset/pull/28082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rusackas merged PR #28031:
URL: https://github.com/apache/superset/pull/28031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rusackas closed issue #27894: Extracted Translation Order
URL: https://github.com/apache/superset/issues/27894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rusackas merged PR #28129:
URL: https://github.com/apache/superset/pull/28129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rusackas commented on PR #28163:
URL: https://github.com/apache/superset/pull/28163#issuecomment-2070855219
We might have to move the hosted, but I like the idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eschutho merged PR #28019:
URL: https://github.com/apache/superset/pull/28019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rusackas commented on issue #28141:
URL: https://github.com/apache/superset/issues/28141#issuecomment-2070886138
I think you just need to lock down the permissions, possibly by creating a
new role. I [think this
thread](https://github.com/apache/superset/issues/28172) effectively answers
rusackas closed issue #28141: Not able to disable edit chart option and
clickable title option In Iframe
URL: https://github.com/apache/superset/issues/28141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
rusackas commented on PR #28110:
URL: https://github.com/apache/superset/pull/28110#issuecomment-2070899236
Running CI... fingers crossed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andy-clapson commented on issue #28172:
URL: https://github.com/apache/superset/issues/28172#issuecomment-2070837328
you'll have to create a custom role, with a subset of permissions, that
would make up a view-only profile (according to what you want)
Basically, take `Gamma` and remove
betodealmeida commented on code in PR #28122:
URL: https://github.com/apache/superset/pull/28122#discussion_r1575304453
##
superset/models/dashboard.py:
##
@@ -214,13 +214,6 @@ def datasources(self) -> set[BaseDatasource]:
def charts(self) -> list[str]:
return
eschutho merged PR #28175:
URL: https://github.com/apache/superset/pull/28175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rusackas commented on issue #28173:
URL: https://github.com/apache/superset/issues/28173#issuecomment-2070893945
Hah, just left a comment to that effect on the PR, but it looks like you
beat me to the punch here :)
--
This is an automated message from the Apache Git Service.
To respond
mistercrunch merged PR #27943:
URL: https://github.com/apache/superset/pull/27943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
andy-clapson commented on issue #28172:
URL: https://github.com/apache/superset/issues/28172#issuecomment-2070853474
FWIW, here's my own personal 'view-only' definition I was looking at:
```
- can csrf token on Superset
- can csv on Superset
- can dashboard on Superset
betodealmeida commented on code in PR #28122:
URL: https://github.com/apache/superset/pull/28122#discussion_r1575303604
##
superset/models/dashboard.py:
##
@@ -214,13 +214,6 @@ def datasources(self) -> set[BaseDatasource]:
def charts(self) -> list[str]:
return
eschutho commented on code in PR #28176:
URL: https://github.com/apache/superset/pull/28176#discussion_r1575346794
##
tests/unit_tests/commands/report/base_test.py:
##
@@ -0,0 +1,191 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
rtexelm commented on code in PR #27891:
URL: https://github.com/apache/superset/pull/27891#discussion_r1575407054
##
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##
@@ -98,48 +94,83 @@ function alterForComparison(value?: string | null | []):
string | null {
mistercrunch commented on code in PR #28135:
URL: https://github.com/apache/superset/pull/28135#discussion_r1575427517
##
superset-websocket/src/index.ts:
##
@@ -94,8 +94,17 @@ export const statsd = new StatsD({
});
// enforce JWT secret length
-if (startServer &&
betodealmeida commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1575286982
##
superset/models/core.py:
##
@@ -572,7 +587,30 @@ def quote_identifier(self) -> Callable[[str], str]:
def get_reserved_words(self) -> set[str]:
villebro commented on issue #28173:
URL: https://github.com/apache/superset/issues/28173#issuecomment-2070849650
@frassinier great feature request/POC! This is something we're eagerly
hoping to support soon, but we need a mechanism for making it possible to
enable/disable this type of
rusackas closed issue #28172: I have embedded a superset dashboard in my
system, but I don't want users to see the "edit chart", "view SQL" buttons.
What should I do? What role permissions need to be modified?
URL: https://github.com/apache/superset/issues/28172
--
This is an automated
rusackas commented on issue #28172:
URL: https://github.com/apache/superset/issues/28172#issuecomment-2070850514
Closing this, since that's indeed the correct answer. I do wonder if it's
worth considering sometime in the future a new role tailored to this
increasingly common use case, but
frassinier commented on issue #28173:
URL: https://github.com/apache/superset/issues/28173#issuecomment-2070863412
@villebro Excellent! I like the idea of setting up a user preferences
service!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
frassinier commented on PR #28171:
URL: https://github.com/apache/superset/pull/28171#issuecomment-2070896297
@rusackas, I agree! but what do you think of an automated aria label, maybe
under a feature flag?
--
This is an automated message from the Apache Git Service.
To respond to the
rusackas commented on PR #27905:
URL: https://github.com/apache/superset/pull/27905#issuecomment-2070913342
--
This is an automated message from the Apache Git Service.
To respond to the
rusackas closed pull request #27905: fix: retain non-ascii characters in result
sets
URL: https://github.com/apache/superset/pull/27905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eschutho commented on code in PR #28176:
URL: https://github.com/apache/superset/pull/28176#discussion_r1575337668
##
superset/commands/report/base.py:
##
@@ -76,3 +78,43 @@ def validate_chart_dashboard(
self._properties["dashboard"] = dashboard
elif not
dependabot[bot] opened a new pull request, #28177:
URL: https://github.com/apache/superset/pull/28177
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 3.2.3 to 5.0.0.
Release notes
Sourced from https://github.com/tschaub/gh-pages/releases;>gh-pages's
releases.
dpgaspar commented on code in PR #28135:
URL: https://github.com/apache/superset/pull/28135#discussion_r1575299221
##
superset-websocket/src/index.ts:
##
@@ -94,8 +94,17 @@ export const statsd = new StatsD({
});
// enforce JWT secret length
-if (startServer &&
rusackas commented on PR #28171:
URL: https://github.com/apache/superset/pull/28171#issuecomment-2070892255
I'm not sure we want to turn on the patterns by default. A lot of people
don't want/need them, and this provides no option to disable them. We could, of
course, add a chart control,
eschutho commented on code in PR #28176:
URL: https://github.com/apache/superset/pull/28176#discussion_r1575326371
##
superset/commands/report/base.py:
##
@@ -76,3 +78,43 @@ def validate_chart_dashboard(
self._properties["dashboard"] = dashboard
elif not
rtexelm commented on code in PR #27891:
URL: https://github.com/apache/superset/pull/27891#discussion_r1575404825
##
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##
@@ -149,72 +180,39 @@ class AlteredSliceTag extends React.Component<
if (['filters',
rtexelm commented on code in PR #27891:
URL: https://github.com/apache/superset/pull/27891#discussion_r1575404825
##
superset-frontend/src/components/AlteredSliceTag/index.tsx:
##
@@ -149,72 +180,39 @@ class AlteredSliceTag extends React.Component<
if (['filters',
mistercrunch commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1575421536
##
superset/utils/log.py:
##
@@ -47,10 +47,12 @@ def collect_request_payload() -> dict[str, Any]:
payload: dict[str, Any] = {
"path":
mistercrunch commented on issue #28166:
URL: https://github.com/apache/superset/issues/28166#issuecomment-2071240451
Minimum docker-compose version is `2.24.0` what are you on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
john-bodley commented on code in PR #28159:
URL: https://github.com/apache/superset/pull/28159#discussion_r1575591460
##
tests/integration_tests/migrations/87d38ad83218_migrate_can_view_and_drill_permission__tests.py:
##
@@ -34,28 +36,28 @@
downgrade =
vikashrajgupta commented on issue #28172:
URL: https://github.com/apache/superset/issues/28172#issuecomment-2071436783
Thanks! @rusackas and @andy-clapson - It worked for me as well, earlier I
was not added the `can grant guest token on security API` due to which I was
not able to generate
vikashrajgupta commented on issue #28172:
URL: https://github.com/apache/superset/issues/28172#issuecomment-2071440230
@rusackas @andy-clapson - Can you please tell me from where I can get a
detailed idea about Superset's config and what custom things we can do via
Superset? I thing
rtexelm commented on code in PR #27891:
URL: https://github.com/apache/superset/pull/27891#discussion_r1575562809
##
superset-frontend/src/components/AlteredSliceTag/AlteredSliceTag.test.jsx:
##
@@ -17,325 +17,164 @@
* under the License.
*/
import React from 'react';
betodealmeida commented on code in PR #28176:
URL: https://github.com/apache/superset/pull/28176#discussion_r1575570334
##
superset/commands/report/base.py:
##
@@ -76,3 +78,43 @@ def validate_chart_dashboard(
self._properties["dashboard"] = dashboard
elif
Stefan781 commented on issue #26337:
URL: https://github.com/apache/superset/issues/26337#issuecomment-2071423621
I missed the other issue, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
74 matches
Mail list logo
