[GitHub] codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError
codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report > Merging [#5026](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5026 +/- ## == + Coverage 77.34% 77.34% +<.01% == Files 44 44 Lines8665 8666 +1 == + Hits 6702 6703 +1 Misses 1963 1963 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5026/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.49% <100%> (+0.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=footer). Last update [5a64b3f...82e7741](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError
codecov-io commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390092106 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=h1) Report > Merging [#5026](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5026 +/- ## == + Coverage 77.34% 77.34% +<.01% == Files 44 44 Lines8665 8666 +1 == + Hits 6702 6703 +1 Misses 1963 1963 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5026/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.49% <100%> (+0.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=footer). Last update [5a64b3f...4f653f7](https://codecov.io/gh/apache/incubator-superset/pull/5026?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zhaoyongjie commented on issue #5026: Fix percent_metrics ZeroDivisionError
zhaoyongjie commented on issue #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026#issuecomment-390079873 @michellethomas According to your suggestion, I made a change. if there's a divsion by 0, return None. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] yamyamyuo closed issue #5002: superset presto database support editing `X-Presto-Source`
yamyamyuo closed issue #5002: superset presto database support editing `X-Presto-Source` URL: https://github.com/apache/incubator-superset/issues/5002 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390067823 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=h1) Report > Merging [#5032](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5032 +/- ## === Coverage 77.34% 77.34% === Files 44 44 Lines8665 8665 === Hits 6702 6702 Misses 1963 1963 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=footer). Last update [5a64b3f...209ad80](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all dependent slices before deleting the datasource but I'll push it to a future PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands
GabeLoins opened a new pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032 Previously to this PR, when adding/viewing a simple filter with number of comparators this could happen:  That doesn't look so great and also makes it quite annoying to make any changes because you are forced to manually expand the box to hit save. In this PR I have the popover expand in reaction when the input field expands.  test plan: - ran the example shown in the above gif - ran the spec reviewers: @michellethomas @john-bodley @williaster @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5019: fix missing datasource error message
codecov-io commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389645443 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=h1) Report > Merging [#5019](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5019 +/- ## == - Coverage 77.34% 77.34% -0.01% == Files 44 44 Lines8665 8668 +3 == + Hits 6702 6704 +2 - Misses 1963 1964 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5019/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.64% <66.66%> (-0.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=footer). Last update [5a64b3f...f52f7aa](https://codecov.io/gh/apache/incubator-superset/pull/5019?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] michellethomas commented on issue #4897: Heatmap improvements
michellethomas commented on issue #4897: Heatmap improvements URL: https://github.com/apache/incubator-superset/pull/4897#issuecomment-390059989 hey @mistercrunch it looks like this causes an issue with heatmaps that use `Value Bounds` with normalized turned off. The legend seems to respect the value bounds but the color doesn't change appropriately. It also looks like without the value bounds the legend is always showing the normalized 0-1 range. I can take a screenshot if the description is not clear. I'm testing on internal data so I'd just need to load test data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on a change in pull request #5019: fix missing datasource error message
john-bodley commented on a change in pull request #5019: fix missing datasource
error message
URL:
https://github.com/apache/incubator-superset/pull/5019#discussion_r189138119
##
File path: superset/views/core.py
##
@@ -1229,6 +1229,12 @@ def datasource_info(datasource_id, datasource_type,
form_data):
datasource = form_data.get('datasource', '')
if '__' in datasource:
datasource_id, datasource_type = datasource.split('__')
+# The case where the datasource has been deleted
+datasource_id = None if datasource_id == 'None' else datasource_id
+
+if not datasource_id:
Review comment:
Why not simply,
```
if datasource_id == 'None':
...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189134922
##
File path: superset/utils.py
##
@@ -841,3 +841,17 @@ def ensure_path_exists(path):
except OSError as exc:
if not (os.path.isdir(path) and exc.errno == errno.EEXIST):
raise
+
+
+def get_limit_from_sql(sql):
+sql = sql.lower()
+limit = None
+tokens = sql.split()
+try:
+if 'limit' in tokens:
+limit_pos = tokens.index('limit') + 1
Review comment:
Ah, true. I hadn't thought of the subquery case. But split can handle the
tabs and newlines just fine. I'll go ahead to reuse your regex approach as that
is more robust.
And your suggestion of adding the logic within the checking function makes
sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-390051454 Agree with raising early. Done that. I agree with the cascading idea of forcing users to delete all other dependent slices before deleting the slice but I'll push it to a future PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley commented on issue #5027: Add missing dep on contextlib2
john-bodley commented on issue #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027#issuecomment-390031606 @mistercrunch that's a good suggestion. I can try looking into a CI check which ensures these files are consistent. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5028: [druid] Fixing Druid version check
codecov-io commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-390011234 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=h1) Report > Merging [#5028](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5028 +/- ## == - Coverage 77.34% 77.33% -0.01% == Files 44 44 Lines8665 8654 -11 == - Hits 6702 6693 -9 + Misses 1963 1961 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5028/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.5% <66.66%> (-0.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=footer). Last update [5a64b3f...76cb4c5](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5028: [druid] Fixing Druid version check
codecov-io commented on issue #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028#issuecomment-390011234 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=h1) Report > Merging [#5028](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=tree) ```diff @@Coverage Diff @@ ## master#5028 +/- ## == - Coverage 77.34% 77.33% -0.01% == Files 44 44 Lines8665 8654 -11 == - Hits 6702 6693 -9 + Misses 1963 1961 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5028/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.5% <66.66%> (-0.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=footer). Last update [5a64b3f...76cb4c5](https://codecov.io/gh/apache/incubator-superset/pull/5028?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user is not the owner of a dashboard, we used to allow user `save-as` a new copy of this dashboard ( and allow copy all slices under current dashboard). With this PR, user can't save-as other owner's dashboard anymore. Is this intended behavior? before: https://user-images.githubusercontent.com/27990562/40135870-37ad10fe-58fb-11e8-9e6c-d21738246f7a.png;> after: https://user-images.githubusercontent.com/27990562/40136272-41b3deb0-58fc-11e8-8869-083a113eea22.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user is not the owner of a dashboard, we used to allow user `save-as` a new copy of this dashboard ( and allow copy all slices under current dashboard). With this PR, user can't save-as another dashboard anymore. Is this intended behavior? before: https://user-images.githubusercontent.com/27990562/40135870-37ad10fe-58fb-11e8-9e6c-d21738246f7a.png;> after: https://user-images.githubusercontent.com/27990562/40136272-41b3deb0-58fc-11e8-8869-083a113eea22.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] abowden-spotx opened a new pull request #5029: [WiP] email subscriptions
abowden-spotx opened a new pull request #5029: [WiP] email subscriptions URL: https://github.com/apache/incubator-superset/pull/5029 Building email subscription service. Will store subscription related data in superset.db and will run on Airflow. To get it up and running will use PhantomJS to take a screen shot of the dashboards needed for each email sub. Should resolve: Issue #[3393](https://github.com/apache/incubator-superset/issues/3393) Issue #[1231](https://github.com/apache/incubator-superset/issues/1231) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] codecov-io commented on issue #5027: Add missing dep on contextlib2
codecov-io commented on issue #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027#issuecomment-389990658 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=h1) Report > Merging [#5027](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5027 +/- ## === Coverage 77.34% 77.34% === Files 44 44 Lines8665 8665 === Hits 6702 6702 Misses 1963 1963 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=footer). Last update [5a64b3f...6bd69c4](https://codecov.io/gh/apache/incubator-superset/pull/5027?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] john-bodley opened a new pull request #5028: [druid] Fixing Druid version check
john-bodley opened a new pull request #5028: [druid] Fixing Druid version check URL: https://github.com/apache/incubator-superset/pull/5028 While investigation another issue with @GabeLoins we realized that the Druid version check was invalid, i.e., per the comment on line #626 this issue was fixed in `0.8.2`, yet the following condition ``` not self.version_higher(self.cluster.druid_version, '0.8.2') ``` returns `True` for any version less than or equal to `0.8.2` rather than being exclusive of `0.8.2` since this is the version which included the fix. The same logic was wrong on line #646. The fix is to use `distutils.version.StrictVersion` for version checking which abides by [Druid's semantic versioning](http://druid.io/docs/latest/development/versioning.html). to: @GabeLoins @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2'
mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389988449 Fixed in `0.25.5` release This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch closed issue #5004: db upgrade importError:No module named 'contextlib2'
mistercrunch closed issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch opened a new pull request #5027: Add missing dep on contextlib2
mistercrunch opened a new pull request #5027: Add missing dep on contextlib2 URL: https://github.com/apache/incubator-superset/pull/5027 @john-bodley community contributed https://github.com/apache/incubator-superset/pull/4927 added dep in `requirements.txt` but not in `setup.py` causing Travis to succeed but the installation of pypi to fail for many. With unpinned deps, should we have an extra suite of tests not using `requirements.txt` to catch when new releases of libs break our stuff? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #4921: [bufix] filtered column was removed
mistercrunch commented on issue #4921: [bufix] filtered column was removed URL: https://github.com/apache/incubator-superset/pull/4921#issuecomment-389983851 Yes there should be a validator on the `FiltersControl` that would raise a flag and prevent the query from running. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189075550
##
File path: superset/utils.py
##
@@ -841,3 +841,17 @@ def ensure_path_exists(path):
except OSError as exc:
if not (os.path.isdir(path) and exc.errno == errno.EEXIST):
raise
+
+
+def get_limit_from_sql(sql):
+sql = sql.lower()
+limit = None
+tokens = sql.split()
+try:
+if 'limit' in tokens:
+limit_pos = tokens.index('limit') + 1
Review comment:
Oh that looks brittle here, for example `limit` can exist within a subquery,
or there can be line breaks or tabs as separators instead of spaces. We should
use the same method / regex approach as the one I defined. Maybe that method in
db_engine_spec can receive `max_limit` and only apply alter if the max
_limit is lower
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF
abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF
URL: https://github.com/apache/incubator-superset/pull/4747
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/javascripts/dashboard/components/Header.jsx
b/superset/assets/javascripts/dashboard/components/Header.jsx
index 52d3024ff9..f56ee1c932 100644
--- a/superset/assets/javascripts/dashboard/components/Header.jsx
+++ b/superset/assets/javascripts/dashboard/components/Header.jsx
@@ -7,6 +7,7 @@ import Button from '../../components/Button';
import FaveStar from '../../components/FaveStar';
import InfoTooltipWithTrigger from '../../components/InfoTooltipWithTrigger';
import { t } from '../../locales';
+import * as util from '../../reduxUtils';
const propTypes = {
dashboard: PropTypes.object.isRequired,
@@ -68,6 +69,19 @@ class Header extends React.PureComponent {
{btnText}
);
}
+ renderDownloadButton() {
+// TODO: review button style
+const btnText = 'Download';
+return (
+
+{btnText}
+ );
+ }
render() {
const dashboard = this.props.dashboard;
return (
diff --git a/superset/assets/javascripts/reduxUtils.js
b/superset/assets/javascripts/reduxUtils.js
index d843d279a2..9036e5421f 100644
--- a/superset/assets/javascripts/reduxUtils.js
+++ b/superset/assets/javascripts/reduxUtils.js
@@ -98,3 +98,15 @@ export function areArraysShallowEqual(arr1, arr2) {
export function areObjectsEqual(obj1, obj2) {
return equals(obj1, obj2, true);
}
+
+export function downloadCurPage() {
+ // This will call a python script to download the current page as a pdf
+ $.ajax({
+ type: 'GET',
+ url: '/download_pdf',
+ data: function() {
+ return string(window.location.href) //TODO: pass dash specific info
+ },
+ success: alert('PDF Downloaded')
+ })
+}
diff --git a/superset/views/core.py b/superset/views/core.py
index 91a420ae28..d723a37adf 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -692,6 +692,15 @@ def ping():
return 'OK'
+@app.route('/download_pdf')
+def download_pdf(url='http://localhost:8088/superset/dashboard/births/'):
#TODO: collect url to download
+#TODO: pass session authorization
+dir = os.getcwd() #TODO
+file_name = 'sample_dl.pdf' #TODO: file naming structure
+pdfkit.from_url(url, dir + file_name)
+return 'Success'
+
+
class KV(BaseSupersetView):
"""Used for storing and retrieving key value pairs"""
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189043405
##
File path: superset/sql_lab.py
##
@@ -171,6 +171,7 @@ def handle_error(msg):
# Limit enforced only for retrieving the data, not for the CTA queries.
superset_query = SupersetQuery(rendered_query)
executed_sql = superset_query.stripped()
+SQL_MAX_ROWS = int(app.config.get('SQL_MAX_ROW', None))
Review comment:
I'll send out the fir for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
timifasubaa commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189043307
##
File path: superset/sql_lab.py
##
@@ -185,7 +186,8 @@ def handle_error(msg):
query.user_id, start_dttm.strftime('%Y_%m_%d_%H_%M_%S'))
executed_sql = superset_query.as_create_table(query.tmp_table_name)
query.select_as_cta_used = True
-elif (query.limit and superset_query.is_select()):
+elif (not query.limit and superset_query.is_select() and SQL_MAX_ROWS):
Review comment:
@mistercrunch I tested it and it works correctly.
I changed the place where query.limit is defined upstream and it is None
only when it is not specified. It is only in those cases that we append the
default limit to the end.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389936762 All examples get executed as integration test, so if you add a new example chart that cover this use case it should fail before your PR, succeed after This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189029182
##
File path: superset/sql_lab.py
##
@@ -171,6 +171,7 @@ def handle_error(msg):
# Limit enforced only for retrieving the data, not for the CTA queries.
superset_query = SupersetQuery(rendered_query)
executed_sql = superset_query.stripped()
+SQL_MAX_ROWS = int(app.config.get('SQL_MAX_ROW', None))
Review comment:
`None` is implicit on the get method and will make `int` raise
```
In [1]: int(None)
TypeError: int() argument must be a string, a bytes-like object or a number,
not 'NoneType'
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit
mistercrunch commented on a change in pull request #5023: [sqllab] force limit
queries only when there is no existing limit
URL:
https://github.com/apache/incubator-superset/pull/5023#discussion_r189029978
##
File path: superset/sql_lab.py
##
@@ -185,7 +186,8 @@ def handle_error(msg):
query.user_id, start_dttm.strftime('%Y_%m_%d_%H_%M_%S'))
executed_sql = superset_query.as_create_table(query.tmp_table_name)
query.select_as_cta_used = True
-elif (query.limit and superset_query.is_select()):
+elif (not query.limit and superset_query.is_select() and SQL_MAX_ROWS):
Review comment:
Wait I think you remove all handling of `query.limit` where it's defined
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389934250 About cascading, I think that would be the desired behavior as long as there's clarity on what is happening. There should be a confirmation screen with all the associated objects that are going to be deleted, and the person performing the operation should have write/delete access to all these objects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389933718 Can we change the error message to something like "The data source associated with this chart no longer exists"? Also, should we raise right then (asap) instead of waiting for raising in `viz.py` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389931667 Seems like a data engineering / data preparation would be best in this case. You'd ETL your user conf data into a data warehouse, while keeping track of the history/changes. While Superset has caching features, there's no chart "snapshoting" feature and would make the cache saved as of a point in time for a specific chart. I don't see that coming anytime soon, so your best bet is ETL. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] ladys1728 commented on issue #4317: [SLICE][RIGHT ISSUE] Problems with restricted rights role
ladys1728 commented on issue #4317: [SLICE][RIGHT ISSUE] Problems with restricted rights role URL: https://github.com/apache/incubator-superset/issues/4317#issuecomment-389917508 Hi yoyos26, I have exactly the same problem. Have you fixed your issue? Regards, This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zhaoyongjie opened a new pull request #5026: Fix percent_metrics ZeroDivisionError
zhaoyongjie opened a new pull request #5026: Fix percent_metrics ZeroDivisionError URL: https://github.com/apache/incubator-superset/pull/5026 Fix percent_metrics ZeroDivisionError and can not get metrics with label issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389893609 > I think this fixes it #4914 the bug in pivot table have not been fixed in #4914 the viz still not work, so I put a new PR,thx @mistercrunch @xrmx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389892505 > I think this fixes it #4914 the bug in pivot have not been fixed in #4914,so I put a new PR @mistercrunch @xrmx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict'
gangh commented on issue #4984: Pivot table not working - unhashable type: 'dict' URL: https://github.com/apache/incubator-superset/issues/4984#issuecomment-389892505 > I think this fixes it #4914 the bug in pivot have not been fixed in #4914,so I put a new PR @mistercrunch @xrmx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] gangh opened a new pull request #5025: [bugfix]fix metrics type error in pivot table viz
gangh opened a new pull request #5025: [bugfix]fix metrics type error in pivot table viz URL: https://github.com/apache/incubator-superset/pull/5025 to fix this bug in pivot table viz @xrmx @mistercrunch https://github.com/apache/incubator-superset/issues/4984 - transfer metrics dict label to the list of string This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] thakur00mayank commented on issue #3729: Added multi-tenancy support.
thakur00mayank commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-389885637 Thanks, @neilsoncarlos for pointing out the new changes. I will soon do the required changes. and update the pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] neilsoncarlos commented on issue #3729: Added multi-tenancy support.
neilsoncarlos commented on issue #3729: Added multi-tenancy support. URL: https://github.com/apache/incubator-superset/pull/3729#issuecomment-389882062 this was built on top of a deprecated endpoint (update_role). https://github.com/apache/incubator-superset/pull/4041 See the commit on core.py https://github.com/apache/incubator-superset/pull/3729/files#diff-ac978615a4f22c4fad4d01f39e1d4595 So, you would probably need to adapt it to the current superset version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] alexjacquot commented on issue #2488: How to authenticate with REST API
alexjacquot commented on issue #2488: How to authenticate with REST API URL: https://github.com/apache/incubator-superset/issues/2488#issuecomment-389877666 Is there a documentation of the rest api ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] alexjacquot commented on issue #1901: Bypassing the login for Supreset iframe in Webpage
alexjacquot commented on issue #1901: Bypassing the login for Supreset iframe in Webpage URL: https://github.com/apache/incubator-superset/issues/1901#issuecomment-389855859 Any news on this ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389824942 Thank you very much @TianyangLi. That was the problem. I install all in python3, pip3, and venv is correct now. The connection to MySQL is established. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] zhaoyongjie commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz
zhaoyongjie commented on issue #4931: date/datetime/timestamp using unix timestamp in Table-viz URL: https://github.com/apache/incubator-superset/issues/4931#issuecomment-389818436 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389813616 @TianyangLi How to check this? And more important, how to solve it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] tianlinzx opened a new issue #5024: feature request: keycloak support
tianlinzx opened a new issue #5024: feature request: keycloak support URL: https://github.com/apache/incubator-superset/issues/5024 feature request: keycloak support - [x] I have checked the superset logs for python stacktraces and included it here as text if any - [x] I have reproduced the issue with at least the latest released version of superset - [x] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version 0.25 ### Expected results Keycloak is a standalone authentication provider, it use openid connection protocal, a community implematation is done in this post https://stackoverflow.com/questions/47678321/using-openid-keycloak-with-superset ### Actual results would it be integrated into official release ? ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389809339 @miloradkrstevski Are you sure you're in the right virtual venv? have you deployed your venv in a python3 environment? its unclear from your steps.. python defaults 2.7. So its possible that you've installed python3-mysqldev library, but when you type 'pip install mysql' you're actually calling the wrong python version. Or your superset is in a python2.7 venv and you're mysqldb is in a python3 one.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389809339 @miloradkrstevski Are you sure you're in the right virtual venv? have you deployed your venv in a python3 environment? its unclear from your steps.. python defaults 2.7. So its possible that you've installed python3-mysqldev library, but when you type 'pip install mysql' you're actually calling the wrong python version. Check that.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389804470 @mistercrunch Can you please reopen the issue so someone could help me? Anyone any solution: @xrmx , @TianyangLi , @mistercrunch , ... The details are above this comment. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE()
hajdbo commented on issue #4857: Incorrect SQL statement on "View Query": python-encoded % character (%%) on STR_TO_DATE() URL: https://github.com/apache/incubator-superset/issues/4857#issuecomment-387708899 Not fixed in 0.25.4 release with SQLalchemy 1.2.2 https://user-images.githubusercontent.com/1834306/39812407-2c4bf3c4-53bf-11e8-9417-d1eca53a9e92.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] JulieRossi closed issue #5006: ImportError: No module named 'flask.exthook'
JulieRossi closed issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] JulieRossi commented on issue #5006: ImportError: No module named 'flask.exthook'
JulieRossi commented on issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006#issuecomment-389783573 Thanks !! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @john-bodley @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is the first place the datasource is checked from the form data. And it's the first place 2. The method intentionally does not fail because the error is handled downstream (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L64), where the intelligible error message (Viz is missing a datasource) is displayed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] timifasubaa commented on issue #5019: fix missing datasource error message
timifasubaa commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389759380 @mistercrunch Upon furthher investigation, I think the current approach is best for the following reaosns 1. datasource_info is the first place the datasource is checked from the form data. And it's the first place 2. The method intentionally does not fail because the error is handled downstream (https://github.com/apache/incubator-superset/blob/master/superset/viz.py#L60), where the intelligible error message (Viz is missing a datasource) is displayed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
