[GitHub] [incubator-superset] mistercrunch merged pull request #8093: Move Darwin-specific JS libs to optional
mistercrunch merged pull request #8093: Move Darwin-specific JS libs to optional URL: https://github.com/apache/incubator-superset/pull/8093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor
graceguo-supercat commented on a change in pull request #8099: [WIP] Allow
resizing width of SQL Lab left bar / editor
URL:
https://github.com/apache/incubator-superset/pull/8099#discussion_r316972088
##
File path: superset/assets/src/SqlLab/components/SqlEditor.jsx
##
@@ -453,25 +458,36 @@ class SqlEditor extends React.PureComponent {
);
}
+ leftBar() {
+return (
+
+
+
+);
+ }
render() {
return (
-
-
-
-
-
-
+
[GitHub] [incubator-superset] mistercrunch merged pull request #8097: [fix] add checks for stopped queries
mistercrunch merged pull request #8097: [fix] add checks for stopped queries URL: https://github.com/apache/incubator-superset/pull/8097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor
graceguo-supercat commented on a change in pull request #8099: [WIP] Allow
resizing width of SQL Lab left bar / editor
URL:
https://github.com/apache/incubator-superset/pull/8099#discussion_r316972088
##
File path: superset/assets/src/SqlLab/components/SqlEditor.jsx
##
@@ -453,25 +458,36 @@ class SqlEditor extends React.PureComponent {
);
}
+ leftBar() {
+return (
+
+
+
+);
+ }
render() {
return (
-
-
-
-
-
-
+
[GitHub] [incubator-superset] villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic
villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic URL: https://github.com/apache/incubator-superset/pull/8098#discussion_r316971799 ## File path: superset/db_engine_specs/hive.py ## @@ -343,7 +346,7 @@ def select_star( latest_partition: bool = True, cols: Optional[List[Dict[str, Any]]] = None, ) -> str: -return BaseEngineSpec.select_star( +return super(PrestoEngineSpec, cls).select_star( Review comment: As `HiveEngineSpec` already extends `PrestoEngineSpec`, this wouldn't really be needed. It is my understanding, that the reason for calling `BaseEngineSpec` here is because we specifically don't want to use the default behaviour of `PrestoEngineSpect`, but rather what's defined in `BaseEngineSpec`. Not being familiar with how Hive/Presto works in this case someone with deeper knowledge of their respective intricacies would probably need to check this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave closed pull request #8096: increase node memory in tox testenv
DiggidyDave closed pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic
villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix
latest partition logic
URL:
https://github.com/apache/incubator-superset/pull/8098#discussion_r316971958
##
File path: superset/db_engine_specs/hive.py
##
@@ -321,10 +324,10 @@ def latest_sub_partition(cls, table_name, schema,
database, **kwargs):
pass
@classmethod
-def _latest_partition_from_df(cls, df):
+def _latest_partition_from_df(cls, df) -> Optional[List[str]]:
"""Hive partitions look like ds={partition name}"""
if not df.empty:
-return df.ix[:, 0].max().split("=")[1]
+return [df.ix[:, 0].max().split("=")[1]]
Review comment:
`return None` here to make sure there's an explicit return.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic
villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic URL: https://github.com/apache/incubator-superset/pull/8098#discussion_r316971399 ## File path: superset/db_engine_specs/hive.py ## @@ -299,16 +299,19 @@ def get_columns( @classmethod def where_latest_partition(cls, table_name, schema, database, qry, columns=None): Review comment: This should be identical with what's in `BaseEngineSpec`: https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs/base.py#L565-L572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix latest partition logic
villebro commented on a change in pull request #8098: [Hive Engine Spec] Fix
latest partition logic
URL:
https://github.com/apache/incubator-superset/pull/8098#discussion_r316971485
##
File path: superset/db_engine_specs/hive.py
##
@@ -299,16 +299,19 @@ def get_columns(
@classmethod
def where_latest_partition(cls, table_name, schema, database, qry,
columns=None):
try:
-col_name, value = cls.latest_partition(
+col_names, values = cls.latest_partition(
table_name, schema, database, show_first=True
)
except Exception:
# table is not partitioned
return False
-if value is not None:
-for c in columns:
-if c.get("name") == col_name:
-return qry.where(Column(col_name) == value)
+if values is not None:
+for col_name, value in zip(col_names, values):
+for c in columns:
+if c.get("name") == col_name:
+qry = qry.where(Column(col_name) == value)
+
+return qry
return False
Review comment:
`return None`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave opened a new pull request #8096: increase node memory in tox testenv
DiggidyDave opened a new pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY I've seen lots of webpack OOM failures in PR requests the last couple of days. This is an attempt to unblock those. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @dpgaspar @mistercrunch @betodealmeida This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida opened a new pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor
betodealmeida opened a new pull request #8099: [WIP] Allow resizing width of SQL Lab left bar / editor URL: https://github.com/apache/incubator-superset/pull/8099 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #7157: [filter box] numbers get truncated
stale[bot] closed issue #7157: [filter box] numbers get truncated URL: https://github.com/apache/incubator-superset/issues/7157 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] wushenchao commented on issue #7362: Pivot Table Field alias display problem
wushenchao commented on issue #7362: Pivot Table Field alias display problem
URL:
https://github.com/apache/incubator-superset/issues/7362#issuecomment-524144368
> This issue affects all of my pivot tables.
I replace with the df_html data in viz.py PivotTableViz,
the code:
group_bys = self.form_data.get('groupby')
if group_bys and len(group_bys) > 1:
for col in group_bys:
for column in self.datasource.columns:
verbose_name = column.verbose_name
if column.column_name == col and verbose_name:
df_html = df_html.replace('{}'.format(col),
'{}'.format(verbose_name), 1)
return dict(
columns=list(df.columns),
html=df_html,
)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 opened a new pull request #8098: [Hive Engine Spec] Fix latest partition logic
etr2460 opened a new pull request #8098: [Hive Engine Spec] Fix latest partition logic URL: https://github.com/apache/incubator-superset/pull/8098 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY When the Presto db engine spec was changed to support multiple partition columns, it broke Hive because it extends Presto. Table previews and copy select star broke because they wouldn't add partition filters. This PR updates the functions that the Hive spec extends to return and accept the same data types ### TEST PLAN - Test copy select statement and ensure it has a partition - Test table preview - Test jinja latest partition function ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @michellethomas @villebro @betodealmeida @serenajiang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8087: fix: minor release/license related issues
mistercrunch merged pull request #8087: fix: minor release/license related issues URL: https://github.com/apache/incubator-superset/pull/8087 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8089: CHANGELOG for 0.30...0.34
mistercrunch merged pull request #8089: CHANGELOG for 0.30...0.34 URL: https://github.com/apache/incubator-superset/pull/8089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed issue #5892: Paginator starts at page zero
stale[bot] closed issue #5892: Paginator starts at page zero URL: https://github.com/apache/incubator-superset/issues/5892 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8097: [fix] add checks for stopped queries
codecov-io commented on issue #8097: [fix] add checks for stopped queries URL: https://github.com/apache/incubator-superset/pull/8097#issuecomment-524109485 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=h1) Report > Merging [#8097](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0d76fc755cd4cdcccf8238311ab00678d38230af?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8097 +/- ## == - Coverage 65.83% 65.81% -0.03% == Files 486 486 Lines 2292122924 +3 Branches 2521 2521 == - Hits1509015087 -3 - Misses 7700 7706 +6 Partials 131 131 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8097/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `76.84% <75%> (-0.17%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8097/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `79.31% <0%> (-17.25%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=footer). Last update [0d76fc7...a767560](https://codecov.io/gh/apache/incubator-superset/pull/8097?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7758: Update gallery.rst
stale[bot] commented on issue #7758: Update gallery.rst URL: https://github.com/apache/incubator-superset/pull/7758#issuecomment-524097415 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8097: [fix] add checks for stopped queries
serenajiang opened a new pull request #8097: [fix] add checks for stopped queries URL: https://github.com/apache/incubator-superset/pull/8097 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY When a user tries to stop a query, very occasionally, the action fails and the query still runs to completion. The issue isn't user-facing, but errors in the backend show that there is some kind of lock wait timeout issue. Unknown if it is possible to completely prevent these, and the issue isn't really user-facing, but I added some tweaks to hopefully prevent a few of these conflicts. * Add `commit()` after setting the initial query status to `RUNNING` * Check if the query has stopped before running each statement. Exit if query has stopped. * (Unrelated) Removed line 281 which (afaik) doesn't do anything ### TEST PLAN Tox passes. I didn't write a test because it is pretty hard to reproduce this error - seems like a rare timing thing. These changes are mostly for safety and shouldn't affect behavior of anything. ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave closed pull request #8096: increase node memory in tox testenv
DiggidyDave closed pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave opened a new pull request #8096: increase node memory in tox testenv
DiggidyDave opened a new pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY I've seen lots of webpack OOM failures in PR requests the last couple of days. This is an attempt to unblock those. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @dpgaspar @mistercrunch @betodealmeida This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database
villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-524085299 If you check the diff, I added a warning about using CTEs on non-ANSIs. Btw, I'm working on something that might improve CTE support on all engines and should fix this problem on non-ANSIs, too, but we'll see how that works out. But in the meantime this is probably the best compromise I can offer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ramonankersmit edited a comment on issue #6267: Incubator-superset container fails: exec user process caused "no such file or directory"
ramonankersmit edited a comment on issue #6267: Incubator-superset container fails: exec user process caused "no such file or directory" URL: https://github.com/apache/incubator-superset/issues/6267#issuecomment-524079632 This solves the original error but after entering password etc you get this error: NotADirectoryError: [Errno 20] Not a directory: '/home/superset/superset/static/assets/package.json' This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ramonankersmit commented on issue #6267: Incubator-superset container fails: exec user process caused "no such file or directory"
ramonankersmit commented on issue #6267: Incubator-superset container fails: exec user process caused "no such file or directory" URL: https://github.com/apache/incubator-superset/issues/6267#issuecomment-524079632 still getting the same error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] abhinavsood commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database
abhinavsood commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-524058448 @villebro - I was able to test this and can confirm that everything works as expected. The test CTE as well as CTEs fetching records from the database work. A couple of things to note: 1. Users would have to be careful trying to pull more data than the browser can handle 2. The SQL Lab UI shows the `Limit 1000` button below the query box which wouldn't have any effect for queries against non-ANSI compliant databases This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] TheLastSultan commented on issue #8086: [SIP] Step/Funnel Step Visualization (American Express)
TheLastSultan commented on issue #8086: [SIP] Step/Funnel Step Visualization (American Express) URL: https://github.com/apache/incubator-superset/pull/8086#issuecomment-524045742 Can anyone comment on what would need to be added to successfully pass these build tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8096: increase node memory in tox testenv
codecov-io edited a comment on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524040297 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=h1) Report > Merging [#8096](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fb51632e18e03d3401d25035b3a14d7a40370295?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#8096 +/- ## === Coverage 65.83% 65.83% === Files 486 486 Lines 2292122921 Branches 2521 2521 === Hits1509015090 Misses 7700 7700 Partials 131 131 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=footer). Last update [fb51632...c2dcaed](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8096: increase node memory in tox testenv
codecov-io commented on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524040297 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=h1) Report > Merging [#8096](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fb51632e18e03d3401d25035b3a14d7a40370295?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#8096 +/- ## === Coverage 65.83% 65.83% === Files 486 486 Lines 2292122921 Branches 2521 2521 === Hits1509015090 Misses 7700 7700 Partials 131 131 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=footer). Last update [fb51632...c2dcaed](https://codecov.io/gh/apache/incubator-superset/pull/8096?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw merged pull request #8083: feat: replace table and box plot vis with new plugins
kristw merged pull request #8083: feat: replace table and box plot vis with new plugins URL: https://github.com/apache/incubator-superset/pull/8083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] agabardo commented on issue #6921: Redirection to shared url after login
agabardo commented on issue #6921: Redirection to shared url after login URL: https://github.com/apache/incubator-superset/pull/6921#issuecomment-524035132 Why do people close unsolved issues? Has this problem being fixed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8083: feat: replace table and box plot vis with new plugins
codecov-io commented on issue #8083: feat: replace table and box plot vis with new plugins URL: https://github.com/apache/incubator-superset/pull/8083#issuecomment-524028955 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=h1) Report > Merging [#8083](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0fd7364503647c98893cb31ff0320367f66f9d89?src=pr=desc) will **increase** coverage by `0.4%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=tree) ```diff @@Coverage Diff@@ ## master#8083 +/- ## = + Coverage 65.42% 65.83% +0.4% = Files 469 486 +17 Lines 2250222921+419 Branches 2452 2521 +69 = + Hits1472215090+368 - Misses 7657 7700 +43 - Partials 123 131 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=tree) | Coverage Δ | | |---|---|---| | [...et/assets/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9wcmVzZXRzL01haW5QcmVzZXQuanM=) | `0% <ø> (ø)` | :arrow_up: | | [superset/assets/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0FuY2hvckxpbmsuanN4) | `83.33% <0%> (-16.67%)` | :arrow_down: | | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydEhvbGRlci5qc3g=) | `74.07% <0%> (-10.78%)` | :arrow_down: | | [...et/assets/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkU3RhdGUuanM=) | `73.46% <0%> (-9.87%)` | :arrow_down: | | [...s/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWJzLmpzeA==) | `61.11% <0%> (-5.05%)` | :arrow_down: | | [...sets/src/dashboard/components/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmRCdWlsZGVyLmpzeA==) | `79.68% <0%> (-2.14%)` | :arrow_down: | | [...ts/src/dashboard/components/gridComponents/Tab.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWIuanN4) | `66.66% <0%> (-1.52%)` | :arrow_down: | | [.../assets/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmRHcmlkLmpzeA==) | `59.64% <0%> (-1.47%)` | :arrow_down: | | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `70% <0%> (-0.89%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.93% <0%> (-0.06%)` | :arrow_down: | | ... and [53 more](https://codecov.io/gh/apache/incubator-superset/pull/8083/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=footer). Last update [0fd7364...a3c5d71](https://codecov.io/gh/apache/incubator-superset/pull/8083?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[GitHub] [incubator-superset] kristw commented on issue #8096: increase node memory in tox testenv
kristw commented on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524014519 The JS build stalls after finishing unit test. Not sure why. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar edited a comment on issue #8088: Replace scripts with entry_points
dpgaspar edited a comment on issue #8088: Replace scripts with entry_points URL: https://github.com/apache/incubator-superset/pull/8088#issuecomment-524008915 I have not tested it, but, don't you need change the name on ./superset/bin/superset to ./superset/bin/superset.py ? I'm making this change also on #8079 :package: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8088: Replace scripts with entry_points
dpgaspar commented on issue #8088: Replace scripts with entry_points URL: https://github.com/apache/incubator-superset/pull/8088#issuecomment-524008915 I have not tested it, but, don't you need change the name on ./superset/bin/superset to ./superset/bin/superset.py ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw commented on issue #8096: increase node memory in tox testenv
kristw commented on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524008242 Thank you @DiggidyDave This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8096: increase node memory in tox testenv
dpgaspar commented on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524005648 Yep `0xad641e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node] 4: 0xad6654 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [no` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave commented on issue #8096: increase node memory in tox testenv
DiggidyDave commented on issue #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096#issuecomment-524001816 This seems to be working based on the push jenkins job. @dpgaspar @thunter009 et al who have OOM failures in other PR builds. @mistercrunch @betodealmeida etc plz review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database
villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-523999886 Unfortunately I an not that familiar with how the docker setup under contrib works (we use a custom Dockerfile in our env). But seems like rebuilding from scratch should help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave opened a new pull request #8096: increase node memory in tox testenv
DiggidyDave opened a new pull request #8096: increase node memory in tox testenv URL: https://github.com/apache/incubator-superset/pull/8096 ### CATEGORY Choose one - [ X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY I've seen lots of webpack OOM failures in PR requests the last couple of days. This is an attempt to unblock those. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] TheLastSultan opened a new pull request #8086: [SIP] Step/Funnel Step Visualization (American Express)
TheLastSultan opened a new pull request #8086: [SIP] Step/Funnel Step Visualization (American Express) URL: https://github.com/apache/incubator-superset/pull/8086 ### SIP: Add Step Visualization (American Express) [SIP issue #7574](https://github.com/apache/incubator-superset/issues/7574) Choose one - [x] Enhancement (new features, refinement) - [x] Refactor - [x] Add tests - [x] Build / Development Environment - [x] Documentation ### SUMMARY Adding Step Visualization to Apache Superset ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF 1) STEPS Using the 'dist_bar' Viz_type the user will be able to add many steps. Each step has is simply a bar graph step with a specific query. Relationships are made between each step by printing the delta for story telling effect.  2) ABSOLUTE FILTER Absolute Filter can be added on a slice as a whole for repetitive filters. For example if you are only interested in telling a story on domestic sales. You can apply the domestic_sales filter once in absolute filter instead of on every step.  ### TEST PLAN Run additional tests on the issue ### ADDITIONAL INFORMATION - [x] Has associated issue: - [x] Changes UI - [x] Requires DB Migration. - [x] Confirm DB Migration upgrade and downgrade tested. - [x] Introduces new feature or API - [x] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] abhinavsood commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database
abhinavsood commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-523974549 @villebro I am currently unable to test the fix. The docker environment for development fails to initialize: ```sh Step 13/23 : RUN pip install --upgrade setuptools pip && pip install -r requirements.txt -r requirements-dev.txt -r requirements-extra.txt && rm -rf /root/.cache/pip ---> Running in 757208a956a6 Collecting setuptools Downloading https://files.pythonhosted.org/packages/b2/86/095d2f7829badc207c893dd4ac767e871f6cd547145df797ea26baea4e2e/setuptools-41.2.0-py2.py3-none-any.whl (576kB) Collecting pip Downloading https://files.pythonhosted.org/packages/8d/07/f7d7ced2f97ca3098c16565efbe6b15fafcba53e8d9bdb431e09140514b0/pip-19.2.2-py2.py3-none-any.whl (1.4MB) Installing collected packages: setuptools, pip Found existing installation: setuptools 41.0.1 Uninstalling setuptools-41.0.1: ERROR: Could not install packages due to an EnvironmentError: [Errno 39] Directory not empty: 'packaging' WARNING: You are using pip version 19.1.1, however version 19.2.2 is available. You should consider upgrading via the 'pip install --upgrade pip' command. ERROR: Service 'superset' failed to build: The command '/bin/sh -c pip install --upgrade setuptools pip && pip install -r requirements.txt -r requirements-dev.txt -r requirements-extra.txt && rm -rf /root/.cache/pip' returned a non-zero code: 1 ``` Do you have any suggestions on what might be causing this? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8095: Incompatible dependencies
issue-label-bot[bot] commented on issue #8095: Incompatible dependencies URL: https://github.com/apache/incubator-superset/issues/8095#issuecomment-523962773 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.70. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mcdallas opened a new issue #8095: Incompatible dependencies
mcdallas opened a new issue #8095: Incompatible dependencies URL: https://github.com/apache/incubator-superset/issues/8095 setup.py requires flask <1.0.0 while flask-appbuilder requires flask >=1.0.0 as a result `pipenv install superset` fails with ``` ERROR: Could not find a version that matches flask<1.0.0,<2,>=0.10,>=0.10.1,>=0.12,>=0.9,>=1.0 Tried: 0.1, 0.2, 0.3, 0.3.1, 0.4, 0.5, 0.5.1, 0.5.2, 0.6, 0.6.1, 0.7, 0.7.1, 0.7.2, 0.8, 0.8.1, 0.9, 0.10, 0.10.1, 0.11, 0.11, 0.11.1, 0.11.1, 0.12, 0.12, 0.12.1, 0.12.1, 0.12.2, 0.12.2, 0.12.3, 0.12.3, 0.12.4, 0.12.4, 1.0, 1.0, 1.0.1, 1.0.1, 1.0.2, 1.0.2, 1.0.3, 1.0.3, 1.0.4, 1.0.4, 1.1.0, 1.1.0, 1.1.1, 1.1.1 ``` related #4953 ### Environment Tried on MacOS with python 3.7.4 and 3.6.5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] LeonanCarvalho commented on issue #3090: [header] Superset landing page and logo link
LeonanCarvalho commented on issue #3090: [header] Superset landing page and logo link URL: https://github.com/apache/incubator-superset/issues/3090#issuecomment-523951406 This issue still happens with the current master branch, The superset logo link redirects to profile page, which is empty if the access is anonymous. ``` http://localhost:8080/superset/profile// ``` It should redirect to the main page or something else instead.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] LeonanCarvalho edited a comment on issue #7763: Cannot enable anonymous users to view dashboards
LeonanCarvalho edited a comment on issue #7763: Cannot enable anonymous users to view dashboards URL: https://github.com/apache/incubator-superset/issues/7763#issuecomment-523949896 I'm using this config-set for Public access `[can dashboard on Superset, can explorev2 on Superset, can explore json on Superset, can csrf token on Superset, can csv on Superset, menu access on Dashboards, all datasource access on all_datasource_access, all database access on all_database_access, can list on DashboardModelViewAsync, can list on DashboardModelView]` You just need to replace all_database_access and all_datasource_access for the public datasource and database. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] LeonanCarvalho commented on issue #7763: Cannot enable anonymous users to view dashboards
LeonanCarvalho commented on issue #7763: Cannot enable anonymous users to view dashboards URL: https://github.com/apache/incubator-superset/issues/7763#issuecomment-523949896 `[can dashboard on Superset, can explorev2 on Superset, can explore json on Superset, can csrf token on Superset, can csv on Superset, menu access on Dashboards, all datasource access on all_datasource_access, all database access on all_database_access, can list on DashboardModelViewAsync, can list on DashboardModelView]` You just need to replace all_database_access and all_datasource_access for the public datasource and database. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8047: [database] Improve connection URI validation
dpgaspar commented on a change in pull request #8047: [database] Improve
connection URI validation
URL:
https://github.com/apache/incubator-superset/pull/8047#discussion_r316727411
##
File path: superset/views/database/__init__.py
##
@@ -16,17 +16,38 @@
# under the License.
# pylint: disable=C,R,W
import inspect
+from typing import Type
-from flask import Markup
+from flask import current_app, Markup
from flask_babel import lazy_gettext as _
+from marshmallow import ValidationError
from sqlalchemy import MetaData
+from sqlalchemy.engine.url import make_url
+from sqlalchemy.exc import ArgumentError
from superset import security_manager
from superset.exceptions import SupersetException
from superset.utils import core as utils
from superset.views.base import SupersetFilter
+def sqlalchemy_uri_validator(
+uri: str, exception: Type[ValidationError] = ValidationError
+) -> None:
+"""
+Check if a user has submitted a valid SQLAlchemy URI
+"""
+try:
+url = make_url(uri.strip())
+except ArgumentError:
+raise exception(_("Invalid connnection string could not parse rfc1738
URL"))
Review comment:
Updated
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] barryslice commented on issue #7811: updated mapbox npm install version to install latest patch
barryslice commented on issue #7811: updated mapbox npm install version to install latest patch URL: https://github.com/apache/incubator-superset/pull/7811#issuecomment-523932830 @etr2460 any idea why this causes ``` - /home/travis/build/apache/incubator-superset/superset/assets/cypress/screenshots/explore/control.test.js/Advanced analytics -- Create custom time compare (failed).png (1280x720)``` to fail? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] gbrian commented on issue #7971: Row Limit in Filter Box
gbrian commented on issue #7971: Row Limit in Filter Box
URL:
https://github.com/apache/incubator-superset/issues/7971#issuecomment-523923242
Currently hard coded
`config.get("FILTER_SELECT_ROW_LIMIT", 1)` will do the trick
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] jcoelho-pt commented on issue #7362: Pivot Table Field alias display problem
jcoelho-pt commented on issue #7362: Pivot Table Field alias display problem URL: https://github.com/apache/incubator-superset/issues/7362#issuecomment-523912353 @wushenchao what did you replaced? the chart? or the table? TThis issue affects all of my pivot tables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] jcoelho-pt edited a comment on issue #7362: Pivot Table Field alias display problem
jcoelho-pt edited a comment on issue #7362: Pivot Table Field alias display problem URL: https://github.com/apache/incubator-superset/issues/7362#issuecomment-523912353 @wushenchao what did you replaced? the chart? or the table? This issue affects all of my pivot tables. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7757: Update druid.rst
stale[bot] commented on issue #7757: Update druid.rst URL: https://github.com/apache/incubator-superset/pull/7757#issuecomment-523877934 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8094: Please add line-bar type graph to visualisations list
issue-label-bot[bot] commented on issue #8094: Please add line-bar type graph to visualisations list URL: https://github.com/apache/incubator-superset/issues/8094#issuecomment-523865165 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.99. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] rajat1428 opened a new issue #8094: Please add line-bar type graph to visualisations list
rajat1428 opened a new issue #8094: Please add line-bar type graph to visualisations list URL: https://github.com/apache/incubator-superset/issues/8094 Now a days a lot of visualisation happen on line-bar chart together in one chart. Please add this type of graph. Thanks in advance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #7657: fixed invalid function date_trunc when connecting to hive -- issue#7270
stale[bot] closed pull request #7657: fixed invalid function date_trunc when connecting to hive -- issue#7270 URL: https://github.com/apache/incubator-superset/pull/7657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] friendzis opened a new pull request #8093: Move Darwin-specific JS libs to optional
friendzis opened a new pull request #8093: Move Darwin-specific JS libs to optional URL: https://github.com/apache/incubator-superset/pull/8093 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [x] Build / Development Environment - [ ] Documentation ### SUMMARY fsevents is Darwin (OSX) specific library/wrapper. Build fails on non-darwin (e.g. linux) environments. Moved fsevents to optional dependencies which can be skipped with `--no-optional`, issuing a warning instead of error. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component
tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component URL: https://github.com/apache/incubator-superset/issues/8091#issuecomment-523826111 > Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.74. Please mark this comment with or to give our bot feedback! > > Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] pckhoi commented on issue #4691: superset db upgrade fails
pckhoi commented on issue #4691: superset db upgrade fails
URL:
https://github.com/apache/incubator-superset/issues/4691#issuecomment-523816482
@lilila very late answer to your original question but hope this will be
helpful to those who comes later. Your `alembic_version` table is probably
corrupted. In my case what I did was running `fabmanager create-db --app
superset` initially instead of `superset db upgrade`, which create the tables
but not the `alembic_version` table. To fix it I figured out the latest
migration and ran this in my database:
```
CREATE TABLE alembic_version (version_num character varying(32) PRIMARY KEY);
INSERT INTO alembic_version (version_num) VALUES ('d6ffdf31bdd4');
```
You'll have to replace the version_num with your own appropriate value of
course.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] pckhoi edited a comment on issue #4691: superset db upgrade fails
pckhoi edited a comment on issue #4691: superset db upgrade fails
URL:
https://github.com/apache/incubator-superset/issues/4691#issuecomment-523816482
@lilila very late answer to your original question but hope this will be
helpful to those who comes later. Your `alembic_version` table is probably
corrupted. In my case what I did was running `fabmanager create-db --app
superset` initially instead of `superset db upgrade`, which create the tables
but not the `alembic_version` table. To fix it I figured out the latest
migration and ran this in my database:
```
CREATE TABLE alembic_version (version_num character varying(32) PRIMARY KEY);
INSERT INTO alembic_version (version_num) VALUES ('d6ffdf31bdd4');
```
You'll have to replace the version_num with your own appropriate value of
course.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] aurelsaillant commented on issue #7416: feat: Scheduling queries from SQL Lab
aurelsaillant commented on issue #7416: feat: Scheduling queries from SQL Lab URL: https://github.com/apache/incubator-superset/pull/7416#issuecomment-523773849 Hello @ArgentFalcon, how did your checking go? Thanks again for your contribution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] andreaslordos commented on issue #7885: Fixed bug with importing maybe_box_datetimelike
andreaslordos commented on issue #7885: Fixed bug with importing maybe_box_datetimelike URL: https://github.com/apache/incubator-superset/pull/7885#issuecomment-523770454 @CerebralMastication yes, there is - edit `superset/dataframe.py` as I have done [here](https://github.com/apache/incubator-superset/pull/7885/files) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] uchihaabhijit opened a new issue #8092: Customize backend logic for visualizing superset graphs
uchihaabhijit opened a new issue #8092: Customize backend logic for visualizing superset graphs URL: https://github.com/apache/incubator-superset/issues/8092 Is there a way I can write some custom logics on my data coming from HIVE database and then visualizing the output in superset. My application demands writing some logics with libraries like numby/scipy and then doing some calculations. I am very new to superset. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8092: Customize backend logic for visualizing superset graphs
issue-label-bot[bot] commented on issue #8092: Customize backend logic for visualizing superset graphs URL: https://github.com/apache/incubator-superset/issues/8092#issuecomment-523761515 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.53. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
