[GitHub] [incubator-superset] kristw opened a new pull request #8258: refactor: use deck.gl plugins from npm package
kristw opened a new pull request #8258: refactor: use deck.gl plugins from npm package URL: https://github.com/apache/incubator-superset/pull/8258 ### CATEGORY Choose one - [X] Refactor ### SUMMARY `deck.gl` plugins are migrated to new repo `superset-ui-plugins-deckgl` and published as `npm` package. https://github.com/apache-superset/superset-ui-plugins-deckgl ### TEST PLAN Ran locally and verify that all deck.gl charts in the example look the same ### REVIEWERS @khtruong @mistercrunch @betodealmeida This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the
request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325986954
##
File path: superset/views/core.py
##
@@ -2594,16 +2594,16 @@ def validate_sql_json(self):
return json_error_response(f"{msg}")
@has_access_api
-@expose("/sql_json/", methods=["POST", "GET"])
+@expose("/sql_json/", methods=["POST"])
Review comment:
were we allowing `GET` for some caching reason? @betodealmeida might have
context
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the
request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325986612
##
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
don't we really want `stringify: false`? I was under the impression that
prevented us from sending up `"null"` and `"false"` versus `null` and `false`
And parseMethod determines how we parse the response, not the request
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
graceguo-supercat commented on a change in pull request #8256: [sql_json]
Ensuring the request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325979526
##
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
I saw this `stringify: false` setting is from PR #5896. @williaster is there
a special reason to turn off stringify?
if use stringify, do we still need `parseMethod: 'text'`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
graceguo-supercat commented on a change in pull request #8256: [sql_json]
Ensuring the request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325979526
##
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
I saw this `stringify: false` setting is from PR #5896. @williaster is there
a special reason to turn off stringify?
if use stringify, do we still need `parseMethod`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
graceguo-supercat commented on a change in pull request #8256: [sql_json]
Ensuring the request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325979526
##
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
I saw this stringify: false setting is from PR #5896. @williaster is there a
special reason to turn off stringify?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
graceguo-supercat commented on a change in pull request #8256: [sql_json]
Ensuring the request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325979526
##
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
I saw this `stringify: false` setting is from PR #5896. @williaster is there
a special reason to turn off stringify?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8257: Remove __row_id
betodealmeida merged pull request #8257: Remove __row_id URL: https://github.com/apache/incubator-superset/pull/8257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8257: Remove __row_id
codecov-io commented on issue #8257: Remove __row_id URL: https://github.com/apache/incubator-superset/pull/8257#issuecomment-532950293 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=h1) Report > Merging [#8257](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8257 +/- ## == - Coverage 65.67% 65.66% -0.01% == Files 481 481 Lines 2334923346 -3 Branches 2572 2572 == - Hits1533415331 -3 Misses 7877 7877 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8257/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.1% <ø> (-0.16%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=footer). Last update [799e08d...2ca4db5](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8257: Remove __row_id
codecov-io edited a comment on issue #8257: Remove __row_id URL: https://github.com/apache/incubator-superset/pull/8257#issuecomment-532950293 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=h1) Report > Merging [#8257](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8257 +/- ## == - Coverage 65.67% 65.66% -0.01% == Files 481 481 Lines 2334923346 -3 Branches 2572 2572 == - Hits1533415331 -3 Misses 7877 7877 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8257/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.1% <ø> (-0.16%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=footer). Last update [799e08d...2ca4db5](https://codecov.io/gh/apache/incubator-superset/pull/8257?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida opened a new pull request #8257: Remove __row_id
betodealmeida opened a new pull request #8257: Remove __row_id URL: https://github.com/apache/incubator-superset/pull/8257 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY For the `PRESTO_EXPAND_DATA` feature I added the functionality of printing the original row when unnesting arrays into rows, but this is breaking the SQL Lab to Explore flow. Let's rethink this. ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @khtruong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on issue #8219: Build better support for schema permissions
bkyryliuk commented on issue #8219: Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532933957 @mistercrunch , @john-bodley - it would be great if somebody could review this diff This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8219: [WIP] Build better support for schema permissions
codecov-io commented on issue #8219: [WIP] Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc) will **increase** coverage by `0.15%`. > The diff coverage is `95.5%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8219 +/- ## == + Coverage 65.67% 65.82% +0.15% == Files 481 481 Lines 2334923361 +12 Branches 2572 2572 == + Hits1533415378 +44 + Misses 7877 7845 -32 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `87.5% <100%> (+5.86%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.94% <100%> (-1%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.13% <100%> (+0.41%)` | :arrow_up: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `86.11% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.43% <100%> (+0.16%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.05% <100%> (+0.05%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.99% <100%> (+0.05%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `88.23% <100%> (+0.35%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.28% <100%> (+0.04%)` | :arrow_up: | | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `84.09% <92.59%> (+10%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=footer). Last update [799e08d...4c72837](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8219: [WIP] Build better support for schema permissions
codecov-io edited a comment on issue #8219: [WIP] Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc) will **increase** coverage by `0.15%`. > The diff coverage is `95.5%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8219 +/- ## == + Coverage 65.67% 65.82% +0.15% == Files 481 481 Lines 2334923361 +12 Branches 2572 2572 == + Hits1533415378 +44 + Misses 7877 7845 -32 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `87.5% <100%> (+5.86%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.94% <100%> (-1%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.13% <100%> (+0.41%)` | :arrow_up: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `86.11% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.43% <100%> (+0.16%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.05% <100%> (+0.05%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.99% <100%> (+0.05%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `88.23% <100%> (+0.35%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.28% <100%> (+0.04%)` | :arrow_up: | | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `84.09% <92.59%> (+10%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=footer). Last update [799e08d...4c72837](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8219: [WIP] Build better support for schema permissions
codecov-io edited a comment on issue #8219: [WIP] Build better support for schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/799e08d76f8489dc4a6a711d42f1f2b7308b6c67?src=pr&el=desc) will **increase** coverage by `0.15%`. > The diff coverage is `95.5%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8219 +/- ## == + Coverage 65.67% 65.82% +0.15% == Files 481 481 Lines 2334923361 +12 Branches 2572 2572 == + Hits1533415378 +44 + Misses 7877 7845 -32 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `87.5% <100%> (+5.86%)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.94% <100%> (-1%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.13% <100%> (+0.41%)` | :arrow_up: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `86.11% <100%> (ø)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.43% <100%> (+0.16%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.05% <100%> (+0.05%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.99% <100%> (+0.05%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `88.23% <100%> (+0.35%)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.28% <100%> (+0.04%)` | :arrow_up: | | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `84.09% <92.59%> (+10%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/8219/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=footer). Last update [799e08d...4c72837](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] zhaoyongjie commented on issue #8223: Fix sync failed when datasource is schema-less
zhaoyongjie commented on issue #8223: Fix sync failed when datasource is schema-less URL: https://github.com/apache/incubator-superset/pull/8223#issuecomment-532930394 please merge it, thanks a lot. @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8255: [sqllab] Make sure null schema is `None` and not `"null"`
serenajiang closed pull request #8255: [sqllab] Make sure null schema is `None` and not `"null"` URL: https://github.com/apache/incubator-superset/pull/8255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ramarnat commented on issue #8252: Sqlite TimeGrain not working
ramarnat commented on issue #8252: Sqlite TimeGrain not working URL: https://github.com/apache/incubator-superset/issues/8252#issuecomment-532910799 Time-series Bar Chart worked. Thank you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ramarnat commented on issue #8252: Sqlite TimeGrain not working
ramarnat commented on issue #8252: Sqlite TimeGrain not working URL: https://github.com/apache/incubator-superset/issues/8252#issuecomment-532909798 I can do that, but shouldnt this work for the bar chart as well? I am fairly sure this worked in an earlier version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on issue #8255: [sqllab] Make sure null schema is `None` and not `"null"`
john-bodley commented on issue #8255: [sqllab] Make sure null schema is `None` and not `"null"` URL: https://github.com/apache/incubator-superset/pull/8255#issuecomment-532908790 @serenajiang could we close this in favor of https://github.com/apache/incubator-superset/pull/8256. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] john-bodley opened a new pull request #8256: [sql_json] Ensuring the request body is JSON encoded
john-bodley opened a new pull request #8256: [sql_json] Ensuring the request
body is JSON encoded
URL: https://github.com/apache/incubator-superset/pull/8256
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Somewhat of a yak-shaving PR as the intent was to fix an issue where Hive
queries failed in SQL Lab if no schema was selected,
The error is coming from
[here](https://github.com/dropbox/PyHive/blob/master/pyhive/hive.py#L205) in
PyHive where it seems that the schema (database) is being defined via the
`"null"` string as opposed to `None`.
The root cause of this is in the front-end the `SupersetClient` has passing
the data as form data (using the `multipart/form-data` Content-Type header)
which was then being processed in Flask via
[`response.form`](https://flask.palletsprojects.com/en/1.1.x/api/#flask.Request.form).
This meant everything was being encoded as strings, i.e., hence why we had
logic like,
```
request.form.get("runAsync") == "true"
```
and why `null` was being encoded as `"null"` as opposed to `None`. The fix
was to:
1. Ensure that the front-end correctly encodes the body as JSON (and sets
the appropriate headers).
2. Use
[`response.json`](https://flask.palletsprojects.com/en/1.1.x/api/#flask.Request.json)
to correctly process the response.
3. Remove the obsolete `GET` method to `sql_json`.
4. For testing use the somewhat misnamed `json` argument to Flask's test
`client.post(...)` method which is actually a Python dictionary (ironically the
`data` argument can be a JSON string) and removes the need to specify the
Content-Type header (which is needed for `response.json` otherwise we would
need to use `response.get_json(force=True)` which seems a little heavy handed).
### TEST PLAN
CI.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @etr2460 @graceguo-supercat @williaster
cc: @mistercrunch @villebro
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #8250: Update another pypi case from superset to apache-superset
etr2460 merged pull request #8250: Update another pypi case from superset to apache-superset URL: https://github.com/apache/incubator-superset/pull/8250 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8255: [sqllab] Make sure null schema is `None` and not `"null"`
serenajiang opened a new pull request #8255: [sqllab] Make sure null schema is `None` and not `"null"` URL: https://github.com/apache/incubator-superset/pull/8255 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY A null schema in the request form is interpreted as the string `"null"` rather than actual `null`, resulting in `/sql_json/` returning a response containing "null". This causes problems. These problems can be better explained by @john-bodley. Just a one line change to make sure `"null"` is translated into Python `None`. ### TEST PLAN Ran query locally that previously returned a `"null"` schema. Confirmed it is now `null`. ### REVIEWERS @john-bodley @graceguo-supercat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk opened a new pull request #8254: WIP. Avoid circular dependency between superset config and superset package
bkyryliuk opened a new pull request #8254: WIP. Avoid circular dependency between superset config and superset package URL: https://github.com/apache/incubator-superset/pull/8254 ### CATEGORY Choose one - [X] Bug Fix ### SUMMARY Small refactor to avoid circular dependency between superset config and superset package. Current code doesn't support adding custom security manager as importing SupersetSecurityManager calls __init__.py that initializes the config. ### TEST PLAN * local testing + testing in DBX environment ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #7905: Filter box 1 value = Filter box 2 value (same fields in different datasources)
stale[bot] commented on issue #7905: Filter box 1 value = Filter box 2 value (same fields in different datasources) URL: https://github.com/apache/incubator-superset/issues/7905#issuecomment-532888173 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8244: docs: reflect the pypi move from superset to apache-superset
mistercrunch merged pull request #8244: docs: reflect the pypi move from superset to apache-superset URL: https://github.com/apache/incubator-superset/pull/8244 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] rubypollev commented on issue #8183: How to pass time filters to SQL Lab queries
rubypollev commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-532879881 That's a nice way of providing separation between the datasource SQL and the visual query builder's additional filtering / grouping. For databases that support CTE it'd make sense. I don't see how this along would solve the issue of propagating human-readable date filters to SQL. You'd still need to access a utility to transform `__time_range` from the form data in the query predicate. Am I missing something? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries
villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-532875347 Ok, so I was thinking the following. Say you have a join as follows: ```sql SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id ``` normally Superset would push this into a subquery and perform filtering/grouping/etc on that as follows: ```sql SELECT dte, count(*) AS "count(*)" FROM (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) AS expr_qry WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' GROUP BY dte ``` Some engines will not perform predicate pushdown into the subquery, resulting in unnecessarily expensive queries when materializing the subquery. To get around this I would propose wrapping the original query in a CTE: ```sql WITH cte_qry AS (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) SELECT dte, count(*) AS "count(*)" FROM cte_qry GROUP BY dte WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' ``` Mind you, the majority of modern SQL engines treat subqueries and CTEs equally, i.e. will not impose a performance penalty on the query, but this may not always be the case. Also, some engines don't support wrapping CTEs in subqueries, causing any CTEs to fail when wrapped in a subquery. Especially for CTEs it would be more preferable to wrap the final query of the CTE in a CTE of it's own, and then let Superset build a query on that. Say, for example, that you would write the following query in Sql Lab: ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl) SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a This would then become ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl), cte_qry AS (SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a) SELECT a, count(*) AS "count(*)" FROM cte_qry GROUP BY a ``` when Superset constructs a query, as opposed to the current behaviour of wrapping the CTE in a subquery, which fails on at least some versions MSSQL. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries
villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-532875347 Ok, so I was thinking the following. Say you have a join as follows: ```sql SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id ``` normally Superset would push this into a subquery and perform filtering/grouping/etc on that as follows: ```sql SELECT dte, count(*) AS "count(*)" FROM (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) AS expr_qry WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' GROUP BY dte ``` Some engines will not perform predicate pushdown into the subquery, resulting in unnecessarily expensive queries when materializing the subquery. To get around this I would propose wrapping the original query in a CTE: ```sql WITH cte_qry AS (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) SELECT dte, count(*) AS "count(*)" FROM cte_qry GROUP BY dte WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' ``` Mind you, the majority of modern SQL engines treat subqueries and CTEs equally, i.e. will not impose a performance penalty on the query, but this may not always be the case. Also, some engines don't support wrapping CTEs in subqueries, causing any CTEs to fail when wrapped in a subquery. Especially for CTEs it would be more preferable to wrap the final query of the CTE in a CTE of it's own, and then let Superset build a query on that. Say, for example, that you would write the following query in Sql Lab: ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl) SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a This would then become ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl), cte_qry AS (SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a) SELECT a, count(*) AS "count(*)" FROM cte_qry GROUP BY a ``` when Superset constructs a query, as opposed to the current behaviour of wrapping the CTE in a subquery. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8183: How to pass time filters to SQL Lab queries
villebro commented on issue #8183: How to pass time filters to SQL Lab queries URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-532875347 Ok, so I was thinking the following. Say you have a join as follows: ```sql SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id ``` normally Superset would push this into a subquery and perform filtering/grouping/etc on that as follows: ```sql SELECT dte, count(*) AS "count(*)" FROM (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) AS expr_qry WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' GROUP BY dte ``` Some engines will not push the where clause into the subquery, resulting in unnecessarily expensive queries when materializing the subquery. To get around this I would propose wrapping the original query in a CTE: ```sql WITH cte_qry AS (SELECT fo.dte, fc.id, fc.name, fo.product FROM fact_customer fc INNER JOIN fact_orders fo ON fc.id = fo.customer_id) SELECT dte, count(*) AS "count(*)" FROM cte_qry GROUP BY dte WHERE dte >= '2019-01-01' AND dte <= '2019-12-31' ``` Mind you, the majority of modern SQL engines treat subqueries and CTEs equally, i.e. will not impose a performance penalty on the query, but this may not always be the case. Also, some engines don't support wrapping CTEs in subqueries, causing any CTEs to fail when wrapped in a subquery. Especially for CTEs it would be more preferable to wrap the final query of the CTE in a CTE of it's own, and then let Superset build a query on that. Say, for example, that you would write the following query in Sql Lab: ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl) SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a This would then become ```sql WITH a AS (SELECT 1 AS a FROM tbl), b AS (SELECT 1 AS a, 'a' AS b FROM tbl), cte_qry AS (SELECT a.a, b.b FROM a INNER JOIN b ON a.a = b.a) SELECT a, count(*) AS "count(*)" FROM cte_qry GROUP BY a ``` when Superset constructs a query, as opposed to the current behaviour of wrapping the CTE in a subquery. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8253: Fix array casting
betodealmeida commented on issue #8253: Fix array casting
URL:
https://github.com/apache/incubator-superset/pull/8253#issuecomment-532874901
> what are the cases where they would not be the same type? is that
suggestive of a bigger issue?
>
> otherwise, LGTM
@DiggidyDave, we're casting the results from the DB — a list of tuples —
into a Numpy array so we can address each column efficiently:
```python
>>> data = [("a", 1), ("b", 10)]
>>> np.array(data)
array([['a', '1'],
['b', '10']], dtype='>> np.array(data)[:,0] # first column
array(['a', 'b'], dtype='>> np.array(data)[:,1] # second column
array(['1', '10'], dtype='>> np.array(data, dtype='object')
array([['a', 1],
['b', 10]], dtype=object)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #8224: [sqllab] create query slightly earlier
etr2460 merged pull request #8224: [sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8201: How to use “email report”?
villebro commented on issue #8201: How to use “email report”? URL: https://github.com/apache/incubator-superset/issues/8201#issuecomment-532865932 I am unable to reproduce the error locally on admin account on master; have you tried this on either 0.34 or master and followed the upgrade instructions? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] DiggidyDave commented on issue #8253: Fix array casting
DiggidyDave commented on issue #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253#issuecomment-532862459 what are the cases where they would not be the same type? is that suggestive of a bigger issue? otherwise, LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table
villebro commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-532859162 I had this same problem a while ago; started out of nowhere. I was able to resolve it by clearing my browser cache (apparently something bad was caught in localStorage). Please clear your cache to see if that fixes the problem. However, beware that this will also clear your SqlLab tabs! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8253: Fix array casting
codecov-io edited a comment on issue #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253#issuecomment-532858185 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=h1) Report > Merging [#8253](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/12fb8e70cce262d8936ff686b6b746494f55fdb3?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#8253 +/- ## === Coverage 65.68% 65.68% === Files 481 481 Lines 2334823348 Branches 2572 2572 === Hits1533515335 Misses 7875 7875 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=footer). Last update [12fb8e7...02f51d4](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8253: Fix array casting
codecov-io edited a comment on issue #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253#issuecomment-532858185 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=h1) Report > Merging [#8253](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/12fb8e70cce262d8936ff686b6b746494f55fdb3?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#8253 +/- ## === Coverage 65.68% 65.68% === Files 481 481 Lines 2334823348 Branches 2572 2572 === Hits1533515335 Misses 7875 7875 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=footer). Last update [12fb8e7...02f51d4](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8253: Fix array casting
codecov-io commented on issue #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253#issuecomment-532858185 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=h1) Report > Merging [#8253](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/12fb8e70cce262d8936ff686b6b746494f55fdb3?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#8253 +/- ## === Coverage 65.68% 65.68% === Files 481 481 Lines 2334823348 Branches 2572 2572 === Hits1533515335 Misses 7875 7875 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8253/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=footer). Last update [12fb8e7...02f51d4](https://codecov.io/gh/apache/incubator-superset/pull/8253?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8249: Unable to display data table in sqlite?
villebro commented on issue #8249: Unable to display data table in sqlite? URL: https://github.com/apache/incubator-superset/issues/8249#issuecomment-532858007 This issue refers to an old version of Superset (also deprecated version of Python); please try the most recent official release (0.34) and reopen if the issue persists. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro closed issue #8249: Unable to display data table in sqlite?
villebro closed issue #8249: Unable to display data table in sqlite? URL: https://github.com/apache/incubator-superset/issues/8249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8252: Sqlite TimeGrain not working
villebro commented on issue #8252: Sqlite TimeGrain not working URL: https://github.com/apache/incubator-superset/issues/8252#issuecomment-532857159 I think you want to use a "Time-series Bar Chart" for this, not "Bar Chart". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-532856220 Ping @graceguo-supercat @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8253: Fix array casting
betodealmeida merged pull request #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida opened a new pull request #8253: Fix array casting
betodealmeida opened a new pull request #8253: Fix array casting URL: https://github.com/apache/incubator-superset/pull/8253 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY The fix introduced in https://github.com/apache/incubator-superset/pull/8226 is not working for some types. We have a query returning the following error: > ### TEST PLAN Query now runs successfully. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @khtruong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8243: Show Presto views as views, not tables
betodealmeida merged pull request #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #8251: Small fix for Presto dtype map
betodealmeida merged pull request #8251: Small fix for Presto dtype map URL: https://github.com/apache/incubator-superset/pull/8251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8243: Show Presto views as views, not tables
codecov-io edited a comment on issue #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243#issuecomment-532478701 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=h1) Report > Merging [#8243](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/88777943faf468df7b2c38fc5f5117a5c0ad8cc3?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `42.1%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8243 +/- ## == - Coverage 65.72% 65.68% -0.05% == Files 481 481 Lines 2331723348 +31 Branches 2572 2572 == + Hits1532615335 +9 - Misses 7853 7875 +22 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `77.69% <ø> (ø)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <ø> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.36% <0%> (-0.05%)` | :arrow_down: | | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.26% <28%> (-2.12%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.54% <66.66%> (-3.01%)` | :arrow_down: | | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `70.96% <75%> (-1.45%)` | :arrow_down: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.38% <80%> (-0.24%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8243/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.71% <0%> (+0.04%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=footer). Last update [8877794...ec6b252](https://codecov.io/gh/apache/incubator-superset/pull/8243?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Shamnadh commented on issue #7143: Error intializing superset after installation
Shamnadh commented on issue #7143: Error intializing superset after installation URL: https://github.com/apache/incubator-superset/issues/7143#issuecomment-532817828 > I got the same error. I tried following steps > > 1. `pip install sqlalchemy==1.2.18` > 2. `superset db upgrade` > > It worked like charm. Tried this and still getting the error 2019-09-18 18:48:21,012:ERROR:flask_appbuilder.security.sqla.manager:DB Creation and initialization failed: (sqlite3.OperationalError) unable to open database file (Background on this error at: http://sqlalche.me/e/e3q8) someone got any solutions ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8220: [sqllab] use celery worker for stop_query
serenajiang closed pull request #8220: [sqllab] use celery worker for stop_query URL: https://github.com/apache/incubator-superset/pull/8220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8220: [sqllab] use celery worker for stop_query
serenajiang opened a new pull request #8220: [sqllab] use celery worker for stop_query URL: https://github.com/apache/incubator-superset/pull/8220 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY #8139 introduced retries for `stop_query` because of lock timeout issues. This turned out to be problematic because users now have to wait a few seconds after clicking "stop_query" before receiving a message that stopping the query failed. So now, if a celery worker is available, we run stop_query on a celery worker so that users immediately get a response and don't have to wait for the query to stop. Doesn't actually fix the errors, but at least now users won't see them. ### TEST PLAN Checked whether `stop_query` worked as expected locally. Threw some fake exceptions to make sure retries still worked. Confirmed that `stop_query` works whether or not a celery worker is available. ### REVIEWERS @graceguo-supercat @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8252: Sqlite TimeGrain not working
issue-label-bot[bot] commented on issue #8252: Sqlite TimeGrain not working URL: https://github.com/apache/incubator-superset/issues/8252#issuecomment-532811221 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.89. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ramarnat opened a new issue #8252: Sqlite TimeGrain not working
ramarnat opened a new issue #8252: Sqlite TimeGrain not working
URL: https://github.com/apache/incubator-superset/issues/8252
Using SQLite, the bar graph is not setting the timegrain to month
### Expected results
The graph should show by month, `__timestamp` should show in SQL
### Actual results
The Graph does not show by month, The sql does not show `__timestamp`
conversion
Screenshots
https://user-images.githubusercontent.com/88762/65175440-df334a80-da20-11e9-9536-38ccd158a5b0.png";>
How to reproduce the bug
Create a bar graph with a timegrain of Month
### Environment
- superset version: `0.34.0`
- python version: `Python 3.6.9`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] nmits commented on issue #8241: Superset fails to build JSON (specifically with producing label colors) for very large sets of data
nmits commented on issue #8241: Superset fails to build JSON (specifically with
producing label colors) for very large sets of data
URL:
https://github.com/apache/incubator-superset/issues/8241#issuecomment-532806561
I don't see a reason for it to build lists of colors over a certain size, as
specifying colors for that many things intentionally would seem unlikely as the
list would be over ~2500 items (Assuming `".{10}": "#00",` so 24 character
average size, 65530/24 = 2730.416) and each slice would be 0.15 degrees
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8243: Show Presto views as views, not tables
betodealmeida commented on a change in pull request #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243#discussion_r325824786 ## File path: superset/db_engine_specs/base.py ## @@ -538,7 +538,9 @@ def get_schema_names(cls, inspector: Inspector) -> List[str]: return sorted(inspector.get_schema_names()) @classmethod -def get_table_names(cls, inspector: Inspector, schema: Optional[str]) -> List[str]: +def get_table_names( +cls, database, inspector: Inspector, schema: Optional[str] Review comment: Will do! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida opened a new pull request #8251: Small fix for Presto dtype map
betodealmeida opened a new pull request #8251: Small fix for Presto dtype map URL: https://github.com/apache/incubator-superset/pull/8251 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Pandas doesn't recognize the `timedelta64` dtype, instead we need to use `timedelta64[ns]`. When querying a Presto table I'm getting the error: > The 'datetime64' dtype has no unit. Please pass in 'datetime64[ns]' instead. This PR fixes it. ### TEST PLAN Added unit test. Tested with real data, now it works. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @khtruong This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Thoris commented on issue #6463: how to connect to HiveServer2 with ssl?
Thoris commented on issue #6463: how to connect to HiveServer2 with ssl? URL: https://github.com/apache/incubator-superset/issues/6463#issuecomment-532794643 Hello all, does anybody know the solution? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 opened a new pull request #8250: Update another pypi case from superset to apache-superset
etr2460 opened a new pull request #8250: Update another pypi case from superset to apache-superset URL: https://github.com/apache/incubator-superset/pull/8250 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [x] Documentation ### SUMMARY Updates the link in the readme to the correct pypi package ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] khtruong commented on a change in pull request #8243: Show Presto views as views, not tables
khtruong commented on a change in pull request #8243: Show Presto views as views, not tables URL: https://github.com/apache/incubator-superset/pull/8243#discussion_r325788898 ## File path: superset/db_engine_specs/base.py ## @@ -538,7 +538,9 @@ def get_schema_names(cls, inspector: Inspector) -> List[str]: return sorted(inspector.get_schema_names()) @classmethod -def get_table_names(cls, inspector: Inspector, schema: Optional[str]) -> List[str]: +def get_table_names( +cls, database, inspector: Inspector, schema: Optional[str] Review comment: nit: can we add a type for database? comment applies elsewhere This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8246: Update README.md
codecov-io commented on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8246: Update README.md
codecov-io edited a comment on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532765254 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=h1) Report > Merging [#8246](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0cd4ef54f884e77cd4c5a810f10697b33e9f6e56?src=pr&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#8246 +/- ## == + Coverage 65.58% 65.73% +0.14% == Files 481 481 Lines 2331923319 Branches 2572 2572 == + Hits1529415328 +34 + Misses 7887 7853 -34 Partials 138 138 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.41% <0%> (+0.21%)` | :arrow_up: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.93% <0%> (+0.63%)` | :arrow_up: | | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+1.57%)` | :arrow_up: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/8246/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.15% <0%> (+49.01%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=footer). Last update [0cd4ef5...c18e51e](https://codecov.io/gh/apache/incubator-superset/pull/8246?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8190: WordCloud font-size set to 0px when displaying single value
villebro commented on issue #8190: WordCloud font-size set to 0px when displaying single value URL: https://github.com/apache/incubator-superset/issues/8190#issuecomment-532763000 Hmm, perhaps we should raise an Exception if a metric is not numeric. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed issue #8247: Explore Button not working
mistercrunch closed issue #8247: Explore Button not working URL: https://github.com/apache/incubator-superset/issues/8247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8247: Explore Button not working
mistercrunch commented on issue #8247: Explore Button not working URL: https://github.com/apache/incubator-superset/issues/8247#issuecomment-532747810 Please reopen if you can reproduce on `0.34.0` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #8246: Update README.md
mistercrunch commented on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532731980 Welcome aboard! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8246: Update README.md
mistercrunch merged pull request #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells
davidhassan commented on issue #8236: Pivot Table Conditional Formatting on Cells - Add Colour to Cells URL: https://github.com/apache/incubator-superset/issues/8236#issuecomment-532686209 How do I use it? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table
dpgaspar commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-532681679 Hi @CyrilLeMat, Are your queries async? Can you post your server logs, when the error occurs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sreedharmb removed a comment on issue #7739: Custom OAuth issue
sreedharmb removed a comment on issue #7739: Custom OAuth issue URL: https://github.com/apache/incubator-superset/issues/7739#issuecomment-532661390 I'm still getting this issue with the latest code in master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] sreedharmb commented on issue #7739: Custom OAuth issue
sreedharmb commented on issue #7739: Custom OAuth issue URL: https://github.com/apache/incubator-superset/issues/7739#issuecomment-532661390 I'm still getting this issue with the latest code in master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] LoveMyBaby opened a new issue #8249: Unable to display data table in sqlite?
LoveMyBaby opened a new issue #8249: Unable to display data table in sqlite? URL: https://github.com/apache/incubator-superset/issues/8249 I have successfully installed superset in docker mode, and the example data is also loaded successfully. When I add local sqlite for testing, it can't display the specific table name in sql lab. - superset version: `0.28.0` - python version: `2.7.5` - node.js version: `10.16.3` - npm version: `6.9.0` ### Checklist - [ √] I have checked the superset logs for python stacktraces and included it here as text if there are any. - [ √] I have reproduced the issue with at least the latest released version of superset. - [ √] I have checked the issue tracker for the same issue and I haven't found one similar. ### Additional context 1. add datasource: Test Connection: ok expose in SQL Lab: selected No data table displayed ! 2. View In SQL Lab Editor: schema: main(only) see table schema(0 in main) 3. View database by sqlite3 in Centos7: display table This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8249: Unable to display data table in sqlite?
issue-label-bot[bot] commented on issue #8249: Unable to display data table in sqlite? URL: https://github.com/apache/incubator-superset/issues/8249#issuecomment-532642103 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.86. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table
issue-label-bot[bot] commented on issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table URL: https://github.com/apache/incubator-superset/issues/8248#issuecomment-532634696 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] CyrilLeMat opened a new issue #8248: SQL Lab doesn't display queries results but rather 'offline' followed by an empty table
CyrilLeMat opened a new issue #8248: SQL Lab doesn't display queries results
but rather 'offline' followed by an empty table
URL: https://github.com/apache/incubator-superset/issues/8248
Since the 0.34 version, SQL Lab doesn't display queries results but rather
'offline' followed by an empty table
### Expected results
When running a query in the sql lab, we should see the 'running' icon
temporarily and then have the results displayed in the tab
### Actual results
After a short display of the 'running' icon, a red 'offline' label is
displayed.
Once the data is loaded, an empty table is displayed (we have the columns
but no rows).
However:
- This bug is not systemic every few calls we have the expected display
- If I click on "Query History" and then on "Results", the rows are displayed
Screenshots
How to reproduce the bug
1. Go to SQL Lab
2. Choose a Database (Here we only use Postgresql Databases)
3. Click on "Run Query"
### Environment
- superset version: 0.34
- python version: 3.6.6
### Checklist
- [ x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x ] I have reproduced the issue with at least the latest released version
of superset.
- [x ] I have checked the issue tracker for the same issue and I haven't
found one similar.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8247: Explore Button not working
issue-label-bot[bot] commented on issue #8247: Explore Button not working URL: https://github.com/apache/incubator-superset/issues/8247#issuecomment-532598568 Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.92. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] syafiqdante opened a new issue #8247: Explore Button not working
syafiqdante opened a new issue #8247: Explore Button not working
URL: https://github.com/apache/incubator-superset/issues/8247
Hello, I quite new with superset.
It seems like the 'explore' button having error
### Expected results
Visualize the chart data from query
### Actual results
Nothing happens, with only error shown in the Chrome console log
Screenshots
How to reproduce the bug
1. Go to 'Sql Editor'
2. Click on 'Explore' button
3. See error in Chrome browser console
### Environment
(please complete the following information):
- superset version: `superset==0.29.0rc7`
- python version: `Python 3.6.8`
- node.js version: `v10.16.0`
- npm version: `6.9.0`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included
it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version
of superset.
- [x] I have checked the issue tracker for the same issue and I haven't
found one similar.
### Additional context
The issue might have similarity to
https://github.com/apache/incubator-superset/issues/6557
but I did not setup druid for superset.
Please help, Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] MaiTiano opened a new pull request #8246: Update README.md
MaiTiano opened a new pull request #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TEST PLAN ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] request-info[bot] commented on issue #8246: Update README.md
request-info[bot] commented on issue #8246: Update README.md URL: https://github.com/apache/incubator-superset/pull/8246#issuecomment-532590440 We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kalimuthu123 opened a new issue #8245: New visualisation Collapse and expand table
kalimuthu123 opened a new issue #8245: New visualisation Collapse and expand table URL: https://github.com/apache/incubator-superset/issues/8245 **Is your feature request related to a problem? Please describe.** i am having a requirement of using collapse and expand chart **Describe the solution you'd like** i want to align the chart under the drilldown **Describe alternatives you've considered** data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wCEAAkGBxIQEBAQERMWFhAVERUXFRURGBgVEBAQFRUWFxcVFRcYHSggGBolHhUVITEhJiorLi8uGB8/OD8tNyotLisBCgoKDg0OFxAQFy0dHx0tLS0tLS0tLS0tLS0tLS0tLS0tLS03Ly0tLS0tLS0tLS0tNS0tLS0tLS0tLSstLS0tLf/AABEIAL8BBwMBIgACEQEDEQH/xAAbAAABBQEBAQIDBAUGB//EAEUQAAIBAgIIBAMGBAIIBwEAAAECEQADEiEEBRMiMVFhoUGBkdEGMrEXI0JTcZIVM1JyFGIHNDV0grPB4SRDc7LC8PEW/8QAGQEBAQEBAQEAAAECAwQF/8QAKREBAAEEAQIEBgMAAAECAxFSFBMhEjFBcSIjMkKx0QRRkf/aAAwDAQACEQMRAD8A9uuPFM23TvS3/DzqOgftunejbdO9NiiDQO23TvRtunemwaINA7bdO9G26d6bBog0Dtt070bbp3pkUsUDtt070bbp3psGiDQO23TvRtunemwaINA7bdO9G26d6bFEUDtt070bbp3psGiDQO23TvRtunemwaINA7bdO9G26d6bBog0Dtt070bbp3psURQO23TvRtunemwaINA7bdO9G26d6bBog0Dtt070bbp3psURQO23TvRtunemxSUD9t070tR0UEl/w86YKff8POmDjQeC3HLksxlmMknMknxJot28RCqJYkAACSWJgADxNIK0/wCKg3tGum2FFk2pCcWFtgTE/pkK+/5R2h8HznvLPv6M1sgOhUnhiEEjzqLLpW5o2tbdsXgMR2iFRht2rWzMNDgKSCwxROWRbPhGpd+I7SX2b7y4BcJV5/CWQ7NQGEpuGJ8WO6a5eOqPtdIpp2cfl0p9yyVJVlIYcQRBHjwNdEfiFCMMOAFAUiMVo7K4hZBORl1Pl4ZVka30sXr9y6JhiPmjFkoEmMpyrdM1TOJpwzVERHarLa+Kr7NomrAzEg2HJkzLDAATzMVzGEcq6P4l/wBU1V/u9z6pWAHGEjCCT+I4sS/pBj1BrNmPg8vWfy1en4v8/BzaG4QXDbYWzwcqQhmYziPA+lNXR2KlwhKDiwBKjhxPAfMvqOda1jWlpbi3itwuEtqVBAtjAoXED+L5QQpAAPiYFXbHxHbUYWW42SgvIFxyux32g8fuj48s/GpNdcfakU0+tTl8ulGXSur0jX9trZYY5Jwm3lFz/wAOtvE8sxwzmM2Mjzpt34lQ4yFfG0SxE4wNpuFS5AXfHMTOQyAdSvRZop2YWqXK37DKYO1TMZH5hWl8cOW0/SJM4WUCfwrgUwOQkn1rL1d/Os/+rb/94rS+NP8AaGlf3r/y0qzHzY9v0mflz7/tiQKmvaE6AM9tlBiCykAzmONTXNNmwlnAu67tjzxHEEH/AMPpw8dJdcWxeF6CYQA2zatqHi0EKvcBLMhjMEcPKtVTVHlSzERPqwMulGXSuqu6+tgW9668rMEgbN9teYNusJeGUEAjI8R4Jc+JUxNuMUYksjRhc7KwgxZmc7THOfm51nx1aN+CnZzJtGFOHJvlMZMJIy55gjyqVtBuDHNtxgMPKkYDx3ssvOtXSdcI96xdIuOLSt/NiWfHcuIDB+UFlH6A1Ld1+j2bilCLty2FYr8hKgqrbzFvlwgzyp4q+2KU8NPf4ifAbldYaOAYDbQMBwYbJzB55gHyrG05y924zGWLsSTmSZNa/wADf7R0X+65/wAm5WNpPzv/AHt9TSIjqz7QszPTj3NtWC7BVUsx4BRJPjwFF6wUbA6lWy3WENnmMjVvRNLVWeVwo9pkOzmVBg4hjYzmBInMTwq/Z1vbS3s1F0gBhvEEXsVsKNoJ3QpBKgTHetVTVHlSzTET5yxb+jm2cLqVbk4wniRwPUEeVR5dK6vSfiW0+13LgxrcXM5b+LCSAwAjFnkTyiM3aX8RW9rdE3HQvc3sgXRnJCKwYFUA4HMZmV4RiLlejU0U7OTgdKn/AMBckjZPIUMRhMhSJDHLgR41p6y1rbvtZxK2zV5ZAACqQgKIZOW6eXhlVy38TKwZrluLrB1m38mAlmUbzTkXfpBHCKs1V4zFKRTTnvUy/hpyumaKVME37YMZSrOAR+hBNe014p8Pf63on+82f+Yte114v531R7Pd/C+mXhe1Jf8ADzqOpL44VH5H0NBxdz/R3ZJJW84WchCmBynxpv2dWvz3/atdt5H0NHkfQ135N3Zw41rVxP2dWvz3/atH2dWvz3/atdt5H0NHkfQ05N3Y41rVxP2dWvz3/atH2dWvz3/atdt5H0NHkfQ05N3Y41rVzmtPhC1ftaPaxuuwUqrCCWUxOIc5AOVZn2dWvz3/AGrXbeR9DR5H0NSm/cpjESs2Lc95hxP2dWvz3/avvR9nVr89/wBq+9dt5H0NHkfQ1eTd2TjWtXE/Z1a/Pf8AatH2dWvz3/atdt5H0NHkfQ05N3Y41rVx2if6P7Vu4jm87BWDYYUSVMgE8sqsa6+CrWk33v7V0Z4LAAESABInhkBXU+R9DR5H0NTr3M5yvQt4xhxP2dWvz3/atH2dWvz3/atdt5H0NHkfQ1eTd2TjWtXE/Z1a/Pf9q0fZ1a/Pf9q123kfQ0eR9DTk3djjWtXE/Z1a/Pf9q0fZ1a/Pf9q123kfQ0eR9DTk3djjWv6cxqP4LtaLfS+LjuyYsIIAALKVJMcciaqaR/o9tM7MLzgFiYhThkzE12XkfQ0eR9DU69zOc916FvGMOJ+zq1+e/wC1aPs6tfnv+1feu28j6GjyPoavJu7JxrWrifs6tfnv+1aPs6tfnv8AtWu28j6GjyPoacm7sca1q4n7OrX57/tX3o+zq1+e/wC1a7byPoaPI+hpybuxxrWrktW/Alqzet3dq7YHDBYABZTIk8piuto8j6GjyPoa513Kq+9U5dKKKaO1MCijyPoaKw2s0Uy5+tMz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2oz5/T2oJqKhz5/T2paB71m690xrOj3biAG4FhAcRBuMQq5KCTmRlHpWjcNRkjpQUdQ6Y9/R7d1wAXxMIDAYCxwfMoPy4fCtCmgjpS4hQLRSYhRiFAtcl8U/EV/Rb1wKoNldFViYlrd65cuJbZh4oSgU8iwPCY6zEKaQOn/AGoOV/8A65nuXrVpLTst1EQ7VgpLPdRhcGDEjKbRyg8RGUGqrfHThbROjrNzZssXctnctLcVcTKBtN4jDwy412kLyHbjRhXkPDl4cKB1LSSKMQoFopMQoxCg5C/8SXE0m+m1tvs9IKf4VVH+JNkaOt03AQ08SeKx50mi/Gpe3o1xrdpVu3jbYm8CMtnGzVQWuE7QiIyK5wCDXXALM5TzymgKuWQy4cMj0oS5mx8UPcOFEslzpK2gu1Je2DtZ2wCfdv8AdThzmaq6D8Y3LmxQJaL3LNtgGuHal7llrgOBUztgqAWHPhXYQOnGfPn+tRWtFtq73FUB3w4jPHCIEDgMuVBydr4xcWUuMLJZksks13BowL2WuEY8JIJK4QM88q0dW/Eb3tJNo2QtrabMMXO2Fw6JZ0mGTDAEXSvzcRW/hXhAjyinZccv+9AtLSYhRiFAtFJiFGIUC0UmIUYhQLRSYhRiFAtFJiFGIUC0UmIUYhQLRSYhRQSkUhA6U6s7WmhNdSMjF206jNYCXFY4jO8YB8KDQwjlRhHKgUtAmEcqMI5UtFAmEcqYzKMiQD1ipDWPpeiMdJF0KxXAg3Nic1dycW0Egbw+U8+lQawA6UYRyrmdG1TpKoVxsDgVVwXMNsLgRSsDMNiDGRHHjnFT3NWXwN13wl2LAXGLtb2lwoqljukKyeI+WDQb5A6UQOlc5e1TeKuCztIC711t5RYtjgIUHaITIA4nma1dM0Qvc0a4B/LuEmTwQ2ri8OBMstUX8I5UYRypaQ0CADpRhHKsq7ZuxeRVIxXQ4YMFDJuYkBBxKxCsJjx4jjVRtXaRvHG/BIUXCWFsXbrMgJMYsJtjEeOGJ8aDoMI6UQOlc8+qr5B+8uYoIWbrA/yAonCQJ2gmYqbW9i4btlgHZCVVltuUJhbpMkEQJw+I8KDbgchRA5CsBNB0pTOIsRsSxLkYyjWi4tiQACFuSGAzPGCYYNVaQV3nfFH4brgfySBwI/8AMgz0oOiIHSiB0rH1roV24bcSQDZPzlVRkvI7swHzyq5DPMeEk1UfVmkHZmTKlS03CSzBLi3HRuKB8SgARHGBQdHA6UhjpWZqzQ7iuz3C2HBCKXZsM3brQwmCQjWxOfDiYms9tVXzhDYiq
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8245: New visualisation Collapse and expand table
issue-label-bot[bot] commented on issue #8245: New visualisation Collapse and expand table URL: https://github.com/apache/incubator-superset/issues/8245#issuecomment-532589259 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.76. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
