[GitHub] gavinju commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType

2018-05-16 Thread GitBox
gavinju commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType URL: https://github.com/apache/incubator-superset/issues/5010#issuecomment-389550176 OKļ¼ŒThank you for your help,

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389522281 @TianyangLi I have tried with sudo apt-get install python-mysqldb, but still no success in Ubuntu either

[GitHub] AbdealiJK opened a new issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors

2018-05-15 Thread GitBox
AbdealiJK opened a new issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors URL: https://github.com/apache/incubator-superset/issues/5005 Make sure these boxes are checked before submitting your issue - thank you! - [X] I have checked the superset logs for python stacktraces

[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389476460 @miloradkrstevski assuming your language of choice is python you need a python driver for mysql as superset uses

[GitHub] xrmx commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
xrmx commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389513748 @miloradkrstevski if you had read the documentation you'll have see that 1) windows is not supported, 2) the docs

[GitHub] qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3

2018-05-16 Thread GitBox
qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389486609 @mistercrunch I'd like to ask for this to be reopened. Our use case is showing query results from today

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389513140 @TianyangLi Does not work. Here is the info (from Windows): (in Ubuntu will try next) > Traceback

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389514720 @xrmx Dude, I read the docs. And somehow it was working in Windows with some previous version of Superset

[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389490045 @miloradkrstevski The error itself is a very straight forward fix. On ubuntu its as straight forward as:

[GitHub] TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
TianyangLi commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389490045 @miloradkrstevski The error itself is a very straight forward fix. On ubuntu its as straight forward as:

[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`

2018-05-15 Thread GitBox
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389222902 Hi, Thanks for your reply and your action. I don't know if it's related to the version but i am getting an error in

[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`

2018-05-15 Thread GitBox
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389222902 Hi, Thanks for your reply and your action. I don't know if it's related to the version but i am getting an error in

[GitHub] mistercrunch opened a new pull request #5007: Fix EncryptedType error

2018-05-15 Thread GitBox
mistercrunch opened a new pull request #5007: Fix EncryptedType error URL: https://github.com/apache/incubator-superset/pull/5007 fixes https://github.com/apache/incubator-superset/issues/5005 This is an automated message

[GitHub] findepi commented on issue #4953: flask-appbuilder 1.10.0 has requirement Flask<0.12.99, >=0.12.1, but you'll have flask 1.0.2 which is incompatible

2018-05-15 Thread GitBox
findepi commented on issue #4953: flask-appbuilder 1.10.0 has requirement Flask<0.12.99,>=0.12.1, but you'll have flask 1.0.2 which is incompatible URL: https://github.com/apache/incubator-superset/issues/4953#issuecomment-389248933 No, i use docker, so I get fresh state each time

[GitHub] graceguo-supercat opened a new pull request #5009: [WiP] fix dashboard server-side unit tests

2018-05-15 Thread GitBox
graceguo-supercat opened a new pull request #5009: [WiP] fix dashboard server-side unit tests URL: https://github.com/apache/incubator-superset/pull/5009 This is an automated message from the Apache Git Service. To respond

[GitHub] mistercrunch commented on issue #5002: superset presto database support editing `X-Presto-Source`

2018-05-15 Thread GitBox
mistercrunch commented on issue #5002: superset presto database support editing `X-Presto-Source` URL: https://github.com/apache/incubator-superset/issues/5002#issuecomment-38922 In the newer version you can use the impersonation feature or the `DB_CONNECTION_MUTATOR` config key:

[GitHub] mistercrunch commented on issue #5000: Use a dummy version number on master

2018-05-15 Thread GitBox
mistercrunch commented on issue #5000: Use a dummy version number on master URL: https://github.com/apache/incubator-superset/pull/5000#issuecomment-389246486 @xrmx it means an extra PR at every release and it's easy to forget.

[GitHub] mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2'

2018-05-15 Thread GitBox
mistercrunch commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389250941 Which version of python? Which os/version? Please provide the full stacktrace.

[GitHub] gdkatant1 commented on issue #4999: Use a better version number in `master`

2018-05-15 Thread GitBox
gdkatant1 commented on issue #4999: Use a better version number in `master` URL: https://github.com/apache/incubator-superset/issues/4999#issuecomment-389231281 Hi, Thank you for your reply. Should i close this issue or do you need it to stay open for final fix that works with

[GitHub] mistercrunch commented on issue #5000: Use a dummy version number on master

2018-05-15 Thread GitBox
mistercrunch commented on issue #5000: Use a dummy version number on master URL: https://github.com/apache/incubator-superset/pull/5000#issuecomment-389246486 @xrmx I means an extra PR at every release and it's easy to forget.

[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389933718 Can we change the error message to something like "The data source associated with this chart no longer exists"? Also,

[GitHub] abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF

2018-05-17 Thread GitBox
abowden-spotx closed pull request #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043405 ## File path: superset/sql_lab.py ## @@ -171,6 +171,7 @@ def

[GitHub] mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-17 Thread GitBox
mistercrunch commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389936762 All examples get executed as integration test, so if you add a new example chart that cover this use

[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3

2018-05-17 Thread GitBox
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389931667 Seems like a data engineering / data preparation would be best in this case. You'd ETL your user conf

[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189029978 ## File path: superset/sql_lab.py ## @@ -185,7 +186,8 @@ def

[GitHub] mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
mistercrunch commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189029182 ## File path: superset/sql_lab.py ## @@ -171,6 +171,7 @@ def

[GitHub] mistercrunch commented on issue #5019: fix missing datasource error message

2018-05-17 Thread GitBox
mistercrunch commented on issue #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#issuecomment-389934250 About cascading, I think that would be the desired behavior as long as there's clarity on what is happening. There should be a

[GitHub] timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit

2018-05-17 Thread GitBox
timifasubaa commented on a change in pull request #5023: [sqllab] force limit queries only when there is no existing limit URL: https://github.com/apache/incubator-superset/pull/5023#discussion_r189043307 ## File path: superset/sql_lab.py ## @@ -185,7 +186,8 @@ def

[GitHub] zkenstein opened a new issue #5017: Error Add MySQL DB

2018-05-16 Thread GitBox
zkenstein opened a new issue #5017: Error Add MySQL DB URL: https://github.com/apache/incubator-superset/issues/5017 Make sure these boxes are checked before submitting your issue - thank you! - [* ] I have checked the superset logs for python stacktraces and included it here as

[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-16 Thread GitBox
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user doesn't have save access to dashboard, we used to allow user `save-as` a

[GitHub] mashbourne commented on issue #900: Nanosecond timestamp year range workaround

2018-05-16 Thread GitBox
mashbourne commented on issue #900: Nanosecond timestamp year range workaround URL: https://github.com/apache/incubator-superset/issues/900#issuecomment-389603000 Throws (default): pd.to_datetime(datetime.date(2262, 4, 12),errors='raise') Swallows: pd.to_datetime(datetime.date(2262, 4,

[GitHub] miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
miloradkrstevski commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389605825 @mistercrunch When I try to install `pip install mysqlclient`, it goes me the following error: >

[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-16 Thread GitBox
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808 @jasnovak @mistercrunch If user doesn't have save access to dashboard, we used to allow user `save-as` to

[GitHub] mistercrunch commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI

2018-05-16 Thread GitBox
mistercrunch commented on issue #5013: Connecting MySQL and PostgreSQL into SQLAlchemy URI URL: https://github.com/apache/incubator-superset/issues/5013#issuecomment-389617576 Please research how to install `mysqlclient` on the os your own, usually installing the package for the mysql

[GitHub] mistercrunch commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType

2018-05-16 Thread GitBox
mistercrunch commented on issue #5010: superset db upgrade error: ImportError: cannot import name EncryptedType URL: https://github.com/apache/incubator-superset/issues/5010#issuecomment-389620809 Should be fixed in `0.25.3`

[GitHub] mistercrunch commented on issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors

2018-05-16 Thread GitBox
mistercrunch commented on issue #5005: DB Upgrade - Fails with sqlalchemy_utils errors URL: https://github.com/apache/incubator-superset/issues/5005#issuecomment-389620646 Should be fixed in `0.25.3` This is an automated

[GitHub] zkenstein closed issue #5017: Error Add MySQL DB

2018-05-16 Thread GitBox
zkenstein closed issue #5017: Error Add MySQL DB URL: https://github.com/apache/incubator-superset/issues/5017 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3

2018-05-16 Thread GitBox
qyoz commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389579059 so it this the right issue for what we're asking? or should I open a feature request? this isn't about running

[GitHub] jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-16 Thread GitBox
jasnovak commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-389625306 Yes, this is intended behavior. We have a read-only role that we don't want to give the ability to create

[GitHub] mts2016 opened a new issue #5018: Data too long for column 'type' at row 1

2018-05-16 Thread GitBox
mts2016 opened a new issue #5018: Data too long for column 'type' at row 1 URL: https://github.com/apache/incubator-superset/issues/5018 Make sure these boxes are checked before submitting your issue - thank you! - [x ] I have checked the superset logs for python stacktraces and

[GitHub] veszig commented on issue #5004: db upgrade importError:No module named 'contextlib2'

2018-05-15 Thread GitBox
veszig commented on issue #5004: db upgrade importError:No module named 'contextlib2' URL: https://github.com/apache/incubator-superset/issues/5004#issuecomment-389277179 I have the same issue. After upgrading I get the following error message when I try to upgrade the db: ```

[GitHub] GabeLoins commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
GabeLoins commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389688161 @michellethomas do we need to do something like this for druid as well?

[GitHub] mistercrunch commented on a change in pull request #5019: fix missing datasource error message

2018-05-16 Thread GitBox
mistercrunch commented on a change in pull request #5019: fix missing datasource error message URL: https://github.com/apache/incubator-superset/pull/5019#discussion_r188800947 ## File path: superset/views/core.py ## @@ -1229,7 +1229,10 @@ def

[GitHub] mistercrunch commented on issue #5006: ImportError: No module named 'flask.exthook'

2018-05-16 Thread GitBox
mistercrunch commented on issue #5006: ImportError: No module named 'flask.exthook' URL: https://github.com/apache/incubator-superset/issues/5006#issuecomment-389697967 Ooops, my bad, fixing in 0.25.4 (pushing this out now)

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on

[GitHub] codecov-io commented on issue #5022: Fix flask<1.0.0

2018-05-16 Thread GitBox
codecov-io commented on issue #5022: Fix flask<1.0.0 URL: https://github.com/apache/incubator-superset/pull/5022#issuecomment-389701303 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5022?src=pr=h1) Report > Merging

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on

[GitHub] zkenstein opened a new issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page

2018-05-16 Thread GitBox
zkenstein opened a new issue #5016: Hi All I am very new with superset, i tired to add a mysql database, all connection tested result seem OK with the list of the tables at the bottom of page, but when I tried to save it present the error: General Error . Any one have faced this before? URL:

[GitHub] mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3

2018-05-16 Thread GitBox
mistercrunch commented on issue #1797: Add Ability to Save Results from Previous Queries Using S3 URL: https://github.com/apache/incubator-superset/issues/1797#issuecomment-389618284 Why not creating a summary table (CREATE TABLE AS) and then slice/dicing the result set in that summary

[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-16 Thread GitBox
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389699387 @mistercrunch I didn't see a lot of tests for this section of the code. Did you have thoughts on

[GitHub] joaomg opened a new issue #5047: Request for guidance

2018-05-21 Thread GitBox
joaomg opened a new issue #5047: Request for guidance URL: https://github.com/apache/incubator-superset/issues/5047 Make sure these boxes are checked before submitting your issue - thank you! - [x] I have checked the superset logs for python stacktraces and included it here as text

[GitHub] codecov-io commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown

2018-05-21 Thread GitBox
codecov-io commented on issue #5038: [Explore] [Adhoc Metrics/Filters] Force Ace editor to refresh when it is shown URL: https://github.com/apache/incubator-superset/pull/5038#issuecomment-390711361 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5038?src=pr=h1) Report

[GitHub] joaomg commented on issue #5047: Request for guidance

2018-05-21 Thread GitBox
joaomg commented on issue #5047: Request for guidance URL: https://github.com/apache/incubator-superset/issues/5047#issuecomment-390716950 I've realized that the FilterBoxViz should be my starting point. I'll probably extend it to my needs. Closing this issue.

[GitHub] joaomg closed issue #5047: Request for guidance

2018-05-21 Thread GitBox
joaomg closed issue #5047: Request for guidance URL: https://github.com/apache/incubator-superset/issues/5047 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] GabeLoins commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric

2018-05-21 Thread GitBox
GabeLoins commented on issue #5045: Can't select the table's other metrics when explore the chart expect the count(*) metric URL: https://github.com/apache/incubator-superset/issues/5045#issuecomment-390699146 @zhangjian0111 we recently updated how the Metrics Control is used, refer to

[GitHub] zhaoyongjie opened a new pull request #5048: [bugfix] Render to section by override value

2018-05-21 Thread GitBox
zhaoyongjie opened a new pull request #5048: [bugfix] Render to section by override value URL: https://github.com/apache/incubator-superset/pull/5048 ![image](https://user-images.githubusercontent.com/2016594/40317860-57f7939e-5d55-11e8-9a7a-6bdb6d8c10e5.png) render section by

[GitHub] codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0

2018-05-21 Thread GitBox
codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390709874 #

[GitHub] codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0

2018-05-21 Thread GitBox
codecov-io commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390709874 #

[GitHub] chutianshu1981 commented on issue #2756: Advanced Analytics Documentation

2018-05-21 Thread GitBox
chutianshu1981 commented on issue #2756: Advanced Analytics Documentation URL: https://github.com/apache/incubator-superset/issues/2756#issuecomment-390656544 +1 same question This is an automated message from the Apache Git

[GitHub] williaster commented on issue #4993: [dashboard v2] tests!

2018-05-21 Thread GitBox
williaster commented on issue #4993: [dashboard v2] tests! URL: https://github.com/apache/incubator-superset/pull/4993#issuecomment-390735896 @graceguo-supercat can you please review the tests for filters + dashboard since you are most familiar with this code? still can't find the bug you

[GitHub] michellethomas opened a new issue #5049: Slices with new Adhoc Filters break dashboards

2018-05-21 Thread GitBox
michellethomas opened a new issue #5049: Slices with new Adhoc Filters break dashboards URL: https://github.com/apache/incubator-superset/issues/5049 Currently on master adding a slice with an adhoc filter breaks the dashboard page. `Cannot read property 'concat' of undefined at

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189679922 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -1,36 +1,40 @@ /* eslint-env browser

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680562 ## File path: superset/assets/src/dashboard/reducers/dashboardState.js ## @@ -14,13 +14,13 @@ import {

[GitHub] mistercrunch closed pull request #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0

2018-05-21 Thread GitBox
mistercrunch closed pull request #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] mistercrunch commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0

2018-05-21 Thread GitBox
mistercrunch commented on issue #5030: [Explore][AdhocMetrics] treating floats like doubles for druid versions lower than 11.0.0 URL: https://github.com/apache/incubator-superset/pull/5030#issuecomment-390747151 LGTM This

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680390 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -138,15 +112,15 @@ class SaveModal

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680285 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -138,15 +112,15 @@ class SaveModal

[GitHub] michellethomas commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-21 Thread GitBox
michellethomas commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390728041 @GabeLoins a few questions but lgtm otherwise!

[GitHub] michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-21 Thread GitBox
michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#discussion_r189660899 ## File path:

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189679344 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -1,12 +1,18 @@ +/* eslint-env browser */

[GitHub] michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-21 Thread GitBox
michellethomas commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#discussion_r189660170 ## File path:

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680024 ## File path: superset/assets/src/dashboard/components/Header.jsx ## @@ -161,44 +197,63 @@ class Header extends

[GitHub] williaster commented on a change in pull request #4979: Dashboard save button

2018-05-21 Thread GitBox
williaster commented on a change in pull request #4979: Dashboard save button URL: https://github.com/apache/incubator-superset/pull/4979#discussion_r189680138 ## File path: superset/assets/src/dashboard/components/SaveModal.jsx ## @@ -59,37 +64,7 @@ class SaveModal

[GitHub] williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs

2018-05-21 Thread GitBox
williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs URL: https://github.com/apache/incubator-superset/pull/5031#discussion_r189677504 ## File path: superset/assets/src/dashboard/util/layoutHelper.js ## @@ -0,0 +1,42 @@

[GitHub] williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs

2018-05-21 Thread GitBox
williaster commented on a change in pull request #5031: Dashboard initial page load logging with tabs URL: https://github.com/apache/incubator-superset/pull/5031#discussion_r189677298 ## File path: superset/assets/src/dashboard/util/layoutHelper.js ## @@ -0,0 +1,42 @@

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189730436 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189732530 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -1,20

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189732362 ## File path: superset/assets/package.json ## @@ -88,6 +88,7 @@ "react-addons-shallow-compare":

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189734396 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189734505 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] GabeLoins commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-21 Thread GitBox
GabeLoins commented on a change in pull request #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#discussion_r189705621 ## File path:

[GitHub] zkenstein commented on issue #5041: Permission to enable / disable CSV export on chart / slice

2018-05-21 Thread GitBox
zkenstein commented on issue #5041: Permission to enable / disable CSV export on chart / slice URL: https://github.com/apache/incubator-superset/issues/5041#issuecomment-390777583 I think on this line CSV_EXPORT = { 'encoding': 'utf-8', } around line 197?

[GitHub] codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands

2018-05-21 Thread GitBox
codecov-io commented on issue #5032: [Explore][Adhoc Filters] Expanding the Adhoc Filter popover when the content expands URL: https://github.com/apache/incubator-superset/pull/5032#issuecomment-390067823 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5032?src=pr=h1)

[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

2018-05-21 Thread GitBox
graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message URL: https://github.com/apache/incubator-superset/pull/4900#issuecomment-390806736 @jasnovak In Superset build-in [roles](https://superset.apache.org/security.html#provided-roles): both

[GitHub] michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-21 Thread GitBox
michellethomas commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-390806412 @mistercrunch added tests, thanks for the suggestion!

[GitHub] ibnjay opened a new issue #5050: self registration issue with LDAP

2018-05-21 Thread GitBox
ibnjay opened a new issue #5050: self registration issue with LDAP URL: https://github.com/apache/incubator-superset/issues/5050 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it

[GitHub] mistercrunch commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
mistercrunch commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189731791 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -1,20 +1,43

[GitHub] TianyangLi commented on issue #5041: Permission to enable / disable CSV export on chart / slice

2018-05-21 Thread GitBox
TianyangLi commented on issue #5041: Permission to enable / disable CSV export on chart / slice URL: https://github.com/apache/incubator-superset/issues/5041#issuecomment-390781564 @miloradkrstevski @zkenstein Close, but i think its jus a matter of commenting out the following:

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189731834 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] betodealmeida commented on a change in pull request #4981: Make time filter more usable

2018-05-21 Thread GitBox
betodealmeida commented on a change in pull request #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#discussion_r189733719 ## File path: superset/assets/src/explore/components/controls/DateFilterControl.jsx ## @@ -28,172

[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-21 Thread GitBox
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-21 Thread GitBox
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression

2018-05-21 Thread GitBox
codecov-io commented on issue #5021: Allow MetricsControl to aggregate on a column with an expression URL: https://github.com/apache/incubator-superset/pull/5021#issuecomment-389692391 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5021?src=pr=h1) Report > Merging

[GitHub] qin4zhang opened a new issue #5053: Database Permission for version 0.22.1

2018-05-22 Thread GitBox
qin4zhang opened a new issue #5053: Database Permission for version 0.22.1 URL: https://github.com/apache/incubator-superset/issues/5053 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and

[GitHub] yuhai1023 commented on issue #347: Feature: Drill down

2018-05-22 Thread GitBox
yuhai1023 commented on issue #347: Feature: Drill down URL: https://github.com/apache/incubator-superset/issues/347#issuecomment-390942451 +1 we need it too This is an automated message from the Apache Git Service. To

[GitHub] codecov-io commented on issue #4981: Make time filter more usable

2018-05-21 Thread GitBox
codecov-io commented on issue #4981: Make time filter more usable URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-388507979 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4981?src=pr=h1) Report > Merging

<    1   2   3   4   5   6   7   8   9   10   >