[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
codecov-io edited a comment on pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829#issuecomment-629905910 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9829?src=pr&el=h1) Report > Merging [#9829](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr&el=h1) Report > Merging [#9810](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr&el=h1) Report > Merging [#9810](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr&el=h1) Report > Merging [#9810](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr&el=h1) Report > Merging [#9810](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9810: feat: [WIP] Superset report slack integration

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9810: URL: https://github.com/apache/incubator-superset/pull/9810#issuecomment-630512435 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9810?src=pr&el=h1) Report > Merging [#9810](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] craig-rueda opened a new pull request #9837: [Docker-Compose] Fixes issue with duplicated dependencies

2020-05-18 Thread GitBox
craig-rueda opened a new pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837 ### SUMMARY * Fixes issue with `pip` install failing when dependencies are duplicated across requirements files. * Removes `restart: always` from tests worker as it crash-loops dur

[GitHub] [incubator-superset] craig-rueda closed pull request #9837: fix - issue with duplicated dependencies

2020-05-18 Thread GitBox
craig-rueda closed pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] stale[bot] commented on issue #9288: Blank login Page when building from 0.36.rc1 release branch

2020-05-18 Thread GitBox
stale[bot] commented on issue #9288: URL: https://github.com/apache/incubator-superset/issues/9288#issuecomment-630515992 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribut

[GitHub] [incubator-superset] stale[bot] commented on issue #9327: While running the complex query from the sqllab editor,its taking time and at the end its throwing error like "An error occurred",i h

2020-05-18 Thread GitBox
stale[bot] commented on issue #9327: URL: https://github.com/apache/incubator-superset/issues/9327#issuecomment-630515996 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribut

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
etr2460 commented on a change in pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#discussion_r426979019 ## File path: superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx ## @@ -65,24 +65,9 @@ describe('ExploreChartH

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: Implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] Sam--Shan commented on issue #9719: Clickhouse connection issue

2020-05-18 Thread GitBox
Sam--Shan commented on issue #9719: URL: https://github.com/apache/incubator-superset/issues/9719#issuecomment-630526691 I tried re install infi.clickhouse_orm and it works. pip uninstall infi.clickhouse_orm pip install infi.clickhouse_orm==1.0.4 ---

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#issuecomment-630522922 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9734?src=pr&el=h1) Report > Merging [#9734](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
etr2460 commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r426987520 ## File path: superset/config.py ## @@ -586,11 +586,24 @@ class CeleryConfig: # pylint: disable=too-few-public-methods # The directory with

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9734: feat: implement csv upload configuration func for the schema enforcement

2020-05-18 Thread GitBox
john-bodley commented on a change in pull request #9734: URL: https://github.com/apache/incubator-superset/pull/9734#discussion_r427013763 ## File path: superset/db_engine_specs/base.py ## @@ -454,55 +452,27 @@ def df_to_sql(cls, df: pd.DataFrame, **kwargs: Any) -> None:

[GitHub] [incubator-superset] lilila commented on issue #9823: filter box be applyed to all charts of one dashboard

2020-05-18 Thread GitBox
lilila commented on issue #9823: URL: https://github.com/apache/incubator-superset/issues/9823#issuecomment-630565175 There is a nice way to edit filter scope. Click on `edit dashboard` then click on "filters" (1). It opens a nice interface to edit filter scope (2) (1) https://us

[GitHub] [incubator-superset] villebro merged pull request #9834: docs: Update the link to ClickHouse official website

2020-05-18 Thread GitBox
villebro merged pull request #9834: URL: https://github.com/apache/incubator-superset/pull/9834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] lilila commented on issue #9395: Preserve label_colors in standalone mode

2020-05-18 Thread GitBox
lilila commented on issue #9395: URL: https://github.com/apache/incubator-superset/issues/9395#issuecomment-630565917 Dear @graceguo-supercat , do you have any clue to solve this issue ? Thank you This is an automated m

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9837: fix: issue with duplicated dependencies

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9837: URL: https://github.com/apache/incubator-superset/pull/9837#issuecomment-630516280 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9837?src=pr&el=h1) Report > Merging [#9837](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] villebro commented on a change in pull request #9825: WIP: Upload excel

2020-05-18 Thread GitBox
villebro commented on a change in pull request #9825: URL: https://github.com/apache/incubator-superset/pull/9825#discussion_r427019488 ## File path: superset/config.py ## @@ -351,8 +351,9 @@ def _try_json_readsha(filepath, length): # pylint: disable=unused-argument SUPERSE

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9829: fix: [filter_box] fix 2 issues in single value filter_box

2020-05-18 Thread GitBox
graceguo-supercat merged pull request #9829: URL: https://github.com/apache/incubator-superset/pull/9829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-superset] john-bodley commented on pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
john-bodley commented on pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833#issuecomment-630571695 @villebro agreed, hence why the comments. Note there's a chance this self resolves once we fully type the repo.

[GitHub] [incubator-superset] john-bodley merged pull request #9833: build: Updating the sphinx configuration

2020-05-18 Thread GitBox
john-bodley merged pull request #9833: URL: https://github.com/apache/incubator-superset/pull/9833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter commented on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] villebro commented on issue #9836: Filter generated alias cause bigquery error: 400 Unrecognized name

2020-05-18 Thread GitBox
villebro commented on issue #9836: URL: https://github.com/apache/incubator-superset/issues/9836#issuecomment-630577399 Thanks @esilver , I have not used nested fields on BigQuery with Superset, hence this has not come up in my testing. To make it easier to reproduce, can you shed some ad

[GitHub] [incubator-superset] villebro commented on issue #9830: Error When Installing Dev Requirements pydruid

2020-05-18 Thread GitBox
villebro commented on issue #9830: URL: https://github.com/apache/incubator-superset/issues/9830#issuecomment-630578531 Thanks @essajiwa , this is a known issue with `pydruid` on python 3.7, see https://github.com/druid-io/pydruid/issues/198 . FYI @etr2460 @john-bodley : To ensure a

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9824: URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report > Merging [#9824](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat commented on a change in pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#discussion_r427040230 ## File path: superset-frontend/spec/javascripts/explore/components/ExploreChartHeader_spec.jsx ## @@ -65,24 +65,9 @@ describe('Exp

[GitHub] [incubator-superset] ktmud commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
ktmud commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630593453 I'm wondering whether we can just remove inline edit? There is an edit button/icon anyway, right? Thi

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat commented on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) This is an automated message from the

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) But it seems hard to decide overwrite or save_as. -

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) But it seems hard to decide overwrite or save_as --

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) I remembered the initial request is mean to overwrite without confirmation (quick save). But i

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat edited a comment on pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817#issuecomment-630594291 _inline edit_ feature is also requested by users :) I remembered the initial request is mean to overwrite without confirmation (quick save). But i

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9794: feat: implement create view as functionality in Sqllab

2020-05-18 Thread GitBox
codecov-commenter edited a comment on pull request #9794: URL: https://github.com/apache/incubator-superset/pull/9794#issuecomment-63056 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9794?src=pr&el=h1) Report > Merging [#9794](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] graceguo-supercat merged pull request #9817: fix: [explore view] inline edit slice name should not overwrite

2020-05-18 Thread GitBox
graceguo-supercat merged pull request #9817: URL: https://github.com/apache/incubator-superset/pull/9817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-superset] zheya08 opened a new issue #9838: Tooltip didn't highlight when mouse moving on the line in Multiple Line Chart

2020-05-18 Thread GitBox
zheya08 opened a new issue #9838: URL: https://github.com/apache/incubator-superset/issues/9838 When I'm using Multiple Line Chart, I move the mouse on the line, but the color in the tooltip didn't highlight, so I can't get the class of line clearly. ![image](https://user-images.github

[GitHub] [incubator-superset] stale[bot] closed issue #8928: how to add a New chart type

2020-05-19 Thread GitBox
stale[bot] closed issue #8928: URL: https://github.com/apache/incubator-superset/issues/8928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed issue #9280: Superset installation build fails using Docker-compose up on MacOS

2020-05-19 Thread GitBox
stale[bot] closed issue #9280: URL: https://github.com/apache/incubator-superset/issues/9280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed issue #9289: Database unsupported SqlAIchemy dialect,but have python driver

2020-05-19 Thread GitBox
stale[bot] closed issue #9289: URL: https://github.com/apache/incubator-superset/issues/9289 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed issue #9293: Big Number formatting(Slice with in Slice) and conditional formatting

2020-05-19 Thread GitBox
stale[bot] closed issue #9293: URL: https://github.com/apache/incubator-superset/issues/9293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] stale[bot] closed issue #9292: Requesting solution for Slice to slice connection in Apache Superset

2020-05-19 Thread GitBox
stale[bot] closed issue #9292: URL: https://github.com/apache/incubator-superset/issues/9292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-superset] AnkitaSanyogita commented on issue #6032: [SIP-11] Proposal for deprecating Druid REST connector

2020-05-19 Thread GitBox
AnkitaSanyogita commented on issue #6032: URL: https://github.com/apache/incubator-superset/issues/6032#issuecomment-630662598 Superset is used for visualization and exploration. While SQL type data can be sliced and these slices can be secured, is it possible to do so in case of druid da

[GitHub] [incubator-superset] prs1022 commented on issue #9785: superset-fontend Error after run npm run dev-server

2020-05-19 Thread GitBox
prs1022 commented on issue #9785: URL: https://github.com/apache/incubator-superset/issues/9785#issuecomment-630710952 @Amylee520 I have met the same problem,how to fix this bug? This is an automated message from the Apache

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9825: WIP: Upload excel

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #9825: URL: https://github.com/apache/incubator-superset/pull/9825#issuecomment-630726559 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9825?src=pr&el=h1) Report > Merging [#9825](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] villebro commented on pull request #9825: WIP: Upload excel

2020-05-19 Thread GitBox
villebro commented on pull request #9825: URL: https://github.com/apache/incubator-superset/pull/9825#issuecomment-630732767 @blcksrx at least the following files are involved in the CSV upload feature: - `superset/app.py`: here the menu item is defined. - `superset/views/database/for

[GitHub] [incubator-superset] dpgaspar opened a new pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
dpgaspar opened a new pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839 ### SUMMARY Bug introduced on #9619, URL for druid datasources rendering name instead of `explore_url` ### TEST PLAN - Create a druid cluster and datasource - Create a chart

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839#issuecomment-630750336 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9839?src=pr&el=h1) Report > Merging [#9839](https://codecov.io/gh/apache/incubator-sup

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839#issuecomment-630750336 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9839?src=pr&el=h1) Report > Merging [#9839](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839#issuecomment-630750336 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9839?src=pr&el=h1) Report > Merging [#9839](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839#issuecomment-630750336 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9839: fix(chart): chart datasource explore URL showing datasource name for druid

2020-05-19 Thread GitBox
codecov-commenter edited a comment on pull request #9839: URL: https://github.com/apache/incubator-superset/pull/9839#issuecomment-630750336 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9839?src=pr&el=h1) Report > Merging [#9839](https://codecov.io/gh/apache/incuba

[GitHub] [incubator-superset] saiharish97 opened a new issue #9840: Automatic profile change

2020-05-19 Thread GitBox
saiharish97 opened a new issue #9840: URL: https://github.com/apache/incubator-superset/issues/9840 Hi, I logged into superset using one set of userid,password. I was preparing a dashboard. After sometime I went into the dashboard page. To my surprise, I was in another profile. The prof

[GitHub] [incubator-superset] villebro opened a new pull request #9841: feat: Add new result formats and types to chart data API

2020-05-19 Thread GitBox
villebro opened a new pull request #9841: URL: https://github.com/apache/incubator-superset/pull/9841 ### SUMMARY This adds support for CSV format and ability to request samples and only the query via the new chart data API. This functionality is needed to be able to deprecate the old `

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9841: feat: Add new result formats and types to chart data API

2020-05-19 Thread GitBox
codecov-commenter commented on pull request #9841: URL: https://github.com/apache/incubator-superset/pull/9841#issuecomment-630786496 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9841?src=pr&el=h1) Report > Merging [#9841](https://codecov.io/gh/apache/incubator-sup

<    1   2   3   4   5   6   7   8   9   10   >