betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-542836941
@graceguo-supercat @etr2460 this should be good for another round of testing.
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-533595765
Thanks, @graceguo-supercat. Fixing it, sorry for the trouble.
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-532856220
Ping @graceguo-supercat @etr2460
This is an automated
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-531115915
@graceguo-supercat, note that if you want to test this you need to downgrade
the DB and upgrade again, since I modified
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-531098189
@graceguo-supercat, thanks for testing this thoroughly, I had completely
missed those two cases. I fixed them, and did
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530943398
Thanks for testing it, @graceguo-supercat! I'll work on it today!
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-530062997
> In general I think all the error messages could use a little work, mainly
phrasing them from the perspective an end
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-527324021
@graceguo-supercat that's expected if you don't have a results backend set
up. In that case, we don't store the results
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526889346
@graceguo-supercat I added code to migrate the query history as well. I'm
now taking a look at the errors you found with
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526767134
> hi @betodealmeida I have one concern for this PR: once this feature is
released to production, the existed sql lab
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526401610
I added new integration tests, but looks like Travis is not running them. I
ran them locally and they passed:
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526388534
@etr2460, do you want to take another stab at reviewing this?
I'm currently working on fixing the failing unit
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-525491749
I'm fixing the unit tests and adding integration tests.
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-523285273
@etr2460, I put all the functionality behind a feature flag. I tested
locally and it works, and switching the flag on
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the
backend
URL:
https://github.com/apache/incubator-superset/pull/8060#issuecomment-523276535
> For such a major change, I think introducing a feature flag would be
preferable since it might require significant
15 matches
Mail list logo
