[GitHub] [zookeeper] maoling opened a new pull request #1137: ZOOKEEPER-3600:[WIP]support the complete Linearizability Read

2019-11-06 Thread GitBox
maoling opened a new pull request #1137: ZOOKEEPER-3600:[WIP]support the complete Linearizability Read URL: https://github.com/apache/zookeeper/pull/1137 - this is still a work in the progress,Plz don't review before removing the WIP tag - more details in the

[GitHub] [zookeeper] maoling opened a new pull request #1136: ZOOKEEPER-3570:make the special client xid constant

2019-11-06 Thread GitBox
maoling opened a new pull request #1136: ZOOKEEPER-3570:make the special client xid constant URL: https://github.com/apache/zookeeper/pull/1136 - more details in the [ZOOKEEPER-3570](https://issues.apache.org/jira/browse/ZOOKEEPER-3570)

[GitHub] [zookeeper] maoling opened a new pull request #1135: ZOOKEEPER-3601:introduce the fault injection framework: Byteman for ZooKeeper

2019-11-06 Thread GitBox
maoling opened a new pull request #1135: ZOOKEEPER-3601:introduce the fault injection framework: Byteman for ZooKeeper URL: https://github.com/apache/zookeeper/pull/1135 - **Byteman** is a powerful tool to inject faults during runtime, especially for distributed system - In the future,

[GitHub] [zookeeper] sujithsimon22 commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-11-06 Thread GitBox
sujithsimon22 commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#discussion_r343484837 ## File path:

[GitHub] [zookeeper] eribeiro commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server

2019-11-06 Thread GitBox
eribeiro commented on a change in pull request #1108: ZOOKEEPER-2238: Support limiting the maximum number of connections/clients to a zookeeper server URL: https://github.com/apache/zookeeper/pull/1108#discussion_r343302097 ## File path:

[GitHub] [zookeeper] ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions

2019-11-06 Thread GitBox
ztzg commented on issue #1068: ZOOKEEPER-1998: Allow C client to throttle host name resolutions URL: https://github.com/apache/zookeeper/pull/1068#issuecomment-550455737 @enixon: I have refreshed the PR, using `finish` rather than `done` as the goto label, as 1/ there is a precedent 2/ it

[GitHub] [zookeeper] eribeiro commented on issue #1106: ZOOKEEPER-1416 - Persistent, recursive watchers

2019-11-06 Thread GitBox
eribeiro commented on issue #1106: ZOOKEEPER-1416 - Persistent, recursive watchers URL: https://github.com/apache/zookeeper/pull/1106#issuecomment-550442192 @Randgalt Congratulations for the awesome work!!! :tada: It's very nice to see this much anticipated feature being finally merged

[GitHub] [zookeeper] ztzg commented on issue #1134: ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client library

2019-11-06 Thread GitBox
ztzg commented on issue #1134: ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client library URL: https://github.com/apache/zookeeper/pull/1134#issuecomment-550365044 Pinging @eolivelli @phunt @anmolnar and @hanm, which were mentioned on the earlier

[GitHub] [zookeeper] ztzg opened a new pull request #1134: ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client library

2019-11-06 Thread GitBox
ztzg opened a new pull request #1134: ZOOKEEPER-1112: Add (Cyrus) SASL authentication support to C client library URL: https://github.com/apache/zookeeper/pull/1134 This is a "respin" of https://github.com/apache/zookeeper/pull/1054, which I withdrew due to some annoying shortcomings.

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343100667 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/AuditEvent.java ## @@

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343104047 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/ZKAuditLogger.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343119363 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343119074 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343122357 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343109530 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/ZKAuditLogger.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343100733 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/AuditEvent.java ## @@

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343106196 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/ZKAuditLogger.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343106951 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/Log4jAuditLogger.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343102884 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/Log4jAuditLogger.java

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343105268 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/ZKAuditLogger.java ##

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2019-11-06 Thread GitBox
anmolnar commented on a change in pull request #1133: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/1133#discussion_r343108218 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/audit/ZKAuditLogger.java ##

[GitHub] [zookeeper] asfgit closed pull request #1132: ZOOKEEPER-3605 - connThrottle needs to be assigned in alternate consructor

2019-11-06 Thread GitBox
asfgit closed pull request #1132: ZOOKEEPER-3605 - connThrottle needs to be assigned in alternate consructor URL: https://github.com/apache/zookeeper/pull/1132 This is an automated message from the Apache Git Service. To

[GitHub] [zookeeper] Randgalt commented on issue #1132: ZOOKEEPER-3605 - connThrottle needs to be assigned in alternate consructor

2019-11-06 Thread GitBox
Randgalt commented on issue #1132: ZOOKEEPER-3605 - connThrottle needs to be assigned in alternate consructor URL: https://github.com/apache/zookeeper/pull/1132#issuecomment-550300292 @anmolnar - I moved the assignment to the field declaration - "We only use the default