[GitHub] [zookeeper] nkalmar commented on issue #1050: ZOOKEEPER-3501:unify the method:op2String()

nkalmar commented on issue #1050: ZOOKEEPER-3501:unify the method:op2String() URL: https://github.com/apache/zookeeper/pull/1050#issuecomment-533454204 Merged to master. Thanks @maoling ! This is an automated message from the

[GitHub] [zookeeper] nkalmar commented on issue #1093: ZOOKEEPER-3552 Source tarbal for branch-3.5 does not set execution permissions to "configure" file

nkalmar commented on issue #1093: ZOOKEEPER-3552 Source tarbal for branch-3.5 does not set execution permissions to "configure" file URL: https://github.com/apache/zookeeper/pull/1093#issuecomment-533458183 Merged to 3.5 and branch-3.5.6 Thanks @eolivelli --

[GitHub] [zookeeper] nkalmar closed pull request #1093: ZOOKEEPER-3552 Source tarbal for branch-3.5 does not set execution permissions to "configure" file

nkalmar closed pull request #1093: ZOOKEEPER-3552 Source tarbal for branch-3.5 does not set execution permissions to "configure" file URL: https://github.com/apache/zookeeper/pull/1093 This is an automated message from the A

[GitHub] [zookeeper] symat commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client

symat commented on issue #1078: ZOOKEEPER-3436 Enhance Mavenized Make C client URL: https://github.com/apache/zookeeper/pull/1078#issuecomment-533503934 > maven doesn't generate sha512 checksum on which branch did you try? -

[GitHub] [zookeeper] symat opened a new pull request #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again)

symat opened a new pull request #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again) URL: https://github.com/apache/zookeeper/pull/1094 - based on the logs, this flakyness happened because some time the client session gets initiated before the observer joined - the client session

[GitHub] [zookeeper] hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r326796321 ## File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInpu

[GitHub] [zookeeper] hanm commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

hanm commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#discussion_r326799134 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md ## @@ -0,0 +1,319 @@

[GitHub] [zookeeper] hanm commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

hanm commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#discussion_r326797925 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md ## @@ -0,0 +1,319 @@

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r326800956 ## File path: zookeeper-jute/src/main/java/org/apache/jute/

[GitHub] [zookeeper] anmolnar commented on issue #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again)

anmolnar commented on issue #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again) URL: https://github.com/apache/zookeeper/pull/1094#issuecomment-533709066 retest maven build This is an automated message from the Apache

[GitHub] [zookeeper] hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r326805524 ## File path: zookeeper-jute/src/main/java/org/apache/jute/BinaryInpu

[GitHub] [zookeeper] enixon commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

enixon commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#issuecomment-533732344 This looks correct to me. Can you describe a situation where this change makes a difference (were there issues before

[GitHub] [zookeeper] maoling commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

maoling commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#discussion_r326851965 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md ## @@ -0,0 +1,319

[GitHub] [zookeeper] maoling commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

maoling commented on a change in pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073#discussion_r326851965 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperUseCases.md ## @@ -0,0 +1,319

[GitHub] [zookeeper] insumity commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

insumity commented on issue #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#issuecomment-533906506 @enixon As said in the [JIRA ticket](https://issues.apache.org/jira/browse/ZOOKEEPER-3537) > If checkLeader on

[GitHub] [zookeeper] arshadmohammad closed pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

arshadmohammad closed pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers. URL: https://github.com/apache/zookeeper/pull/338 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [zookeeper] maoling commented on a change in pull request #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

maoling commented on a change in pull request #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#discussion_r326935293 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ReferenceCou

[GitHub] [zookeeper] maoling commented on a change in pull request #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

maoling commented on a change in pull request #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#discussion_r326935498 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ReferenceCou

[GitHub] [zookeeper] mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-533948867 @maoling thx a lot for the reviewing work! I've pushed a new commit to address two places of lengthy codes y

[GitHub] [zookeeper] maoling commented on issue #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid

maoling commented on issue #1079: ZOOKEEPER-3231:Purge task may lost data when the recent snapshots are all invalid URL: https://github.com/apache/zookeeper/pull/1079#issuecomment-533952451 @anmolnar > Have you considered @enixon 's suggestion about removing invalid snapshot files to re

[GitHub] [zookeeper] hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

hanm commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r327309721 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperAdm

[GitHub] [zookeeper] asfgit closed pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md

asfgit closed pull request #1073: ZOOKEEPER-3529: add a new doc: zookeeperUseCases.md URL: https://github.com/apache/zookeeper/pull/1073 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [zookeeper] mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-534328771 @maoling I came across two other related ones today: Lineage-driven Fault Injection [SIGMOD '15] On F

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

lvfangmin commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#discussion_r327385407 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLead

[GitHub] [zookeeper] asfgit closed pull request #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again)

asfgit closed pull request #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again) URL: https://github.com/apache/zookeeper/pull/1094 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [zookeeper] nkalmar commented on issue #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again)

nkalmar commented on issue #1094: ZOOKEEPER-3470: Fix flaky LearnerMetricsTest (again) URL: https://github.com/apache/zookeeper/pull/1094#issuecomment-534454184 Merged to master, thanks @symat This is an automated message fr

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on a change in pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#discussion_r327741410 ## File path: zookeeper-docs/src/main/resources/markdown/zo

[GitHub] [zookeeper] hanm commented on issue #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

hanm commented on issue #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#issuecomment-534715062 @arshadmohammad can you also open a pull request to master branch? this pull request wa

[GitHub] [zookeeper] insumity commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

insumity commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#discussion_r327822590 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeade

[GitHub] [zookeeper] TisonKun opened a new pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun opened a new pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095 1. Extract ZKWatchManager to single file 2. Move ZKWatchManager instance to ClientCnxn in order to eliminate cycle depe

[GitHub] [zookeeper] arshadmohammad opened a new pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad opened a new pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096 This is an automated message from

[GitHub] [zookeeper] eolivelli commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

eolivelli commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#issuecomment-534874159 on master we have checkstyle, please fix the errors [INFO] [INFO] --- maven-che

[GitHub] [zookeeper] arshadmohammad commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#issuecomment-534878045 Seems check style is running on test classes. I think checkstyle should not run on

[GitHub] [zookeeper] eolivelli commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

eolivelli commented on issue #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#issuecomment-53403 We have checkstyle everywhere. Test classes are first class citizens IMHO Please fix

[GitHub] [zookeeper] maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability

maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability URL: https://github.com/apache/zookeeper/pull/994#issuecomment-534960115 - I take another look at this PR. One of the most valuable thing of this PR is the pointcut of tracing,i.e. whe

[GitHub] [zookeeper] maoling commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

maoling commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#issuecomment-534961590 Have Checkstyle violations, Looking This i

[GitHub] [zookeeper] TisonKun commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#issuecomment-534971090 Thanks for your reminder @maoling! Updated. --

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

eolivelli commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#discussion_r328062686 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.jav

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

eolivelli commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#discussion_r328063071 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

eolivelli commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#discussion_r328064856 ## File path: zookeeper-docs/src/main/resources/markdown/zookeep

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#discussion_r328076933 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java

[GitHub] [zookeeper] TisonKun commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun commented on a change in pull request #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#discussion_r328077024 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java

[GitHub] [zookeeper] TisonKun commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper

TisonKun commented on issue #1095: ZOOKEEPER-837: Eliminate cycle dependency between ClientCnxn and ZooKeeper URL: https://github.com/apache/zookeeper/pull/1095#issuecomment-534986196 Thanks for your review @eolivelli! Addressing inline comments... These changes could bring impact to

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#discussion_r328147177 ## File path: zookeeper-docs/src/main/resources/markdown/zo

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

eolivelli commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#discussion_r328208988 ## File path: zookeeper-docs/src/main/resources/markdown/zookeep

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on a change in pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096#discussion_r328209885 ## File path: zookeeper-docs/src/main/resources/markdown/zo

[GitHub] [zookeeper] coheigea opened a new pull request #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

coheigea opened a new pull request #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097 Jackson should be updated to the latest version to pick up a fix for CVE-2019-14540 This

[GitHub] [zookeeper] maoling commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

maoling commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097#issuecomment-535297398 Link to [CVE-2019-14540](https://nvd.nist.gov/vuln/detail/CVE-2019-14540) T

[GitHub] [zookeeper] hanm commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.

hanm commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot. URL: https://github.com/apache/zookeeper/pull/1092#issuecomment-535325239 anyone can help merge this? This is an automated me

[GitHub] [zookeeper] hanm opened a new pull request #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests.

hanm opened a new pull request #1098: ZOOKEEPER-3560: Add response cache to serve get children (2) requests. URL: https://github.com/apache/zookeeper/pull/1098 ZOOKEEPER-3180 introduces response cache but it only covers getData requests. This commit is to extend the response cache based on

[GitHub] [zookeeper] asfgit closed pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

asfgit closed pull request #1096: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1096 This is an automated message from the Apache Git

[GitHub] [zookeeper] arshadmohammad commented on issue #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad commented on issue #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080#issuecomment-535379558 Thanks @eolivelli @hanm and @lvfangmin for the reviews.

[GitHub] [zookeeper] arshadmohammad closed pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable

arshadmohammad closed pull request #1080: ZOOKEEPER-3496: Transaction larger than jute.maxbuffer makes ZooKeeper service unavailable URL: https://github.com/apache/zookeeper/pull/1080 This is an automated message from the Ap

[GitHub] [zookeeper] coheigea commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

coheigea commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097#issuecomment-535426868 @eolivelli Done, although "ant tar" fails due to what looks like a Jetty dependency issue.

[GitHub] [zookeeper] asfgit closed pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.

asfgit closed pull request #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot. URL: https://github.com/apache/zookeeper/pull/1092 This is an automated message from the Apache Git Service. To respond to

[GitHub] [zookeeper] nkalmar commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.

nkalmar commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot. URL: https://github.com/apache/zookeeper/pull/1092#issuecomment-535476588 Merged to master. Thanks @hanm This is an automat

[GitHub] [zookeeper] hanm commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot.

hanm commented on issue #1092: ZOOKEEPER-3548: Redundant zxid check in SnapStream.isValidSnapshot. URL: https://github.com/apache/zookeeper/pull/1092#issuecomment-535590559 @nkalmar thank you! This is an automated message fro

[GitHub] [zookeeper] hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#discussion_r328865837 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderEle

[GitHub] [zookeeper] hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

hanm commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#discussion_r328865890 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderEle

[GitHub] [zookeeper] eolivelli commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

eolivelli commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097#issuecomment-535838613 Thank you @maoling for checkin and reporting the usage in HBase @nkalmar o @anmolnar please take a look merge and cherry pick to br

[GitHub] [zookeeper] asfgit closed pull request #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

asfgit closed pull request #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [zookeeper] nkalmar commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10

nkalmar commented on issue #1097: ZOOKEEPER-3559 - Update Jackson to 2.9.10 URL: https://github.com/apache/zookeeper/pull/1097#issuecomment-535899315 Merged to master, branch-3.5 and branch-3.5.6 Thanks @coheigea This is a

[GitHub] [zookeeper] sujithsimon22 opened a new pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

sujithsimon22 opened a new pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099 Make server principal configurable at the client side

[GitHub] [zookeeper] anmolnar commented on a change in pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer

anmolnar commented on a change in pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer URL: https://github.com/apache/zookeeper/pull/1085#discussion_r329060854 ## File path: zookeeper-server/src/main/j

[GitHub] [zookeeper] arshadmohammad commented on a change in pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

arshadmohammad commented on a change in pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#discussion_r329069973 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZK

[GitHub] [zookeeper] asfgit closed pull request #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

asfgit closed pull request #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066 This is an automated message from the Apache Git Service. To respon

[GitHub] [zookeeper] anmolnar commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

anmolnar commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066#issuecomment-535945531 Committed to master and 3.5 branches. Thanks @ztzg ! -

[GitHub] [zookeeper] sujithsimon22 commented on a change in pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

sujithsimon22 commented on a change in pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#discussion_r329087641 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/client/ZKC

[GitHub] [zookeeper] arshadmohammad commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

arshadmohammad commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#issuecomment-536004042 Changes look good to me. +1 This

[GitHub] [zookeeper] eolivelli commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

eolivelli commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066#issuecomment-536011760 @anmolmar is it worth to cherry pick to 3.5.6? -

[GitHub] [zookeeper] TisonKun opened a new pull request #1100: ZOOKEEPER-3509: Revisit log format

TisonKun opened a new pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100 1. Always wrap `.trace` with `isTraceEnabled`. It is because that some of trace calls are a bit complex. 2. Never wrap other levels with `isXXXEnabled`. Logger

[GitHub] [zookeeper] eolivelli commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

eolivelli commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r329263687 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6

[GitHub] [zookeeper] anmolnar commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

anmolnar commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066#issuecomment-536208908 @eolivelli Without taking the size and impact of patch into account, I would say that don't interfere the rel

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer

lvfangmin commented on a change in pull request #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer URL: https://github.com/apache/zookeeper/pull/1085#discussion_r329342057 ## File path: zookeeper-server/src/main/

[GitHub] [zookeeper] lvfangmin commented on issue #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer

lvfangmin commented on issue #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer URL: https://github.com/apache/zookeeper/pull/1085#issuecomment-536263078 @anmolnar adding the test for SoLinger behavior would be tricky, and

[GitHub] [zookeeper] lvfangmin commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

lvfangmin commented on a change in pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081#discussion_r329342356 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLead

[GitHub] [zookeeper] eolivelli commented on issue #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer

eolivelli commented on issue #1085: [ZOOKEEPER-3384] Add SO_LINGER socket option to avoid long quorum unavailable during close with full send buffer URL: https://github.com/apache/zookeeper/pull/1085#issuecomment-536281594 IMHO there is no strict need of a test in this case ---

[GitHub] [zookeeper] mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe…

mcfatealan commented on issue #1077: ZOOKEEPER-3531: Synchronization on ACLCache cause cluster to hang whe… URL: https://github.com/apache/zookeeper/pull/1077#issuecomment-536365842 @maoling @lvfangmin My pleasure, thanks for the reviewing work!

[GitHub] [zookeeper] maoling commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions

maoling commented on a change in pull request #1045: ZOOKEEPER-3400: Add documentation on local sessions URL: https://github.com/apache/zookeeper/pull/1045#discussion_r329403355 ## File path: zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md ## @@ -503,6 +

[GitHub] [zookeeper] ztzg commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks

ztzg commented on issue #1066: ZOOKEEPER-2282: C Client: chroot not stripped in asynchronous callbacks URL: https://github.com/apache/zookeeper/pull/1066#issuecomment-536420203 Thank you! This is an automated message from the

[GitHub] [zookeeper] ztzg closed pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication

ztzg closed pull request #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication URL: https://github.com/apache/zookeeper/pull/1054 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zookeeper] ztzg commented on issue #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication

ztzg commented on issue #1054: ZOOKEEPER-1112: Add support for C client for SASL authentication URL: https://github.com/apache/zookeeper/pull/1054#issuecomment-536423589 Greetings, all, I am withdrawing this pull request for now. We had to rework the mechanism to enable automatic S

[GitHub] [zookeeper] enixon commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

enixon commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#issuecomment-536655889 looks good to me too +1 This is an autom

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701159 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java ## @@ -169,7

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329704838 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@ -1687,8 +169

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701768 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -1634,9 +1638,

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329698201 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java ## @@ -76,20

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701474 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -505,7 +516,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329708222 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -1273,11 +1279,13 @@ publi

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329700162 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java ## @@ -293,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701364 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -620,8 +636,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329691424 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientTest.java ## @@ -140,15 +140,15 @@

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329705056 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -373,15 +381,15 @

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701560 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -441,11 +450,

[GitHub] [zookeeper] arshadmohammad opened a new pull request #1101: ZOOKEEPER-3561: Generalize target authentication scheme for ZooKeeper authentication enforcement

arshadmohammad opened a new pull request #1101: ZOOKEEPER-3561: Generalize target authentication scheme for ZooKeeper authentication enforcement URL: https://github.com/apache/zookeeper/pull/1101 This is an automated message

[GitHub] [zookeeper] asfgit closed pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

asfgit closed pull request #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099 This is an automated message from the Apache Git Service. To resp

[GitHub] [zookeeper] arshadmohammad commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

arshadmohammad commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#issuecomment-536747276 Merged into master. This PR has conflict with branch-3.5. @sujithsimon22 can you please raise

[GitHub] [zookeeper] eolivelli commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname

eolivelli commented on issue #1099: ZOOKEEPER-1467: Server principal on client side is derived using hostname URL: https://github.com/apache/zookeeper/pull/1099#issuecomment-536748429 @arshadmohammad can you commit this change to master branch? -

[GitHub] [zookeeper] asfgit closed pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages

asfgit closed pull request #1081: ZOOKEEPER-3537: Leader election - Use of out of election messages URL: https://github.com/apache/zookeeper/pull/1081 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [zookeeper] phunt commented on issue #1102: ZOOKEEPER-3563: dependency check failing on 3.4 and 3.5 branches - CV…

phunt commented on issue #1102: ZOOKEEPER-3563: dependency check failing on 3.4 and 3.5 branches - CV… URL: https://github.com/apache/zookeeper/pull/1102#issuecomment-536797180 Tests passed for me on my Mac. This is an automa

  1   2   3   4   5   6   7   8   9   10   >