[GitHub] [geode] lgtm-com[bot] commented on pull request #5270: GEODE-6150: added test

lgtm-com[bot] commented on pull request #5270: URL: https://github.com/apache/geode/pull/5270#issuecomment-648800451 This pull request **introduces 9 alerts** and **fixes 2** when merging 43052f39ff8b21c33ed3c7c0b79cd9f28188c75f into ca5d961bf3e79e88d06405604b6eb25c2acfd238 - [view on

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r444930478 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/mutators/DiskStoreManager.java ## @@ -0,0 +1,76 @@ +/* + *

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r444928974 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5282: GEODE-8288: Match Redis's glob-style pattern

sabbeyPivotal commented on a change in pull request #5282: URL: https://github.com/apache/geode/pull/5282#discussion_r444925733 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/KeysExecutor.java ## @@ -45,7 +47,10 @@ public RedisResponse

[GitHub] [geode-native] albertogpz commented on a change in pull request #621: GEODE-8213: Switch SerializationRegistry spinlock to mutex

albertogpz commented on a change in pull request #621: URL: https://github.com/apache/geode-native/pull/621#discussion_r444704517 ## File path: cppcache/src/SerializationRegistry.hpp ## @@ -79,10 +80,10 @@ class TheTypeMap { std::unordered_map

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5282: GEODE-8288: Match Redis's glob-style pattern

dschneider-pivotal commented on a change in pull request #5282: URL: https://github.com/apache/geode/pull/5282#discussion_r444730179 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/KeysExecutor.java ## @@ -45,7 +47,10 @@ public

[GitHub] [geode] jujoramos opened a new pull request #5295: [WIP]: Do not review - Reflections

jujoramos opened a new pull request #5295: URL: https://github.com/apache/geode/pull/5295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] kohlmu-pivotal merged pull request #5293: GEODE-8190: Clean up tests and automate Geode version.

kohlmu-pivotal merged pull request #5293: URL: https://github.com/apache/geode/pull/5293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] kirklund commented on pull request #5294: Geode Logging doc changes

kirklund commented on pull request #5294: URL: https://github.com/apache/geode/pull/5294#issuecomment-648914278 @davebarnes97 The Jira ticket is GEODE-8250: https://issues.apache.org/jira/browse/GEODE-8250 This is an

[GitHub] [geode] nabarunnag commented on a change in pull request #5279: GEODE-8287: Added another condition to cause the indexed value to be …

nabarunnag commented on a change in pull request #5279: URL: https://github.com/apache/geode/pull/5279#discussion_r445014814 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/dunit/IndexUsageInJoinQueryDistributedTest.java ## @@ -0,0 +1,209 @@ +/*

[GitHub] [geode] yozaner1324 opened a new pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

yozaner1324 opened a new pull request #5297: URL: https://github.com/apache/geode/pull/5297 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] yozaner1324 closed pull request #5296: GEODE-8239 - Add Gradle config to add 'Class-Path' and 'Dependent-Modules' attributes to manifest file

yozaner1324 closed pull request #5296: URL: https://github.com/apache/geode/pull/5296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r444931732 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [geode] jinmeiliao commented on a change in pull request #5281: Further rework of the RestoreRedundancy data objects for serialization

jinmeiliao commented on a change in pull request #5281: URL: https://github.com/apache/geode/pull/5281#discussion_r444981216 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java ## @@ -153,39 +157,64

[GitHub] [geode] jinmeiliao commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jinmeiliao commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r444989870 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r445045526 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

rhoughton-pivot commented on a change in pull request #5297: URL: https://github.com/apache/geode/pull/5297#discussion_r445061619 ## File path: gradle/publish-java.gradle ## @@ -28,3 +28,41 @@ publishing { } } } + +gradle.taskGraph.whenReady({ graph -> +

[GitHub] [geode] mhansonp commented on a change in pull request #5281: Further rework of the RestoreRedundancy data objects for serialization

mhansonp commented on a change in pull request #5281: URL: https://github.com/apache/geode/pull/5281#discussion_r445019548 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java ## @@ -153,39 +157,64 @@

[GitHub] [geode] mhansonp commented on a change in pull request #5281: Further rework of the RestoreRedundancy data objects for serialization

mhansonp commented on a change in pull request #5281: URL: https://github.com/apache/geode/pull/5281#discussion_r445019236 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java ## @@ -153,39 +157,64 @@

[GitHub] [geode] yozaner1324 closed pull request #5292: GEODE-8239 - Add Gradle config to generate manifest file

yozaner1324 closed pull request #5292: URL: https://github.com/apache/geode/pull/5292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] yozaner1324 opened a new pull request #5296: GEODE-8239 - Add Gradle config to add 'Class-Path' and 'Dependent-Modules' attributes to manifest file

yozaner1324 opened a new pull request #5296: URL: https://github.com/apache/geode/pull/5296 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] davebarnes97 merged pull request #5294: Geode Logging doc changes

davebarnes97 merged pull request #5294: URL: https://github.com/apache/geode/pull/5294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] mhansonp commented on a change in pull request #5281: Further rework of the RestoreRedundancy data objects for serialization

mhansonp commented on a change in pull request #5281: URL: https://github.com/apache/geode/pull/5281#discussion_r445034670 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/control/SerializableRestoreRedundancyResultsImplTest.java ## @@ -153,39 +157,64 @@

[GitHub] [geode] jmelchio commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jmelchio commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r444973701 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache

[GitHub] [geode] boglesby commented on a change in pull request #5279: GEODE-8287: Added another condition to cause the indexed value to be …

boglesby commented on a change in pull request #5279: URL: https://github.com/apache/geode/pull/5279#discussion_r445033163 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/dunit/IndexUsageInJoinQueryDistributedTest.java ## @@ -0,0 +1,210 @@ +/* +

[GitHub] [geode] jinmeiliao commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jinmeiliao commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r445063302 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the

[GitHub] [geode] boglesby commented on a change in pull request #5279: GEODE-8287: Added another condition to cause the indexed value to be …

boglesby commented on a change in pull request #5279: URL: https://github.com/apache/geode/pull/5279#discussion_r445025441 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/dunit/IndexUsageInJoinQueryDistributedTest.java ## @@ -0,0 +1,210 @@ +/* +

[GitHub] [geode] jinmeiliao commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445142798 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/cli/SingleGfshCommand.java ## @@ -39,7 +42,11 @@ *return value of your

[GitHub] [geode] jinmeiliao commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445142428 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/remote/OnlineCommandProcessor.java ## @@ -53,14 +57,13 @@ private

[GitHub] [geode] kirklund merged pull request #5268: GEODE-8250: Create new custom log config acceptance tests

kirklund merged pull request #5268: URL: https://github.com/apache/geode/pull/5268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] bschuchardt merged pull request #5280: GEODE-8285: Fix error message's directory path for sanctioned text file

bschuchardt merged pull request #5280: URL: https://github.com/apache/geode/pull/5280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] kohlmu-pivotal merged pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

kohlmu-pivotal merged pull request #5297: URL: https://github.com/apache/geode/pull/5297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jinmeiliao opened a new pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

jinmeiliao opened a new pull request #5299: URL: https://github.com/apache/geode/pull/5299 * improve some backward compatibility test to cover more versions. This is an automated message from the Apache Git Service. To

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

kohlmu-pivotal commented on a change in pull request #5297: URL: https://github.com/apache/geode/pull/5297#discussion_r445075841 ## File path: gradle/publish-java.gradle ## @@ -28,3 +28,41 @@ publishing { } } } + +gradle.taskGraph.whenReady({ graph -> +

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

kohlmu-pivotal commented on a change in pull request #5297: URL: https://github.com/apache/geode/pull/5297#discussion_r445075557 ## File path: gradle/publish-java.gradle ## @@ -28,3 +28,41 @@ publishing { } } } + +gradle.taskGraph.whenReady({ graph -> +

[GitHub] [geode-native] pdxcodemonkey merged pull request #622: GEODE-8128: Add new SNI test in new test framewok

pdxcodemonkey merged pull request #622: URL: https://github.com/apache/geode-native/pull/622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #621: GEODE-8213: Switch SerializationRegistry spinlock to mutex

pivotal-jbarrett commented on a change in pull request #621: URL: https://github.com/apache/geode-native/pull/621#discussion_r445106638 ## File path: cppcache/src/SerializationRegistry.hpp ## @@ -79,10 +80,10 @@ class TheTypeMap { std::unordered_map

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5216: Refactor set executor

dschneider-pivotal commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445111647 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/StringsIntegrationTest.java ## @@ -0,0

[GitHub] [geode] jinmeiliao commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445136917 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java ## @@ -113,7 +113,7 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445141795 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/cli/SingleGfshCommand.java ## @@ -39,7 +42,11 @@ *return value of your

[GitHub] [geode] lgtm-com[bot] commented on pull request #5270: GEODE-6150: added test

lgtm-com[bot] commented on pull request #5270: URL: https://github.com/apache/geode/pull/5270#issuecomment-649068114 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5289: refactor GeodeRedisServer

jdeppe-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445196891 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/PassiveExpirationManager.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] [geode] yozaner1324 commented on a change in pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

yozaner1324 commented on a change in pull request #5297: URL: https://github.com/apache/geode/pull/5297#discussion_r445075176 ## File path: gradle/publish-java.gradle ## @@ -28,3 +28,41 @@ publishing { } } } + +gradle.taskGraph.whenReady({ graph -> +

[GitHub] [geode] jdeppe-pivotal merged pull request #5282: GEODE-8288: Match Redis's glob-style pattern

jdeppe-pivotal merged pull request #5282: URL: https://github.com/apache/geode/pull/5282 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5289: refactor GeodeRedisServer

lgtm-com[bot] commented on pull request #5289: URL: https://github.com/apache/geode/pull/5289#issuecomment-649069446 This pull request **introduces 1 alert** and **fixes 1** when merging 3eb2b0e65fbcea9d49f518bf2b5bd56609c3e68f into 210dc4fe9b1657d8d7cb5c197c6b0153389be3ea - [view on

[GitHub] [geode] mhansonp merged pull request #5281: Further rework of the RestoreRedundancy data objects for serialization

mhansonp merged pull request #5281: URL: https://github.com/apache/geode/pull/5281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] agingade commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

agingade commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445095963 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java ## @@ -113,7 +113,7 @@ public class

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5297: GEODE-8239 - Add gradle config to add 'Class-Path' and 'Dependent-Modules' attirbutes to manifest file

rhoughton-pivot commented on a change in pull request #5297: URL: https://github.com/apache/geode/pull/5297#discussion_r445129237 ## File path: gradle/publish-java.gradle ## @@ -28,3 +28,41 @@ publishing { } } } + +gradle.taskGraph.whenReady({ graph -> +

[GitHub] [geode] jinmeiliao commented on pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on pull request #5285: URL: https://github.com/apache/geode/pull/5285#issuecomment-649039263 > I have some questions about `SingleGfshCommand`, which is extended by commands that will update cluster config. Now in this pull request, quite a few classes used to be

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5289: refactor GeodeRedisServer

dschneider-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445206636 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jinmeiliao commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445216158 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java ## @@ -113,7 +113,7 @@ public

[GitHub] [geode] dschneider-pivotal opened a new pull request #5302: Redis stats

dschneider-pivotal opened a new pull request #5302: URL: https://github.com/apache/geode/pull/5302 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] lgtm-com[bot] commented on pull request #5302: Redis stats

lgtm-com[bot] commented on pull request #5302: URL: https://github.com/apache/geode/pull/5302#issuecomment-649164092 This pull request **introduces 1 alert** and **fixes 1** when merging 9e002a594db931305e8bc38a1e5156a37face52e into 5732a1c1ef9c8ccb979770a963d5c4b1b7324f1a - [view on

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445205109 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/StringsIntegrationTest.java ## @@ -0,0 +1,1637 @@

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445204696 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/string/StringSetExecutorJUnitTest.java ## @@ -213,4 +229,34 @@ public

[GitHub] [geode] lgtm-com[bot] commented on pull request #5289: GEODE-8295: refactor GeodeRedisServer

lgtm-com[bot] commented on pull request #5289: URL: https://github.com/apache/geode/pull/5289#issuecomment-649120737 This pull request **introduces 1 alert** and **fixes 1** when merging 54ed604c30def8db08bc18f9eeea656624e2ea7d into 5732a1c1ef9c8ccb979770a963d5c4b1b7324f1a - [view on

[GitHub] [geode] kirklund opened a new pull request #5301: Revert "GEODE-8250: Create new custom log config acceptance tests (#5…

kirklund opened a new pull request #5301: URL: https://github.com/apache/geode/pull/5301 …268)" This reverts commit ba6e44cf3aafcee211590fd06a65fc561f20578f. This is an automated message from the Apache Git

[GitHub] [geode] jinmeiliao commented on a change in pull request #5288: GEODE-8283: Provide REST interface for disk-store creation

jinmeiliao commented on a change in pull request #5288: URL: https://github.com/apache/geode/pull/5288#discussion_r445263810 ## File path: geode-management/src/main/java/org/apache/geode/management/configuration/DiskStore.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445204473 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/string/StringSetExecutorJUnitTest.java ## @@ -213,4 +229,34 @@ public

[GitHub] [geode] mhansonp opened a new pull request #5300: GEODE-8095: Changes to make GEODE Respond to Restore Redundancy REST Command

mhansonp opened a new pull request #5300: URL: https://github.com/apache/geode/pull/5300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jchen21 commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

jchen21 commented on a change in pull request #5299: URL: https://github.com/apache/geode/pull/5299#discussion_r445226334 ## File path: geode-assembly/src/upgradeTest/java/org/apache/geode/management/DeploymentManagementUpgradeTest.java ## @@ -55,16 +84,16 @@ public static

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5289: refactor GeodeRedisServer

dschneider-pivotal commented on a change in pull request #5289: URL: https://github.com/apache/geode/pull/5289#discussion_r445208186 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/PassiveExpirationManager.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to

[GitHub] [geode] onichols-pivotal commented on pull request #4800: Add Mass Test Run pipeline.

onichols-pivotal commented on pull request #4800: URL: https://github.com/apache/geode/pull/4800#issuecomment-649105786 superceded by #5271 + #5287 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] onichols-pivotal closed pull request #4800: Add Mass Test Run pipeline.

onichols-pivotal closed pull request #4800: URL: https://github.com/apache/geode/pull/4800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] lgtm-com[bot] commented on pull request #5302: Redis stats

lgtm-com[bot] commented on pull request #5302: URL: https://github.com/apache/geode/pull/5302#issuecomment-649151060 This pull request **introduces 1 alert** and **fixes 1** when merging 823f452e702b4be09a43c7a6c5eb5df8732fe122 into 5732a1c1ef9c8ccb979770a963d5c4b1b7324f1a - [view on

[GitHub] [geode] smgoller opened a new pull request #5298: Fix metric-tools image python requirements.

smgoller opened a new pull request #5298: URL: https://github.com/apache/geode/pull/5298 Authored-by: Sean Goller Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #621: GEODE-8213: Switch SerializationRegistry spinlock to mutex

pivotal-jbarrett commented on a change in pull request #621: URL: https://github.com/apache/geode-native/pull/621#discussion_r445104329 ## File path: cppcache/src/SerializationRegistry.hpp ## @@ -79,10 +80,10 @@ class TheTypeMap { std::unordered_map

[GitHub] [geode] jchen21 commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

jchen21 commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445095363 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/cli/SingleGfshCommand.java ## @@ -39,7 +42,11 @@ *return value of your

[GitHub] [geode] smgoller merged pull request #5298: Fix metric-tools image python requirements.

smgoller merged pull request #5298: URL: https://github.com/apache/geode/pull/5298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] agingade commented on a change in pull request #5285: GEODE-8099: make those gfsh commands that updates cluster configurati…

agingade commented on a change in pull request #5285: URL: https://github.com/apache/geode/pull/5285#discussion_r445173321 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java ## @@ -113,7 +113,7 @@ public class