[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on a change in pull request #5175: URL: https://github.com/apache/geode/pull/5175#discussion_r472873883 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/OfflineDiskStoreCommandsDUnitTest.java ## @@ -0,0

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473085253 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] alb3rtobr commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676479642 Hi @pdxcodemonkey , @pivotal-jbarrett , @moleske . I have not been able to create a test case that fails every time it is executed. Without the fix, the test case I have

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473107131 ## File path: cppcache/integration/test/sni-test-config/geode-config/truststore_sni.pem ## @@ -0,0 +1,68 @@ +-BEGIN CERTIFICATE-

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] alb3rtobr opened a new pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

alb3rtobr opened a new pull request #635: URL: https://github.com/apache/geode-native/pull/635 A segmentation fault is produced when `PdxInstanceFactory::create()` is called by several threads that are registering the same new pdx type. The core is produced here: ``` void

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473081067 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^ host,

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473185831 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public ResultModel

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473184805 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [geode-native] moleske commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

moleske commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473247270 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473117796 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +106,65 @@ private void

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473195346 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public ResultModel

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473244538 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473251486 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473123270 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473143292 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType,

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473192044 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -120,28 +117,14 @@ public void

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473191623 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473192044 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -120,28 +117,14 @@ public void

[GitHub] [geode-native] pdxcodemonkey commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pdxcodemonkey commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676558659 I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument:

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

pivotal-jbarrett commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473135846 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -120,28 +117,14 @@ public void

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473123270 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676515632 > Hi @pdxcodemonkey , @pivotal-jbarrett , @moleske . I have not been able to create a test case that fails every time it is executed. Without the fix, the test case

[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on a change in pull request #5175: URL: https://github.com/apache/geode/pull/5175#discussion_r472878920 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java ## @@ -2318,7 +2318,7 @@ void close(boolean destroy) {

[GitHub] [geode] gesterzhou merged pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

gesterzhou merged pull request #5464: URL: https://github.com/apache/geode/pull/5464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473190161 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473141355 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473183003 ## File path: cppcache/integration/test/sni-test-config/geode-config/truststore_sni.pem ## @@ -0,0 +1,68 @@ +-BEGIN CERTIFICATE-

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode-native] pivotal-jbarrett edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473141355 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473142076 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] pdxcodemonkey commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pdxcodemonkey commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676524873 Travis CI is failing due to a clang-format issue in the new test file. Please run `cmake --build . --target all-clangformat` and check in the formatting changes.

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473186241 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] pivotal-jbarrett edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473346910 ## File path: cppcache/src/TcpSslConn.hpp ## @@ -67,14 +81,18 @@ class TcpSslConn : public TcpConn { const char* privkeyfile,

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode-native] pdxcodemonkey merged pull request #634: GEODE-8398: Add SNI support to .NET API

pdxcodemonkey merged pull request #634: URL: https://github.com/apache/geode-native/pull/634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] echobravopapa commented on pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on pull request #634: URL: https://github.com/apache/geode-native/pull/634#issuecomment-676737699 @pivotal-jbarrett latest mergable is up... This is an automated message from the Apache Git Service.

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473389534 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473389112 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode] bschuchardt merged pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt merged pull request #5465: URL: https://github.com/apache/geode/pull/5465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473293806 ## File path: cppcache/src/TcpSslConn.cpp ## @@ -87,15 +97,13 @@ void TcpSslConn::connect() { ACE_OS::signal(SIGPIPE, SIG_IGN); // Ignore

[GitHub] [geode] BenjaminPerryRoss merged pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

BenjaminPerryRoss merged pull request #5391: URL: https://github.com/apache/geode/pull/5391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] lgtm-com[bot] commented on pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

lgtm-com[bot] commented on pull request #5363: URL: https://github.com/apache/geode/pull/5363#issuecomment-676750568 This pull request **introduces 1 alert** and **fixes 1** when merging 51c68d95ffdb37432b184926b97bf666be9638b0 into 6f12a360d82f0de9259557af2bca34cd84e4b5f4 - [view on

[GitHub] [geode-native] moleske commented on pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on pull request #625: URL: https://github.com/apache/geode-native/pull/625#issuecomment-676864451 @pdxcodemonkey still no rush, but I had to resolve a conflict `cppcache/integration/framework/TestConfig.cpp.in`. I'd like to merge this is in sooner rather than later.

[GitHub] [geode-native] moleske commented on pull request #636: Add notes about docker requirement

moleske commented on pull request #636: URL: https://github.com/apache/geode-native/pull/636#issuecomment-676882065 I think we need both, we should call out that if you really want to run all the tests, you will need docker and we should do some cmake logic to help out

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #636: Add notes about docker requirement

pivotal-jbarrett commented on pull request #636: URL: https://github.com/apache/geode-native/pull/636#issuecomment-676879501 How about making CMake detect Docker and enable/disable Docker based tests depending on its existence?

[GitHub] [geode-native] moleske opened a new pull request #636: Add notes about docker requirement

moleske opened a new pull request #636: URL: https://github.com/apache/geode-native/pull/636 Authored-by: M. Oleske Test `42: SNITest.connectViaProxyTest` requires docker running on your machine, otherwise it fails. This means docker should be mentioned as a required install now

[GitHub] [geode-native] pdxcodemonkey closed pull request #573: GEODE-7697: OpenSSL 1.1.0 minimum required, removed openssl-compat

pdxcodemonkey closed pull request #573: URL: https://github.com/apache/geode-native/pull/573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey commented on pull request #573: GEODE-7697: OpenSSL 1.1.0 minimum required, removed openssl-compat

pdxcodemonkey commented on pull request #573: URL: https://github.com/apache/geode-native/pull/573#issuecomment-676854328 We've merged the SSL code into the client proper, so this is no longer relevant. This is an automated