[GitHub] [geode-native] albertogpz opened a new pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

albertogpz opened a new pull request #642: URL: https://github.com/apache/geode-native/pull/642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

rhoughton-pivot commented on a change in pull request #5479: URL: https://github.com/apache/geode/pull/5479#discussion_r477467740 ## File path: ci/scripts/execute_build_examples.sh ## @@ -46,7 +46,8 @@ INSTANCE_IP_ADDRESS="$(cat instance-data/instance-ip-address)"

[GitHub] [geode] smgoller opened a new pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

smgoller opened a new pull request #5479: URL: https://github.com/apache/geode/pull/5479 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] rhoughton-pivot opened a new pull request #5480: GEODE-8458: Use build metadata properties as task inputs

rhoughton-pivot opened a new pull request #5480: URL: https://github.com/apache/geode/pull/5480 * Rebuilds GemFireVersion.properties on Git repo or property changes * version * build user * java version * productName * etc Thank you for submitting a

[GitHub] [geode] jinmeiliao merged pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

jinmeiliao merged pull request #5469: URL: https://github.com/apache/geode/pull/5469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal opened a new pull request #5481: GEODE-8459: Redis API for Geode handles errors when member disconnects

sabbeyPivotal opened a new pull request #5481: URL: https://github.com/apache/geode/pull/5481 Redis API for Geode should properly handle DistributedSystemDisconnectedException and ForcedDisconnectException when member disconnects. Client should be closed and a null response should be

[GitHub] [geode-native] mmartell commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

mmartell commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477356345 ## File path: clicache/test2/Tests2.cs ## @@ -123,7 +123,24 @@ public void RegisterPdxType() Assert.False(_pdxDelegate2Called); } -

[GitHub] [geode-native] mmartell commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

mmartell commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477357183 ## File path: cppcache/src/Pool.cpp ## @@ -45,6 +45,9 @@ std::chrono::milliseconds Pool::getReadTimeout() const { return

[GitHub] [geode] smgoller merged pull request #5474: Part 2 - Change all tests to use liberica instead of openjdk. Part 3 will remove openjdk.

smgoller merged pull request #5474: URL: https://github.com/apache/geode/pull/5474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r477410555 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode-native] mmartell merged pull request #641: GEODE-8398: Add sni unittest for dotnet

mmartell merged pull request #641: URL: https://github.com/apache/geode-native/pull/641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt opened a new pull request #5482: GEODE-8463: server's log filled with SSLException: Tag mismatch!

bschuchardt opened a new pull request #5482: URL: https://github.com/apache/geode/pull/5482 This disables the use of TLSv1.3 selection if "any" is specified as the protocol and throws an exception if TLSv1.3 is requested in a JVM older than Java 11. Most Java 8 implementations do not

[GitHub] [geode-native] moleske commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

moleske commented on a change in pull request #642: URL: https://github.com/apache/geode-native/pull/642#discussion_r477581852 ## File path: cppcache/src/ThinClientPoolDM.cpp ## @@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest( }

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

pivotal-jbarrett commented on a change in pull request #642: URL: https://github.com/apache/geode-native/pull/642#discussion_r477658402 ## File path: cppcache/src/ThinClientPoolDM.cpp ## @@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest( }

[GitHub] [geode] moleske commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

moleske commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r477579763 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken implements

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r477596231 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken

[GitHub] [geode] DonalEvans commented on a change in pull request #5476: GEODE-8455: Fix difference between create region with gw sender and a…

DonalEvans commented on a change in pull request #5476: URL: https://github.com/apache/geode/pull/5476#discussion_r477509049 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -3197,6 +3114,18 @@ public static Boolean

[GitHub] [geode] smgoller merged pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

smgoller merged pull request #5479: URL: https://github.com/apache/geode/pull/5479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jdeppe-pivotal merged pull request #5481: GEODE-8459: Redis API for Geode handles errors when member disconnects

jdeppe-pivotal merged pull request #5481: URL: https://github.com/apache/geode/pull/5481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-681131715 This pull request **introduces 2 alerts** and **fixes 2** when merging 52589379decb06a1f58a5d4e67d645bf0a93c288 into cecf0035be9ea02b8ff66749f61ce93c026646ca - [view on

[GitHub] [geode-native] mmartell opened a new pull request #641: GEODE-8398: Add sni unittest for dotnet

mmartell opened a new pull request #641: URL: https://github.com/apache/geode-native/pull/641 Since the .NET API is a thin wrapper around the C++ API, all we really need to test in this layer is that the sni parameters are passed properly to the C++ layer. This PR adds a new unit

[GitHub] [geode-native] echobravopapa commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

echobravopapa commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477343512 ## File path: clicache/test2/Tests2.cs ## @@ -123,7 +123,24 @@ public void RegisterPdxType() Assert.False(_pdxDelegate2Called); }