eric-milles opened a new pull request #1680:
URL: https://github.com/apache/groovy/pull/1680
In the case of a binary trait, a helper method may have the varargs modifier
(same as transient for a field). This change removes that before the transient
modifier check that was added in Groovy
eric-milles merged pull request #1680:
URL: https://github.com/apache/groovy/pull/1680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
eric-milles opened a new pull request #1681:
URL: https://github.com/apache/groovy/pull/1681
> The discovery mechanism is present in
`ClassNodeResolver`/`CompileUnit`/`CompilationUnit` to locate a source, add it
and start resolve phase over. The map `sources` in `CompilationUnit` is
inser
eric-milles commented on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1030378719
I could do a counting loop from length-1 to 0 instead of reverse to save
that cost.
--
This is an automated message from the Apache Git Service.
To respond to the message,
eric-milles edited a comment on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1030378719
I could do a counting loop from length-1 to 0 instead to save the cost of
`reverse`.
--
This is an automated message from the Apache Git Service.
To respond to the
eric-milles opened a new pull request #1682:
URL: https://github.com/apache/groovy/pull/1682
https://issues.apache.org/jira/browse/GROOVY-8448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eric-milles opened a new pull request #1683:
URL: https://github.com/apache/groovy/pull/1683
Groovy 2.5 can support Java 15 target with minimal changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eric-milles commented on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1031910543
I did run into a case of same-package types where the reverse order causes
missed inner type resolution. I'll try to construct a test case. At least
this commit can serve
eric-milles merged pull request #1682:
URL: https://github.com/apache/groovy/pull/1682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert opened a new pull request #1684:
URL: https://github.com/apache/groovy/pull/1684
…volved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
paulk-asert merged pull request #1683:
URL: https://github.com/apache/groovy/pull/1683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on pull request #1683:
URL: https://github.com/apache/groovy/pull/1683#issuecomment-1038730513
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asfgit merged pull request #1684:
URL: https://github.com/apache/groovy/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
paulk-asert opened a new pull request #1685:
URL: https://github.com/apache/groovy/pull/1685
…f $getLookup() method is not static
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
eric-milles opened a new pull request #1686:
URL: https://github.com/apache/groovy/pull/1686
Wrapping `NamedParam` annotations in a `NamedParams` container is
straightforward. For default values, I wanted to use `map.containsKey(name) ?
map.name : defaultValue` instead of `map.name ? map.
asfgit merged pull request #1685:
URL: https://github.com/apache/groovy/pull/1685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
paulk-asert commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041493348
I am still looking at the changes. Some effort was put into making
primitives behave in an "expected" way but whether we are consistent to what
happens elsewhere needs furth
eric-milles commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041701400
The change for GROOVY-10484 could be separated out. The other changes are
to address 10176 and 9158 (which can be argued have been addressed already by
changes in Groovy 4)
eric-milles edited a comment on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041701400
The change for GROOVY-10484 could be separated out. The other changes are
to address 10176 and 9158 (which can be argued have been addressed already by
changes in Gr
eric-milles edited a comment on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041701400
The change for GROOVY-10484 could be separated out. The other changes are
to address 10176 and 9158 (which can be argued have been addressed already by
changes in Gr
eric-milles edited a comment on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041701400
The change for GROOVY-10484 could be separated out. The other changes are
to address 10176 and 9158 (which can be argued have been addressed already by
changes in Gr
eric-milles commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1041892273
This commit has been reduced to 10484 changes only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
eric-milles opened a new pull request #1687:
URL: https://github.com/apache/groovy/pull/1687
For default values, I want to use `map.containsKey(name) ? map.name :
defaultValue` instead of `map.name ?: defaultValue` -- in case `null` or `0` or
another falsy value is supplied. This change d
eric-milles commented on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1041912453
`map.getOrDefault(name,defaultValue)` is another option. The ternary avoids
evaluating `defaultValue` if it is not used.
--
This is an automated message from the Apache G
eric-milles commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1042096674
NOTE: This is a solution that I can backport to Groovy 2.5, which lacks the
`@Repeatable` annotation:
https://github.com/apache/groovy/blob/GROOVY_2_5_X/src/main/groovy/groo
paulk-asert commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1044421069
I still wonder whether forcing the collation early should be a 2.5 only
thing - simply because if other frameworks like Grails or Micronaut did similar
NamedParam additions
paulk-asert commented on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1044455780
I am in favor of removing the truthy and null-handling aspect. I think the
intention was just to handle the null case but I think we shouldn't even handle
that. We could alw
paulk-asert edited a comment on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1044455780
I am in favor of removing the truthy and null-handling aspect. I think the
intention was just to handle the null case but I think we shouldn't even handle
that - inst
paulk-asert edited a comment on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1044455780
I am in favor of removing the truthy and null-handling aspect. I think the
intention was just to handle the null case but I think we shouldn't even handle
that - inst
eric-milles commented on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1044796879
Not sure I follow fully. Are you saying go with the replacement of elvisX
with ternaryX/containsKey, but leave off the primitive null check (lines
283-285)?
--
This is a
eric-milles commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1044799201
I can look into STCV changes instead if there is concern that others may be
adding `@NamedParam` without the wrapper. Are there any examples of this?
--
This is an automa
paulk-asert commented on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1045245638
Yes. And I was suggesting:
- we can add in some additional throw IllegalArgumentException statements in
places where the resulting error message is confusing, e.g. whe
paulk-asert merged pull request #1687:
URL: https://github.com/apache/groovy/pull/1687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on pull request #1687:
URL: https://github.com/apache/groovy/pull/1687#issuecomment-1045415536
I merged and will adjust a little as per my comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
eric-milles opened a new pull request #1688:
URL: https://github.com/apache/groovy/pull/1688
https://issues.apache.org/jira/browse/GROOVY-10500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
paulk-asert opened a new pull request #1689:
URL: https://github.com/apache/groovy/pull/1689
…tment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kriegaex opened a new pull request #1690:
URL: https://github.com/apache/groovy/pull/1690
This PR fixes
[`GROOVY-10503`](https://issues.apache.org/jira/browse/GROOVY-10503).
ASM 9.2 is compatible with Java 18. So now when compiling under Java 16+,
the compiler will be able to succes
eric-milles commented on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047870064
There is also a file for the CI build(s) if you wish the verification to
include Java 16 or 17 or 18:
https://github.com/apache/groovy/pull/1683/files#diff-6ac3f79fc25d95cd1
eric-milles commented on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047877124
Also if Groovy 2.5 offers official support for Java 16+, there are a class
of bugs around interface default methods that have only been fixed in Groovy 4+
that will likely b
eric-milles edited a comment on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047877124
Also if Groovy 2.5 offers official support for Java 16+, there are a class
of bugs around interface default methods that have only been fixed in Groovy 4+
that will l
eric-milles edited a comment on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047870064
There is also a file for the CI build(s) if you wish the verification to
include Java 16 or 17 or 18:
https://github.com/apache/groovy/pull/1683/files#diff-6ac3f79fc2
eric-milles edited a comment on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047870064
There is also a file for the CI build(s) if you wish the verification to
include Java 16 or 17 or 18:
https://github.com/apache/groovy/pull/1683/files#diff-6ac3f79fc2
kriegaex commented on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047958288
> Just a quick FYI, ASM 7 was only introduced 15 days ago and has not made
it into a release of Groovy 2.5 yet
What are you talking about? This is on the Groovy 2.5 branc
kriegaex commented on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047963645
> Also if Groovy 2.5 offers official support for Java 16+
I answered that on Jira already. It is not about official Java 16+ support
but about being able to parse class f
eric-milles commented on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047994547
> This is on the Groovy 2.5 branch and my change bumped it to 9.2
Yes, 15 days ago ASM was increased from 7 to 8 on 2_5_X branch. I chose to
hold back from ASM 9 to l
eric-milles edited a comment on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047870064
There is also a file for the CI build(s) if you wish the verification to
include Java 16 or 17 or 18:
https://github.com/apache/groovy/pull/1683/files#diff-6ac3f79fc2
kriegaex edited a comment on pull request #1690:
URL: https://github.com/apache/groovy/pull/1690#issuecomment-1047958288
> Just a quick FYI, ASM 8 was only introduced 15 days ago and has not made
it into a release of Groovy 2.5 yet
What are you talking about? This is on the Groovy 2.
asfgit merged pull request #1689:
URL: https://github.com/apache/groovy/pull/1689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
paulk-asert closed pull request #1688:
URL: https://github.com/apache/groovy/pull/1688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on pull request #1688:
URL: https://github.com/apache/groovy/pull/1688#issuecomment-1048788273
Proposed PR merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
paulk-asert closed pull request #267:
URL: https://github.com/apache/groovy/pull/267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications
paulk-asert commented on pull request #267:
URL: https://github.com/apache/groovy/pull/267#issuecomment-1050708729
Closing this as there is now a revised PR over on the Apache Groovy site:
https://github.com/apache/groovy/pull/1692
--
This is an automated message from the Apache Git Se
paulk-asert edited a comment on pull request #267:
URL: https://github.com/apache/groovy/pull/267#issuecomment-1050708729
Closing this as there is now a revised PR: #1692.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
paulk-asert commented on pull request #1391:
URL: https://github.com/apache/groovy/pull/1391#issuecomment-1050720763
No further feedback, I'll close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
paulk-asert closed pull request #1391:
URL: https://github.com/apache/groovy/pull/1391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
asfgit merged pull request #1692:
URL: https://github.com/apache/groovy/pull/1692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
paulk-asert commented on pull request #1692:
URL: https://github.com/apache/groovy/pull/1692#issuecomment-1052039065
Proposed PR merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
paulk-asert opened a new pull request #1693:
URL: https://github.com/apache/groovy/pull/1693
…sform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
paulk-asert commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1053938214
@eric-milles The alternative would look something like: #1693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
paulk-asert edited a comment on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1053938214
@eric-milles The alternative would look something like: #1693. I say
alternative, but both could be applied. My preference would be to go with #1693
for 3 and above a
paulk-asert opened a new pull request #1694:
URL: https://github.com/apache/groovy/pull/1694
…ics handling with fully qualified types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asfgit merged pull request #1693:
URL: https://github.com/apache/groovy/pull/1693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-un
paulk-asert commented on pull request #1694:
URL: https://github.com/apache/groovy/pull/1694#issuecomment-1054999287
Not needed, so closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
paulk-asert closed pull request #1694:
URL: https://github.com/apache/groovy/pull/1694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on a change in pull request #1691:
URL: https://github.com/apache/groovy/pull/1691#discussion_r816443569
##
File path:
src/main/java/org/codehaus/groovy/transform/trait/TraitASTTransformation.java
##
@@ -498,7 +500,7 @@ private void processField(final Fie
paulk-asert opened a new pull request #1695:
URL: https://github.com/apache/groovy/pull/1695
… a Statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
paulk-asert closed pull request #1686:
URL: https://github.com/apache/groovy/pull/1686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on pull request #1686:
URL: https://github.com/apache/groovy/pull/1686#issuecomment-1055403230
PR#1693 was merged in Groovy 3 and above. This PR was merged with minor
adjustments onto 2_5_X.
--
This is an automated message from the Apache Git Service.
To respond to
aulea commented on a change in pull request #1691:
URL: https://github.com/apache/groovy/pull/1691#discussion_r816819050
##
File path:
src/main/java/org/codehaus/groovy/transform/trait/TraitASTTransformation.java
##
@@ -498,7 +500,7 @@ private void processField(final FieldNode
paulk-asert commented on pull request #1695:
URL: https://github.com/apache/groovy/pull/1695#issuecomment-1056045783
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
paulk-asert closed pull request #1695:
URL: https://github.com/apache/groovy/pull/1695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
paulk-asert commented on pull request #1691:
URL: https://github.com/apache/groovy/pull/1691#issuecomment-1056058133
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
paulk-asert closed pull request #1691:
URL: https://github.com/apache/groovy/pull/1691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
eric-milles opened a new pull request #1696:
URL: https://github.com/apache/groovy/pull/1696
Here are some changes to support running Groovy 3 builds with Java 16+ for
purposes of evaluating issue reports. `upload.gradle` still needs to be
migrated to use the `maven-publish` plugin.
--
paulk-asert opened a new pull request #1697:
URL: https://github.com/apache/groovy/pull/1697
…n't own
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
eric-milles opened a new pull request #1698:
URL: https://github.com/apache/groovy/pull/1698
Solve order issue by resolving all class headers before resolving class
bodies (incl. `VariableScopeVisitor` application). `ResolveVisitor#visitClass`
is split into phases. I chose not to refacto
eric-milles closed pull request #1681:
URL: https://github.com/apache/groovy/pull/1681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificatio
sonatype-lift[bot] commented on a change in pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#discussion_r820010850
##
File path: src/main/java/org/codehaus/groovy/control/ResolveVisitor.java
##
@@ -1316,46 +1316,50 @@ public void visitClass(final ClassNode no
eric-milles commented on a change in pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#discussion_r820013195
##
File path: src/main/java/org/codehaus/groovy/control/ResolveVisitor.java
##
@@ -1316,46 +1316,50 @@ public void visitClass(final ClassNode node) {
sonatype-lift[bot] commented on a change in pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#discussion_r820013211
##
File path: src/main/java/org/codehaus/groovy/control/ResolveVisitor.java
##
@@ -1316,46 +1316,50 @@ public void visitClass(final ClassNode no
daniellansun merged pull request #1697:
URL: https://github.com/apache/groovy/pull/1697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
daniellansun commented on pull request #1697:
URL: https://github.com/apache/groovy/pull/1697#issuecomment-1059657455
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
johnrengelman opened a new pull request #1699:
URL: https://github.com/apache/groovy/pull/1699
Closes Groovy-10520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
paulk-asert commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1060251441
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
leonard84 commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1060530526
Will this make it into 4.0.1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
paulk-asert commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1060626763
That isn't the current plan. One day left in voting window for 4.0.1. We can
do a 4.0.2 fairly quickly if we need to but it would be good to do further
testing once this is
paulk-asert commented on pull request #1699:
URL: https://github.com/apache/groovy/pull/1699#issuecomment-1060657212
I suspect L#563 can now also lose the "sep?" but otherwise LGTM.
I haven't tried to measure if it impacts performance but accuracy would
trump performance.
--
This is a
paulk-asert edited a comment on pull request #1699:
URL: https://github.com/apache/groovy/pull/1699#issuecomment-1060657212
I suspect L#563 can now also lose the "sep?" but otherwise LGTM.
We don't seem to have a line column test for empty blocks but they should be
unaffected since we co
johnrengelman commented on pull request #1699:
URL: https://github.com/apache/groovy/pull/1699#issuecomment-1060720455
Thanks @paulk-asert
I included that change and forced pushed the branch with a commit message
that more closely follows existing comments.
--
This is an automated me
lptr commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1060755491
Can you publish a snapshot with these changes please? I'd like to run it on
Gradle. Alternatively, please try to run `./gradlew compileAll` on this brach:
https://github.com/gradle
paulk-asert commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1060797757
@lptr Does this work for you:
https://github.com/apache/groovy/actions/runs/1936513664
--
This is an automated message from the Apache Git Service.
To respond to the mes
daniellansun opened a new pull request #1700:
URL: https://github.com/apache/groovy/pull/1700
https://issues.apache.org/jira/browse/GROOVY-10495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
paulk-asert commented on pull request #1700:
URL: https://github.com/apache/groovy/pull/1700#issuecomment-1061342352
See alternate PR#1701.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
paulk-asert edited a comment on pull request #1700:
URL: https://github.com/apache/groovy/pull/1700#issuecomment-1061342352
See alternate PR #1701.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
paulk-asert commented on pull request #1701:
URL: https://github.com/apache/groovy/pull/1701#issuecomment-1061349121
The `preserveWhitespace` flag on `XmlTemplateEngine` works for content
inside a node. You also need `keepIgnorableWhitespace` for `XmlParser` to do
proper roundtripping as p
daniellansun commented on pull request #1700:
URL: https://github.com/apache/groovy/pull/1700#issuecomment-1061373586
> See alternate PR #1701.
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
daniellansun closed pull request #1700:
URL: https://github.com/apache/groovy/pull/1700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
lptr commented on pull request #1698:
URL: https://github.com/apache/groovy/pull/1698#issuecomment-1061648570
I don't think I can consume snapshots directly from GitHub like that. But
the test seems to be passing now, so I'd say it looks good to merge, and then I
can test the resulting sna
daniellansun merged pull request #1701:
URL: https://github.com/apache/groovy/pull/1701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notificati
daniellansun commented on pull request #1701:
URL: https://github.com/apache/groovy/pull/1701#issuecomment-1061698977
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1 - 100 of 4347 matches
Mail list logo
