Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
@nacx Sorry it's been a while since I have been able to spend some more time on JClouds and I am just returning to this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/400#issuec

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + @Nullable @PayloadParam("disk") List disks, @Nullable > CreateServerOptions options); + + @Named("server:delete") + @POST + @Path("/deleteServer") + @Produces(MediaType.APPLICATION_JSON) + @Fallback(Fallbacks.VoidOnNotFoundOr4

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > - public abstract int sizeGb(); + @Nullable + public abstract Integer sizeGb(); In our API disk size is always an integer value. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view i

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.dimensiondata.cloudcontrol.predicates; + +import com.google.common.base.Predicate; +import org.jclouds.dimensionda

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > throw new IllegalStateException(message); } } + public static void waitForVmToolsRunning(ServerApi api, String serverId, long timeoutMillis, String message) { + boolean vmwareToolsRunning = retry(new VMToolsRunningSt

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + } + } + + public void testGetServer() throws Exception { + server.enqueue(jsonResponse("/server.json")); + Server found = serverApi().getServer("12345"); + assertSent(GET, "/caas/2.4/6ac1e746-b1ea-4da5-a24e-caf1a978789d/

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + @Test + public void testDeployAndStartServer() { + Boolean started = Boolean.TRUE; + NetworkInfo networkInfo = NetworkInfo +.create(NETWORK_DOMAIN_ID, NIC.builder().vlanId(VLAN_ID).build(), Lists.newArrayList()); +

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 223707d JCLOUDS-1255 Server API migration. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/400/files/9b3b37ca9805041f9e635c4b9518fb8405d83adb..223707d9cdabf37d5c28528e8b7005418

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + } + + public void testListServers() throws Exception { + server.enqueue(jsonResponse("/servers.json")); + List servers = serverApi().listServers().concat().toList(); + Uris.UriBuilder uriBuilder = Uris.uriBuilder("/caas/2.4/6

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + @Test(dependsOnMethods = "testStartServer") + public void testShutdownServer() { + api().shutdownServer(serverId); + waitForServerStatus(api(), serverId, false, true, 30 * 60 * 1000, "Error"); + } + + @Test(dependsOnMethods =

Re: [jclouds/jclouds-labs] JCLOUDS-1255 Server API migration. (#400)

2017-11-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + protected Logger logger = Logger.NULL; + private final ServerApi api; + + public VMToolsRunningStatus(ServerApi api) { + this.api = api; + } + + @Override + public boolean apply(String serverId) { + checkNotNull(serverId, "

[jclouds/jclouds-labs] Adding missing Parser tests (#420)

2017-11-24 Thread Trevor Flanagan
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/420 -- Commit Summary -- * JCLOUD-62 Create ParseTest for Domain objects in AccountApi * JCLOUD-65 Create ParseTest for Domain objects in InfrastructureApi * JCLOUD-65 Create Par

[jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-27 Thread Trevor Flanagan
This PR shows the approach we will use for the next steps involved in creating the JCLouds abstraction now that the feature APIs are complete. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/421 -- Commit Summary -- * Implement Os

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-27 Thread Trevor Flanagan
@nacx thanks for taking a look. I will make the required changes shortly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-347442442

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + OsImageToImage(@Memoized final Supplier> locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override + public Image

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override + public Image apply(OsImage input) { + + OsFamily osFamily = imageDescriptionToOsFamily.apply(input.description(

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-28 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + OsImageToImage(@Memoized final Supplier> locations, + Function imageDescriptionToOsFamily) { + this.locations = locations; + this.imageDescriptionToOsFamily = imageDescriptionToOsFamily; + } + + @Override + public Image

Re: [jclouds/jclouds-site] Release notes for jclouds 2.0.3 (#202)

2017-11-28 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.0.3 is the third bugfix release after jclouds 2.0 and comes

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-29 Thread Trevor Flanagan
Hi @nacx I would like to make some further changes for the PR. Since you are busy with the release I think it's safe to do so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-29 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. c3943ad Refactor OsImageToImage to instead use BaseImage. This allows for both OS Images and Customer Images to be used. Improved the version and os family logic to use the guest operating system information. -- You are receiving this because you are subscrib

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-29 Thread Trevor Flanagan
@nacx I have refactored OsImageToImage in order to handle OsImage and CustomerImage. This means that JClouds can expose all of our image types. I have also improved the version and os family handling to be more robust. -- You are receiving this because you are subscribed to this thread. Reply t

[jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-11-29 Thread Trevor Flanagan
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/422 -- Commit Summary -- * Implementing BaseImageToHardware and CleanupServer functions. -- File Changes -- A dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontro

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-29 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 58366dd Correcting the types used in ComputeServiceAdapterContextModule. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421/files/c3943adffaec4e251138fdcc26a834c2b322d114..583

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-11-30 Thread Trevor Flanagan
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#issuecomment-348116402

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Trevor Flanagan
hey @andreaturli we were not aware of the requirement to sign an ICLA. We will have to check internally to see if Dimension Data have a process in place already for this. BTW I have not signed one either. -- You are receiving this because you are subscribed to this thread. Reply to this email d

Re: [jclouds/jclouds-labs] JCLOUD-72 / JCLOUD-75 - DatacenterToLocation / ServerToServerWithExternalIp Functions (#423)

2017-11-30 Thread Trevor Flanagan
BTW @nacx I saw the comments on the site PR regarding the slack channel. Would it be possible to invite @btrishkin and I? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issue

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-01 Thread Trevor Flanagan
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/423#issuecomment-348616664

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + } + + @Override + public Boolean apply(final String serverId) { + final ServerApi serverApi = api.getServerApi(); + Server server = serverApi.getServer(serverId); + + if (server == null) { + return true; + } + +

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + String networkDomainId = server.networkInfo().networkDomainId(); + final String internalIp = server.networkInfo().primaryNic().privateIpv4(); + + // delete nat rules associated to the server, if any + final Netwo

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. f04c95d Implementing BaseImageToHardware and CleanupServer functions. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422/files/08d902d63383da37b3fdc6b2024d0a623ac

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-02 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 9d78555 Implementing BaseImageToHardware and CleanupServer functions. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422/files/f04c95db74621e32aea2e6ad9f6996f7d10

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-04 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + String networkDomainId = server.networkInfo().networkDomainId(); + final String internalIp = server.networkInfo().primaryNic().privateIpv4(); + + // delete nat rules associated to the server, if any + final Netwo

Re: [jclouds/jclouds-labs] Implementing BaseImageToHardware and CleanupServer functions. (#422)

2017-12-04 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 4b3a037 Implementing BaseImageToHardware and CleanupServer functions. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/422/files/9d7855515bcdf4d752dc6ff3d3527d71c5d

Re: [jclouds/jclouds-labs] Implement OsImageToImage Function (#421)

2017-12-05 Thread Trevor Flanagan
Closed #421. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/421#event-1372266168

[jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
This will be useful for supporting Groups and also for the functions that create the subclasses of `org.jclouds.compute.domain.internal.ComputeMetadataImpl#tags` You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/425 -- Commit Summary

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. b5021da Adding the Dimension Data Tag API interface. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425/files/e67b0018f713086d9e901b7c8b8bf6d11578a5a5..b5021dae177ec8f76f1ec76

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. aab0692 Adding the Dimension Data Tag API interface. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425/files/b5021dae177ec8f76f1ec76bab53498cacc1e466..aab069263f3475b4f19d74a

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-06 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -143,7 +143,7 @@ public void testDeleteTagKey() throws Exception { @Test public void testTagKeyById() throws Exception { - server.enqueue(jsonResponse("/tagKey.json")); + server.enqueue(jsonResponse("/tagkey.json")); caught

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import java.util.List; + +@RequestFilters({ BasicAuthentication.class, OrganisationIdFilter.class }) +@Consumes(MediaType.APPLICATION_JSON) +@Path("/{jclouds.api-version}/tag") +public interface TagApi { + + @Named("tag:createTagKey") + @POST

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + @MapBinder(BindToJsonPayload.class) + void applyTags(@PayloadParam("assetId") String assetId, @PayloadParam("assetType") String assetType, + @PayloadParam("tagById") List tagById); + + @Named("tag:removeTags") + @POST + @Path(

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-07 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 565dfa5 Adding the Dimension Data Tag API interface. Updates for PR. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425/files/aab069263f3475b4f19d74a75b83507235ee1260..565dfa5

Re: [jclouds/jclouds-labs] Adding the Dimension Data Tag API interface. (#425)

2017-12-08 Thread Trevor Flanagan
@nacx thanks for reviewing. Commits are squashed and pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/425#issuecomment-350240771

[jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-08 Thread Trevor Flanagan
Extending `org.jclouds.compute.strategy.impl.CreateNodesWithGroupEncodedIntoNameThenAddToSet` for jclouds abstraction strategy. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/426 -- Commit Summary -- * Implement GetOrCreateNetwo

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-12 Thread Trevor Flanagan
@nacx thanks for the feedback. I will make the change for the State and Status classes in another pull request before making the requested changes you have suggested. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://

[jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-14 Thread Trevor Flanagan
@nacx as requested I have done this piece of refactoring that was requested in https://github.com/jclouds/jclouds-labs/pull/426 and https://github.com/jclouds/jclouds-labs/pull/400#discussion_r127640050. You can view, comment on, or merge this pull request online at: https://github.com/jcloud

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-14 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import org.jclouds.dimensiondata.cloudcontrol.domain.NetworkDomain; +import org.jclouds.dimensiondata.cloudcontrol.domain.Server; +import org.jclouds.dimensiondata.cloudcontrol.domain.State; +import org.jclouds.dimensiondata.cloudcontrol.domain.V

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-14 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 07e8d0d Implement GetOrCreateNetworkDomainThenCreateNodes Strategy. PR updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/426/files/c7c31e073a1be4995272877f77b332fd09ea5e

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-15 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + private final NetworkApi networkApi; + + private NetworkDomainState(final NetworkApi networkApi, final State state) { + this.networkApi = networkApi; + this.state = state; + } + + @Override + public bool

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-15 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. aef83ec Refactor DimensionDataCloudControlResponseUtils waitFor* methods so that they are injectable. PR Updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427/files/b88

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions() .as(DimensionDataCloudControlTempla

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 349211f Refactor DimensionDataCloudControlResponseUtils waitFor* methods so that they are injectable. PR Updates. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/427/files/aef

Re: [jclouds/jclouds-labs] Refactor DimensionDataCloudControlResponseUtils waitFor* methods so they are injectable (#427)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > } @Provides @Named(SERVER_STOPPED_PREDICATE) @VisibleForTesting public Predicate provideServerStoppedPredicate(final DimensionDataCloudControlApi api, final ComputeServiceConstants.Timeouts timeouts, final Compute

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-18 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -79,17 +74,21 @@ protected GetOrCreateNetworkDomainThenCreateNodes(final > CreateNodeWithGroupEncod final DimensionDataCloudControlTemplateOptions templateOptions = template.getOptions() .as(DimensionDataCloudControlTempla

Re: [jclouds/jclouds-labs] Implement GetOrCreateNetworkDomainThenCreateNodes Strategy (#426)

2017-12-20 Thread Trevor Flanagan
@nacx I have squashed my commits. As agreed earlier on slack I have done with the approach of defaulting to a single vlan for the nodes created. I am also using the approach of storing `vlanName` in `templateOptions.networks(vlanName);` -- You are receiving this because you are subscribed to t

Re: [jclouds/jclouds-labs] Implement ServerWithNatRuleToNodeMetadata Function (#428)

2017-12-22 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + this.nodeNamingConvention = checkNotNull(namingConvention, > "namingConvention").createWithoutPrefix(); + this.locations = checkNotNull(locations, "locations"); + this.baseImageToImage = checkNotNull(baseImageToImage, "baseImage

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider = checkNotNull(justProvider, "j

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2017-12-22 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustPro

[jclouds/jclouds-labs] JCLOUDS-1405 - Dimension Data Live Tests Broken - Domain classes for Server and Image with List nics incorrect (#432)

2018-04-09 Thread Trevor Flanagan
https://issues.apache.org/jira/browse/JCLOUDS-1405 Build output for Live Tests: > Running TestSuite > Configuring TestNG with: TestNG652Configurator > Starting test > testGetAccount(org.jclouds.dimensiondata.cloudcontrol.features.AccountApiLiveTest) > [TestNG] Test > testGetAccount(org.jclouds.

[jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-12 Thread Trevor Flanagan
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/433 -- Commit Summary -- * JCLOUDS-1406 - Add default location configuration to dimension data provider -- File Changes -- M dimensiondata/pom.xml (1) M dimensiondata/src/

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-12 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -40,6 +43,17 @@ @ConfiguresHttpApi public class DimensionDataCloudControlHttpApiModule extends HttpApiModule { + @Override + protected void installLocations() { + super.installLocations(); + // bind(RegionIdToZoneIdsSup

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-12 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. b50bb1f JCLOUDS-1406 - Add default location configuration to dimension data provider -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433/files/01881d987f369fde371b94e2f8be3450

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-12 Thread Trevor Flanagan
trevorflanagan commented on this pull request. >if (datacenterIds != null && !datacenterIds.isEmpty()) { - return request.toBuilder().addQueryParam("datacenterId", datacenterIds).build(); + return request.toBuilder().addQueryParam(queryParam, datacenterIds).build();

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-12 Thread Trevor Flanagan
@nacx I have made the suggested changes, but I am stuck with another one of those circular dependency issues. My only thought is that the ordering of bindings in `org.jclouds.dimensiondata.cloudcontrol.config.DimensionDataCloudControlHttpApiModule#installLocations` could be the problem? here i

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -40,6 +51,16 @@ @ConfiguresHttpApi public class DimensionDataCloudControlHttpApiModule extends HttpApiModule { + @Override + protected void installLocations() { + super.installLocations(); + bind(RegionIdToURISupplier.class)

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-13 Thread Trevor Flanagan
> Change looks good. Would it make sense, though, to create a couple filter > objects ListServerOptions and ListDatacenterOptions that extend > PaginationOptions and introduce the datacenter query parameters? if the > datacenter filter parameter is optional, then it would be better and cleaner

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-17 Thread Trevor Flanagan
@nacx this sounds nice, the rebuilding of the filter options wasn't a nice approach. I will take a look and see how this looks. It might be a couple of days before I can provide some updates. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or vi

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-17 Thread Trevor Flanagan
@trevorflanagan pushed 2 commits. 8d13f3e JCLOUDS-1406 - Add default location configuration to dimension data provider b702c82 JCLOUDS-1406 - Add default location configuration to dimension data provider -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-17 Thread Trevor Flanagan
@nacx - I have taken a look at what you are proposing. I do see the value in what you suggest. However I am slightly confused about how I might complete this. I have [pushed a new branch](https://github.com/DimensionDataDublin/jclouds-labs/tree/zones_review_updates_for_nacx) that maybe you coul

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-18 Thread Trevor Flanagan
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382462656

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-18 Thread Trevor Flanagan
@trevorflanagan pushed 3 commits. 26724ba JCLOUDS-1406 - Add default location configuration to dimension data provider 1070c18 JCLOUDS-1406 - Add default location configuration to dimension data provider f20b15d JCLOUDS-1406 - Add default location configuration to dimension data provider -

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-19 Thread Trevor Flanagan
Suggested changes made @nacx, thanks. I have also re-based onto master and squashed commits. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382696716

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-19 Thread Trevor Flanagan
trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-19 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.jclouds.dimensiondata.cloudcontrol.options; +

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-19 Thread Trevor Flanagan
Appreciate all the help with this one @nacx , I've learnt alot about jclouds working on it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/433#issuecomment-382742915

Re: [jclouds/jclouds-labs] JCLOUDS-1406 - Add default location configuration to dimension data provider (#433)

2018-04-19 Thread Trevor Flanagan
trevorflanagan commented on this pull request. >super(builder); } public static Properties defaultProperties() { Properties properties = DimensionDataCloudControlApiMetadata.defaultProperties(); + properties.setProperty(PROPERTY_REGIONS, "na,eu,au,mea,ap,canada");

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-04-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustProvider justProvider) { + this.justProvider = checkNotNull(justProvider, "j

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-04-20 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +import static com.google.inject.internal.util.$Preconditions.checkNotNull; + +@Singleton +public class DatacenterToLocation implements Function { + + private final JustProvider justProvider; + + @Inject + public DatacenterToLocation(JustPro

Re: [jclouds/jclouds-labs] JCLOUDS-1432 - handle RESOURCE_NOT_FOUND, (#439)

2018-07-04 Thread Trevor Flanagan
This is @FileIOUtility first PR for Apache jclouds but he has been working on several aspects of the project for a while now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/439#

Re: [jclouds/jclouds-labs] DatacenterToLocation / ServerToServerWithExternalIp Functions implementation for dimensiondata (#423)

2018-10-02 Thread Trevor Flanagan
> Wow, something went wrong during synchronization with master, a lot of > commits here that are not supposed to be part of PR. Should I recreate branch > and PR maybe? I think it might be the best thing to do @btrishkin, especially since the scope of the changes has reduced since the original

[jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
I have removed the reliance on pre-seeded servers, images, networks and vlans and instead the tests will setup and importantly clear down what they create. The tests will now be run with the following ``` mvn clean install -Plive -pl dimensiondata -Dtest.dimensiondata-cloudcontrol.identity=apach

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -45,4 +46,7 @@ @Delegate TagApi getTagApi(); + + @Delegate + CustomerImageApi getCustomerImageApi(); A new API added as part of this so that we can delete the image we create when we test the clone api. -- You are receiving th

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -89,8 +89,17 @@ public void setUp() { datacenters = getZones(); } + // private Set getZones() { + // return ctx.utils().injector().getInstance(ZoneIdsSupplier.class).get(); + // } + + // TODO this leads to a warni

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > } - private void applyTagToAsset() { I am doing this test in the ServerApiLiveTest now -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > @@ -54,7 +54,7 @@ protected Builder() { id("dimensiondata-cloudcontrol").name("DimensionData CloudControl API").identityName("user name") .credentialName("user password") .documentation(URI.create("http:

Re: [jclouds/jclouds-labs] JCLOUDS-1431 - Support AU geo for Live Tests (#446)

2018-10-04 Thread Trevor Flanagan
rebuild please appears to be a failure unrelated to my changes on jenkins -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/446#issuecomment-427003272

[jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-08 Thread Trevor Flanagan
Bumped version to 2.2.0-SNAPSHOT across all modules Added three examples: 1. ```org.jclouds.examples.dimensiondata.cloudcontrol.DeployNetworkDomainVlanAndServer``` - deploys Network Domain, VLAN and a Server and waits for them to be state Normal and in the case of the Server for it also to be s

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-08 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 20a5a65 Ignore any exceptions when deleting servers or vlans for best effort cleanup -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/b2050be4d52458d3079c94ce87a2c

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-08 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. f5cc1cd Example of Dimension Data CloudControl provider -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/20a5a65ecfc0a15d49ed3acff009cabe468b99b9..f5cc1cda6d42378b9

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-08 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 3e1290a Adding comments to the code, in order to prep for adding guide to https://jclouds.apache.org/guides -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/f5cc1c

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-09 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 9f7b5cf Adding comments to the code, in order to prep for adding guide to https://jclouds.apache.org/guides -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/3e1290

[jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-09 Thread Trevor Flanagan
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-site/pull/220 -- Commit Summary -- * JCLOUDS-1458 Create Dimension Data Provider Guide -- File Changes -- A guides/dimensiondata.md (719) M guides/index.md (1) -- Patch Links -- ht

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-09 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 3dd85f6 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/220/files/f25a0b2973dc3aa48e260f88c154ba099659eb75..3dd85f6698116976df

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-10 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 74b3524 JCLOUDS-1458 Create Dimension Data Provider Guide -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-site/pull/220/files/3dd85f6698116976df279c87ea32099dd2f198d5..74b352415306028ebd

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-10 Thread Trevor Flanagan
Thanks for taking a look @nacx I will make the required changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94#issuecomment-428505174

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-10 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 99c618d Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/9f7b5cff46d85aba4264e1d2a476667ae44e

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-10 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + +-- + +## Concepts + +The jclouds library wraps the [Dimension Data CloudControl API](https://docs.mcp-services.net/display/DEV/Welcome+to+the+CloudControl+documentation+portal). All operations are performed over SSL and authentica

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-10 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > +### Terms +Like any cloud provider, Dimension Data CloudControl has its own set of terms in cloud computing. To abstract this into jclouds' Compute interface, these terms were associated: + +- Node - a `Server` +- Image - both *user-uploaded* a

Re: [jclouds/jclouds-examples] Added Dimension Data examples (#94)

2018-10-10 Thread Trevor Flanagan
@trevorflanagan pushed 1 commit. 7855306 Example of Dimension Data CloudControl provider. Code review comments. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-examples/pull/94/files/99c618d34a919ad9fd4e16dc60d6e7042c50

Re: [jclouds/jclouds-site] JCLOUDS-1458 Create Dimension Data Provider Guide (#220)

2018-10-10 Thread Trevor Flanagan
trevorflanagan commented on this pull request. > + +The Dimension Data CloudControl organization will be associated with one or more [MCP 2.0 Data Centers](https://docs.mcp-services.net/display/CCD/Introduction+to+MCP+2.0+Data+Center+Locations). A Data Center is a container for the assets tha

  1   2   3   >