[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341741#comment-17341741 ] Pierre Smits commented on OFBIZ-11955: -- This is still an issue for WG-9943 and ecomseo in demo-trunk. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337846#comment-17337846 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 2c7a414cc2d7d17d34e15a14f3ed39a5978dc951 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2c7a414 ] Fixed: Error page shown when clicking on a product Id in the purchase order page (OFBIZ-12229) There is no "basePrice" resulting from calculatePurchasePrice service calling but a simple "price". This was put in with d04f777 commit and OFBIZ-11955 Thanks: Woyce Batkins for report > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337848#comment-17337848 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 9aa4e6c662ec4fc6c1c7a833557d81d2ee2f285f in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9aa4e6c ] Fixed: Error page shown when clicking on a product Id in the purchase order page (OFBIZ-12229) There is no "basePrice" resulting from calculatePurchasePrice service calling but a simple "price". This was put in with d04f777 commit and OFBIZ-11955 Thanks: Woyce Batkins for report > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17337842#comment-17337842 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 3f2fbc6f72a27afda4580441223b0ea62f06fc54 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3f2fbc6 ] Fixed: Error page shown when clicking on a product Id in the purchase order page (OFBIZ-12229) There is no "basePrice" resulting from calculatePurchasePrice service calling but a simple "price". This was put in with d04f777 commit and OFBIZ-11955 Thanks: Woyce Batkins for report > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268432#comment-17268432 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, What is the situation here? There is still an issue in ecommerce: OFBIZ-12105 > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208646#comment-17208646 ] Alex Bodnaru commented on OFBIZ-11955: -- I'm about to finish my patching here, also reverting some of the edits. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208643#comment-17208643 ] Alex Bodnaru commented on OFBIZ-11955: -- i cannot thank you enough for your mentoring. indeed the demos should be up, especially to have a reference system. my patches are trunk level only. I'm just mentioning if I've seen the issue elsewhere. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208633#comment-17208633 ] Jacques Le Roux commented on OFBIZ-11955: - I'll have a look at that after I have completed my work on the security issue which prevents to run the demos. Locally Git switching between branches to test regressions is a pain :/ > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202799#comment-17202799 ] Alex Bodnaru commented on OFBIZ-11955: -- please apply clean2 patch and see if i didn't break anything. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-clean2.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199458#comment-17199458 ] Jacques Le Roux commented on OFBIZ-11955: - Thanks for the explanation Alex! > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199365#comment-17199365 ] Alex Bodnaru commented on OFBIZ-11955: -- thank you [~jleroux] the changes in ordermgr influence e-commerce too. the moved code was something left behind by me. the comments are excluding code that will be totally removed in the next cut. i was asking for checking my modifications to avoid regression in other code. the product configuration is under a bug investigation too. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199261#comment-17199261
]
Jacques Le Roux commented on OFBIZ-11955:
-
Hi Alex,
TL;DR
{noformat}
You need to be more specific in what your changes implie in term of changed
features. For instance I read:
bq. // Format to apply the currency code to the variant price in the javascript
Why did you move that block and what should I check?
Also why did you comment out several small parts?
Or about <>?
In other words don't expect me to be the one which reviews and tests your
changes w/o having an idea about what I'm doing :)
You have already made a lot of changes in these Jira (OFBIZ-11993 and here)
and, w/ the time passing, it begins to be convoluted...
{noformat}
This said , I expect it's only about the titles (ie "display/selection of unit
of measure is broken/plugins") and I checked only that.
It works well in both ordermgr and ecommerce.
One question: the changes in ecommerce and ordermgr are independent, right?
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch,
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch,
> variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198954#comment-17198954 ] Alex Bodnaru commented on OFBIZ-11955: -- i would especially need your help with testing inlineproductdetail (groovy|ftl). i don't see where could they be used. thanks in advance > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198951#comment-17198951 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] , here you have a first step cleaning patch. please don't commit, just check in the same manner if the orderentry and ecommerce still work. i will provide a complementary patch for plugins. thanks in advance, alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-clean1.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194124#comment-17194124 ] Jacques Le Roux commented on OFBIZ-11955: - BTW, since you are working on Freemarker files, maybe you could be interested by https://try.freemarker.apache.org/ > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194123#comment-17194123 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, You asked me: bq. btw, how can i invoke code of InlineProductdetail.ftl? You can have an idea by looking for it. It's into Product.groovy. Then you will see it's used when an AGGREGATED is shown. One of them is "CFSV1001" that you can found into OrderDemoData.xml. Others are in DemoConfigurator.xml in ecommerce, HTH > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194118#comment-17194118 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 207d8f8ac080996ec11882fd6cb7f38a56dcc7d6 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=207d8f8 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Improve code for UOM dropdown of products like WG-9943 Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194119#comment-17194119 ] ASF subversion and git services commented on OFBIZ-11955: - Commit d04f777389830297da80926de259d8bc4c1f8766 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d04f777 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Improve code for UOM dropdown of products like WG-9943 Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194117#comment-17194117 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 8622a761e0f407a5c07947ea3ed1b5de18be0242 in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8622a76 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Improve code for UOM dropdown of products like WG-9943 Thanks: Alex Conflicts handled by hand in ProductDetail.ftl > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193885#comment-17193885 ] Alex Bodnaru commented on OFBIZ-11955: -- I don't know the status after reverting, please apply the final patch too. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193686#comment-17193686 ] Jacques Le Roux commented on OFBIZ-11955: - After reverting I noticed something, When you get to https://localhost:8443/ordermgr/products/p_WG-9943 (after using the order creation Wizard and looking for WG-9943) you can select the UOM for WG-9943 but not for WG-. Actually it sets the UOM of WG-9943 (ie WG--BX4). Is that temporary and wanted? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193610#comment-17193610 ] Alex Bodnaru commented on OFBIZ-11955: -- sure, it was something to apply, in order to reverse ;) thanks jacques > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193597#comment-17193597 ] Jacques Le Roux commented on OFBIZ-11955: - OK got it (Unreversed patch detected!) $ patch -p1 < variantinfojs-undo.patch patching file applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy patching file applications/order/groovyScripts/entry/catalog/ProductDetail.groovy patching file applications/order/groovyScripts/entry/catalog/ProductSummary.groovy patching file applications/order/template/entry/catalog/ProductDetail.ftl patching file applications/order/template/entry/catalog/ProductSummary.ftl Hunk #2 succeeded at 92 (offset -5 lines). Hunk #3 succeeded at 100 (offset -5 lines). Hunk #4 succeeded at 131 (offset -5 lines). patching file applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl patching file applications/order/template/entry/catalog/ProductVariantJS.ftl patching file applications/order/widget/ordermgr/OrderEntryCatalogScreens.xml I'll check and hopefully commit... > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193582#comment-17193582 ] Jacques Le Roux commented on OFBIZ-11955: - Of course I use trunk HEAD > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193581#comment-17193581 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, Here you go: $ patch -p1 -R < variantinfojs-undo.patch patching file applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] y Hunk #1 succeeded at 105 with fuzz 2 (offset 3 lines). Hunk #2 FAILED at 287. Hunk #3 FAILED at 301. 2 out of 3 hunks FAILED -- saving rejects to file applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy.rej patching file applications/order/groovyScripts/entry/catalog/ProductDetail.groovy Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] Y Skipping patch. 5 out of 5 hunks ignored -- saving rejects to file applications/order/groovyScripts/entry/catalog/ProductDetail.groovy.rej patching file applications/order/groovyScripts/entry/catalog/ProductSummary.groovy Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] Y Skipping patch. 3 out of 3 hunks ignored -- saving rejects to file applications/order/groovyScripts/entry/catalog/ProductSummary.groovy.rej patching file applications/order/template/entry/catalog/ProductDetail.ftl Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] y Hunk #1 FAILED at 279. Hunk #2 FAILED at 479. Hunk #3 FAILED at 496. 3 out of 3 hunks FAILED -- saving rejects to file applications/order/template/entry/catalog/ProductDetail.ftl.rej patching file applications/order/template/entry/catalog/ProductSummary.ftl Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] y Hunk #1 FAILED at 49. Hunk #2 FAILED at 97. Hunk #3 succeeded at 104 with fuzz 2 (offset -1 lines). Hunk #4 FAILED at 137. 3 out of 4 hunks FAILED -- saving rejects to file applications/order/template/entry/catalog/ProductSummary.ftl.rej patching file applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl Unreversed patch detected! Ignore -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl.rej The next patch, when reversed, would create the file applications/order/template/entry/catalog/ProductVariantJS.ftl, which already exists! Ignore -R? [n] Apply anyway? [n] n Skipping patch. 1 out of 1 hunk ignored patching file applications/order/widget/ordermgr/OrderEntryCatalogScreens.xml Hunk #1 succeeded at 74 (offset 8 lines). [^ProductUomDropDownOnly.ftl.rej] [^ProductSummary.ftl.rej] [^ProductDetail.ftl.rej] [^ProductSummary.groovy.rej] [^ProductDetail.groovy.rej] [^InlineProductDetail.groovy.rej] > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, InlineProductDetail.groovy.rej, ProductDetail.ftl.rej, > ProductDetail.groovy.rej, ProductSummary.ftl.rej, ProductSummary.groovy.rej, > ProductUomDropDownOnly.ftl.rej, ProductVariantJS.ftl, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-1.patch, variantinfojs-2.patch, variantinfojs-3.patch, > variantinfojs-data.xml, variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191820#comment-17191820 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] thank you for your collaboration. i cloned trunk and p-*-2 did unapply (well i used /usr/bin/patch, didn't even know of git apply ;) ). anyway, could you show me the conflict? about the *2 functions, i'll consider, since i'm in the middle of the cleanup. about the commented code, i still consider it's usage. i'll dare ask you to re-check as i progress with the cleanup. btw, how can i invoke code of InlineProductdetail.ftl? thanks again for your help > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191790#comment-17191790 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, Sorry I can't unapply: C:\projectsASF\Git\ofbiz-framework\plugins>git status On branch trunk Your branch is up to date with 'origin/trunk'. Untracked files: (use "git add ..." to include in what will be committed) birt/src/docs/asciidoc/images/OFBiz-Logo.svg ebay/src/docs/asciidoc/images/ ldap/src/docs/asciidoc/images/ myportal/src/docs/asciidoc/images/ p-variantinfojs-2.patch p-variantinfojs-final.patch projectmgr/src/docs/asciidoc/images/ solr/src/docs/ variantinfojs-final.patch nothing added to commit but untracked files present (use "git add" to track) C:\projectsASF\Git\ofbiz-framework\plugins>git apply -R p-variantinfojs-2.patch error: patch failed: ecommerce/template/catalog/ProductDetail.ftl:335 error: ecommerce/template/catalog/ProductDetail.ftl: patch does not apply C:\projectsASF\Git\ofbiz-framework\plugins> > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191788#comment-17191788
]
Jacques Le Roux commented on OFBIZ-11955:
-
Hi Alex,
The patches apply, I suggest to rename setAddProductId2 to setAddProductId. I
see no reason to name it setAddProductId2 once setAddProductId is removed, same
for setVariantPrice2.
Also why keeping, this commented out?
{code}
+//var price_div = $('.variant-price', form);
+//if (price) {
+//price_div.css('display', 'inline-block');
+//}
+//else {
+//price_div.hide();
+//}
{code}
I suggest to create an unique patch formed after applying both. A PR could fit.
I'll then review a last time (did not much yet), TIA
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch,
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml,
> variantinfojs-final.patch, variantinfojs-undo.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190950#comment-17190950 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] please apply the -undo patch. then apply the -final patch. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch, variantinfojs-undo.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190748#comment-17190748 ] Alex Bodnaru commented on OFBIZ-11955: -- ok, [~jleroux] , i will revert this, pull, then re-apply to fix conflicts. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190699#comment-17190699
]
Jacques Le Roux commented on OFBIZ-11955:
-
Sorry again Alex, the patch does not completely apply:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git status
On branch trunk
Your branch is up to date with 'origin/trunk'.
C:\projectsASF\Git\ofbiz-framework>git apply variantinfojs-final.patch
variantinfojs-final.patch:367: trailing whitespace.
});
variantinfojs-final.patch:443: trailing whitespace.
variantinfojs-final.patch:479: trailing whitespace.
});
error: patch failed:
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy:102
error:
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy:
patch does not apply
error: patch failed:
applications/order/groovyScripts/entry/catalog/ProductDetail.groovy:106
error: applications/order/groovyScripts/entry/catalog/ProductDetail.groovy:
patch does not apply
error: patch failed:
applications/order/groovyScripts/entry/catalog/ProductSummary.groovy:97
error: applications/order/groovyScripts/entry/catalog/ProductSummary.groovy:
patch does not apply
error: patch failed:
applications/order/template/entry/catalog/ProductDetail.ftl:265
error: applications/order/template/entry/catalog/ProductDetail.ftl: patch does
not apply
error: patch failed:
applications/order/template/entry/catalog/ProductSummary.ftl:49
error: applications/order/template/entry/catalog/ProductSummary.ftl: patch does
not apply
error: patch failed:
applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl:17
error: applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl:
patch does not apply
error: applications/order/template/entry/catalog/ProductVariantJS.ftl: already
exists in working directory
{noformat}
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch,
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml,
> variantinfojs-final.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190175#comment-17190175 ] Alex Bodnaru commented on OFBIZ-11955: -- [final patch before cleanup|https://issues.apache.org/jira/browse/OFBIZ-11993?focusedCommentId=17190077=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17190077] > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, > variantinfojs-final.patch > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187632#comment-17187632 ] Alex Bodnaru commented on OFBIZ-11955: -- not yet, i wish to fine-tune further > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187571#comment-17187571 ] Jacques Le Roux commented on OFBIZ-11955: - Alex, I let you decide if we should close > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187569#comment-17187569 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 8a5107e498f5d9fc03be2f1c39baafbc13e5f1e8 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=8a5107e ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Fixes UOM dropdown for products like WG-9943 Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187567#comment-17187567 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 26075f06a84fff2e84c7fdb79cdcabed6e56fbdf in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=26075f0 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Fixes UOM dropdown for products like WG-9943 Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187568#comment-17187568 ] ASF subversion and git services commented on OFBIZ-11955: - Commit d670f3671301825f3bdc0bab7ae3592e0c9d3519 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=d670f36 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) Fixes UOM dropdown for products like WG-9943 Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187313#comment-17187313 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] please apply patch -3 and test the details page for product *WG-9943* the uom selection will appear by ajax after you select the colour and the size. please note, our wg3?- products will show on the same page as associated products, so you may test the whole interaction. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187198#comment-17187198 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 9a957eb7a7d330873401887658b3d26113ea7908 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9a957eb ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) This fixes in in order component Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187196#comment-17187196 ] ASF subversion and git services commented on OFBIZ-11955: - Commit f83be8652e86f8a3b5246bcc69dcb7004c172a3c in ofbiz-framework's branch refs/heads/release17.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f83be86 ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) This fixes in in order component Thanks: Alex Conflict handled by hand in ProductSummary.ftl > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187197#comment-17187197 ] ASF subversion and git services commented on OFBIZ-11955: - Commit 3b751db55e524b85c3a019758332f0e3edc64300 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b751db ] Fixed: display/selection of unit of measure is broken (OFBIZ-11955) This fixes in in order component Thanks: Alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187154#comment-17187154 ] Alex Bodnaru commented on OFBIZ-11955: -- thank you [~jleroux] if it works all the way (including the correct variant added to the order), you may commit and we'll move further to the ecommerce. later, we'll have a second round (with need for additional product variations) and a cleanup round, both rounds in both repositories. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187146#comment-17187146 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, Everything works fine, should I commit the changes or do you want/need to get further before? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187079#comment-17187079 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] please apply patch -2 too, and check the product detail, again in the backend. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-2.patch, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187071#comment-17187071 ] Alex Bodnaru commented on OFBIZ-11955: -- sent you [~jleroux] > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187033#comment-17187033 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, After applying your patch, loading your data, and searching for WG-9943 in order, I got an error: 2020-08-29 17:48:41,710 |jsse-nio-8443-exec-9 |HtmlWidget |E| Error rendering included template at location [component://order/template/entry/catalog/ProductVariantJS.ftl]: freemarker.template.TemplateNotFoundException : Template not found for name "component://order/template/entry/catalog/ProductVariantJS.ftl". You missed to put ProductVariantJS.ftl in the patch > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186908#comment-17186908 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] we're going baby steps with this bug, in order to reduce other damage. your explanation of how to show products list in the ordermgr is a key point to granulate the work. i'm kindly asking you to apply my [provisory patch|https://issues.apache.org/jira/secure/attachment/13010705/variantinfojs-1.patch] and test if the product list in the ordermgr is working correctly regarding the virtual uom. to do this, please search for *WG-9943*. thus both wg- and wg3- will be listed, and will work by my patch. please also add these products to the order, in various uom variations., if there's a regression, you'll find it better than me. thanks in advance, alex > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184096#comment-17184096 ] Alex Bodnaru commented on OFBIZ-11955: -- i went the opposite way. found through OrderEntryCatalogScreens and the groovy sources that the screen i needed was product. np with that, but the main product_id parameter is not enough, it needs storage facility and inventory and other parameters. hence, i understand it's being invoked in a more complex way, probably from a page in admin. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184042#comment-17184042 ] Jacques Le Roux commented on OFBIZ-11955: - When you have a such need, simply get to the URL, ie https://localhost:8443/ordermgr/control/product and look at the HTML page generated source (Ctlr+U on most browsers). It's the screen product in OrderEntryCatalogScreens.xml. I hope I understood your need... > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184014#comment-17184014 ] Alex Bodnaru commented on OFBIZ-11955: -- yes i can fix it. it's more complex than it shows, indeed. but not much more. i still need your help in showing me where /ordermgr/control/product is being invoked (in admin) it needs some params to show inventory etc. this bug is there too. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183950#comment-17183950
]
Jacques Le Roux commented on OFBIZ-11955:
-
ProductSummary.ftl generates only 1 displayProductVirtualId call and 1
product_id_display
We miss to iterate over mainProducts:
{code:java}
<#if mainProducts?has_content>
"mainProducts"${mainProducts}
Select Unit Of Measure
<#list mainProducts as mainProduct>
${mainProduct.uomDesc} :
${mainProduct.piecesIncluded}
{code}
ProductSummary.groovy could be also implied, see {{jsBuf.append("")}}
It seems tobe a complicate case of having several virtualVariants on the same
page.
I let you handle it Alex?
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183797#comment-17183797 ] Jacques Le Roux commented on OFBIZ-11955: - Do you have an idea to fix the issue? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183795#comment-17183795 ] Jacques Le Roux commented on OFBIZ-11955: - Ah, I see it now. I focused on the content when it's after the selection! > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183794#comment-17183794 ] Jacques Le Roux commented on OFBIZ-11955: - bq. do you see wg- and wg3- on your screen? Yes in the 3 cases, but I see no issues with UOM selection. So what's the pb? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183793#comment-17183793 ] Jacques Le Roux commented on OFBIZ-11955: - Hi Alex, bq. if you wish to see both products side by side, apply the div.row patch, but this is not needed for now. It does not work for the catalog search using the "WG3-" word, still not side by side. Not a big deal for now. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183271#comment-17183271 ] Alex Bodnaru commented on OFBIZ-11955: -- ok [~jleroux] let's go to the search for wg3-. if you wish to see both products side by side, apply the div.row patch, but this is not needed for now. are you there? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183263#comment-17183263 ] Jacques Le Roux commented on OFBIZ-11955: - After doing that, as I supposed, this is not due to DB switching but much certainly to an interaction between getJs and ServerHit. We can forget that by now here. It's unrelated to this issue, just the origin of the Category tree not showing, which is confusin. I'll report later in OFBIZ-11686, must got now :) > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183232#comment-17183232 ] Jacques Le Roux commented on OFBIZ-11955: - When you get to [https://localhost:8443/ecomseo/product/Micro-Chrome-Widget3-WG3-.html] the UOM dropdown works. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183231#comment-17183231
]
Jacques Le Roux commented on OFBIZ-11955:
-
In "Last searches" I have:
{noformat}
Last Searches...
Clear Search History
Clear Search History Note
Search Number1
Search Refine
- Category: Micro Widgets (Include All Sub Categories)
- Catalog: Demo Catalog
- Keywords: "WG3-", where any word matches
- Exclude Variants
Search Number2
Search Refine
- Category: Demo Default Search (Include All Sub Categories)
- Keywords: "WG3-", where any word matches
- Exclude Variants
Search Number3
Search Refine
- Category: Demo Default Search (Include All Sub Categories)
- Keywords: " wg3-", where any word matches
- Exclude Variants
Search Number4
Search Refine
- Category: Demo Default Search (Include All Sub Categories)
- Keywords: " wg3-", where any word matches
- Exclude Variants
Search Number5
Search Refine
- Category: Demo Default Search (Include All Sub Categories)
- Keywords: " wg3-", where any word matches
- Exclude Variants
{noformat}
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183228#comment-17183228 ] Jacques Le Roux commented on OFBIZ-11955: - After loading the data again, I see the 2 products using either: * the product tree, at the node Micro Widgets. As mentionned at OFBIZ-11975, on the main page, getting there using https://localhost:8443/ecomseo/ or https://localhost:8443/ecommerce you don't *ever* see the category tree (not sure I missed to see on screen, I can't reproduce now :/). The products are then side by side and both "Select Unit of Measure" dropdowns work. * The catalog search using the "WG3-" word. But then not side by side. both "Select Unit of Measure" dropdowns work. * The category search shown on the page you get with the point just above (ie using the catalog search with the "WG3-" word). Then again both products side by side and "Select Unit of Measure" dropdowns work. I wonder know what the problem is? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183215#comment-17183215 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] , may we continue? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182403#comment-17182403 ] Alex Bodnaru commented on OFBIZ-11955: -- i reloaded the data and changed the price, since the price difference is important for another part of the same bug. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182395#comment-17182395 ] Alex Bodnaru commented on OFBIZ-11955: -- indeed, i can't see wg3-* in the category listing, but i see them both in the search > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182383#comment-17182383 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] i have imported the xml again in the admin gui, with 73 entries saved, just like yours. in ecomseo, in the search catalog box, there is a catalog field. i searched for wg3-, and got 2 results, in summary format: wg- and wg3-. could you please try too? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182375#comment-17182375 ] Alex Bodnaru commented on OFBIZ-11955: -- could you please duplicate wg- to wg2- in admin, and make sure the alternative package relationship is between the wg2- and wg2--bx2 and between wg2- and wg2--bx4? > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182373#comment-17182373 ] Alex Bodnaru commented on OFBIZ-11955: -- the problem occurs when there are more than one products in the same page with the uom selection option. that's why i have duplicated wg-, to have 2 displayed side by side in the same category. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182372#comment-17182372 ] Jacques Le Roux commented on OFBIZ-11955: - I checked (tested all supported branches with new DB contents) OFBIZ-10536 and I don't know but it's fixed. You need to trust me, because, as you may know for security reason we had to shut down the demos... Alternatively, you can checkout https://github.com/apache/ofbiz-framework and include https://github.com/apache/ofbiz-plugins/ in a plugins dir by checkout it out also, create a DB content (loadAll) and use it to test all the supported branches :) > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182359#comment-17182359 ] Jacques Le Roux commented on OFBIZ-11955: - bq. it loads in 1/3 of time on the same old machine. What do you exaclty mean by that? bq. all the file data, including the wrapped lines, are from the original demo data, where's mentioned the id *wg-, and i changed them to *wg3-. Yes I know, it was just to show that bq. i didn't see the wg3 immediately also, but it's probably a matter of caching. I restarted to be sure, same issue: Micro Chrome Widget3 still does not show on the https://localhost:8443/ecomseo/category/Widgets-BEST-SELL-2.html page But please note that anyway, as shows the image above, I have no UOM showing issue in trunk HEAD... bq. please note, that the wg3 products don't have pictures, if that matters. It should not matter > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182343#comment-17182343 ] Alex Bodnaru commented on OFBIZ-11955: -- I'm using postgres, it loads in 1/3 of time on the same old machine. all the file data, including the wrapped lines, are from the original demo data, where's mentioned the id *wg-, and i changed them to *wg3-. i did load the files on the command line, after moving the file in ofbiz-framework root (to load without slashes). i didn't see the wg3 immediately also, but it's probably a matter of caching. please note, that the wg3 products don't have pictures, if that matters. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182330#comment-17182330
]
Jacques Le Roux commented on OFBIZ-11955:
-
bq. it gives quite a few depreciation warnings with openjdk 11
For now we only support Java 9
bq. in your pictures, i can't see micro widget 3, that should have been loaded
from the xml.
As explained I loaded the file using webtools/import. It loaded 73 entities.
All that depend on the file content and seems consistent if you count the lins
in the files after removing the ASL2 header and some wrapped lines, like
{noformat}
{noformat}
You may check yourself. Are you sure of your DB content? Else try with another
set. If you use Derby you can save the DB at runtime\data\derby somewhere else
and create a new fresh one using gradlew loadAll, and then import your own
data...
> display/selection of unit of measure is broken
> --
>
> Key: OFBIZ-11955
> URL: https://issues.apache.org/jira/browse/OFBIZ-11955
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce, order
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: Image 002.png, Image 002.png, Image damned.png,
> Image1.png, image-2020-08-22-13-00-44-947.png,
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png,
> image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple
> forms, one for each product: whether detailed or in summary. thus, they
> should be marked by names and classes, not by ids, that are unique in the
> entire document.
> the bug did not manifest in demo data, since only one product has alternative
> packaging.
> i did duplicate wg-* products and arranged their relations. is, btw, a
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182328#comment-17182328 ] Alex Bodnaru commented on OFBIZ-11955: -- in your pictures, i can't see micro widget 3, that should have been loaded from the xml. it is meant to be in the same category with micro widget, as i wrote in the issue description. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182327#comment-17182327 ] Alex Bodnaru commented on OFBIZ-11955: -- no problem, I'm using trunk now, and fetching it frequently to be in step. it gives quite a few depreciation warnings with openjdk 11, but i took your word it's better. i found this problem while working on another issue in html, and I'd like us to fix this one first. there are quite a few issues that will benefit together of the fix we're working at here now. it's definitely not a css/ visual matter, but incorrect data display. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182324#comment-17182324 ] Jacques Le Roux commented on OFBIZ-11955: - Beware that Bootstrap improvements have been only done in trunk. So only trunk HEAD is up to date for the UI in ecom > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182323#comment-17182323 ] Jacques Le Roux commented on OFBIZ-11955: - I guess deleting images locally when used, while using 2 browers gave hardtime to Jira :D > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image damned.png, > Image1.png, image-2020-08-22-13-00-44-947.png, > image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, > image-2020-08-22-13-04-07-722.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182321#comment-17182321 ] Jacques Le Roux commented on OFBIZ-11955: - Not sure what happened to a comment I created with image1 and image2 in. It's not in the history, maybe my old browser or their damned Visual mode, weird. Here it's again: bq. you'll see 2 micro chrome widget and micro chrome widget3. No: !Image 002.png! about bq. selecting the unit of measure on either one, will show on the leftmost one only. UOM shows in trunk HEAD !Image1.png! > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image1.png, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182320#comment-17182320 ] Alex Bodnaru commented on OFBIZ-11955: -- yes [~jleroux] , i switched to trunk, following your advice. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image1.png, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182315#comment-17182315 ] Jacques Le Roux commented on OFBIZ-11955: - I have uploaded the 73 entities present in [^variantinfojs-data.xml] using webtools/control/EntityImport. !image-2020-08-22-13-00-44-947.png! !image-2020-08-22-13-04-07-722.png! So they are present in the DB: !Image 002.png! But 1st thing 1st, do you test using trunk HEAD? Because any other branch can give different result and is not supported. We *always* fix in trunk HEAD and backport in supported release branches when necessary. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image 002.png, Image1.png, > image-2020-08-22-13-00-44-947.png, image-2020-08-22-13-00-57-856.png, > image-2020-08-22-13-03-22-775.png, image-2020-08-22-13-04-07-722.png, > variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182303#comment-17182303 ] Alex Bodnaru commented on OFBIZ-11955: -- hello [~jleroux] please load from the xml. you'll have an additional group of products, that are packing alternatives, in the same category. having both on the screen, select an alternative package on each of them. actually click on the selected option. you'll see that only one product will show the change. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Image 002.png, Image1.png, variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11955) display/selection of unit of measure is broken
[ https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181495#comment-17181495 ] Alex Bodnaru commented on OFBIZ-11955: -- reproduction of the basic form of the bug: download variantinfojs-data.xml and load it with ./gradlew "ofbiz --load-data file=downloaded-file-name" open [https://localhost:8443/ecomseo/category/Widgets-BEST-SELL-2.html] you'll see 2 micro chrome widget and micro chrome widget3. selecting the unit of measure on either one, will show on the leftmost one only. > display/selection of unit of measure is broken > -- > > Key: OFBIZ-11955 > URL: https://issues.apache.org/jira/browse/OFBIZ-11955 > Project: OFBiz > Issue Type: Bug > Components: ecommerce, order >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: variantinfojs-data.xml > > > checkAmtReq and getVariantPrice are broken for similar reasons, too. > the display and selection of alternative uom elements occur in multiple > forms, one for each product: whether detailed or in summary. thus, they > should be marked by names and classes, not by ids, that are unique in the > entire document. > the bug did not manifest in demo data, since only one product has alternative > packaging. > i did duplicate wg-* products and arranged their relations. is, btw, a > way to export product trees in order to share them? > the fix does span the framework and ecommerce repositories. -- This message was sent by Atlassian Jira (v8.3.4#803005)
