[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

aderm commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584415398 Ok, no problem This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584500117 @dmsolr The download link has been fixed, the issue is why the test passed when the download fails

[skywalking] branch chore/code-style updated (60c597e -> 8c31743)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 60c597e Set up more strict code styles and fix existing issues add 8c31743 Set up more

[skywalking] branch chore/code-style updated (6331adb -> 5ddc90b)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 6331adb Set up more strict code style rules add 5ddc90b Set up more strict code style rules

[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues

codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr=h1) Report > Merging

[skywalking] branch grpc_alarm updated (b7605f7 -> 194df3e)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b7605f7 Merge branch 'master' into grpc_alarm add 194df3e finish logical. No new revisions were

[GitHub] [skywalking] wu-sheng merged pull request #4335: Provide profile analyze query

wu-sheng merged pull request #4335: Provide profile analyze query URL: https://github.com/apache/skywalking/pull/4335 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449882 Merged, and conflicts showing up. Please fix, let's make this PR merged as next to avoid endless conflicts.

[skywalking] branch master updated (8c96fd4 -> fa526e5)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8c96fd4 Update elasticsearch-7.x agent support version. (#4340) add fa526e5 Provide profile analyze

[GitHub] [skywalking] arugal commented on a change in pull request #4228: Support Browser protocol at OAP

arugal commented on a change in pull request #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#discussion_r377471040 ## File path:

[GitHub] [skywalking] cui-liqiang opened a new pull request #4346: some code style

cui-liqiang opened a new pull request #4346: some code style URL: https://github.com/apache/skywalking/pull/4346 Signed-off-by: liqiang.clq Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature

[GitHub] [skywalking] JaredTan95 commented on issue #4344: supprt gRPC alarm hook.

JaredTan95 commented on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584439653 Acording to https://github.com/apache/skywalking/pull/4337, should remove `@author` anonatation, right?

[GitHub] [skywalking] wu-sheng commented on issue #4104: [FEATURE] Performance profile at method level in production environment

wu-sheng commented on issue #4104: [FEATURE] Performance profile at method level in production environment URL: https://github.com/apache/skywalking/issues/4104#issuecomment-584452284 All backend related PRs have been merged, and e2e tests passed. @mrproliu Next step, let's provide a

[skywalking] branch chore/code-style updated (bd3e522 -> 6331adb)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard bd3e522 Set up more strict code style rules add 6331adb Set up more strict code style rules

[skywalking] branch chore/code-style updated (5ddc90b -> 60c597e)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 5ddc90b Set up more strict code style rules add 60c597e Set up more strict code styles and

[GitHub] [skywalking] jadezhong commented on issue #4292: Improve ES query performance

jadezhong commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584486603 any progress？ This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.

wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377411742 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/exporter/ExportData.java ## @@

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues

kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316 > 2790 files changed. :P How this could be review. Haha. I can't even review myself  , that's why I

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues

kezhenxu94 edited a comment on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316 > 2790 files changed. :P How this could be review. Haha. I can't even review myself  , that's why I

[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues

codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4344: supprt gRPC alarm hook.

wu-sheng commented on issue #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#issuecomment-584442704 Yes. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584442794 2790 files changed. :P How this could be review. Haha.

[GitHub] [skywalking] kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues

kezhenxu94 commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584448316 > 2790 files changed. :P How this could be review. Haha. I can't even review myself  , that's why I configure an

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584449406 Don't worry about profile e2e, it has a code issue which has been fixed in #4335. Waiting CI confirmation to merge it.

[GitHub] [skywalking] hanahmily commented on issue #4291: Improve ES query performance

hanahmily commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584456508 Just some tips for us, some queries still need "query context" instead of "filter context", for example, endpoint_inventory whose name should

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression

wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#discussion_r377433128 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression

wu-sheng commented on a change in pull request #4327: Tag annotation supports returned expression URL: https://github.com/apache/skywalking/pull/4327#discussion_r37741 ## File path:

[skywalking] branch grpc_alarm updated (c9d3ef4 -> afa8e98)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from c9d3ef4 remove author anonatation. add fa526e5 Provide profile analyze query (#4335) add

[skywalking] branch grpc_alarm updated (afa8e98 -> 17e5b33)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from afa8e98 Merge branch 'master' into grpc_alarm add 17e5b33 fix ci. No new revisions were added by

[GitHub] [skywalking] cui-liqiang closed pull request #4346: some code style

cui-liqiang closed pull request #4346: some code style URL: https://github.com/apache/skywalking/pull/4346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[skywalking] branch grpc_alarm updated (194df3e -> c9d3ef4)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 194df3e finish logical. add c9d3ef4 remove author anonatation. No new revisions were added by this

[skywalking] branch chore/code-style updated (bd67f14 -> bd3e522)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard bd67f14 Set up more strict code style rules add fa526e5 Provide profile analyze query

[GitHub] [skywalking] dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584495052 @kezhenxu94 , if you don't have time, I can submit a PR to pre-install the driver in e2e-container image.

[GitHub] [skywalking] arugal commented on issue #4228: Support Browser protocol at OAP

arugal commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584504175 Please review @wu-sheng @Fine0830. This is an automated message from the Apache Git

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

Fine0830 commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584511783 JS error rate equal PV with JS error in specified time divide total PV in specified time.

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584513941 Is the agent compiling test failure from one to another because of network issue? The CI passed, so I assume the compiling

[GitHub] [skywalking] wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s

wu-sheng commented on issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347#issuecomment-584508743 Sorry, this hasn't been provided. @innerpeacez has network issue because of the public health situation. Most configurations should be as

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584510004 Fail in spring case every time, strange though. :P This is

[GitHub] [skywalking] Fine0830 commented on issue #4228: Support Browser protocol at OAP

Fine0830 commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584514378 No, the value couldn't be more than 100%. JS error rate = PV(JS error in specified time) / PV (total PV in specified time).

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584514498 > [ERROR] Failed to execute goal on project feign-scenario: Could not resolve dependencies for project

[GitHub] [skywalking] Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP

Fine0830 edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584514378 No, the value couldn't be more than 100%. JS error rate = PV(pv with JS error in specified time) / PV (total PV in specified time).

[GitHub] [skywalking] dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

dmsolr commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584506426 got it. This is an automated message from

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584513115 > JS error rate equal PV with JS error in specified time divide total PV in specified time. @Fine0830 As I described, that value could be

[GitHub] [skywalking] wu-sheng commented on issue #4292: Improve ES query performance

wu-sheng commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584507064 > any progress？ The conclusion has been made here. https://github.com/apache/skywalking/issues/4291#issuecomment-584063442 This PR would not

[GitHub] [skywalking] JCchenxiang opened a new issue #4347: How can I deploy skywalking 6.6 in k8s

JCchenxiang opened a new issue #4347: How can I deploy skywalking 6.6 in k8s URL: https://github.com/apache/skywalking/issues/4347 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues

wu-sheng commented on issue #4337: Set up more strict code styles and fix existing issues URL: https://github.com/apache/skywalking/pull/4337#issuecomment-584001942 Please fix the conflicts. Besides the unstable profile e2e(will be fixed soon), there are other tests failing, please

[GitHub] [skywalking] wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584019219 First, make sure you could send the metrics to OAP server.

[GitHub] [skywalking-client-js] Fine0830 commented on a change in pull request #6: Feat: add performance data

Fine0830 commented on a change in pull request #6: Feat: add performance data URL: https://github.com/apache/skywalking-client-js/pull/6#discussion_r376930892 ## File path: src/performance/index.ts ## @@ -0,0 +1,55 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584018938 > If you are trying to use Istio, you should have the capability to address the issue.

[GitHub] [skywalking] justmine66 edited a comment on issue #3589: No data in skywalking-ui

justmine66 edited a comment on issue #3589: No data in skywalking-ui URL: https://github.com/apache/skywalking/issues/3589#issuecomment-584003143 > tcp: lookup oap.skywalking.svc.cluster.local apiVersion: config.istio.io/v1alpha2 kind: handler metadata: name: swhandler

[GitHub] [skywalking] hanahmily commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

hanahmily commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584022868 From what I know, we only support `1.3.3` now according to

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584024909 And for `collectErrorLogs`, there are logs from further requests on that page. @Fine0830 Please indicate your idea of success/error rate

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

[GitHub] [skywalking] justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584023373 > From what I know, we only support `1.3.3` now according to > >

[GitHub] [skywalking] wu-sheng commented on issue #4228: Support Browser protocol at OAP

wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584024143 @Fine0830 Currently, we used to ask `browser_app_error_rate` as a metrics, including `error_rate` of single version and page. But in the latest

[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #6: Feat: add performance data

wu-sheng commented on a change in pull request #6: Feat: add performance data URL: https://github.com/apache/skywalking-client-js/pull/6#discussion_r376933920 ## File path: src/performance/index.ts ## @@ -0,0 +1,55 @@ + +/** + * Licensed to the Apache Software Foundation

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584023373 > From what I know, we only support `1.3.3` now according to > >

[GitHub] [skywalking] justmine66 commented on issue #3589: No data in skywalking-ui

justmine66 commented on issue #3589: No data in skywalking-ui URL: https://github.com/apache/skywalking/issues/3589#issuecomment-584003143 > tcp: lookup oap.skywalking.svc.cluster.local apiVersion: config.istio.io/v1alpha2 kind: handler metadata: name: swhandler

[GitHub] [skywalking] justmine66 edited a comment on issue #3589: No data in skywalking-ui

justmine66 edited a comment on issue #3589: No data in skywalking-ui URL: https://github.com/apache/skywalking/issues/3589#issuecomment-584003143 > tcp: lookup oap.skywalking.svc.cluster.local apiVersion: config.istio.io/v1alpha2 kind: handler metadata: name: swhandler

[GitHub] [skywalking] justmine66 opened a new issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 opened a new issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ]

[GitHub] [skywalking] wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584018049 If you are trying to use Istio, you should have the capability to address the issue. You

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584019966 > First, make sure you could send the metrics to OAP server. see above. when

[skywalking] branch chore/code-style updated (e96a425 -> 8a69b86)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard e96a425 Review code styles automatically add 8c96fd4 Update elasticsearch-7.x agent support

[GitHub] [skywalking] justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 edited a comment on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584030168 > > Can make a patch immediately to support istio 1.4.3. > @hanahmily Do you

[GitHub] [skywalking] justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

justmine66 commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584030168 > > Can make a patch immediately to support istio 1.4.3. > @hanahmily Do you have

[skywalking] branch grpc_alarm updated (7f89261 -> 69bdcf7)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 7f89261 Merge branch 'master' into grpc_alarm add 69bdcf7 revert submodule commit. No new revisions

[GitHub] [skywalking] wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

wu-sheng commented on issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343#issuecomment-584031563 The download link will be fixed through #4335, but we need to invest why and fix it ASAP.

[GitHub] [skywalking] wu-sheng opened a new issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure.

wu-sheng opened a new issue #4343: [e2e] MySQL e2e test could pass even MySQL driver downloaded failure. URL: https://github.com/apache/skywalking/issues/4343 We detected a high priority e2e test issue at #4335, the download link of MySQL driver is dead, but the e2e test could pass every

[GitHub] [skywalking] codecov-io edited a comment on issue #4340: Update elasticsearch-7.x agent support version.

codecov-io edited a comment on issue #4340: Update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4340#issuecomment-583955232 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4340?src=pr=h1) Report > Merging

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook.

JaredTan95 commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r376960689 ## File path:

[skywalking] branch master updated: Update elasticsearch-7.x agent support version. (#4340)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 8c96fd4 Update elasticsearch-7.x agent

[GitHub] [skywalking] wu-sheng commented on issue #4291: Improve ES query performance

wu-sheng commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584071547 By following your conclusion, as we indeed change conditions usually, should we close this PR and tag won't fix?

[GitHub] [skywalking] wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui.

wu-sheng commented on issue #4342: According to the latest docs，use mixer solution to istio, but no data in skywalking ui. URL: https://github.com/apache/skywalking/issues/4342#issuecomment-584029232 > Can make a patch immediately to support istio 1.4.3. @hanahmily Do you have time

[GitHub] [skywalking] JaredTan95 opened a new pull request #4344: supprt gRPC alarm hook.

JaredTan95 opened a new pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve

[skywalking] branch chore/code-style updated (045b64c -> dc1b68d)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 045b64c Review code styles automatically add e9eaa74 sync ui pr #252 (#4338) add

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook.

wu-sheng commented on a change in pull request #4344: supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r376959676 ## File path:

[skywalking] branch grpc_alarm updated (69bdcf7 -> 3613ff6)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 69bdcf7 revert submodule commit. add 3613ff6 revert submodule commitid. No new revisions were added

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng merged pull request #4340: Update elasticsearch-7.x agent support version.

wu-sheng merged pull request #4340: Update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4340 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook.

wu-sheng commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r37741 ## File path:

[skywalking] branch grpc_alarm updated (3613ff6 -> b7605f7)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 3613ff6 revert submodule commitid. add 8c96fd4 Update elasticsearch-7.x agent support version.

[GitHub] [skywalking] wu-sheng commented on issue #4340: Update elasticsearch-7.x agent support version.

wu-sheng commented on issue #4340: Update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4340#issuecomment-584072145 Merging with e2e profile failure, because the profile case has issue itself.

[skywalking] branch grpc_alarm created (now 7f89261)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 7f89261 Merge branch 'master' into grpc_alarm This branch includes the following new commits: new

[skywalking] 01/02: support gRPC hook.

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 788a416b90e721cfffc300023ebd1ff05c50d6d8 Author: JaredTan95 AuthorDate: Mon Feb 10 17:37:55 2020 +0800

[skywalking] 02/02: Merge branch 'master' into grpc_alarm

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch grpc_alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 7f8926144931812a19fdc1dd0a4b8ce305edea71 Merge: 788a416 fc4402f Author: JaredTan95 AuthorDate: Mon Feb 10

[skywalking] branch chore/code-style updated (dc1b68d -> e96a425)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard dc1b68d Review code styles automatically add e96a425 Review code styles automatically This

[GitHub] [skywalking] aderm commented on issue #4291: Improve ES query performance

aderm commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584063442 ### Based on the previous situation, a 60W test data was created.

[skywalking] branch chore/code-style updated (002a735 -> 7d351b3)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch chore/code-style in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 002a735 Set up more strict code style rules add 7d351b3 Set up more strict code style rules

[GitHub] [skywalking] wu-sheng commented on issue #4345: topology: That 3 servers point to the same mysql at the same time

wu-sheng commented on issue #4345: topology: That 3 servers point to the same mysql at the same time URL: https://github.com/apache/skywalking/issues/4345#issuecomment-584131432 I think currently you can't, unless you use the different hostnames to access the local database.

[GitHub] [skywalking] wu-sheng closed issue #4345: topology: That 3 servers point to the same mysql at the same time

wu-sheng closed issue #4345: topology: That 3 servers point to the same mysql at the same time URL: https://github.com/apache/skywalking/issues/4345 This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] aderm closed pull request #4292: Improve ES query performance

aderm closed pull request #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] krmeda commented on issue #4279: Micrometer Registry support for Skywalking Metrics

krmeda commented on issue #4279: Micrometer Registry support for Skywalking Metrics URL: https://github.com/apache/skywalking/issues/4279#issuecomment-584140882 My proposal is to write an adapter for micrometer which plugs into micrometer end and publish metrics using skywalking support.

[GitHub] [skywalking] aderm commented on issue #4292: Improve ES query performance

aderm commented on issue #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#issuecomment-584141118 Reference #4291, so closed This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] JohnNiang commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook.

JohnNiang commented on a change in pull request #4344: [WIP]supprt gRPC alarm hook. URL: https://github.com/apache/skywalking/pull/4344#discussion_r377105587 ## File path: docs/en/setup/backend/backend-alarm.md ## @@ -113,6 +114,24 @@ Example as following }] ``` +##

[GitHub] [skywalking] fadeli1 opened a new issue #4345: That 3 servers point to the same mysql at the same time

fadeli1 opened a new issue #4345: That 3 servers point to the same mysql at the same time URL: https://github.com/apache/skywalking/issues/4345 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug

[GitHub] [skywalking] wu-sheng commented on issue #4291: Improve ES query performance

wu-sheng commented on issue #4291: Improve ES query performance URL: https://github.com/apache/skywalking/issues/4291#issuecomment-584148823 @aderm Could you work on another pull request to implement #4236's idea? That PR seems stopped, but the idea and report seem useful. Could you take a

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4335: Provide profile analyze query

wu-sheng commented on a change in pull request #4335: Provide profile analyze query URL: https://github.com/apache/skywalking/pull/4335#discussion_r377051247 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4335: Provide profile analyze query

wu-sheng commented on a change in pull request #4335: Provide profile analyze query URL: https://github.com/apache/skywalking/pull/4335#discussion_r377052937 ## File path:

[GitHub] [skywalking] codecov-io edited a comment on issue #4228: Support Browser protocol at OAP

codecov-io edited a comment on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging

  1   2   >