[GitHub] [incubator-superset] mistercrunch opened a new pull request #8729: fix: don't show filter popover on explore view load

2019-12-03 Thread GitBox
mistercrunch opened a new pull request #8729: fix: don't show filter popover on explore view load URL: https://github.com/apache/incubator-superset/pull/8729 There's this confusing "feature" that I thought was a bug that shows the metric popover opened when entering the explore view when

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8728: Support timeFormat extraction function for Druid as filter field

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8728: Support timeFormat extraction function for Druid as filter field URL: https://github.com/apache/incubator-superset/pull/8728#issuecomment-561039917 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8728?src=pr&el=h1) Report >

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8728: Support timeFormat extraction function for Druid as filter field

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8728: Support timeFormat extraction function for Druid as filter field URL: https://github.com/apache/incubator-superset/pull/8728#issuecomment-561039917 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8728?src=pr&el=h1) Report >

[GitHub] [incubator-superset] longenouvo opened a new pull request #8730: Fix error control label Metrics validator

2019-12-03 Thread GitBox
longenouvo opened a new pull request #8730: Fix error control label Metrics validator URL: https://github.com/apache/incubator-superset/pull/8730 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ]

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8730: Fix error control label Metrics validator

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8730: Fix error control label Metrics validator URL: https://github.com/apache/incubator-superset/pull/8730#issuecomment-561065147 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8730?src=pr&el=h1) Report > Merging [#8730](https:

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8730: Fix error control label Metrics validator

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8730: Fix error control label Metrics validator URL: https://github.com/apache/incubator-superset/pull/8730#issuecomment-561065147 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8730?src=pr&el=h1) Report > Merging [#8730](https:

[GitHub] [incubator-superset] codecov-io commented on issue #8730: Fix error control label Metrics validator

2019-12-03 Thread GitBox
codecov-io commented on issue #8730: Fix error control label Metrics validator URL: https://github.com/apache/incubator-superset/pull/8730#issuecomment-561065147 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8730?src=pr&el=h1) Report > Merging [#8730](https://codeco

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8725: Docker support

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#discussion_r353067104 ## File path: Dockerfile ## @@ -0,0 +1,87 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8725: Docker support

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#discussion_r353059444 ## File path: docker/pythonpath_dev/superset_config.py ## @@ -14,9 +14,21 @@ # KIND, either express or implied. See the

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8725: Docker support

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#discussion_r353062947 ## File path: docker/pythonpath_dev/superset_config_local.example ## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Softwar

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8725: Docker support

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#discussion_r353060153 ## File path: docker/docker-entrypoint.sh ## @@ -15,24 +15,15 @@ # See the License for the specific language governing pe

[GitHub] [incubator-superset] dpgaspar merged pull request #8680: [release] Fix, update superset docs process

2019-12-03 Thread GitBox
dpgaspar merged pull request #8680: [release] Fix, update superset docs process URL: https://github.com/apache/incubator-superset/pull/8680 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-superset] dpgaspar merged pull request #8693: [jinja_context] Fix, allow for app factory pattern

2019-12-03 Thread GitBox
dpgaspar merged pull request #8693: [jinja_context] Fix, allow for app factory pattern URL: https://github.com/apache/incubator-superset/pull/8693 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-superset] alexandrejuma opened a new issue #8731: Advanced Superset cache management

2019-12-03 Thread GitBox
alexandrejuma opened a new issue #8731: Advanced Superset cache management URL: https://github.com/apache/incubator-superset/issues/8731 **Is your feature request related to a problem? Please describe.** Superset cache management appears to follow a traditional strategy of time-based

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8731: Advanced Superset cache management

2019-12-03 Thread GitBox
issue-label-bot[bot] commented on issue #8731: Advanced Superset cache management URL: https://github.com/apache/incubator-superset/issues/8731#issuecomment-561110443 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.95. Please mark t

[GitHub] [incubator-superset] nabhosal commented on issue #5294: [SIP-3] Scheduled email reports for Slices / Dashboards

2019-12-03 Thread GitBox
nabhosal commented on issue #5294: [SIP-3] Scheduled email reports for Slices / Dashboards URL: https://github.com/apache/incubator-superset/pull/5294#issuecomment-561118146 We are using superset with schedule report emailing, it works great for us. In the below article, we have published

[GitHub] [incubator-superset] nabhosal commented on issue #1231: Support for emailing reports at regular intervals?

2019-12-03 Thread GitBox
nabhosal commented on issue #1231: Support for emailing reports at regular intervals? URL: https://github.com/apache/incubator-superset/issues/1231#issuecomment-561118394 We are using superset with schedule report emailing, it works great for us. In the below article, we have published st

[GitHub] [incubator-superset] Guires commented on issue #8661: ImportError: cannot import name 'superset'

2019-12-03 Thread GitBox
Guires commented on issue #8661: ImportError: cannot import name 'superset' URL: https://github.com/apache/incubator-superset/issues/8661#issuecomment-561136200 #Anaconda prompt Step1:Install - "pip install virtualenv" Step2: Create VM- "py -m venv your_env_name" or "python -m venv y

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8712: catch IntegrityError in datasource save

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8712: catch IntegrityError in datasource save URL: https://github.com/apache/incubator-superset/pull/8712#discussion_r353159017 ## File path: superset/views/datasource.py ## @@ -47,13 +51,29 @@ def save(self):

[GitHub] [incubator-superset] dpgaspar opened a new pull request #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
dpgaspar opened a new pull request #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732 ### CATEGORY - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Env

[GitHub] [incubator-superset] codecov-io commented on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
codecov-io commented on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561184128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8732?src=pr&el=h1) Report > Merging [#8732](https://codecov.i

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561184128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8732?src=pr&el=h1) Report > Merging [#8732](https://c

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561184128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8732?src=pr&el=h1) Report > Merging [#8732](https://c

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561184128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8732?src=pr&el=h1) Report > Merging [#8732](https://c

[GitHub] [incubator-superset] etr2460 commented on issue #8729: fix: don't show filter popover on explore view load

2019-12-03 Thread GitBox
etr2460 commented on issue #8729: fix: don't show filter popover on explore view load URL: https://github.com/apache/incubator-superset/pull/8729#issuecomment-561252587 Huh, i was wondering why this was happening! Looks like your fix broke a couple of cypress tests though... Also w

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353296835 ## File path: superset/constants.py ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Fou

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353296582 ## File path: superset/assets/src/utils/common.js ## @@ -19,6 +19,8 @@ import { SupersetClien

[GitHub] [incubator-superset] mistercrunch commented on issue #8219: Support schema permissions

2019-12-03 Thread GitBox
mistercrunch commented on issue #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-561256951 From travis pylint logs: ``` Module superset.views.database.mixins R: 31, 4: Method could be a function (no-self-use)

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8219: Support schema permissions

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8219: Support schema permissions

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8219: Support schema permissions

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-532932389 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8219?src=pr&el=h1) Report > Merging [#8219](https://codecov.io/gh

[GitHub] [incubator-superset] bkyryliuk commented on issue #8219: Support schema permissions

2019-12-03 Thread GitBox
bkyryliuk commented on issue #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219#issuecomment-561265917 @mistercrunch - done This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] craig-rueda commented on issue #8725: Docker support

2019-12-03 Thread GitBox
craig-rueda commented on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-561268473 @dpgaspar - addressed all of your comments. Thanks for the review! This is an automated m

[GitHub] [incubator-superset] brunoalano commented on issue #3007: [explore, PostgreSQL] filter values not correctly displayed for boolean columns

2019-12-03 Thread GitBox
brunoalano commented on issue #3007: [explore, PostgreSQL] filter values not correctly displayed for boolean columns URL: https://github.com/apache/incubator-superset/issues/3007#issuecomment-561272694 I've the same issue Th

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8725: Docker support

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-560965289 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8725?src=pr&el=h1) Report > Merging [#8725](https://codecov.io/gh/apache/incub

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8725: Docker support

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-560965289 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8725?src=pr&el=h1) Report > Merging [#8725](https://codecov.io/gh/apache/incub

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8725: Docker support

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-560965289 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8725?src=pr&el=h1) Report > Merging [#8725](https://codecov.io/gh/apache/incub

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8725: Docker support

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-560965289 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8725?src=pr&el=h1) Report > Merging [#8725](https://codecov.io/gh/apache/incub

[GitHub] [incubator-superset] willbarrett commented on issue #8720: Require the SQLAlchemy URI on the database model

2019-12-03 Thread GitBox
willbarrett commented on issue #8720: Require the SQLAlchemy URI on the database model URL: https://github.com/apache/incubator-superset/pull/8720#issuecomment-561278344 @john-bodley this change was to trigger a UI change in the FAB database UI. I don't feel strongly about adding a NOT NU

[GitHub] [incubator-superset] willbarrett commented on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
willbarrett commented on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561280037 I'm OK with this, given that it's behind a permission. This is an

[GitHub] [incubator-superset] villebro commented on a change in pull request #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
villebro commented on a change in pull request #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#discussion_r353328368 ## File path: superset/config.py ## @@ -162,7 +161,9 @@ def _try_json_readsha(filepath): # Uncom

[GitHub] [incubator-superset] willbarrett commented on issue #8721: Add protocol to cache warmup

2019-12-03 Thread GitBox
willbarrett commented on issue #8721: Add protocol to cache warmup URL: https://github.com/apache/incubator-superset/pull/8721#issuecomment-561282320 We probably want to add a note to `UPDATING.md` - I'm hoping that most people are running Superset over HTTPS in production. --

[GitHub] [incubator-superset] john-bodley commented on issue #8225: Pandas casting int64 to float64, misrepresenting value

2019-12-03 Thread GitBox
john-bodley commented on issue #8225: Pandas casting int64 to float64, misrepresenting value URL: https://github.com/apache/incubator-superset/issues/8225#issuecomment-561282736 We noticed an issue with the the Numpy reshaping logic in SQL Lab. Here `labels` is an `ARRAY` and renders corr

[GitHub] [incubator-superset] etr2460 commented on issue #8720: Require the SQLAlchemy URI on the database model

2019-12-03 Thread GitBox
etr2460 commented on issue #8720: Require the SQLAlchemy URI on the database model URL: https://github.com/apache/incubator-superset/pull/8720#issuecomment-561283225 I think we should keep the data model and the database in sync as much as possible here. Also because any generated migrati

[GitHub] [incubator-superset] betodealmeida commented on issue #8721: Add protocol to cache warmup

2019-12-03 Thread GitBox
betodealmeida commented on issue #8721: Add protocol to cache warmup URL: https://github.com/apache/incubator-superset/pull/8721#issuecomment-561286476 > We probably want to add a note to UPDATING.md - I'm hoping that most people are running Superset over HTTPS in production. I'll d

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8725: Docker support

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-560965289 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8725?src=pr&el=h1) Report > Merging [#8725](https://codecov.io/gh/apache/incub

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
dpgaspar commented on a change in pull request #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#discussion_r353338032 ## File path: superset/config.py ## @@ -162,7 +161,9 @@ def _try_json_readsha(filepath): # Uncom

[GitHub] [incubator-superset] nytai commented on issue #8705: Table th bug when switch Tabs

2019-12-03 Thread GitBox
nytai commented on issue #8705: Table th bug when switch Tabs URL: https://github.com/apache/incubator-superset/issues/8705#issuecomment-561287496 @aaa92729 I've tried reproducing your bug and after changing back and forth between a few tabs I was able to git the table chart into a state w

[GitHub] [incubator-superset] suddjian commented on issue #8726: require a series on a bar chart in the UI

2019-12-03 Thread GitBox
suddjian commented on issue #8726: require a series on a bar chart in the UI URL: https://github.com/apache/incubator-superset/pull/8726#issuecomment-561289038 Thanks @john-bodley! Can I get a merge? This is an automated mess

[GitHub] [incubator-superset] suddjian commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
suddjian commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353343947 ## File path: superset/viz.py ## @@ -1543,10 +1544,15 @@ def query_obj(self): def get_da

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8732: [config] Enables swagger UI by default URL: https://github.com/apache/incubator-superset/pull/8732#issuecomment-561184128 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8732?src=pr&el=h1) Report > Merging [#8732](https://c

[GitHub] [incubator-superset] willbarrett commented on issue #8720: Require the SQLAlchemy URI on the database model

2019-12-03 Thread GitBox
willbarrett commented on issue #8720: Require the SQLAlchemy URI on the database model URL: https://github.com/apache/incubator-superset/pull/8720#issuecomment-561293407 Works for me. I'll add the migration. This is an autom

[GitHub] [incubator-superset] betodealmeida closed issue #8489: Import Dashboard : filter_immune_slice_fields not converted

2019-12-03 Thread GitBox
betodealmeida closed issue #8489: Import Dashboard : filter_immune_slice_fields not converted URL: https://github.com/apache/incubator-superset/issues/8489 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-superset] betodealmeida merged pull request #8718: Import `filter_immune_slice_fields` when importing dashboards

2019-12-03 Thread GitBox
betodealmeida merged pull request #8718: Import `filter_immune_slice_fields` when importing dashboards URL: https://github.com/apache/incubator-superset/pull/8718 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] graceguo-supercat merged pull request #8719: [Explore] should not trigger chart render when overlay is on

2019-12-03 Thread GitBox
graceguo-supercat merged pull request #8719: [Explore] should not trigger chart render when overlay is on URL: https://github.com/apache/incubator-superset/pull/8719 This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] dpgaspar merged pull request #8725: Docker support

2019-12-03 Thread GitBox
dpgaspar merged pull request #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-superset] codecov-io commented on issue #8721: Add protocol to cache warmup

2019-12-03 Thread GitBox
codecov-io commented on issue #8721: Add protocol to cache warmup URL: https://github.com/apache/incubator-superset/pull/8721#issuecomment-561300405 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8721?src=pr&el=h1) Report > Merging [#8721](https://codecov.io/gh/apach

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8721: Add protocol to cache warmup

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8721: Add protocol to cache warmup URL: https://github.com/apache/incubator-superset/pull/8721#issuecomment-561300405 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8721?src=pr&el=h1) Report > Merging [#8721](https://codecov.io/g

[GitHub] [incubator-superset] betodealmeida merged pull request #8721: Add protocol to cache warmup

2019-12-03 Thread GitBox
betodealmeida merged pull request #8721: Add protocol to cache warmup URL: https://github.com/apache/incubator-superset/pull/8721 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-superset] betodealmeida closed issue #8461: Cache warmup does not work

2019-12-03 Thread GitBox
betodealmeida closed issue #8461: Cache warmup does not work URL: https://github.com/apache/incubator-superset/issues/8461 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-superset] betodealmeida commented on issue #8366: No such file or directory

2019-12-03 Thread GitBox
betodealmeida commented on issue #8366: No such file or directory URL: https://github.com/apache/incubator-superset/issues/8366#issuecomment-561310300 @venlee1993 can you give more context on this error? What command did you run? ---

[GitHub] [incubator-superset] betodealmeida commented on issue #8428: Unable to use Table Timestamp Format dropdown option

2019-12-03 Thread GitBox
betodealmeida commented on issue #8428: Unable to use Table Timestamp Format dropdown option URL: https://github.com/apache/incubator-superset/issues/8428#issuecomment-561314395 👀 This is an automated message from the Apach

[GitHub] [incubator-superset] robdiciuccio opened a new pull request #8733: WIP: Replace pandas.DataFrame with PyArrow.Table for nullable int typing

2019-12-03 Thread GitBox
robdiciuccio opened a new pull request #8733: WIP: Replace pandas.DataFrame with PyArrow.Table for nullable int typing URL: https://github.com/apache/incubator-superset/pull/8733 ### CATEGORY Choose one - [x] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Ref

[GitHub] [incubator-superset] nytai commented on issue #8666: Filter Boxes with a large number of items are slow

2019-12-03 Thread GitBox
nytai commented on issue #8666: Filter Boxes with a large number of items are slow URL: https://github.com/apache/incubator-superset/issues/8666#issuecomment-561320386 @etr2460 I tried to repro this issue by generating a random set of ~17k email addresses and didn't notice a huge performa

[GitHub] [incubator-superset] andrewjkeith edited a comment on issue #8649: superset_1 container is not starting after running docker-compose

2019-12-03 Thread GitBox
andrewjkeith edited a comment on issue #8649: superset_1 container is not starting after running docker-compose URL: https://github.com/apache/incubator-superset/issues/8649#issuecomment-558774978 Ok I was able to get this fixed and there was two issues. One was that the `docker-entrypo

[GitHub] [incubator-superset] etr2460 opened a new pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
etr2460 opened a new pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests

[GitHub] [incubator-superset] andrewjkeith commented on issue #8649: superset_1 container is not starting after running docker-compose

2019-12-03 Thread GitBox
andrewjkeith commented on issue #8649: superset_1 container is not starting after running docker-compose URL: https://github.com/apache/incubator-superset/issues/8649#issuecomment-561325826 @evanmiller29 Thanks yeah, that was definitely needed because it wasn't just those two files that h

[GitHub] [incubator-superset] khtruong commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
khtruong commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734#discussion_r353385393 ## File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx ##

[GitHub] [incubator-superset] jackyourkill commented on issue #8725: Docker support

2019-12-03 Thread GitBox
jackyourkill commented on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-56107 Please update the documentation at https://superset.incubator.apache.org/installation.html, since this breaks the steps for Start with Docker -

[GitHub] [incubator-superset] suddjian commented on issue #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
suddjian commented on issue #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#issuecomment-561335398 @etr2460 @john-bodley Thanks for the feedback, I added tests and changed to `NULL_STRING`. Feel free to merge if it looks good.

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
etr2460 commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734#discussion_r353398205 ## File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx ##

[GitHub] [incubator-superset] craig-rueda opened a new pull request #8735: Fixing up Docker installation docs

2019-12-03 Thread GitBox
craig-rueda opened a new pull request #8735: Fixing up Docker installation docs URL: https://github.com/apache/incubator-superset/pull/8735 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build

[GitHub] [incubator-superset] craig-rueda commented on issue #8725: Docker support

2019-12-03 Thread GitBox
craig-rueda commented on issue #8725: Docker support URL: https://github.com/apache/incubator-superset/pull/8725#issuecomment-561337229 Done in #8735 😄 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734#discussion_r353400490 ## File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx ##

[GitHub] [incubator-superset] rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
rusackas commented on a change in pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734#discussion_r353400490 ## File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx ##

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8735: Fixing up Docker installation docs

2019-12-03 Thread GitBox
etr2460 commented on a change in pull request #8735: Fixing up Docker installation docs URL: https://github.com/apache/incubator-superset/pull/8735#discussion_r353423677 ## File path: docs/installation.rst ## @@ -57,19 +57,15 @@ Start with Docker - ..

[GitHub] [incubator-superset] etr2460 merged pull request #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
etr2460 merged pull request #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-superset] codecov-io commented on issue #8734: [Explore] Fix annotation layer select box formatting

2019-12-03 Thread GitBox
codecov-io commented on issue #8734: [Explore] Fix annotation layer select box formatting URL: https://github.com/apache/incubator-superset/pull/8734#issuecomment-561359392 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8734?src=pr&el=h1) Report > Merging [#8734](ht

[GitHub] [incubator-superset] codecov-io commented on issue #8735: Fixing up Docker installation docs

2019-12-03 Thread GitBox
codecov-io commented on issue #8735: Fixing up Docker installation docs URL: https://github.com/apache/incubator-superset/pull/8735#issuecomment-561360350 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8735?src=pr&el=h1) Report > Merging [#8735](https://codecov.io/gh

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8735: Fixing up Docker installation docs

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8735: Fixing up Docker installation docs URL: https://github.com/apache/incubator-superset/pull/8735#issuecomment-561360350 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8735?src=pr&el=h1) Report > Merging [#8735](https://codeco

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
etr2460 commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353428052 ## File path: superset/assets/src/utils/common.js ## @@ -19,6 +19,8 @@ import { SupersetClien

[GitHub] [incubator-superset] etr2460 opened a new issue #8167: PUT requests to /tablecolumninlineview/api/update/ fail

2019-12-03 Thread GitBox
etr2460 opened a new issue #8167: PUT requests to /tablecolumninlineview/api/update/ fail URL: https://github.com/apache/incubator-superset/issues/8167 Making a PUT request to the tablecolumninlineview api fails when not all required fields on the model are provided. ### Expected re

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
john-bodley commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353430900 ## File path: superset/connectors/druid/models.py ## @@ -1363,7 +1364,7 @@ def homogenize_

[GitHub] [incubator-superset] suddjian commented on a change in pull request #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
suddjian commented on a change in pull request #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#discussion_r353434699 ## File path: superset/connectors/druid/models.py ## @@ -1363,7 +1364,7 @@ def homogenize_typ

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8736: ON DELETE CASCADE for ab_user

2019-12-03 Thread GitBox
issue-label-bot[bot] commented on issue #8736: ON DELETE CASCADE for ab_user URL: https://github.com/apache/incubator-superset/issues/8736#issuecomment-561370968 Issue Label Bot is not confident enough to auto-label this issue. See [dashboard](https://mlbot.net/data/apache/incubator-supers

[GitHub] [incubator-superset] metaperl opened a new issue #8736: ON DELETE CASCADE for ab_user

2019-12-03 Thread GitBox
metaperl opened a new issue #8736: ON DELETE CASCADE for ab_user URL: https://github.com/apache/incubator-superset/issues/8736 Is there a reason that deleting a user from `ab_user` does not do an `ON DELETE CASCADE` to `ab_user_role` and other related tables? --

[GitHub] [incubator-superset] willbarrett opened a new pull request #8737: Migration and model changes to synchronize the data model

2019-12-03 Thread GitBox
willbarrett opened a new pull request #8737: Migration and model changes to synchronize the data model URL: https://github.com/apache/incubator-superset/pull/8737 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] A

[GitHub] [incubator-superset] nytai opened a new pull request #8738: bump style-loader to fix FOUC when sourcemaps are enabled

2019-12-03 Thread GitBox
nytai opened a new pull request #8738: bump style-loader to fix FOUC when sourcemaps are enabled URL: https://github.com/apache/incubator-superset/pull/8738 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tes

[GitHub] [incubator-superset] suddjian commented on issue #8675: Set dynamically default value of data filter

2019-12-03 Thread GitBox
suddjian commented on issue #8675: Set dynamically default value of data filter URL: https://github.com/apache/incubator-superset/issues/8675#issuecomment-561374315 You can enter raw SQL as the value for your filter, so I think this should be doable using the `now()` function with some man

[GitHub] [incubator-superset] betodealmeida opened a new pull request #8739: Change column to longtext

2019-12-03 Thread GitBox
betodealmeida opened a new pull request #8739: Change column to longtext URL: https://github.com/apache/incubator-superset/pull/8739 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Devel

[GitHub] [incubator-superset] suddjian commented on issue #8683: Add checkbox beside each row of "table"

2019-12-03 Thread GitBox
suddjian commented on issue #8683: Add checkbox beside each row of "table" URL: https://github.com/apache/incubator-superset/issues/8683#issuecomment-561381839 I suggest looking at the "emit filter events" option in the "Customize" menu for the table viz. It might already have what you're

[GitHub] [incubator-superset] betodealmeida commented on issue #8727: How to use custom SQL in metric field in chart?

2019-12-03 Thread GitBox
betodealmeida commented on issue #8727: How to use custom SQL in metric field in chart? URL: https://github.com/apache/incubator-superset/issues/8727#issuecomment-561384117 The custom SQL allows you to define a metric using any valid expression for the DB you're targeting. For example, if

[GitHub] [incubator-superset] betodealmeida edited a comment on issue #8727: How to use custom SQL in metric field in chart?

2019-12-03 Thread GitBox
betodealmeida edited a comment on issue #8727: How to use custom SQL in metric field in chart? URL: https://github.com/apache/incubator-superset/issues/8727#issuecomment-561384117 The custom SQL allows you to define a metric using any valid expression for the DB you're targeting, and it w

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #8740: [filter_box] Fix show time column in filter_box

2019-12-03 Thread GitBox
graceguo-supercat opened a new pull request #8740: [filter_box] Fix show time column in filter_box URL: https://github.com/apache/incubator-superset/pull/8740 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [x] Add t

[GitHub] [incubator-superset] suddjian commented on issue #8321: Deck GL plots 5.3 version with google maps integration in react js zoom issue with plots

2019-12-03 Thread GitBox
suddjian commented on issue #8321: Deck GL plots 5.3 version with google maps integration in react js zoom issue with plots URL: https://github.com/apache/incubator-superset/issues/8321#issuecomment-561388410 Some repro steps would be useful here. -

[GitHub] [incubator-superset] suddjian commented on issue #8323: TypeError: Cannot read property '0b15b5daf836c399f755c742e77dd20c' of undefined #question

2019-12-03 Thread GitBox
suddjian commented on issue #8323: TypeError: Cannot read property '0b15b5daf836c399f755c742e77dd20c' of undefined #question URL: https://github.com/apache/incubator-superset/issues/8323#issuecomment-561389844 Can repro, taking a look at this. -

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#issuecomment-560964798 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=h1) Report > Merging [#8724](https

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8724: handle nulls in bar chart series/breakdown

2019-12-03 Thread GitBox
codecov-io edited a comment on issue #8724: handle nulls in bar chart series/breakdown URL: https://github.com/apache/incubator-superset/pull/8724#issuecomment-560964798 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8724?src=pr&el=h1) Report > Merging [#8724](https

[GitHub] [incubator-superset] mistercrunch merged pull request #8219: Support schema permissions

2019-12-03 Thread GitBox
mistercrunch merged pull request #8219: Support schema permissions URL: https://github.com/apache/incubator-superset/pull/8219 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-superset] mistercrunch opened a new pull request #8741: fix: remove unused .js module

2019-12-03 Thread GitBox
mistercrunch opened a new pull request #8741: fix: remove unused .js module URL: https://github.com/apache/incubator-superset/pull/8741 found this unused file... This is an automated message from the Apache Git Service. To res

  1   2   >