[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane

2018-05-04 Thread GitBox
williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186229561 ## File path: superset/assets/src/dashboard/components/SliceHeaderControls.jsx ## @@ -57,53 +64,44 @@ class

[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane

2018-05-04 Thread GitBox
williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186224877 ## File path: superset/assets/src/dashboard/containers/SliceAdder.js ## @@ -0,0 +1,32 @@ +import {

[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane

2018-05-04 Thread GitBox
williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186225334 ## File path: superset/assets/src/dashboard/stylesheets/grid.less ## @@ -17,6 +17,11 @@ display: flex;

[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane

2018-05-04 Thread GitBox
williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186224338 ## File path: superset/assets/src/dashboard/components/Controls.jsx ## @@ -124,33 +116,25 @@ class Controls