[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane
williaster commented on a change in pull request #4893: add sticky to sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186229561
##
File path: superset/assets/src/dashboard/components/SliceHeaderControls.jsx
##
@@ -57,53 +64,44 @@ class SliceHeaderControls extends React.PureComponent {
const slice = this.props.slice;
const isCached = this.props.isCached;
const cachedWhen = moment.utc(this.props.cachedDttm).fromNow();
-const refreshTooltip = isCached
- ? t('Served from data cached %s . Click to force refresh.', cachedWhen)
- : t('Force refresh data');
+const refreshTooltip = isCached ? t('Cached %s', cachedWhen) : '';
return (
-
-
-
-{slice.description && (
-
-)}
-
-
-
-
-
-
-
+
Review comment:
`bsRole` is throwing an unknown prop error
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane
williaster commented on a change in pull request #4893: add sticky to sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186224877
##
File path: superset/assets/src/dashboard/containers/SliceAdder.js
##
@@ -0,0 +1,32 @@
+import { bindActionCreators } from 'redux';
+import { connect } from 'react-redux';
+
+import { fetchAllSlices } from '../actions/sliceEntities';
+import SliceAdder from '../components/SliceAdder';
+
+function mapStateToProps(
+ { sliceEntities, dashboardInfo, dashboardState },
+ ownProps,
+) {
+ return {
+userId: dashboardInfo.userId,
+selectedSliceIds: dashboardState.sliceIds,
+slices: sliceEntities.slices,
+isLoading: sliceEntities.isLoading,
+errorMessage: sliceEntities.errorMessage,
+lastUpdated: sliceEntities.lastUpdated,
+editMode: dashboardState.editMode,
+height: ownProps.height,
Review comment:
why override a prop that it already has with the same value? you can just
remove this line and it will still have that prop.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane
williaster commented on a change in pull request #4893: add sticky to sidepane URL: https://github.com/apache/incubator-superset/pull/4893#discussion_r186225334 ## File path: superset/assets/src/dashboard/stylesheets/grid.less ## @@ -17,6 +17,11 @@ display: flex; flex-direction: column; margin-bottom: 100px; + padding-top: 16px; Review comment: hmm I fixed the extra padding already which was due to an empty droptarget, can you remove this and the `padding-top` line below? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] williaster commented on a change in pull request #4893: add sticky to sidepane
williaster commented on a change in pull request #4893: add sticky to sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186224338
##
File path: superset/assets/src/dashboard/components/Controls.jsx
##
@@ -124,33 +116,25 @@ class Controls extends React.PureComponent {
expandedSlices={expandedSlices}
onSave={onSave}
css={this.state.css}
-triggerNode={
-
-}
+triggerNode={{editMode ? t('Save') : t('Save as')}}
isMenuItem
/>
{editMode && (
- {
-window.location = `/dashboardmodelview/edit/${
- this.props.dashboardInfo.id
-}`;
- }}
-/>
+
+ {t('Edit dashboard metadata')}
+
)}
{editMode && (
- {
Review comment:
this should be a component method/not defined in the render.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
