[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329840013 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java ## @@ -76,20

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329700162 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ObserverMaster.java ## @@ -293,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701364 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -620,8 +636,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701560 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -441,11 +450,

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701474 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java ## @@ -505,7 +516,1

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329708222 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeper.java ## @@ -1273,11 +1279,13 @@ publi

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329704838 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java ## @@ -1687,8 +169

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701768 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java ## @@ -1634,9 +1638,

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329698201 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java ## @@ -76,20

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329701159 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java ## @@ -169,7

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329691424 ## File path: zookeeper-server/src/test/java/org/apache/zookeeper/test/ClientTest.java ## @@ -140,15 +140,15 @@

[GitHub] [zookeeper] enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format

2019-09-30 Thread GitBox
enixon commented on a change in pull request #1100: ZOOKEEPER-3509: Revisit log format URL: https://github.com/apache/zookeeper/pull/1100#discussion_r329705056 ## File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java ## @@ -373,15 +381,15 @