[DRAFT] New features in Vim interface

2015-01-10 Thread David Bremner
Bartosz writes: > Hi, > > I really like to use notmuch for organising my emails. However, I noticed > that vim interface is slightly lagging behind emacs. Some of the most > important features still missing are: > > - adding attachments (PATCH 4) > - saving sent emails to "Sent" box in maildir

Re: [DRAFT] New features in Vim interface

2015-01-10 Thread David Bremner
Bartosz writes: > Hi, > > I really like to use notmuch for organising my emails. However, I noticed > that vim interface is slightly lagging behind emacs. Some of the most > important features still missing are: > > - adding attachments (PATCH 4) > - saving sent emails to "Sent" box in maildir

[PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Jani Nikula
On Sat, 10 Jan 2015, Todd wrote: > I wanted to tag messages with calendar invitations, but couldn't as > the information wasn't indexed. > > This patch allows for queries for like: > > Find calendar invites > - contenttype:text/calendar or contenttype:applicaton/ics > > Find any image attachments

[PATCH 4/4] VIM: adding attachments

2015-01-10 Thread Bartosz
files to be attached are listed at the end of composed message as paths prefixed by "Attachment:" --- vim/notmuch.vim | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e95db4d..d999aef 100644 --- a/vim/notmuch.vim +++ b/vim/notm

[PATCH 3/4] VIM: save sent message to maildir

2015-01-10 Thread Bartosz
maildir folder is slected based on the address in from header and it is configurable via notmuch config. --- vim/notmuch.vim | 20 1 file changed, 20 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4f90d79..e95db4d 100644 --- a/vim/notmuch.vim +++ b/vim/not

[PATCH 2/4] VIM: move backward trough messages in thread mode

2015-01-10 Thread Bartosz
--- vim/notmuch.vim | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 34d4f92..4f90d79 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -39,7 +39,8 @@ let g:notmuch_show_maps = { \ 'p': 'show_save_patches(

[PATCH 1/4] VIM: implemented message folding in thread view

2015-01-10 Thread Bartosz
--- vim/notmuch.vim | 6 ++ 1 file changed, 6 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cad9517..34d4f92 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -345,8 +345,13 @@ ruby << EOF VIM::command("syntax region nmShowMsg#{i}Desc start='\\%%%il'

[DRAFT] New features in Vim interface

2015-01-10 Thread Bartosz
Hi, I really like to use notmuch for organising my emails. However, I noticed that vim interface is slightly lagging behind emacs. Some of the most important features still missing are: - adding attachments (PATCH 4) - saving sent emails to "Sent" box in maildir (PATCH 3) - forwarding messages

[PATCH] completion: update list of commands in zsh completion.

2015-01-10 Thread David Bremner
This is actually generated by the script in id:1420289900-29717-2-git-send-email-david at tethera.net We may as well update the list of commands while we decide if it's worth automating the process. Note that there is a bit more noise than expected because it alphabetizes all of the commands

[v2 3/3] thread-naming test: Test empty subject names.

2015-01-10 Thread David Bremner
Jesse Rosenthal writes: > > +test_begin_subtest "Use empty subjects if necessary." > +add_message '[subject]="@FORCE_EMPTY"' \ > + '[date]="Sat, 13 Jan 2001 15:43:45 -"' \ > +'[from]="Empty Sender \

[PATCH 4/4] VIM: adding attachments

2015-01-10 Thread Bartosz
files to be attached are listed at the end of composed message as paths prefixed by "Attachment:" --- vim/notmuch.vim | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index e95db4d..d999aef 100644 --- a/vim/notmuch.vim +++ b/vim/notm

[PATCH 2/4] VIM: move backward trough messages in thread mode

2015-01-10 Thread Bartosz
--- vim/notmuch.vim | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 34d4f92..4f90d79 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -39,7 +39,8 @@ let g:notmuch_show_maps = { \ 'p': 'show_save_patches(

[PATCH 1/4] VIM: implemented message folding in thread view

2015-01-10 Thread Bartosz
--- vim/notmuch.vim | 6 ++ 1 file changed, 6 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cad9517..34d4f92 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -345,8 +345,13 @@ ruby << EOF VIM::command("syntax region nmShowMsg#{i}Desc start='\\%%%il'

[DRAFT] New features in Vim interface

2015-01-10 Thread Bartosz
Hi, I really like to use notmuch for organising my emails. However, I noticed that vim interface is slightly lagging behind emacs. Some of the most important features still missing are: - adding attachments (PATCH 4) - saving sent emails to "Sent" box in maildir (PATCH 3) - forwarding messages

[PATCH 3/4] VIM: save sent message to maildir

2015-01-10 Thread Bartosz
maildir folder is slected based on the address in from header and it is configurable via notmuch config. --- vim/notmuch.vim | 20 1 file changed, 20 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4f90d79..e95db4d 100644 --- a/vim/notmuch.vim +++ b/vim/not

[v2 1/3] thread.cc: Avoid empty thread names if possible.

2015-01-10 Thread David Bremner
Jesse Rosenthal writes: > > +#define EMPTY_STRING(s) ((s)[0] == '\0') > + Extra whitespace at end of line. If that's the only issue I can rebase it away, but maybe you want to enable the standard pre-commit hook? > struct visible _notmuch_thread { > notmuch_database_t *notmuch; >

[PATCH v1 2/2] emacs: Washing should use more `defcustom'.

2015-01-10 Thread David Bremner
David Edmondson writes: > More of the washing variables should be available through the standard > customisation interface. series LGTM. d

[PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread David Bremner
Todd writes: > I wanted to tag messages with calendar invitations, but couldn't as > the information wasn't indexed. > > This patch allows for queries for like: > > Find calendar invites > - contenttype:text/calendar or contenttype:applicaton/ics > > Find any image attachments > - contenttype:ima

[PATCH v2] emacs: Use the message cite variable

2015-01-10 Thread David Bremner
Todd writes: > I checked in the Emacs 22.1 source code, and there it was a defaulted > to message-cite-original as well. This patch falls back to > message-cite-original in the unlikely case that someone has customized > message-cite-function to nil. > The new patch _looks_ ok, but for some rea

[PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Todd
> "Jani" == Jani Nikula writes: Jani> On Sat, 10 Jan 2015, Todd wrote: >> I wanted to tag messages with calendar invitations, but couldn't as >> the information wasn't indexed. >> >> This patch allows for queries for like: >> >> Find calendar invites >> - c

[PATCH v3] emacs: Use the message cite variable instead of a calling cite-message-original directly

2015-01-10 Thread Todd
This fixes the test failure. I didn't have dtach installed, so the tests were being skipped earlier. As to why the test fails, it appears that the default for message-cite-function may depend on the version of Emacs that you use. This will likely cause notmuch replying to behave differently for

[PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Todd
> "DB" == David Bremner writes: DB> Todd writes: >> I wanted to tag messages with calendar invitations, but couldn't as >> the information wasn't indexed. >> >> This patch allows for queries for like: >> >> Find calendar invites >> - contenttype:text/calend

Re: [PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Todd
> "Jani" == Jani Nikula writes: Jani> On Sat, 10 Jan 2015, Todd wrote: >> I wanted to tag messages with calendar invitations, but couldn't as >> the information wasn't indexed. >> >> This patch allows for queries for like: >> >> Find calendar invites >> - c

[PATCH v3] emacs: Use the message cite variable instead of a calling cite-message-original directly

2015-01-10 Thread Todd
This fixes the test failure. I didn't have dtach installed, so the tests were being skipped earlier. As to why the test fails, it appears that the default for message-cite-function may depend on the version of Emacs that you use. This will likely cause notmuch replying to behave differently for

Re: [PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Todd
> "DB" == David Bremner writes: DB> Todd writes: >> I wanted to tag messages with calendar invitations, but couldn't as >> the information wasn't indexed. >> >> This patch allows for queries for like: >> >> Find calendar invites >> - contenttype:text/calend

Re: [PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread Jani Nikula
On Sat, 10 Jan 2015, Todd wrote: > I wanted to tag messages with calendar invitations, but couldn't as > the information wasn't indexed. > > This patch allows for queries for like: > > Find calendar invites > - contenttype:text/calendar or contenttype:applicaton/ics > > Find any image attachments

[PATCH] completion: update list of commands in zsh completion.

2015-01-10 Thread David Bremner
This is actually generated by the script in id:1420289900-29717-2-git-send-email-da...@tethera.net We may as well update the list of commands while we decide if it's worth automating the process. Note that there is a bit more noise than expected because it alphabetizes all of the commands wi

Re: [v2 3/3] thread-naming test: Test empty subject names.

2015-01-10 Thread David Bremner
Jesse Rosenthal writes: > > +test_begin_subtest "Use empty subjects if necessary." > +add_message '[subject]="@FORCE_EMPTY"' \ > + '[date]="Sat, 13 Jan 2001 15:43:45 -"' \ > +'[from]="Empty Sender \http://notmuchmail.org/mailman/listinfo/notmuch

Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.

2015-01-10 Thread David Bremner
Jesse Rosenthal writes: > > +#define EMPTY_STRING(s) ((s)[0] == '\0') > + Extra whitespace at end of line. If that's the only issue I can rebase it away, but maybe you want to enable the standard pre-commit hook? > struct visible _notmuch_thread { > notmuch_database_t *notmuch; >

Re: [PATCH v1 2/2] emacs: Washing should use more `defcustom'.

2015-01-10 Thread David Bremner
David Edmondson writes: > More of the washing variables should be available through the standard > customisation interface. series LGTM. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] Index Content-Type of attachments with a contenttype prefix

2015-01-10 Thread David Bremner
Todd writes: > I wanted to tag messages with calendar invitations, but couldn't as > the information wasn't indexed. > > This patch allows for queries for like: > > Find calendar invites > - contenttype:text/calendar or contenttype:applicaton/ics > > Find any image attachments > - contenttype:ima

Re: [PATCH v2] emacs: Use the message cite variable

2015-01-10 Thread David Bremner
Todd writes: > I checked in the Emacs 22.1 source code, and there it was a defaulted > to message-cite-original as well. This patch falls back to > message-cite-original in the unlikely case that someone has customized > message-cite-function to nil. > The new patch _looks_ ok, but for some rea