Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages

2024-03-10 Thread Mohsin Kaleem
t the exclude option you add to saved searches but I've addressed that in this next patch version. -- Mohsin Kaleem ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded

2023-05-05 Thread Mohsin Kaleem
ed and default to nil so nothing has to be changed in existing functions that call notmuch-search. Or we could switch to using cl-defun and have the default value substituted in the parameter list. I've never used cl-defun with interactive functions but long term I think that's the sane

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-08 Thread Mohsin Kaleem
buffer` or hit i as much as you like, the mail should now always be shown since its no longer excluded. -- Mohsin Kaleem ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-08-07 Thread Mohsin Kaleem
y to do this with notmuch involved (ideally through emacs and Magit)? -- Mohsin Kaleem ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

[PATCH 9/9] build: Fix declare-function calls for updated functions

2022-08-07 Thread Mohsin Kaleem
--- emacs/notmuch-hello.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 39ba2537..6d4197dd 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -33,10 +33,11 @@ (declare-function notmuch-poll "notmuch

[PATCH 8/9] review: Rename variables to better express intention

2022-08-07 Thread Mohsin Kaleem
--- emacs/notmuch-hello.el | 18 +- emacs/notmuch-jump.el | 2 +- emacs/notmuch-lib.el | 4 ++-- emacs/notmuch-tree.el | 24 emacs/notmuch.el | 29 +++-- 5 files changed, 39 insertions(+), 38 deletions(-) diff --git a/em

[PATCH 7/9] test: Fix Navigation of notmuch-hello to search results

2022-08-07 Thread Mohsin Kaleem
The default value of oldest-first is true so the oldest mail is shown first by default. This test case used the tree-from-search function which now persists this value of true (previously always defaulting to nil in its place) which produced a different tree output where the oldest-mail is sorted f

[PATCH 6/9] test: Add test cases for new exclude option

2022-08-07 Thread Mohsin Kaleem
--- test/T461-emacs-search-exclude.sh | 99 +++ .../notmuch-search-tag-inbox-with-excluded| 25 + .../notmuch-search-tag-inbox-without-excluded | 21 .../notmuch-tree-tag-inbox-with-excluded | 53 ++ .../notmuch-tree-tag-inbox-without-excluded

[PATCH 5/9] feat: Add more interactive specs

2022-08-07 Thread Mohsin Kaleem
--- emacs/notmuch-tree.el | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el index 9ed8a3d9..5f999424 100644 --- a/emacs/notmuch-tree.el +++ b/emacs/notmuch-tree.el @@ -1215,7 +1215,15 @@ The arguments are:

[PATCH 1/9] emacs: add new option notmuch-search-exclude

2022-08-07 Thread Mohsin Kaleem
The new notmuch-search-exclude option allows users to configure whether to show or hide excluded messages (as determined by search.exclude_tags in the local config file). It defaults to true for now to maintain backwards-compatibility with how notmuch-{search,tree} already worked. New commands not

[PATCH 2/9] docs: Update with notmuch-*-toggle-exclude

2022-08-07 Thread Mohsin Kaleem
--- devel/emacs-keybindings.org | 2 +- doc/notmuch-emacs.rst | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/devel/emacs-keybindings.org b/devel/emacs-keybindings.org index ad7f72ef..be6b2481 100644 --- a/devel/emacs-keybindings.org +++ b/devel/emacs-keybindings.org

[PATCH 3/9] test: Fix Search handles subprocess error exit codes

2022-08-07 Thread Mohsin Kaleem
Add in a new option --exclude which wasn't previously passed to the subprocess. --- test/T310-emacs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh index 9d0df187..b89a100e 100755 --- a/test/T310-emacs.sh +++ b/test/T310-emacs.sh @@ -1

[PATCH 4/9] feat: Allow :exclude configuration in notmuch-hello

2022-08-07 Thread Mohsin Kaleem
--- emacs/notmuch-hello.el | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 4662e704..810f094e 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -143,6 +143,10 @@ a plis

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-07-24 Thread Mohsin Kaleem
aining tests as something to come back to later but would prefer leaving them as something to add in a follow up PR if possible. Note: Some of the test cases are still failing: Specifically 4 of them, but their failing on the master branch as well so I believe their unrelated to this PR. >From 18

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-03-22 Thread Mohsin Kaleem
issing prerequisites: dtach(1) SKIP all tests in T720-emacs-attachment-warnings missing prerequisites: dtach(1) SKIP all tests in T730-emacs-forwarding Notmuch test suite complete. 1362/1379 tests passed. 7 broken tests failed as expected. 4 tests fa

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-03-22 Thread Mohsin Kaleem
;m not sure why that would be causing this to fail. I tried running `XDG_DATA_HOME= make test` and it's still failing. I also tried moving my notmuch repository copy outside of any XDG* directories but the tests are still failing :-(. -- Mohsin Kaleem _

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-03-22 Thread Mohsin Kaleem
uisites: dtach(1) SKIP all tests in T720-emacs-attachment-warnings missing prerequisites: dtach(1) SKIP all tests in T730-emacs-forwarding Notmuch test suite complete. 1324/1369 tests passed. 7 broken tests failed as expected. 42 tests failed. -4 tests skipped. All tests in 18 files skipped. ER

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-03-22 Thread Mohsin Kaleem
e existing tests are fixed before adding or changing new ones. >From 1872120821ccad5d23ab48d128d8d77efd85055d Mon Sep 17 00:00:00 2001 From: Mohsin Kaleem Date: Sat, 27 Nov 2021 18:58:43 + Subject: [PATCH 1/2] emacs: add new option notmuch-search-exclude The new notmuch-search-exclude option

[PATCH] emacs: add new option notmuch-search-exclude

2021-11-28 Thread Mohsin Kaleem
The new notmuch-search-exclude option allows users to configure whether to show or hide excluded messages (as determined by search.exclude_tags in the local config file). It defaults to true for now to maintain backwards-compatibility with how notmuch-{search,tree} already worked. New commands not

Re: notmuch-emacs: Add option to set -exclude=false in notmuch search/tree

2021-11-27 Thread Mohsin Kaleem
m 9b11223c0162f8736dd27d6f1db3fadbd3b027e2 Mon Sep 17 00:00:00 2001 From: Mohsin Kaleem Date: Sat, 27 Nov 2021 18:58:43 + Subject: [PATCH] emacs: add new option notmuch-search-exclude The new notmuch-search-exclude option allows users to configure whether to show or hide excluded messages (as

notmuch-emacs: Add option to set -exclude=false in notmuch search/tree

2021-10-25 Thread Mohsin Kaleem
ude` which toggles the value of `notmuch-search-exclude` for the current search. -- Mohsin Kaleem ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org