Re: Carriage returns in subject line cause problems in unthreaded and tree mode

2024-05-18 Thread Tomi Ollila
On Thu, May 16 2024, Richard Stanton wrote: > Today I received an email with (raw) subject line > > Subject: =?UTF-8?B?8J+Pi++4jw==?= A SALE to boost your > =?UTF-8?Q?workout=0D=0A?= > > When displayed in Emacs in either unthreaded or tree mode, “^M” appears after > the word “workout”, and the

[PATCH] NEWS: aspell(1)d few words

2024-03-12 Thread tomi . ollila
From: Tomi Ollila Executed aspell -l en -c NEWS and replaced few obvious cases. --- NEWS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index 315f4136..3b2ee05e 100644 --- a/NEWS +++ b/NEWS @@ -160,7 +160,7 @@ Library Add the `sexp` prefix

Re: [PATCH] config: allow custom separators in author lists

2024-02-16 Thread Tomi Ollila
On Fri, Dec 22 2023, Lars Kotthoff wrote: > The attached patch allows to customize the default ", " and "| " > separators in author lists. The main rationale for supporting this is > that the Python API uses the same functionality to get the list of > authors -- if I want to separate them again

Re: [PATCH v3] Add hook inside notmuch-mua-reply

2023-12-11 Thread Tomi Ollila
On Mon, Dec 11 2023, Sandra Snan wrote: > This hook is run after `notmuch reply` has been successfully called > with the headers from the original message. > --- > emacs/notmuch-mua.el | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH] Add hook inside notmuch-mua-reply

2023-12-11 Thread Tomi Ollila
On Mon, Dec 11 2023, David Bremner wrote: > Sandra Snan writes: > > >> +(defvar in-notmuch-mua-reply-functions nil >> + "Functions to run after `notmuch-reply' was called successfully >> +without erroring. The functions get the message-id as a string >> +argument.") >> + > > Overall this looks

Re: [PATCH] notmuch-emacs-mua: avoid extra separators at the end of the line

2023-11-30 Thread Tomi Ollila
On Thu, Nov 30 2023, Jani Nikula wrote: > Currently the --to/--cc/--bcc options add "u...@example.com, " to the > message headers, with the the unnecessary ", " separator after the > last address, regardless of how many addresses are being added. > > This used to be fine, but with recent emacs

Re: [PATCH] lib/string_map: simulate stable sorting

2023-11-26 Thread Tomi Ollila
On Sat, Nov 25 2023, David Bremner wrote: > qsort(3) does not promise stability, and recent versions of glibc have > been showing more unstable behaviour [2]. Michael Gruber observed [1] test > breakage due to changing output order for message properties. > > We provide a sorting order of

Re: [PATCH 0/4] test: T380 rework

2023-11-24 Thread Tomi Ollila
On Fri, Nov 24 2023, Michael J. Gruber wrote: > So, with the key-value pairs sorted by both, I resumed testing for Python > 3.1.13 and encountered failing T380 which gave me some a deja-vue due to > its confusing messages: > > ``` > T380-atomicity: Testing atomicity > cat: outcount: No such file

Re: partial cleanup of warnings from byte compilation

2023-10-07 Thread Tomi Ollila
On Fri, Oct 06 2023, David Bremner wrote: > This is almost all docstring formatting, except for the last > patch. > > This is really just some low hanging fruit, but presumable eliminating > some warnings is better than nothing. The warnings are more annoying > now that native compilation exposes

Re: [PATCH] devel/nmweb: read mail files in binary mode.

2023-09-17 Thread Tomi Ollila
On Sat, Sep 16 2023, David Bremner wrote: > "ju" reported on IRC that browsing > > > https://nmbug.notmuchmail.org/nmweb/show/20160719094205.qmf5sjnja6crt5t3%40gotlib > > crashed. The underlying issue is that python3 defaults to utf8 > decoding files unless they are opened in binary mode.

Re: [PATCH] NEWS: NEWS for 0.38

2023-09-11 Thread Tomi Ollila
On Sat, Sep 09 2023, David Bremner wrote: > --- > I did my best to reconstruct the changes since 0.37. Let me know any > suggested corrections or updates in the next few days. I don't know about the NEWS content, but the rc2 (w/ 2 (+2 test test) changes on top) works for me (that makes the

Re: [PATCH] compat: probe for strcasestr more thoroughly

2023-08-27 Thread Tomi Ollila
ude both so that both detection and compilation phases use the same > (possibly optimised) implementations. > > Suggested-by: Thomas Schneider > Suggested-by: Florian Weimer > Suggested-by: Tomi Ollila > --- LGTM :D Tomi > This is related to the discussion here:

Re: [PATCH] test/emacs: adapt to breaking change in Gnus defaults

2023-08-21 Thread Tomi Ollila
On Sun, Aug 20 2023, David Bremner wrote: > As of Emacs 29.1, In-Reply-To is in the default value for > message-hidden-headers. We actually want to see that in the test > suite, so remove it again. To future proof the tests, fix a default > value for message-hidden-headers specifically for the

Re: Speedup for deleting files

2023-07-22 Thread Tomi Ollila
On Thu, Jul 20 2023, David Bremner wrote: > Thanks to discussion with Olly Betts and some perf runs, I realized > the current clean up of deleted files from the database is somewhat > wasteful since it modifies the message documents (by deleting the > filename) before in most cases deleting the

Re: [PATCH v4 4/5] test: support testing notmuch as installed

2023-07-11 Thread Tomi Ollila
On Sun, Jul 09 2023, David Bremner wrote: Note: I almost commented cases where it was not ensured that variable is defined, to notice later that those were actually defined for sure -- so in some previous mails in this series I may have missed same cases. The comments for this message may be

Re: [PATCH v4 3/5] test: Guess a value for NOTMUCH_PYTHON

2023-07-11 Thread Tomi Ollila
On Sun, Jul 09 2023, David Bremner wrote: > python3 will work for many people, and reduce the friction to running > the tests without running configure first. > --- > test/test-lib-common.sh | 4 > 1 file changed, 4 insertions(+) > > diff --git a/test/test-lib-common.sh

Re: [PATCH v4 2/5] test: check for empty/missing files in test_expect_equal_message_body

2023-07-11 Thread Tomi Ollila
On Sun, Jul 09 2023, David Bremner wrote: > Messages can have empty bodies, but empty files are not messages. > --- > test/test-lib.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 1a6525df..b5aa94dd 100644 > --- a/test/test-lib.sh >

Re: [PATCH v4 1/5] test: treat undefined feature variables as 0

2023-07-11 Thread Tomi Ollila
On Sun, Jul 09 2023, David Bremner wrote: > When running the test suite without building first, it is desirable to > have the tests consider these variables being undefined as equivalent > to the feature not being present, and in particular for the tests not > to generate errors. > --- ... > diff

Re: [PATCH] python: adjust legacy bindings to py 3.12

2023-06-21 Thread Tomi Ollila
On Fri, Jun 16 2023, michaeljgruber wrote: > From: Michael J Gruber > > Py 3.12 finally pulled the plug on the `SafeConfigParser` class which > has been deprecated since py 3.2. > > We use it in the legacy bindings only, so take the easy route of > importing `ConfigParser` as `SafeConfigParser`

Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Tomi Ollila
On Sun, Apr 09 2023, David Bremner wrote: > It is desirable to have the tests consider these variables being > undefined as equivalent to the feature not being present, and in > particular for the tests not to generate errors. > > We know the test suite is tied to bash anyway, so this is a simple

Re: [PATCH v3 1/5] test: use bash specific test for feature tests

2023-04-13 Thread Tomi Ollila
On Thu, Apr 13 2023, Felipe Contreras wrote: > On Sun, Apr 9, 2023 at 9:26 AM David Bremner wrote: >> >> It is desirable to have the tests consider these variables being >> undefined as equivalent to the feature not being present, and in >> particular for the tests not to generate errors. > >

Re: [PATCH 2/2] lib/message-property: sync removed properties to the database

2023-03-02 Thread Tomi Ollila
On Wed, Mar 01 2023, Kevin Boulain wrote: > _notmuch_message_remove_all_properties wasn't syncing the message back > to the database but was still invalidating the metadata, giving the > impression the properties had actually been removed. > > Also move the metadata invalidation to

Re: [PATCH 1/4] test: mark some tests as broken when run as root.

2023-01-05 Thread Tomi Ollila
On Wed, Jan 04 2023, David Bremner wrote: > File permission errors e.g., are hard to trigger as root. > --- > test/T050-new.sh | 1 + > test/T150-tagging.sh | 1 + > test/test-lib.sh | 6 ++ > 3 files changed, 8 insertions(+) > > diff --git a/test/T050-new.sh b/test/T050-new.sh >

Re: [PATCH 1/3] lib/database: propagate status code from _notmuch_message_delete

2022-12-25 Thread Tomi Ollila
On Sat, Dec 03 2022, David Bremner wrote: > _notmuch_message_delete can return (at least) > NOTMUCH_STATUS_XAPIAN_EXCEPTION, which we should not ignore. Series LGTM Tomi > --- > lib/database.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/database.cc

Re: [PATCH] compat/strcasestr: Include correct header file

2022-12-25 Thread Tomi Ollila
On Sat, Dec 03 2022, Thomas Schneider wrote: > Tomi Ollila writes: > >> On Fri, Dec 02 2022, Thomas Schneider wrote: >> >>> As per strcasestr(3) of glibc and FreeBSD, the header that defines >>> strcasestr() is string.h, not strings.h. This may cause compila

Re: [PATCH] compat/strcasestr: Include correct header file

2022-12-03 Thread Tomi Ollila
On Fri, Dec 02 2022, Thomas Schneider wrote: > As per strcasestr(3) of glibc and FreeBSD, the header that defines > strcasestr() is string.h, not strings.h. This may cause compilation, > and thus detection whether an (optimised) version is available, to > fail even if the function is available,

Re: [PATCH 3/3] emacs/show: use n-s-i-headerline to update tags

2022-11-15 Thread Tomi Ollila
On Tue, Nov 15 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> and then grepping thru notmuch source code: >> >> notmuch-tree.el:497: (delete-region (point) (1+ (line-end-position))) >> >> -- it looks to me this could be simpler and fa

Re: [PATCH 3/3] emacs/show: use n-s-i-headerline to update tags

2022-11-13 Thread Tomi Ollila
On Fri, Nov 11 2022, David Bremner wrote: > Although this has more steps than the previous regular expression > search and replace, it should be more robust against changes in the > headerline format, such as the inclusion of duplicate numbers (which > broke the previous version). > --- >

Re: [PATCH] emacs: fix notmuch-show-update-tags to support duplicate files

2022-11-06 Thread Tomi Ollila
On Sat, Nov 05 2022, David Bremner wrote: > Tomi Ollila writes: > > >> Is this getting too complex (well, we may have other stuff with >> similar complexity there ;/) ? >> >> Is there any better solutions ? > > I want to try redrawing the whole headerl

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-14 Thread Tomi Ollila
On Wed, Oct 12 2022, Robin Jarry wrote: > Hi Tomi, > > Tomi Ollila, Oct 12, 2022 at 21:39: >> > diff --git a/notmuch-show.c b/notmuch-show.c >> > index ee9efa7448d7..ad31e0123268 100644 >> > --- a/notmuch-show.c >> > +++ b/notmuch-show.c >> &

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-12 Thread Tomi Ollila
On Wed, Oct 12 2022, Robin Jarry wrote: > notmuch search does not output header values. However, when browsing > through a large email corpus, it can be time saving to be able to > paginate without running notmuch show for each message/thread. > > Add --offset and --limit options to notmuch show.

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-10 Thread Tomi Ollila
On Thu, Oct 06 2022, Michael J. Gruber wrote: > Am Do., 6. Okt. 2022 um 18:34 Uhr schrieb David Bremner : >> >> Michael J Gruber writes: >> >> > >> > Yes, lto-wrapper calls make. >> > >> > Are we compiling test functions on the fly during the test? In that >> > case we need to make sure that

[PATCH] emacs: fix notmuch-show-update-tags to support duplicate files

2022-09-22 Thread Tomi Ollila
With duplicate files, the headerlines of messages in notmuch-show buffer contains (initially) 1/n at the end of line. Update the regexp used to search and replace tag changes to match the current line -- drop unnecessary capturing of the (tags), but capture the duplicates indicator. Update the

[PATCH] emacs: add notmuch-search-edit-search and notmuch-tree-edit-search

2022-09-18 Thread Tomi Ollila
...and bind these to "E" in their respective keymaps. Expected to be called interactively, then using read-from-minibuffer with current search string as initial contents for editing. (Noninteractive use makes little sense, but is supported.) With this one can expand (as an opposite to limit)

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-16 Thread Tomi Ollila
On Mon, Sep 12 2022, Daniel Kahn Gillmor wrote: > On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: >> Tomi Ollila writes: >> >>> On Fri, Sep 09 2022, Justus Winter wrote: >>> >>>> --- >>>> test/T350-crypto.sh | 2 +- >>>>

Re: "-1 tests skipped"

2022-09-16 Thread Tomi Ollila
On Sun, Sep 11 2022, Daniel Kahn Gillmor wrote: > I'm running the test suite on notmuch master > (8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following > report: > > ``` > All 1758 tests behaved as expected (12 expected failures). > -1 tests skipped. > All tests in 2 files skipped. >

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-11 Thread Tomi Ollila
On Fri, Sep 09 2022, Justus Winter wrote: > --- > test/T350-crypto.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 3c6626b4..721cbfdd 100755 > --- a/test/T350-crypto.sh > +++ b/test/T350-crypto.sh > @@ -467,7 +467,7 @@

Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-08-31 Thread Tomi Ollila
On Tue, Aug 30 2022, Antoine Beaupré wrote: > This enables auto-completion of commands, something which plain > read-string does not do. It's otherwise a drop-in > replacement. According to `C-h f`, read-shell-command was introduced > in Emacs 23.1 or earlier. LGTM. Tomi > --- >

Re: [PATCH] emacs: new notmuch-tree-process-exit-functions

2022-08-21 Thread Tomi Ollila
On Sun, Aug 21 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- LGTM. I (also would have chosen this name instead of the *sentinel* one) Tomi > This patch supersedes , but > changing the new variable name. > > Right now, it can be used for silly

Re: [PATCH] emacs: new notmuch-tree-process-hook

2022-08-16 Thread Tomi Ollila
On Tue, Aug 16 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- > > Right now, it can be used for silly things like removing or changing > the the "End of search." hardcoded message in the tree buffer. But > also for more sophisticated things like

Re: [PATCH] test: increase cffi timeout

2022-08-15 Thread Tomi Ollila
On Sun, Aug 14 2022, michaeljgruber wrote: > From: Michael J Gruber > > By default, the test suite uses 2min for other tests and 5s for cffi > tests. Sporadically, this leads to test failures caused by the timeout > on slower or loaded test infrastructure (as seen on ppc64le in Fedora's >

Re: Embed elisp.py from flycheck, use it in notmuch-emacs doc

2022-08-10 Thread Tomi Ollila
On Sun, Jul 31 2022, David Bremner wrote: > After finding myself spending a while trying to re-create one of the > features [0] of the el sphinx domain used in flycheck, I decided to try > just converting the docs to use that sphinx extension. > > As I remarked in 2018 [1], there doesn't seem to

Re: [PATCH 2/2] emacs/show: restrict inlined mimetypes on refresh.

2022-08-10 Thread Tomi Ollila
On Mon, Aug 01 2022, David Bremner wrote: > This fixes the bug reported by Al [1]. Essentially apply the same fix > as [2] in a different place. > > [1]: id:877d41nmr1@gmail.com > [2]: 90a7c1af368a527700dcde9b0dcbd760afc7bd92 LGTM. Tomi > --- > emacs/notmuch-show.el | 1 + >

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-08 Thread Tomi Ollila
On Sun, Aug 07 2022, Mohsin Kaleem wrote: > --- > test/T461-emacs-search-exclude.sh | 99 +++ > .../notmuch-search-tag-inbox-with-excluded| 25 + > .../notmuch-search-tag-inbox-without-excluded | 21 > .../notmuch-tree-tag-inbox-with-excluded | 53

Re: Create tags from folders

2022-08-08 Thread Tomi Ollila
On Sun, Aug 07 2022, Notmuch mailinglist wrote: > Hello, > > I've managed to get mbsync, notmuch and neomutt all setup. But its now time > for fine tuning and tinkering. > My email is from Protonmail and I use sieve filters to organise my mail as > needed into folders. > Mbsync creates a folder

[PATCH] notmuch.c: add missing trailing newlines in two error messages

2022-07-31 Thread Tomi Ollila
Removed duplicate error check (and the message) in 3rd case where the same error message (w/o trailing newline) was present. In case of test/T040-setup.sh, command substitution deletes trailing newlines, so related test there cannot be changed (and therefore could not notice this user experience

Re: [PATCH v2] CLI/git: opportunistically use bindings to check for known messages

2022-07-16 Thread Tomi Ollila
On Fri, Jul 15 2022, David Bremner wrote: > If the bindings are installed, use them to avoid one exec of notmuch > search per message. tnx. continues to work for me where I have symlink to nmbug in ~/bin/. some time in the future i'll investigate whether i get python3 path/to/nmbug.zip ...

quoting: (was: Re: bug#56442: gnus-search-run-search: Hits notmuch command line length limits)

2022-07-09 Thread Tomi Ollila
On Sat, Jul 09 2022, Eric Abrahamsen wrote: > > Huh, I tried this a couple months ago with a more complicated query, > like: > > thread:{from:bob or from:jane} > > and I remember notmuch barking at me about spaces or the "or" or > something -- anyway I got the impression that it couldn't accept >

Re: [PATCH 4/4] CLI/git: replace calls to notmuch-search with database access

2022-07-07 Thread Tomi Ollila
On Sun, Jul 03 2022, David Bremner wrote: > This introduces a dependency on the (new) python bindings, but since > it also yields a 4x performance improvement on the large performance > corpus, I think it is worth it. > --- > debian/control | 1 + > notmuch-git.py | 18 +- >

Re: [PATCH 2/4] perf-test: add tests for notmuch-git

2022-07-05 Thread Tomi Ollila
On Sun, Jul 03 2022, David Bremner wrote: > The main focus of these initial tests is the (currently unacceptably > slow) checkout performance. > --- > performance-test/T07-git.sh | 23 +++ > 1 file changed, 23 insertions(+) > create mode 100755 performance-test/T07-git.sh >

Re: [PATCH] doc/emacs: add notmuch-show-empty-saved-searches to manual

2022-07-05 Thread Tomi Ollila
On Fri, Jul 01 2022, David Bremner wrote: > Answering a user question, I had to dig for this variable, but I think > it is a reasonably common customization wish, particularly for users > with custom count-functions. pretty trivial. i trust it works as expected (at least no extra whitespace ;)

Re: [PATCH] CLI/git: replace most mentions of nmbug

2022-07-05 Thread Tomi Ollila
On Mon, Jul 04 2022, David Bremner wrote: > Particularly in help messages, nmbug is confusing for users who may > have never heard of it. Good Progress! LGTM! Tomi > --- > notmuch-git.py | 40 > 1 file changed, 20 insertions(+), 20 deletions(-) > >

Re: [PATCH] emacs: mark notmuch-query.el as obsolete

2022-07-03 Thread Tomi Ollila
On Tue, Jun 28 2022, David Bremner wrote: > The only functionality actually used by notmuch is the base function > notmuch-query-get-threads; the other functions in this file have > nothing to do with that (single) use. Move that function into > notmuch-lib.el and rename to reflect use.

Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions

2022-05-18 Thread Tomi Ollila
On Tue, May 17 2022, Jose A. Ortega Ruiz wrote: > On Tue, May 17 2022, Tomi Ollila wrote: > > [...] > >> Otherwise it looks good to me (took a bit to match cond CLAUSES...) > > perhaps it'd be bit clearer if i factor it out in a separate function > that just does th

Re: [PATCH v2 1/1] emacs: notmuch-show-header-line: allow format strings and functions

2022-05-17 Thread Tomi Ollila
On Mon, May 16 2022, j...@gnu.org wrote: > If a string value is assigned to notmuch-show-header-line, it's used > as a format string to be passed passed to format-spec with `%s` > substituted by the message's subject. If a function is given, it's > called with the subject as argument, and its

Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread

2022-05-03 Thread Tomi Ollila
On Mon, May 02 2022, Leo Okawa Ericson wrote: > --- > emacs/notmuch.el | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index c9cf80dc..c1ddb06b 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -525,13

Re: [PATCH] doc/sexp-queries: escape @ in non-verbatim text

2022-04-29 Thread Tomi Ollila
On Thu, Apr 28 2022, David Bremner wrote: > This prevents sphinx-doc from creating spurious mailto: links. Thanks > to Jakub Wilk for telling me about the fix. looks trivial to me > --- > doc/man7/notmuch-sexp-queries.rst | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > >

Re: [PATCH 1/1] emacs: Make notmuch-show-next-thread return nil on failure

2022-04-29 Thread Tomi Ollila
On Thu, Apr 28 2022, Leo wrote: > From: Leo Okawa Ericson > > Having notmuch-show-next-thread return non-nil on success and nil on > failure makes it easier for users to interact with notmuch via elisp. > --- > emacs/notmuch.el | 17 + > 1 file changed, 9 insertions(+), 8

Re: [PATCH] configure: avoid warning with -Wall

2022-04-19 Thread Tomi Ollila
On Mon, Apr 18 2022, michaeljgruber wrote: > From: Michael J Gruber > > 7228fe68 ("configure: restructure gmime cert validity checker code", > 2022-04-09) restructured generated C code to repurpose it later on. This > put usage of `validity` within an `#if`, resulting in an "unused > warning" if

Re: mailto: in Firefox and notmuch-emacs-mua

2022-04-18 Thread Tomi Ollila
On Fri, Apr 15 2022, talin nicholas wrote: > When opening a mailto: link, Firefox defaults to notmuch-emacs-mua, > which is what I want, minus that it spawns a new Emacs instance (which > hangs) rather than opening an *unsent mail* buffer in my existing > daemon. I copied the .desktop file from

Re: emacs: notmuch-address-command 'as-is throws error (was: [PATCH] emacs: Add more front ends for address completion)

2022-02-22 Thread Tomi Ollila
On Mon, Feb 21 2022, Alexander Adolf wrote: > Alexander Adolf writes: > >> [...] >> Hence, from my personal point of view, moving _all_ completion to go >> through completion-at-point-functions seems the only reasonable way >> forward. >> >> That would remove any special cases for when company

[PATCH v3] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " replaced with use of sed "s/^/ /" in next line. --- Replaces v2 id:20220220210111.17653-1-tomi.oll...@iki.fi

[PATCH v2] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " replaced with use of sed 's/^/ /' in next line. --- Replaces id:20220220205230.17446-1-tomi.oll...@iki.fi

[PATCH 1/5] removed use of 'echo -n' (and echo -n -e ...)

2022-02-20 Thread Tomi Ollila
In most cases used printf %s ... instead. echo -n > file lines to create empty / truncate files were changed to : > file lines, like done in in test-lib-emacs.sh And one echo -n " " just merged to echo in previous line. --- Most of the changes went to release-checks.sh -- the one I've mostly

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-19 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Michael J Gruber writes: > > >> When analysing this, I was confused by the way >> test_require_external_prereq works and the "if" in T380 (as opposed to how >> test_require_external_prereq is used in other tests). Over at git.git, >> we have test setup

Re: [PATCH 4/4] CLI/insert: escape envelope from

2022-02-19 Thread Tomi Ollila
On Sun, Feb 13 2022, David Bremner wrote: > The idea is to do as little parsing and modification of the delivered > message as possible. Luckily the position of the "envelope header" > lets us escape it by replacing the first 5 characters of the stream > with a regular header name (with ':'). >

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Tomi Ollila wrote: > > I'd not merge this NOTMUCH_NEW_OPTIONS=--full-scan ;D too eagerly > ... I'd like we really knew the reason (which is then written in > commit message) I seem I did not get my message above (or why the ;D is there) expressed clear enough

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-16 14:04:17: >> Michael J Gruber writes: >> >> > Some build infrastructure appears to habe problems with mtime/stat, >> >> have > > Huh, this looks as if my mother tongue slipped in, while it's just key >

Re: [PATCH] emacs: escape quote in notmuch-search-result-format docstring

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, David Bremner wrote: LGTM, now I remeber this syntax... Tomi > Prevent Emacs' mangling of quotes, which breaks the code sample. > --- > emacs/notmuch.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index

Re: [BUG] Bad quote in help

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Rudolf Adamkovič wrote: > Repro steps: > > 1. C-h v > 2. notmuch-search-result-format > 3. RET > > See: > > For example: > (setq notmuch-search-result-format > ’(("authors" . "%-40s") > ("subject" . "%s"))) > > The quote ’ needs changed to ',

Re: Test suite timing issues?

2022-02-14 Thread Tomi Ollila
On Mon, Feb 14 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp >> comparisons (which would indicate the subsecond resolution most fs' provide >> is not used)... >> >> ...

Re: Test suite timing issues?

2022-02-14 Thread Tomi Ollila
On Mon, Feb 14 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp >> comparisons (which would indicate the subsecond resolution most fs' provide >> is not used)... >> >> ...

Re: [PATCH v2] nmbug: write tags out to a temporary file, not 'nmbug.index'

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Sean Whitton wrote: > Hello, > > On Sun 13 Feb 2022 at 09:54am -07, Sean Whitton wrote: > >> If more than nmbug process is running at once, then each will try to >> read and write the same file. The particular failure I've seen is >> that the process which finishes first

Re: Test suite timing issues?

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Tomi Ollila wrote: > On Sat, Feb 12 2022, David Bremner wrote: > >> Tomi Ollila writes: >> >>> >>> Does such a change hide "buggy" functionality ? >> >> We mostly don't use add_message, call notmuch new via NOTMUCH_

Re: [PATCH] nmbug: write tags out to a temporary file, not 'nmbug.index'

2022-02-13 Thread Tomi Ollila
On Sun, Feb 13 2022, Sean Whitton wrote: > If more than nmbug process is running at once, then each will try to > read and write the same file. The particular failure I've seen is > that the process which finishes first deletes nmbug.index, and then > the other process dies with a

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Does such a change hide "buggy" functionality ? > > We mostly don't use add_message, call notmuch new via NOTMUCH_NEW in > T050-new.sh. So I think it would mostly not hide bugs in notmuc

Re: [Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

2022-02-12 Thread Tomi Ollila
On Fri, Feb 11 2022, Utkarsh Singh wrote: > On 2022-02-10, 19:37 +0200, Tomi Ollila wrote: > >> >> When doing in notmuch repo, one can execute ./devel/try-emacs-mua -Q >> >> ... which probably uses the same package database (under $HOME) as any >> oth

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, David Bremner wrote: > Tomi Ollila writes: > >> On Sat, Feb 12 2022, Michael J. Gruber wrote: >> >> Only thing that came into mind are directory timestamps... if directory >> (m)time is same as before notmuch will not scan it fo

Re: Test suite timing issues?

2022-02-12 Thread Tomi Ollila
On Sat, Feb 12 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-12 01:03:00: >> Michael J Gruber writes: >> >> > Hi there, >> > >> > I'm trying to package notmuch for Redhat's enterprise linux and clones >> > (EPEL, extra packages for enterprise linux). >> > >> > This

Re: Python binding SIGABRT/SIGSEGV

2022-02-11 Thread Tomi Ollila
On Fri, Feb 11 2022, Michael J. Gruber wrote: > Austin Lund venit, vidit, dixit 2022-02-10 23:21:58: >> On Thu, Feb 10, 2022 at 01:12:47PM +0100, Michael J Gruber wrote: >> > Austin Lund venit, vidit, dixit 2022-02-10 06:56:12: >> > > I'm clearly doing this python code wrong by not using the

Re: [Utkarsh Singh] Re: [PATCH] emacs: Add more front ends for address completion

2022-02-10 Thread Tomi Ollila
On Thu, Feb 10 2022, Utkarsh Singh wrote: > Start of forwarded message > From: Utkarsh Singh > To: Tomi Ollila > Subject: Re: [PATCH] emacs: Add more front ends for address completion > Date: Thu, 10 Feb 2022 08:58:49 +0530 > > He

Re: [PATCH 4/4] test: set up the outcount file for T380.1

2022-02-10 Thread Tomi Ollila
On Thu, Feb 10 2022, Michael J. Gruber wrote: > Tomi Ollila venit, vidit, dixit 2022-02-09 21:50:35: >> On Wed, Feb 09 2022, Michael J. Gruber wrote: >> >> > If gdb is present but for some reason `atomicity.py` fails to write to >> > the output file then the test

Re: [PATCH] emacs: Add more front ends for address completion

2022-02-09 Thread Tomi Ollila
On Tue, Feb 08 2022, Utkarsh Singh wrote: > Hello maintainers, > > Emacs Lisp Package Archive (ELPA) now includes a package called 'corfu', > according to its documentation: > > Corfu enhances the default completion in region function with a > completion overlay. The current

Re: [PATCH 4/4] test: set up the outcount file for T380.1

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is present but for some reason `atomicity.py` fails to write to > the output file then the test fails with some ugly bash errors in the > wrong places (because the outcount variable is empty). > > Therefore, set up the outcount file with `0`

Re: [PATCH 3/4] test: reword T380.2 to be clearer

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > T380.2 gives a test description which depends on the actual test output, > rather than the expected outcome or actual test which is performed. > > So, when the test fails due missing abort points, the test describes > itself as `detected 0>10 abort

Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > If gdb is missing then some files are never written to so that the > comparisons of non-existing files succeeds for the wrong reason, > claiming that `notmch new` is idempotent when it was in fact never run. > > Catch this and (for lack of a better

Re: [PATCH 1/4] test: correct comparison order in T380

2022-02-09 Thread Tomi Ollila
On Wed, Feb 09 2022, Michael J. Gruber wrote: > Specifying test comparisons as "expected actual" gives a better readable > diff since the "-" indicates missing, "+" additional items compared to > the expectations. > > Signed-off-by: Michael J Gruber > --- > test/T380-atomicity.sh | 2 +- > 1

[PATCH] NEWS: emacs/notmuch-logo.svg is there in 0.35

2022-01-31 Thread Tomi Ollila
--- NEWS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS b/NEWS index bc2a80de..d03d0a33 100644 --- a/NEWS +++ b/NEWS @@ -44,6 +44,9 @@ Use `--excludes=false` when generating the 'All tags' section. Use cached copy of message body for `Fcc`, avoiding variant bodies for signed and/or

Re: [PATCH] NEWS: my changes for 0.35

2022-01-31 Thread Tomi Ollila
On Sun, Jan 30 2022, David Bremner wrote: I don't know about content, but style looks good ;D Pushing now would help when forthcoming NEWS changes pour in... Tomi > --- > NEWS | 68 > 1 file changed, 68 insertions(+) > > diff --git

Re: [PATCH 2/4] test: define test_expect_equal_message_body

2022-01-20 Thread Tomi Ollila
On Thu, Jan 20 2022, David Bremner wrote: > This is a relatively simple sed invocation, but rather than write a > comment everywhere, give it a descriptive name. > --- > test/test-lib.sh | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh

Re: [PATCH] test/emacs: known broken test for matching fcc and sent message

2022-01-20 Thread Tomi Ollila
On Wed, Jan 19 2022, David Bremner wrote: > David Bremner writes: > >> Based on the method outlined by Daniel Kahn Gilmour in >> id:87k1zm225v@fifthhorseman.net. With a delay of 0.2 seconds the >> test becomes flaky on my machine. With a 1 second delay it fails >> consistently for more than

Re: [PATCH] CLI: print extra headers only for non-replies

2022-01-19 Thread Tomi Ollila
On Tue, Jan 18 2022, David Bremner wrote: > If in the future we decide to output extra headers for replies, this > should be controlled by a separate configuration option. > --- > notmuch-show.c | 3 ++- > test/T310-emacs.sh | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH v4] emacs: customizable names for search buffers

2022-01-16 Thread Tomi Ollila
On Fri, Jan 14 2022, Jose A. Ortega Ruiz wrote: > on second thought, i think we could perhaps just go for the simpler > "%t", which would allow inserting the type anywhere, even in the middle > of a word... i think a problem here is that "word" or "symbol" (which is > what my suggestion used)

Re: [PATCH v2] emacs/notmuch-tag.el: add xmlns attribute to svg icons

2022-01-14 Thread Tomi Ollila
On Fri, Jan 14 2022, LdBeth wrote: > emacs-mac that compiled with OS X system API for image display > support cannot correctly render svg without xmlns parameter [1]. LGTM. Tomi > > [1]: id:tencent_127aa231767438ac66fee4ddb4bbf51df...@qq.com > --- > emacs/notmuch-tag.el | 6 +++--- > 1 file

Re: [PATCH] emacs/notmuch-tag.el: add xmlns attribute to svg icons

2022-01-13 Thread Tomi Ollila
On Thu, Jan 13 2022, LdBeth wrote: > emacs-mac that compiled with OS X system API instead of imagemagick > cannot render svg without xmlns correctly [1]. Referecing Imagemagick in this commit message may be incorrect, otherwise content looks good. In case of Emacs 26, when imagemagick is used

Re: notmuch-emacs: svg icon cannot be rendered by emacs-mac

2022-01-13 Thread Tomi Ollila
On Wed, Jan 12 2022, LdBeth wrote: > The svg icons included in notmuch-emacs cannot be correctly rendered > by emacs-mac (https://bitbucket.org/mituharu/emacs-mac/src/master/), > > The empty SVG created by `svg-image' function from svg.el has XML > attribute `xmlns' like: > > "

Re: [PATCH v4] emacs: customizable names for search buffers

2022-01-12 Thread Tomi Ollila
On Mon, Jan 10 2022, j...@gnu.org wrote: > Customizable names for buffers presenting search results, via two > custom variables (notmuch-search-buffer-name-format and > notmuch-saved-search-buffer-name-format), defaulting to values > currently used for plain searches and including too tree and >

FYI: emacs / notmuch-search-edit-search

2022-01-12 Thread Tomi Ollila
Hi all I've had this for a while in .emacs.d/notmuch-config.el --- (defun notmuch-search-edit-search () "Edit current search" (interactive) (notmuch-search (read-from-minibuffer "Edit search: " notmuch-search-query-string) notmuch-search-oldest-first))

Re: [PATCH] configure: Ignore more options that Fedora spec macros expect

2022-01-11 Thread Tomi Ollila
On Tue, Jan 11 2022, michaeljgruber wrote: > From: Michael J Gruber > > Signed-off-by: Michael J Gruber > --- LGTM. Tomi > This allows the Fedora packager to use the standard Fedora packaging > macros rather than a hand-tailored configure call. > > [Sorry for resend, my mails don't seem to

Re: [PATCH 1/3] build: move LDFLAGS after notmuch libraries.

2021-12-29 Thread Tomi Ollila
On Fri, Dec 24 2021, David Bremner wrote: > In [1] Ryan Schmidt reported a problem on macports [2] with notmuch > finding an existing installed version of libnotmuch during the build > when the user specified LDFLAGS including the libnotmuch install > directory. > > This change should prevent

  1   2   3   4   5   6   7   8   9   10   >