Re: [PATCH v4 2/7] emacs/show: Accommodate the lack of part header buttons

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > Various pieces of code assumed (reasonably) that part header buttons > are present. Modify them to avoid problems if no part headers were > inserted. This looks fine. > --- > emacs/notmuch-show.el | 88 >

Re: [PATCH v4 1/7] emacs/show: Re-arrange determination if a part header is necessary

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > Move the determination of whether a part header is required to a > distinct function. > --- > emacs/notmuch-show.el | 25 ++--- > 1 file changed, 18 insertions(+), 7 deletions(-) > > diff --git

Re: [PATCH v4 5/7] emacs/show: Make the insertion of part headers overridable.

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > This allows callers of notmuch-show-insert-bodypart to use a `let' > binding to override the default function for specifying when part > headers should be inserted. Looks fine. > --- > emacs/notmuch-show.el | 16

Re: [PATCH v4 3/7] emacs/mua: Generate improved cited text for replies

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > Use the message display code to generate message text to cite in > replies. Looks fine. > --- > emacs/notmuch-mua.el | 38 -- > 1 file changed, 8 insertions(+), 30

Re: [PATCH v4 7/7] test: fix the tests for the new reply code

On Sat, Nov 07 2015, Mark Walters wrote: > This sets the part-insertion code to never insert part headers (as we > didn't before). > > With that change there is only one failing test: this test has a text > part (an email message) listed as application/octet-stream. Notmuch > show displays this

Re: [PATCH v4 6/7] emacs/mua: Let user specify which parts get a header in citations.

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > Add a customizable function specifying which parts get a header when > replying, and give some sensible possiblities. These are, > > 1) all parts except multipart/*. (Subparts of a multipart part do > receive a

Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'

On Sat, Jun 13 2015, Mark Walters wrote: > Change the key binding for filter (or "limit") in search-mode. This > gives consistency with the new filter in show-mode, and frees 'f' for > forward-thread in the future. Is there a conclusion on this change? The patch itself seems obviously fine from a

Re: [PATCH] emacs: hello: display jump key next to saved search when available

On Sun, Feb 07 2016, Jani Nikula wrote: > On Sun, 07 Feb 2016, David Edmondson wrote: >> On Sun, Dec 13 2015, Jani Nikula wrote: >>> Display the shortcut jump key next to the saved search name in notmuch >>> hello, if one is defined for the saved search. >> >> I

Re: [PATCH v4 4/7] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart'

On Sat, Nov 07 2015, Mark Walters wrote: > From: David Edmondson > > No code uses the 'no-buttons argument to > `notmuch-show-insert-bodypart', so remove it. Looks fine. > --- > emacs/notmuch-show.el | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH v3 01/16] add util/search-path.{c, h} to test for executables in $PATH

Daniel Kahn Gillmor writes: > +notmuch_bool_t > +test_for_executable(const char* exename) > +{ > +char *c = NULL, *save = NULL, *tok; > +size_t n; > +int dfd = -1; c, dfd, and n could be more meaningful as variable names. % uncrustify --config

[PATCH v1 2/3] emacs: Always insert crypto buttons.

When no decryption or signature examination is happening (i.e. `notmuch-crypto-process-mime' is `nil') insert buttons that indicate this, rather than remaining silent. --- emacs/notmuch-show.el | 29 +++-- 1 file changed, 11 insertions(+), 18 deletions(-) diff --git

[PATCH v1 1/3] emacs: Improve crypto button labels.

Make the labels for both encryption and signature buttons share a common format, in which both report the status if it is not one of those known. --- emacs/notmuch-crypto.el | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-crypto.el

[PATCH v1 3/3] Test: Fix tests.

--- .../notmuch-show-elide-non-matching-messages-off | 3 +++ .../notmuch-show-elide-non-matching-messages-on | 3 +++ .../emacs-show.expected-output/notmuch-show-indent-thread-content-off | 3 +++ .../notmuch-show-process-crypto-mime-parts-off

[PATCH v1 0/3] Always insert crypto buttons.

Always insert crypto buttons. This set of patches is in response to the discussion started in id:87silucnfx@maritornes.cs.unb.ca and specifically the comments from dkg in id:53cdeae8.3000...@fifthhorseman.net. David Edmondson (3): emacs: Improve crypto button labels. emacs: Always

Re: [Gaudenz Steinlin] Bug#810784: should match email adress case insensitive when sending encrypted mail

On Mon, Feb 08 2016, David Edmondson wrote: > On Mon, Feb 08 2016, David Edmondson wrote: >> On Fri, Jan 15 2016, Daniel Kahn Gillmor wrote: >>> So where is the case-insensitive lookup happening? Is this a bug in >>> mml-mode, or in notmuch-emacs? >> >> It's caused by behaviour in mml2015.el

[PATCH v4] add util/search-path.{c, h} to test for executables in $PATH

This is a utility function we can use to see whether an executable is available. --- util/Makefile.local | 2 +- util/search-path.c | 50 ++ util/search-path.h | 24 3 files changed, 75 insertions(+), 1 deletion(-)

Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'

On Tue, 09 Feb 2016, David Edmondson wrote: > On Sat, Jun 13 2015, Mark Walters wrote: >> Change the key binding for filter (or "limit") in search-mode. This >> gives consistency with the new filter in show-mode, and frees 'f' for >> forward-thread in the future. > > Is there a

Re: [PATCH v4 6/7] emacs/mua: Let user specify which parts get a header in citations.

On Tue, 09 Feb 2016, David Edmondson wrote: > On Sat, Nov 07 2015, Mark Walters wrote: >> From: David Edmondson >> >> Add a customizable function specifying which parts get a header when >> replying, and give some sensible possiblities. These are, >> >> 1) all parts

Re: [PATCH v2 (rebased) 0/3] Improve the display of matching/non-matching authors.

On Mon, Dec 14 2015, Mark Walters wrote: > This is just a rebased (to current master) version of > id:1414172643-28270-1-git-send-email-...@dme.org (git did the rebase by > itself using a three-way merge) > > I will send some review comments as replies to this thread. I didn't see any, but in

Re: [PATCH v3 15/16] added notmuch_message_reindex

On Tue 2016-02-09 19:41:01 -0500, Jameson Graef Rollins wrote: > On Sun, Jan 31 2016, Daniel Kahn Gillmor wrote: >> This new function asks the database to reindex a given message, using >> the supplied indexopts. >> >> This can be used, for example, to index the cleartext

Re: [PATCH v3 15/16] added notmuch_message_reindex

On Sun, Jan 31 2016, Daniel Kahn Gillmor wrote: > This new function asks the database to reindex a given message, using > the supplied indexopts. > > This can be used, for example, to index the cleartext of an encrypted > message. I just wanted to mention that I think

Re: [PATCH v3 02/16] Move crypto.c into libutil

Daniel Kahn Gillmor writes: > This prepares us for using the crypto object in both the library and > the client. > > i've prefixed notmuch_crypto with _ to indicate that while this can be > built into the library when needed, it's not something to be exported > or used

Re: [PATCH v3 03/16] make shared crypto code behave library-like

Daniel Kahn Gillmor writes: > -static GMimeCryptoContext* > -create_gpg_context (_notmuch_crypto_t *crypto) > +static notmuch_status_t > +get_gpg_context (_notmuch_crypto_t *crypto, GMimeCryptoContext **ctx) I was a littled puzzled by this renaming. I guess it's fine, it