Re: Elisp error with recent master-branch Emacs

2021-12-04 Thread David Bremner
Joseph Mingrone writes: > Hello, > > When building the FreeBSD OS package for notmuch-emacs, we have begun to > see build errors recently that report > > (error "Unknown button type `help-function'"). > >

[PATCH 2/2] doc: introduce stamp file for info build

2021-12-04 Thread David Bremner
This partially fixes (i.e. just for sphinx) the problem reported by Daniel in id:87r29wwgq2@fifthhorseman.net. --- doc/Makefile.local | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index 1782c784..c2ae1743 100644 ---

[PATCH 1/2] doc: replace phony target with variable

2021-12-04 Thread David Bremner
Depending on a phony target seems like a good way to always trigger a recipe. --- doc/Makefile.local | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/Makefile.local b/doc/Makefile.local index 730ad4fb..1782c784 100644 --- a/doc/Makefile.local +++

Re: Add stamp files to prevent rebuilds

2021-12-04 Thread David Bremner
David Bremner writes: > There are several places where the current Makefiles either have a > dependency on a phony target, or on a directory. Both of these lead to > constant rebuilds. > > Stamp files are not the most elegant solution, but it seems to prevent > the rebuilds. I applied patches 2

Elisp error with recent master-branch Emacs

2021-12-04 Thread Joseph Mingrone
Hello, When building the FreeBSD OS package for notmuch-emacs, we have begun to see build errors recently that report (error "Unknown button type `help-function'"). http://pkg.ftfl.ca/data/12amd64-default/2021-12-04_12h41m25s/logs/errors/notmuch-emacs_devel-0.34.1_1.log This seems to

Re: Forwarding inline html mails

2021-12-04 Thread David Bremner
"inwit" writes: > On Sat Dec 4, 2021 at 4:42 PM CET, David Bremner wrote: > >> One option would be to use bounce (bound to b) instead of forward, if that >> works for you. It will not change the 'From:' header , so that might confuse >> some recipients. > Thanks, David. Unfortunately, that won't

Re: notmuch insert: Cannot open Xapian database (0.34.1)

2021-12-04 Thread David Bremner
"Peter J. Jones" writes: > I can see in `notmuch.c` that the insert command doesn't have the > `NOTMUCH_COMMAND_DATABASE_CREATE` bit set, so this is the expected > behavior in 0.34 and was probably a bug in 0.31. However, I would argue > that it's useful to create the database in this

[PATCH] doc: drop use of env with sphinx-build

2021-12-04 Thread David Bremner
NOTMUCH_BUILDDIR is not defined in make, only in test scripts, so this cannot be doing any good. Without the notmuch2 python module installed, it the docs still build, so removing the use of env seems to do no harm. This is a partial revert of 2739549c --- doc/Makefile.local | 2 +- 1 file

Re: [PATCH] emacs: don't add space to tag completion candidates.

2021-12-04 Thread David Bremner
David Bremner writes: > Apparently this messes up various third party completion > frameworks. This change does mean that users will have to hit space > after completing a tag change in order to enter another change. > > As a bonus, remove the call to #'delete, since > completing-read-multiple

Re: [PATCH v2 1/3] test: move system includes to notmuch-test.h

2021-12-04 Thread David Bremner
David Bremner writes: > This removes some redudant includes, and will also make it easier to > introduce "#define _GNU_SOURCE", which must come before all system > includes. series applied to master d ___ notmuch mailing list --

Re: [PATCH 1/2] test: known broken tests for leading/trailing ws in config

2021-12-04 Thread David Bremner
David Bremner writes: > These tests duplicate the bug/misfeature reported in > > id:ca+tk8fzjplaed3vl1f9ebk_bf_rv8pdtlzdupratkclcpja...@mail.gmail.com This series, and the next one in the same thread, applied to master. d ___ notmuch mailing

Re: [PATCH] emacs: run notmuch-search-hook lazily

2021-12-04 Thread David Bremner
David Bremner writes: > In message id:YT3ueuZHKW931NW3@localhost, Fabio Natali isolated a > visual glitch caused by running notmuch-search-hook too early. This > change moves the running of that hook to > notmuch-search-process-filter, which ensures there is some output in > the buffer before

Re: Forwarding inline html mails

2021-12-04 Thread inwit
On Sat Dec 4, 2021 at 4:42 PM CET, David Bremner wrote: > One option would be to use bounce (bound to b) instead of forward, if that > works for you. It will not change the 'From:' header , so that might confuse > some recipients. Thanks, David. Unfortunately, that won't do. There must be a way

Re: macOS globals.py issue

2021-12-04 Thread David Bremner
Dominyk Tiller writes: > Hi there, > > I believe there's potentially a bug in the handling of signposting the > notmuch dynamic library when installed in non-standard prefixes. For > example, Homebrew moved their standard prefix on macOS from /usr/local > to /opt/homebrew for machines running

Re: [PATCH] cli: handle bash completion of all shared options

2021-12-04 Thread David Bremner
Tobias Backer Dirks writes: > A slight rework of base bash completion to handle all shared options. > This simplifies the handling of base commands and adds creature comforts > such as directory completion for --config, and removing trailing spaces > from options ending in an `=`. Also fixes a

Re: Forwarding inline html mails

2021-12-04 Thread David Bremner
"inwit" writes: > I usually receive mails in html (sigh), and sometimes I need to forward them. > However, when doing so with notmuch-emacs, the recipient of the forwarded > message sees the html code instead of a readable message. I know I can > forward the message as an attachment, but is

Forwarding inline html mails

2021-12-04 Thread inwit
I usually receive mails in html (sigh), and sometimes I need to forward them. However, when doing so with notmuch-emacs, the recipient of the forwarded message sees the html code instead of a readable message. I know I can forward the message as an attachment, but is there a way to forward it

planned point release 0.34.2

2021-12-04 Thread David Bremner
I have applied a few bug fixes related to configuration and python bindings to the release branch. Please let me know if there are any showstopper problems, I will update NEWS and make a point release in the next few days. Those changes are also in the master branch, along with some possibly

Re: [PATCH 1/3] test: add known broken test for conflict with database parameter

2021-12-04 Thread David Bremner
David Bremner writes: > This is arguably user error: having configuration file with bad > settings in it (and/or having a bad NOTMUCH_CONFIG environment > variable). On the other hand returning a different path than was > actually opened is definitely a bug. Series applied to release and

Re: [PATCH] doc/python-cffi: import from built bindings, not installed module

2021-12-04 Thread David Bremner
David Bremner writes: > Previously the python-cffi bindings either failed to build, or built > for the wrong module by using the installed module. applied to release and master ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an

Re: [PATCH 1/4] python-cffi: fix typos in docstring for Database.default_path

2021-12-04 Thread David Bremner
David Bremner writes: > These generate warnings from sphinx doc, which makes it harder to > debug documentation changes. They also corrupt the output. Series applied to release and master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To