Re: [PROTO] possible solution for "Race condition for '*' command"

2011-07-04 Thread Pieter Praet
er the matched messages or the entire thread (for which the `thread-id' property is already present). Can't think of a use case for non-matched messages right now, but if required, we'll just use `set-exclusive-or'. > -- > Sent from my Android. Please excuse my brevity.

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 04 Jul 2011 13:08:43 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line')

[PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
t; The extra space is also added to expected results of emacs tests. > --- > > Amended version with a better commit message. Stolen from a similar > patch by Kan-Ru Chen [1] as suggested by Pieter Praet :) Muhahaaa! > Regards, > Dmitry > > [1] id:&quo

[PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

2011-07-04 Thread Pieter Praet
_______ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Signed-off-by: Pieter Praet Though it's worth noting that (as a previous test of yours [1] demonstrates), it doesn't work consistently when the previous message has a text/html part: complains with "No URL at point". Peace -- Pieter [1] id:"1309752441-10651-4-git-send-email-dmitry.kurochkin at gmail.com"

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
> Besides, nobody commented on it except a noob like myself. > > Just by keeping half an eye on all that gets merged, imagining what > a maintainer's job must be like sends shivers down my spine. ^ The following was sent in true top-posting style, for your personal bewilderment. Please stand o

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 04 Jul 2011 11:37:06 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line')

[PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin wrote: > It is very convenient when C-e (bound to `widget-end-of-line') ignores > trailing spaces inside the search widget. But it only does so if a > widget is not followed by a newline (that is why it works in the saved > search widgets). Th

[PATCH 5/5] emacs: make `notmuch-search-operate-all' use matched-msgids instead of the original query string

2011-07-04 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 46e276a..0d040a2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -869,7 +869,10 @@ Each character of the tag name may

[PATCH 4/5] test: emacs: add/remove tags from all matching messages with `notmuch-search-operate-all'

2011-07-04 Thread Pieter Praet
Signed-off-by: Pieter Praet --- test/emacs-search-operate-all | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100755 test/emacs-search-operate-all diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all new file mode 100755

[PATCH 3/5] emacs: stashing (a region of) matched-msgids

2011-07-04 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 2338044..46e276a 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -226,6 +226,7 @@ For a mouse binding, return

[PATCH 2/5] emacs: add some functions to fetch the matched-msgids of a (region of) search result(s)

2011-07-04 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 674deb7..2338044 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -402,6 +402,14 @@ Complete list of currently

[PATCH 1/5] emacs: add property "matched-msgids" to each search result

2011-07-04 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..674deb7 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -801,13 +801,14 @@ non-authors is found, assume that all

[PROTO] possible solution for "Race condition for '*' command"

2011-07-04 Thread Pieter Praet
Thanks Austin! Unfortunately, your patch causes *all* Message-Id's in the thread to be appended, as opposed to only the ones matching the query: #+BEGIN_EXAMPLE $ notmuch search tag:inbox AND from:amdragon at mit.edu thread:2777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet; [

Re: notmuch 0.6: notmuch new dies with std::terminate

2011-07-04 Thread Pieter Praet
On Mon, 04 Jul 2011 09:20:25 -0300, David Bremner wrote: > On Mon, 04 Jul 2011 11:58:24 +0100, Robin Green wrote: > > Some time after upgrading to notmuch 0.6, notmuch new suddenly started > > failing, with this backtrace: (this is on DragonFly BSD) > > > > Program terminated with signal 6, Abor

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 04 Jul 2011 13:08:43 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin > > wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line') ignores

Re: [PATCH v2] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
t; The extra space is also added to expected results of emacs tests. > --- > > Amended version with a better commit message. Stolen from a similar > patch by Kan-Ru Chen [1] as suggested by Pieter Praet :) Muhahaaa! > Regards, > Dmitry > > [1] id:&

Re: [PATCH 2/2] emacs: skip forward to visible text in notmuch-show-message-extent

2011-07-04 Thread Pieter Praet
_______ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch Signed-off-by: Pieter Praet Though it's worth noting that (as a previous test of yours [1] demonstrates), it doesn't work con

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
> Besides, nobody commented on it except a noob like myself. > > Just by keeping half an eye on all that gets merged, imagining what > a maintainer's job must be like sends shivers down my spine. ^ The following was sent in true top-posting style, for your personal bewilderment. Please stand o

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 04 Jul 2011 11:37:06 +0400, Dmitry Kurochkin wrote: > On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote: > > On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin > > wrote: > > > It is very convenient when C-e (bound to `widget-end-of-line') ignores

Re: [PATCH] emacs: add insisible space after the search widget field in notmuch-hello

2011-07-04 Thread Pieter Praet
On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin wrote: > It is very convenient when C-e (bound to `widget-end-of-line') ignores > trailing spaces inside the search widget. But it only does so if a > widget is not followed by a newline (that is why it works in the saved > search widgets). T

[PATCH 5/5] emacs: make `notmuch-search-operate-all' use matched-msgids instead of the original query string

2011-07-03 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 46e276a..0d040a2 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -869,7 +869,10 @@ Each character of the tag name may

[PATCH 4/5] test: emacs: add/remove tags from all matching messages with `notmuch-search-operate-all'

2011-07-03 Thread Pieter Praet
Signed-off-by: Pieter Praet --- test/emacs-search-operate-all | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) create mode 100755 test/emacs-search-operate-all diff --git a/test/emacs-search-operate-all b/test/emacs-search-operate-all new file mode 100755

[PATCH 3/5] emacs: stashing (a region of) matched-msgids

2011-07-03 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 2338044..46e276a 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -226,6 +226,7 @@ For a mouse binding, return

[PATCH 2/5] emacs: add some functions to fetch the matched-msgids of a (region of) search result(s)

2011-07-03 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 674deb7..2338044 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -402,6 +402,14 @@ Complete list of currently

[PATCH 1/5] emacs: add property "matched-msgids" to each search result

2011-07-03 Thread Pieter Praet
Signed-off-by: Pieter Praet --- emacs/notmuch.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..674deb7 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -801,13 +801,14 @@ non-authors is found, assume that all

[PROTO] possible solution for "Race condition for '*' command"

2011-07-03 Thread Pieter Praet
Thanks Austin! Unfortunately, your patch causes *all* Message-Id's in the thread to be appended, as opposed to only the ones matching the query: #+BEGIN_EXAMPLE $ notmuch search tag:inbox AND from:amdra...@mit.edu thread:2777 Yest. 19:17 [1/3] Austin Clements| Pieter Praet; [PA

Possible bug: wrong from address when forwarding

2011-07-02 Thread Pieter Praet
--- Either enable `notmuch-always-prompt-for-sender', or apply this quick-fix patch, which uses `name' and `primary_email' as configured in your .notmuch-config if aforementioned isn't enabled. emacs/notmuch-mua.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs

problem with message/rfc822 parts

2011-07-02 Thread Pieter Praet
On Sat, 02 Jul 2011 02:23:34 +0100, Andreas Amann wrote: > > It's a known problem. As a short term fix, try the patches of > > > > id:"1307320169-29905-1-git-send-email-jrollins at finestructure.net" > > Or use `notmuch-show-view-raw-message' (bound to 'V'). > thanks a lot David. I can confi

[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-07-02 Thread Pieter Praet
On Fri, 1 Jul 2011 12:37:11 -0400, Austin Clements wrote: Non-text part: multipart/alternative > On Jul 1, 2011 10:55 AM, "Austin Clements" wrote: > > > > On Thu, Jun 30, 2011 at 3:38 PM, Pieter Praet wrote: > > > Ok, even though my very first reply [

Re: Possible bug: wrong from address when forwarding

2011-07-02 Thread Pieter Praet
--- Either enable `notmuch-always-prompt-for-sender', or apply this quick-fix patch, which uses `name' and `primary_email' as configured in your .notmuch-config if aforementioned isn't enabled. emacs/notmuch-mua.el |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/emacs

Re: problem with message/rfc822 parts

2011-07-02 Thread Pieter Praet
On Sat, 02 Jul 2011 02:23:34 +0100, Andreas Amann wrote: > > It's a known problem. As a short term fix, try the patches of > > > > id:"1307320169-29905-1-git-send-email-jroll...@finestructure.net" > > Or use `notmuch-show-view-raw-message' (bound to 'V'). > thanks a lot David. I can confirm

Re: [PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-07-02 Thread Pieter Praet
On Fri, 1 Jul 2011 12:37:11 -0400, Austin Clements wrote: Non-text part: multipart/alternative > On Jul 1, 2011 10:55 AM, "Austin Clements" wrote: > > > > On Thu, Jun 30, 2011 at 3:38 PM, Pieter Praet wrote: > > > Ok, even though my very first reply [

Preventing the user shooting themself in the foot

2011-07-01 Thread Pieter Praet
On Fri, 1 Jul 2011 11:28:10 +1000, Brian May wrote: > On 30 June 2011 17:50, Pieter Praet wrote: > > And AFAIK, "Archive" does *not* mark a message as read in GMail. > > (see previous messages suggesting the inverse) > > gmail will mark all messages in the thr

Preventing the user shooting themself in the foot

2011-07-01 Thread Pieter Praet
On Fri, 01 Jul 2011 09:26:48 +1200, Michael Hudson-Doyle wrote: > On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth wrote: > Non-text part: multipart/mixed > Non-text part: multipart/signed > > not sure why notmuch reply is putting that there :) > > > The lack of a "move to next thread" binding he

Re: Preventing the user shooting themself in the foot

2011-07-01 Thread Pieter Praet
On Fri, 1 Jul 2011 11:28:10 +1000, Brian May wrote: > On 30 June 2011 17:50, Pieter Praet wrote: > > And AFAIK, "Archive" does *not* mark a message as read in GMail. > > (see previous messages suggesting the inverse) > > gmail will mark all messages in the thr

Re: Preventing the user shooting themself in the foot

2011-07-01 Thread Pieter Praet
On Fri, 01 Jul 2011 09:26:48 +1200, Michael Hudson-Doyle wrote: > On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth wrote: > Non-text part: multipart/mixed > Non-text part: multipart/signed > > not sure why notmuch reply is putting that there :) > > > The lack of a "move to next thread" binding h

[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-07-01 Thread Pieter Praet
instead of the latter itself. See discussion @ id:"86d3i1d06r@dragonfly.greenrd.org" Signed-off-by: Pieter Praet --- Carl, I've gone along a different route which assures only matched messages are touched, but it does come with quite a performance hit. Since there is

Re: [PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-07-01 Thread Pieter Praet
On Thu, 30 Jun 2011 18:08:28 +0200, Pieter Praet wrote: > `notmuch-search-operate-all' may cause a race condition because > repeatedly running `notmuch-tag' with the *original* query string > makes the result list a moving target. > > One approach to resolving this, i

Re: [PATCH] remove prefixes from `--output={threads, messages}' results

2011-07-01 Thread Pieter Praet
On Thu, 30 Jun 2011 09:24:12 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Thu, 30 Jun 2011 10:19:49 +0200, Pieter Praet wrote: > > Alter `do_search_threads()' and `do_search_messages()' > > to not prepend each result with `thread:' respectively `id:

[PATCH 1/2] test: add/remove tags from all matching messages with `notmuch-search-operate-all'

2011-07-01 Thread Pieter Praet
This test is meant solely to make sure my next patch doesn't break anything (in an obvious way, at least). In other words: it does *not* demonstrate a race condition issue. Signed-off-by: Pieter Praet --- Robin, Could you provide a test to expose the actual race condition? Or at the

[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-06-30 Thread Pieter Praet
On Thu, 30 Jun 2011 18:08:28 +0200, Pieter Praet wrote: > `notmuch-search-operate-all' may cause a race condition because > repeatedly running `notmuch-tag' with the *original* query string > makes the result list a moving target. > > One approach to resolving this, i

[PATCH] remove prefixes from `--output={threads, messages}' results

2011-06-30 Thread Pieter Praet
On Thu, 30 Jun 2011 09:24:12 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Thu, 30 Jun 2011 10:19:49 +0200, Pieter Praet wrote: > > Alter `do_search_threads()' and `do_search_messages()' > > to not prepend each result with `thread:' respectively `id:

[PATCH 2/2] [RFC] possible solution for "Race condition for '*' command"

2011-06-30 Thread Pieter Praet
instead of the latter itself. See discussion @ id:"86d3i1d06r.fsf at dragonfly.greenrd.org" Signed-off-by: Pieter Praet --- Carl, I've gone along a different route which assures only matched messages are touched, but it does come with quite a performance hit. Since there is

[PATCH 1/2] test: add/remove tags from all matching messages with `notmuch-search-operate-all'

2011-06-30 Thread Pieter Praet
This test is meant solely to make sure my next patch doesn't break anything (in an obvious way, at least). In other words: it does *not* demonstrate a race condition issue. Signed-off-by: Pieter Praet --- Robin, Could you provide a test to expose the actual race condition? Or at the

Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Thu, 30 Jun 2011 09:50:27 +0200, Pieter Praet wrote: > [...] > And AFAIK, "Archive" does *not* mark a message as read in GMail. > (see previous messages suggesting the inverse [...] ... be implemented in Notmuch. > [...] ) Nobody claimed the inverse was the case in G

[PATCH] fix breakage in `notmuch-select-tag-with-completion' due to `tag:' prefix

2011-06-30 Thread Pieter Praet
send-email-pieter at praet.org" Signed-off-by: Pieter Praet --- emacs/notmuch.el |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..af66510 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -77,7 +77,11 @@ Fo

[PATCH] fix breakage in `notmuch-hello-generate-tag-alist' due to `tag:' prefix

2011-06-30 Thread Pieter Praet
send-email-pieter at praet.org" Signed-off-by: Pieter Praet --- emacs/notmuch-hello.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 65fde75..4551be1 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-

[PATCH] test: stashing in notmuch-{show,search}

2011-06-30 Thread Pieter Praet
Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet --- test/emacs| 41 + test/emacs.expected-output/emacs-stashing |9 ++ 2 files changed, 50 insertions(+), 0 deletions(-) create mode

[PATCH] emacs: add keybind and function to stash Message-ID without prefix

2011-06-30 Thread Pieter Praet
t'ing in 9 places instead of 1. Signed-off-by: Pieter Praet --- emacs/notmuch-show.el |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 6685717..a703732 100644 --- a/emacs/notmuch-show.el +++ b/emacs/no

[PATCH] add `tag:' prefix to `--output=tags' results

2011-06-30 Thread Pieter Praet
Alter `do_search_tags()' to prepend each result with `tag:', and update affected test. This makes its output consistent with `do_search_threads()' and `do_search_messages()'. See this discussion: id:"871v6b79s0.fsf at yoom.home.cworth.org" Signed-off-by: Piete

[PATCH] remove prefixes from `--output={threads,messages}' results

2011-06-30 Thread Pieter Praet
ean. Time isn't the issue (sed flies through it faster than Windoze can BSOD), but the patch will be so huge and disruptive that even Ubuntu devs might consider frowning disapprovingly. ######## Signed-off-by: Pieter Praet ---

[PATCH 4/4] emacs: Add pseudo tag to match all messages that have no tags

2011-06-30 Thread Pieter Praet
On Tue, 28 Jun 2011 07:31:32 +, Jani Nikula wrote: > Add a pseudo tag that matches all the messages that have no tags. Add new > customization option notmuch-tags-nomatch to enable and name the pseudo > tag. > --- > emacs/notmuch-hello.el | 18 -- > 1 files changed, 16 inser

Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 19:53:03 -0400, Austin Clements wrote: Non-text part: multipart/mixed Non-text part: multipart/alternative > I've spent embarrassingly little time in the emacs UI, so my opinions on > this should be taken lightly, but I feel like all of the bindings are of the > form "if W, do

Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Thu, 30 Jun 2011 13:04:23 +1000, Brian May microcomaustralia.com.au> wrote: > > On 30 June 2011 08:40, Carl Worth wrote: > > > The 'a' keybinding, (in turn), was designed for

notmuch Digest, Vol 20, Issue 57

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 16:19:44 -0600, Mark Anderson wrote: > On Wed, 29 Jun 2011 13:54:40 -0700, Jameson Graef Rollins finestructure.net> wrote: > > On Wed, 29 Jun 2011 14:21:11 -0600, Mark Anderson > > wrote: > > > I personally prefer --output=files remain as it was, with one file per > > > mail

Re: Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Thu, 30 Jun 2011 09:50:27 +0200, Pieter Praet wrote: > [...] > And AFAIK, "Archive" does *not* mark a message as read in GMail. > (see previous messages suggesting the inverse [...] ... be implemented in Notmuch. > [...] ) Nobody claimed the inverse was the case in G

[PATCH] fix breakage in `notmuch-select-tag-with-completion' due to `tag:' prefix

2011-06-30 Thread Pieter Praet
1-git-send-email-pie...@praet.org" Signed-off-by: Pieter Praet --- emacs/notmuch.el |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index f11ec24..af66510 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -77,7 +77,11 @@ Fo

[PATCH] fix breakage in `notmuch-hello-generate-tag-alist' due to `tag:' prefix

2011-06-30 Thread Pieter Praet
1-git-send-email-pie...@praet.org" Signed-off-by: Pieter Praet --- emacs/notmuch-hello.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 65fde75..4551be1 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-

[PATCH] test: stashing in notmuch-{show,search}

2011-06-30 Thread Pieter Praet
Should provide full test coverage of the stashing feature. Signed-off-by: Pieter Praet --- test/emacs| 41 + test/emacs.expected-output/emacs-stashing |9 ++ 2 files changed, 50 insertions(+), 0 deletions(-) create mode

[PATCH] emacs: add keybind and function to stash Message-ID without prefix

2011-06-30 Thread Pieter Praet
t'ing in 9 places instead of 1. Signed-off-by: Pieter Praet --- emacs/notmuch-show.el |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index 6685717..a703732 100644 --- a/emacs/notmuch-show.el +++ b/emacs/no

[PATCH] add `tag:' prefix to `--output=tags' results

2011-06-30 Thread Pieter Praet
Alter `do_search_tags()' to prepend each result with `tag:', and update affected test. This makes its output consistent with `do_search_threads()' and `do_search_messages()'. See this discussion: id:"871v6b79s0@yoom.home.cworth.org" Signed-off-by: Piete

[PATCH] remove prefixes from `--output={threads,messages}' results

2011-06-30 Thread Pieter Praet
. Time isn't the issue (sed flies through it faster than Windoze can BSOD), but the patch will be so huge and disruptive that even Ubuntu devs might consider frowning disapprovingly. ######## Signed-off-by: Pieter Praet ---

Re: [PATCH 4/4] emacs: Add pseudo tag to match all messages that have no tags

2011-06-30 Thread Pieter Praet
On Tue, 28 Jun 2011 07:31:32 +, Jani Nikula wrote: > Add a pseudo tag that matches all the messages that have no tags. Add new > customization option notmuch-tags-nomatch to enable and name the pseudo > tag. > --- > emacs/notmuch-hello.el | 18 -- > 1 files changed, 16 inser

Re: Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 19:53:03 -0400, Austin Clements wrote: Non-text part: multipart/mixed Non-text part: multipart/alternative > I've spent embarrassingly little time in the emacs UI, so my opinions on > this should be taken lightly, but I feel like all of the bindings are of the > form "if W, do

Re: Preventing the user shooting themself in the foot

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 22:40:07 -0700, Carl Worth wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Thu, 30 Jun 2011 13:04:23 +1000, Brian May > wrote: > > On 30 June 2011 08:40, Carl Worth wrote: > > > The 'a' keybinding, (in turn), was designed for cases when you *know*

Re: notmuch Digest, Vol 20, Issue 57

2011-06-30 Thread Pieter Praet
On Wed, 29 Jun 2011 16:19:44 -0600, Mark Anderson wrote: > On Wed, 29 Jun 2011 13:54:40 -0700, Jameson Graef Rollins > wrote: > > On Wed, 29 Jun 2011 14:21:11 -0600, Mark Anderson > > wrote: > > > I personally prefer --output=files remain as it was, with one file per > > > mail (even though I

[PATCH] test: revert non-intentional changes introduced in eb4cf465

2011-06-29 Thread Pieter Praet
Signed-off-by: Pieter Praet --- test/emacs |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/emacs b/test/emacs index e59de47..53f455a 100755 --- a/test/emacs +++ b/test/emacs @@ -123,13 +123,13 @@ test_emacs '(notmuch-search "id:\"123..456 at example\&q

[PATCH v3] test:Improve test behaviors when --root is used

2011-06-29 Thread Pieter Praet
On Tue, 28 Jun 2011 16:03:00 -0700, Carl Worth wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Tue, 28 Jun 2011 16:11:32 -0600, Mark Anderson > wrote: > > Change add_email_corpus, emacs_deliver_message and tests to use > > $TEST_DIRECTORY instead of '..'. > ... > > Doc

[PATCH] test: revert non-intentional changes introduced in eb4cf465

2011-06-29 Thread Pieter Praet
. in Message-Id: PASS Message with .. in Message-Id: instead of: PASS Message with .. in Message-Id: PASS Sending a message via (fake) SMTP The second one is simply the insertion of a line break, so no harm there. This commit reverts both changes, as they were clearly accidental. Signed

Re: [PATCH v3] test:Improve test behaviors when --root is used

2011-06-29 Thread Pieter Praet
On Tue, 28 Jun 2011 16:03:00 -0700, Carl Worth wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Tue, 28 Jun 2011 16:11:32 -0600, Mark Anderson wrote: > > Change add_email_corpus, emacs_deliver_message and tests to use > > $TEST_DIRECTORY instead of '..'. > ... > > Docume

Notmuch scripts

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 21:31:26 -0400, Ben Gamari wrote: > [SNIP] It > would be nice, however, if the emacs interface supported hiding tags > matching certain patterns (say /\..+/). This should be possible as of last month (eb4e0ea2), by courtesy of Daniel Schoepe [1]. > > - Ben > >

Drafts being tagged as inbox

2011-06-28 Thread Pieter Praet
On Tue, 28 Jun 2011 08:00:53 +0100, Robin Green wrote: > On Tue, 28 Jun 2011 08:34:44 +0200, Pieter Praet wrote: > > notmuch tag -inbox +draft -- folder:${where_your_drafts_reside} > > My notmuch help does not mention "folder:", and indeed folder:drafts as a > search

[PATCH] fix sum moar typos

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 14:17:27 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Fri, 24 Jun 2011 22:04:13 +0200, Pieter Praet wrote: > > You however, seem to be incredibly disciplined in this respect, > > so statistically speaking, you're destined to become typo-ki

Race condition for '*' command

2011-06-28 Thread Pieter Praet
On Sun, 26 Jun 2011 10:00:41 +0100, Robin Green wrote: > On Sat, 25 Jun 2011 16:57:50 -0700, Jameson Graef Rollins finestructure.net> wrote: > > On Sat, 25 Jun 2011 23:18:52 +0100, Robin Green > > wrote: > > > A race condition in the '*' command was noted when it was first > > > proposed. It lo

[PATCH] test:Folder tags shouldn't match after removal of file in given folder

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 11:12:24 -0600, Mark Anderson wrote: > > Test for bug. Current stemming support for notmuch adds extra terms > to the DB which aren't removed when the file renames are detected. > > When folder tags are added to a message, Xapian terms for both XFOLDER > and ZXFOLDER are gen

Debian package not building

2011-06-28 Thread Pieter Praet
On Fri, 24 Jun 2011 16:34:02 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > Hey, folks. As of today I am for some reason no longer able to build > the Notmuch Debian package. I'm using the same build technique I have > been using for a while

[PATCH] test:Improve test behaviors when --root is used

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 16:50:47 -0400, Austin Clements wrote: > This looks great (modulo one bug, below). I've wanted to run the > tests on tmpfs before, but was too lazy to actually fix the tests. > > Given how easy it is to accidentally use "..", I wonder if there's a > way to force people to use

Drafts being tagged as inbox

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 22:50:25 +0100, Robin Green wrote: > My drafts (created using emacs message mode) are being tagged as > inbox. However, they are not tagged as drafts. This is because emacs > message mode does not store drafts in Maildir format, so there are no > Maildir flags (e.g. D for draft

Re: Notmuch scripts

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 21:31:26 -0400, Ben Gamari wrote: > [SNIP] It > would be nice, however, if the emacs interface supported hiding tags > matching certain patterns (say /\..+/). This should be possible as of last month (eb4e0ea2), by courtesy of Daniel Schoepe [1]. > > - Ben > > _

Re: Drafts being tagged as inbox

2011-06-28 Thread Pieter Praet
On Tue, 28 Jun 2011 08:00:53 +0100, Robin Green wrote: > On Tue, 28 Jun 2011 08:34:44 +0200, Pieter Praet wrote: > > notmuch tag -inbox +draft -- folder:${where_your_drafts_reside} > > My notmuch help does not mention "folder:", and indeed folder:drafts as a > search

Re: [PATCH] fix sum moar typos

2011-06-28 Thread Pieter Praet
On Mon, 27 Jun 2011 14:17:27 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Fri, 24 Jun 2011 22:04:13 +0200, Pieter Praet wrote: > > You however, seem to be incredibly disciplined in this respect, > > so statistically speaking, you're destined to become typo-ki

Re: Race condition for '*' command

2011-06-27 Thread Pieter Praet
On Sun, 26 Jun 2011 10:00:41 +0100, Robin Green wrote: > On Sat, 25 Jun 2011 16:57:50 -0700, Jameson Graef Rollins > wrote: > > On Sat, 25 Jun 2011 23:18:52 +0100, Robin Green wrote: > > > A race condition in the '*' command was noted when it was first > > > proposed. It looks to me like it sti

Re: [PATCH] test:Folder tags shouldn't match after removal of file in given folder

2011-06-27 Thread Pieter Praet
On Mon, 27 Jun 2011 11:12:24 -0600, Mark Anderson wrote: > > Test for bug. Current stemming support for notmuch adds extra terms > to the DB which aren't removed when the file renames are detected. > > When folder tags are added to a message, Xapian terms for both XFOLDER > and ZXFOLDER are gen

Re: Debian package not building

2011-06-27 Thread Pieter Praet
On Fri, 24 Jun 2011 16:34:02 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > Hey, folks. As of today I am for some reason no longer able to build > the Notmuch Debian package. I'm using the same build technique I have > been using for a while

Re: [PATCH] test:Improve test behaviors when --root is used

2011-06-27 Thread Pieter Praet
On Mon, 27 Jun 2011 16:50:47 -0400, Austin Clements wrote: > This looks great (modulo one bug, below). I've wanted to run the > tests on tmpfs before, but was too lazy to actually fix the tests. > > Given how easy it is to accidentally use "..", I wonder if there's a > way to force people to use

Re: Drafts being tagged as inbox

2011-06-27 Thread Pieter Praet
On Mon, 27 Jun 2011 22:50:25 +0100, Robin Green wrote: > My drafts (created using emacs message mode) are being tagged as > inbox. However, they are not tagged as drafts. This is because emacs > message mode does not store drafts in Maildir format, so there are no > Maildir flags (e.g. D for draft

[PATCH] test: remove useless test_emacs call from an emacs FCC test

2011-06-26 Thread Pieter Praet
On Thu, 23 Jun 2011 22:15:25 -0300, David Bremner wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > [...] I'm going > to skip the typo fixes for 0.6, unless convinced otherwise. Well, the whole point of my de-typo-ifying sprint was to make 0.6 a ~typo-free release, actually

Re: [PATCH] test: remove useless test_emacs call from an emacs FCC test

2011-06-26 Thread Pieter Praet
On Thu, 23 Jun 2011 22:15:25 -0300, David Bremner wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > [...] I'm going > to skip the typo fixes for 0.6, unless convinced otherwise. Well, the whole point of my de-typo-ifying sprint was to make 0.6 a ~typo-free release, actually

[PATCH] fix sum moar typos

2011-06-24 Thread Pieter Praet
On Thu, 23 Jun 2011 16:22:27 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Mon, 20 Jun 2011 22:14:21 +0200, Pieter Praet wrote: > > Various typo fixes in docs, docstrings, comments, etc... > > > > Signed-off-by: Pieter Praet > > Thanks for these

Re: [PATCH] fix sum moar typos

2011-06-24 Thread Pieter Praet
On Thu, 23 Jun 2011 16:22:27 -0700, Carl Worth wrote: Non-text part: multipart/signed > On Mon, 20 Jun 2011 22:14:21 +0200, Pieter Praet wrote: > > Various typo fixes in docs, docstrings, comments, etc... > > > > Signed-off-by: Pieter Praet > > Thanks for these

[PATCH] fix sum moar typos

2011-06-20 Thread Pieter Praet
Various typo fixes in docs, docstrings, comments, etc... Signed-off-by: Pieter Praet --- Rebased to current master (12d6f90e) NEWS | 10 +- TODO |4 ++-- compat/README|2 +- completion/Makefile |2

bug in emacs-ui ?

2011-06-20 Thread Pieter Praet
On Mon, 20 Jun 2011 12:53:37 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet > wrote: > > > You didn't try forwarding the email to the list ;) > > ah! that easy, heh ? > > > Attachment: > 1

bug in emacs-ui ?

2011-06-20 Thread Pieter Praet
On Mon, 20 Jun 2011 21:06:09 +0200, Sebastien Binet wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Mon, 20 Jun 2011 11:18:11 -0700, Jameson Graef Rollins finestructure.net> wrote: > Non-text part: multipart/signed > > On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Bine

[PATCH] fix sum moar typos

2011-06-20 Thread Pieter Praet
Various typo fixes in docs, docstrings, comments, etc... Signed-off-by: Pieter Praet --- Rebased to current master (12d6f90e) NEWS | 10 +- TODO |4 ++-- compat/README|2 +- completion/Makefile |2

Re: bug in emacs-ui ?

2011-06-20 Thread Pieter Praet
On Mon, 20 Jun 2011 12:53:37 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet > wrote: > > > You didn't try forwarding the email to the list ;) > > ah! that easy, heh ? > > > Attachment: >

Re: bug in emacs-ui ?

2011-06-20 Thread Pieter Praet
On Mon, 20 Jun 2011 21:06:09 +0200, Sebastien Binet wrote: Non-text part: multipart/mixed Non-text part: multipart/signed > On Mon, 20 Jun 2011 11:18:11 -0700, Jameson Graef Rollins > wrote: > Non-text part: multipart/signed > > On Mon, 20 Jun 2011 18:43:01 +0200, Sebastien Binet > > wrote: >

[PATCH] fix sum moar typos

2011-06-04 Thread Pieter Praet
Because they cause global warming. Signed-off-by: Pieter Praet --- TL;DR: Various typo fixes. Applies to jrollins/release-candidate/0.6 (2baf08f5) Due to the impending 0.6 release, I've gone off on an ephemeral typo hunt, and have brought back some trophies. As it's such an utter

[PATCH] fix sum moar typos

2011-06-04 Thread Pieter Praet
Because they cause global warming. Signed-off-by: Pieter Praet --- TL;DR: Various typo fixes. Applies to jrollins/release-candidate/0.6 (2baf08f5) Due to the impending 0.6 release, I've gone off on an ephemeral typo hunt, and have brought back some trophies. As it's such an utter

[PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs-large-search-buffer |9 +++-- 1 files

[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs | 43 --

<    2   3   4   5   6   7   8   >