[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-13 Thread Charles Celerier
As noted in the In-Reply-To header, this patch replaces id:1399402716-13714-1-git-send-email-cceleri at cs.stanford.edu. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 494 bytes Desc: not available URL:

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-13 Thread Charles Celerier
David Bremner writes: > David Bremner writes: > >> Originally I thought this was uneccesarily intrusive, but on a second >> look I see that there is only one symbol changed that doesn't start with >> _notmuch, so I guess for consistency it's fine. Actually, they all start with _notmuch. The sym

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-13 Thread Charles Celerier
As noted in the In-Reply-To header, this patch replaces id:1399402716-13714-1-git-send-email-ccel...@cs.stanford.edu. pgpOnVsuIV3Xa.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/n

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-13 Thread Charles Celerier
David Bremner writes: > David Bremner writes: > >> Originally I thought this was uneccesarily intrusive, but on a second >> look I see that there is only one symbol changed that doesn't start with >> _notmuch, so I guess for consistency it's fine. Actually, they all start with _notmuch. The sym

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-12 Thread David Bremner
David Bremner writes: > Charles Celerier writes: > >> An underscore should precede every function name in >> lib/notmuch-private.h. This was not true and was noted by the failure of >> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore >> before each function name in lib/notmu

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-12 Thread David Bremner
Charles Celerier writes: > An underscore should precede every function name in > lib/notmuch-private.h. This was not true and was noted by the failure of > test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore > before each function name in lib/notmuch-private.h where the undersco

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-12 Thread David Bremner
David Bremner writes: > Charles Celerier writes: > >> An underscore should precede every function name in >> lib/notmuch-private.h. This was not true and was noted by the failure of >> test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore >> before each function name in lib/notmu

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-12 Thread David Bremner
Charles Celerier writes: > An underscore should precede every function name in > lib/notmuch-private.h. This was not true and was noted by the failure of > test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore > before each function name in lib/notmuch-private.h where the undersco

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-08 Thread David Bremner
Charles Celerier writes: > An underscore should precede every function name in > lib/notmuch-private.h. Is this a reference to notmuch coding style document, or something else? > This was not true and was noted by the failure of test > T360-symbol-hiding on Mac OS/X. This patch inserts an unde

Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-08 Thread David Bremner
Charles Celerier writes: > An underscore should precede every function name in > lib/notmuch-private.h. Is this a reference to notmuch coding style document, or something else? > This was not true and was noted by the failure of test > T360-symbol-hiding on Mac OS/X. This patch inserts an und

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-06 Thread Charles Celerier
An underscore should precede every function name in lib/notmuch-private.h. This was not true and was noted by the failure of test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore before each function name in lib/notmuch-private.h where the underscore was missing and renames function

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-06 Thread Charles Celerier
An underscore should precede every function name in lib/notmuch-private.h. This was not true and was noted by the failure of test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore before each function name in lib/notmuch-private.h where the underscore was missing and renames function