Re: [PATCH] notmuch-mutt: check that the search cache Maildir is not a real Maildir WAS: Re: Data loss

2023-05-27 Thread Paul Wise
On Sat, 2023-05-27 at 21:10 -0300, David Bremner wrote: > If possible, please use git-send-email for future series. Will do, I forgot about the --cover-letter option. > This seems to have introduced a warning, and I think there's a bug. > > % notmuch mutt search tag:inbox > Argument "new"

Re: [PATCH] notmuch-mutt: check that the search cache Maildir is not a real Maildir WAS: Re: Data loss

2023-05-27 Thread David Bremner
Paul Wise writes: > I think a better option is to detect if the search cache Maildir is > actually a Maildir and doesn't contain any data that could be lost. > > I have attached three patches I created to improve notmuch-mutt safety. If possible, please use git-send-email for future series. >

[PATCH] notmuch-mutt: check that the search cache Maildir is not a real Maildir WAS: Re: Data loss

2023-05-23 Thread Paul Wise
2001 From: Paul Wise Date: Wed, 24 May 2023 06:22:01 +0800 Subject: [PATCH 3/3] notmuch-mutt: check that the search cache Maildir is not a real Maildir This prevents data loss when users configure the search cache Maildir to be a real Maildir containing their real mail data, since the search ca

Re: Data loss

2023-04-08 Thread David Bremner
Carl Worth writes: > > What it could also do is create some placeholder file like > .NOTMUCH-MUTT-OUTPUT-DIR when it writes its output. And then it could > check for that file's existence before removing a directory. > Sounds reasonable to me. Would someone like to make a patch for notmuch-mutt?

Re: Data loss

2023-04-04 Thread Carl Worth
On Tue, Apr 04 2023, Michael J. Gruber wrote: >> It's really unfortunate if notmuch-mutt makes it that easy to throw away >> your email. >> >> That sounds like a nasty bug that should be fixed in that program. > > To be fair to notmuch-mutt: > ``` > --output-dir DIR > > Store search results as

Re: Data loss

2023-04-04 Thread Michael J Gruber
Am Di., 4. Apr. 2023 um 00:54 Uhr schrieb Carl Worth : > > Ouch. > Yes, we're feeling with you, Fulvio :| > It's really unfortunate if notmuch-mutt makes it that easy to throw away > your email. > > That sounds like a nasty bug that should be fixed in that program. To be fair to notmuch-mutt:

Re: Data loss

2023-04-03 Thread Carl Worth
Ouch. It's really unfortunate if notmuch-mutt makes it that easy to throw away your email. That sounds like a nasty bug that should be fixed in that program. As for recovering, I suppose there _is_ a fair amount of detail in your notmuch index from all of the position-indexed terms, (as long as

Re: Data loss

2023-04-03 Thread Fulvio Pizzigoni
On Mon, Apr 03, 2023 at 08:39:02PM +0200, Michael J Gruber wrote: > Am Mo., 3. Apr. 2023 um 20:17 Uhr schrieb Fulvio Pizzigoni > : > > > > > > > > > > > > > > Hi Carl e thanks for your prompt answer. > > > > As you suggested, I add notmuch@notmuchmail.org email as well. > > > > This is what I did:

Re: Data loss

2023-04-03 Thread Fulvio Pizzigoni
On Mon, Apr 03, 2023 at 03:38:21PM -0300, David Bremner wrote: > Fulvio Pizzigoni writes: > > > > After this my .mutt directory (~ 4 GB di mail-boxess) appears so: > > fulvio@linux:~$ ll .mutt > > totale 12 > > drwxr-xr-x 2 fulvio fulvio 4096 18 feb 20.32 cur > > drwxr-xr-x 2 fulvio fulvio 4096

Re: Data loss

2023-04-03 Thread Michael J Gruber
Am Mo., 3. Apr. 2023 um 20:17 Uhr schrieb Fulvio Pizzigoni : > > > > > > > Hi Carl e thanks for your prompt answer. > > As you suggested, I add notmuch@notmuchmail.org email as well. > > This is what I did: > fulvio@linux:~$ notmuch setup > Your full name [fulvio]: > Your primary email address [my

Re: Data loss

2023-04-03 Thread David Bremner
Fulvio Pizzigoni writes: > > After this my .mutt directory (~ 4 GB di mail-boxess) appears so: > fulvio@linux:~$ ll .mutt > totale 12 > drwxr-xr-x 2 fulvio fulvio 4096 18 feb 20.32 cur > drwxr-xr-x 2 fulvio fulvio 4096 18 feb 20.32 new > drwxr-xr-x 2 fulvio fulvio 4096 18 feb 20.32 tmp Hi

Re: Data loss

2023-04-03 Thread Fulvio Pizzigoni
Hi Carl e thanks for your prompt answer. As you suggested, I add notmuch@notmuchmail.org email as well. This is what I did: fulvio@linux:~$ notmuch setup Your full name [fulvio]: Your primary email address [my address]: return Additional email address [Press 'Enter' if none]: return

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-04-13 Thread Carl Worth
..), please feel free to make plenty of noise when there are known fixes for data-loss bugs. We really shouldn't let those sit for a couple of weeks! -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 byte

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-04-13 Thread Carl Worth
with this project...), please feel free to make plenty of noise when there are known fixes for data-loss bugs. We really shouldn't let those sit for a couple of weeks! -Carl pgpv1jX4K9zi0.pgp Description: PGP signature ___ notmuch mailing list notmuch

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-30 Thread Michal Sojka
When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were not removed. It happened at least once to me. Signed-off-by: Michal Sojka --- notmuch-new.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-30 Thread Michal Sojka
On Mon, 29 Mar 2010, spaetz wrote: > > hehe, this version compiles but has the logic inverted. Removing the ! from > your patch makes it actually work as intended :--). Right! I should definitely be more careful even for such a trivial patches :) It's interesting, that in my branch, I have no

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-30 Thread Michal Sojka
On Mon, 29 Mar 2010, spaetz wrote: hehe, this version compiles but has the logic inverted. Removing the ! from your patch makes it actually work as intended :--). Right! I should definitely be more careful even for such a trivial patches :) It's interesting, that in my branch, I have no

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-30 Thread Michal Sojka
When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were not removed. It happened at least once to me. Signed-off-by: Michal Sojka sojk...@fel.cvut.cz --- notmuch-new.c |3 +++ 1 files changed, 3 insertions(+), 0

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-29 Thread spaetz
hehe, this version compiles but has the logic inverted. Removing the ! from your patch makes it actually work as intended :--). -- View this message in context: http://n3.nabble.com/PATCH-Prevent-data-loss-caused-by-SIGINT-during-notmuch-new-tp677501p684691.html Sent from the notmuch mailing

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-29 Thread Sebastian Spaeth
> Oh, sorry. I thought it is so trivial, that I didn't even compile it for > master. The right version is here: Thanks, that worked fine now. I pushed it to my branch. Sebastian

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-29 Thread Sebastian Spaeth
Oh, sorry. I thought it is so trivial, that I didn't even compile it for master. The right version is here: Thanks, that worked fine now. I pushed it to my branch. Sebastian ___ notmuch mailing list notmuch@notmuchmail.org

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-29 Thread spaetz
hehe, this version compiles but has the logic inverted. Removing the ! from your patch makes it actually work as intended :--). -- View this message in context: http://n3.nabble.com/PATCH-Prevent-data-loss-caused-by-SIGINT-during-notmuch-new-tp677501p684691.html Sent from the notmuch mailing

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-28 Thread Michal Sojka
->8--- >From 117de1fcc316a4792244a36b68e38215ff2a5bdc Mon Sep 17 00:00:00 2001 From: Michal Sojka <sojk...@fel.cvut.cz> Date: Fri, 26 Mar 2010 22:16:26 +0100 Subject: [PATCH v2] Prevent data loss caused by SIGINT during notmuch new When Ctrl-C is pressed in a wrong tim

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-28 Thread Sebastian Spaeth
On Sun, 28 Mar 2010 00:37:00 +0100, "Sebastian Spaeth" wrote: > On Fri, 26 Mar 2010 22:18:13 +0100, Michal Sojka > wrote: > > When Ctrl-C is pressed in a wrong time during notmuch new, it can lead > > to removal of messages from the database even if the files were not > > removed. CC -O2

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-28 Thread Sebastian Spaeth
On Fri, 26 Mar 2010 22:18:13 +0100, Michal Sojka wrote: > When Ctrl-C is pressed in a wrong time during notmuch new, it can lead > to removal of messages from the database even if the files were not > removed. Thanks, applied in my feature-all branch. Sebastian

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-27 Thread Sebastian Spaeth
On Fri, 26 Mar 2010 22:18:13 +0100, Michal Sojka sojk...@fel.cvut.cz wrote: When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were not removed. Thanks, applied in my feature-all branch. Sebastian

Re: [notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-27 Thread Michal Sojka
2001 From: Michal Sojka sojk...@fel.cvut.cz Date: Fri, 26 Mar 2010 22:16:26 +0100 Subject: [PATCH v2] Prevent data loss caused by SIGINT during notmuch new When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-26 Thread Michal Sojka
When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were not removed. It happened at least once to me. Signed-off-by: Michal Sojka --- notmuch-new.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff

[notmuch] [PATCH] Prevent data loss caused by SIGINT during notmuch new

2010-03-26 Thread Michal Sojka
When Ctrl-C is pressed in a wrong time during notmuch new, it can lead to removal of messages from the database even if the files were not removed. It happened at least once to me. Signed-off-by: Michal Sojka sojk...@fel.cvut.cz --- notmuch-new.c |3 +++ 1 files changed, 3 insertions(+), 0