Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On Tue, 06 Sep 2011 15:51:42 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Everyone that I know of who has tried to reproduce this bug has been able to. I vote that we include this patch in 0.8, so that we can get it out of the way. I have pushed this to master. Sorry, I still don't plan to include it in 0.8. I think it is better to have a short strict freeze, than a long friendly one. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On Wed, 07 Sep 2011 18:46:10 -0300, David Bremner da...@tethera.net wrote: I have pushed this to master. Sorry, I still don't plan to include it in 0.8. I think it is better to have a short strict freeze, than a long friendly one. Ok, thanks. Just as long as I don't have to push to get this fix applied anymore. This will be more an issue for the users of the 0.8 branch, anyway, since I run my own version where this patch was applied many moons ago. jamie. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
Everyone that I know of who has tried to reproduce this bug has been able to. I vote that we include this patch in 0.8, so that we can get it out of the way. jamie. pgpEBorFl1kU2.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth cwo...@cworth.org wrote: I'd like to investigate this case a little bit to help answer the question of whether notmuch should have done anything in this case. Hi, Carl. You can see this error if you try to output raw a multipart/* or message/rfc822 part, ie: servo:~ 0$ notmuch show --part=1 --format=raw id:87wrgccedd@yoom.home.cworth.org /dev/null (process:29838): GLib-GObject-WARNING **: invalid cast from `GMimeMultipartSigned' to `GMimePart' (process:29838): gmime-CRITICAL **: g_mime_part_get_content_object: assertion `GMIME_IS_PART (mime_part)' failed servo:~ 0$ Gmime seems to be successfully casting the part into GMimePart and then outputting the content, but it does produce the warning on stderr. jamie. pgpkt4wvMyNal.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On Mon, Jun 27, 2011 at 1:07 PM, Jameson Graef Rollins jroll...@finestructure.net wrote: On Thu, 23 Jun 2011 16:33:18 -0700, Carl Worth cwo...@cworth.org wrote: I'd like to investigate this case a little bit to help answer the question of whether notmuch should have done anything in this case. Hi, Carl. You can see this error if you try to output raw a multipart/* or message/rfc822 part, ie: servo:~ 0$ notmuch show --part=1 --format=raw id:87wrgccedd@yoom.home.cworth.org /dev/null (process:29838): GLib-GObject-WARNING **: invalid cast from `GMimeMultipartSigned' to `GMimePart' (process:29838): gmime-CRITICAL **: g_mime_part_get_content_object: assertion `GMIME_IS_PART (mime_part)' failed servo:~ 0$ Gmime seems to be successfully casting the part into GMimePart and then outputting the content, but it does produce the warning on stderr. Just to clarify my understanding, --format=raw is only intended to work on either the whole message (special-cased in do_show_single) or a leaf MIME part, and in any other case, it will output nothing? The raw output test cases seem pretty thin. (BTW, I believe the show restructuring I have under way should both lift this restriction and eliminate the special case.) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On 06/27/2011 04:43 PM, Austin Clements wrote: Just to clarify my understanding, --format=raw is only intended to work on either the whole message (special-cased in do_show_single) or a leaf MIME part, and in any other case, it will output nothing? The raw output test cases seem pretty thin. I personally think that --format=raw *should* work on non-leaf parts; i don't know if that was the original intent. (BTW, I believe the show restructuring I have under way should both lift this restriction and eliminate the special case.) I hope the tests for this feature can eventually include some weird compound parts with whitespace-wrapped header lines, odd MIME delimiters, character encodings, etc. It would be really good if the --part=whatever --format=raw output produces byte-for-byte identical streams. Both PGP/MIME and S/MIME signatures rely on explicit opacity of the signed MIME parts, so being able to retrieve the signed data precisely would be quite useful for weird corner cases. --dkg signature.asc Description: OpenPGP digital signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
On Mon, 27 Jun 2011 16:43:36 -0400, Austin Clements amdra...@mit.edu wrote: Just to clarify my understanding, --format=raw is only intended to work on either the whole message (special-cased in do_show_single) or a leaf MIME part, and in any other case, it will output nothing? The raw output test cases seem pretty thin. Hey, Austin. The raw part output works for *any* part, be it leaf part, multipart, message/rfc822, etc. I added a bunch of tests for raw part output that should cover all of this, although I don't think they've been pulled into master yet. I think there are a lot of open questions about what should be output for multipart raw. We should output _something_, though. I think we can fix all of this up for 0.7, based on the work you've already done, after 0.6 is released. jamie. pgpQYw4Fq2Dl2.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Do not attept to output part raw if part is not GMimePart.
Quoth Jameson Graef Rollins on Jun 27 at 2:44 pm: On Mon, 27 Jun 2011 16:43:36 -0400, Austin Clements amdra...@mit.edu wrote: Just to clarify my understanding, --format=raw is only intended to work on either the whole message (special-cased in do_show_single) or a leaf MIME part, and in any other case, it will output nothing? The raw output test cases seem pretty thin. Hey, Austin. The raw part output works for *any* part, be it leaf part, multipart, message/rfc822, etc. I added a bunch of tests for raw part output that should cover all of this, although I don't think they've been pulled into master yet. Oh, right, of course. show_message_part will walk into the parts, so format_part_content_raw will still be called on the leafs of a requested multipart. Though, this approach results in each leaf being transfer decoded and printed individually, so if you ask for a multipart, you won't get the raw contents of the multipart (unless it's part 0), so much as you get the concatenated raw contents of each part in the multipart. Daniel, is this the problem that you're getting at with opacity? That if you ask for a multipart, you should effectively get a slice out of the original message bytes (since multipart/* parts can't have non-identity transfer encodings). Are you also saying that should extend to transfer encoded leaf parts, too? I think there are a lot of open questions about what should be output for multipart raw. We should output _something_, though. I think we can fix all of this up for 0.7, based on the work you've already done, after 0.6 is released. Yes, hopefully. That's why I'm making sure I understand the issues here. ]:--8) ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
