Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config
Excerpts from Carl Worth's message of Sat Dec 05 01:56:56 +0100 2009: Cool. At least not everyone thinks I'm crazy then. That's encouraging. :-) I'm not convinced that re-implementing lots of things that autoconf already handles properly portably is the better route to go. It's purely a waste of time. Hence, I'll be happy to send patches to use autoconf, if you change your mind on the subject. Now when you say you hate automake libtool, then I'll wholeheartedly agree with you. -Ingmar -- Exherbo KDE, X.org maintainer ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config
On Sat, 28 Nov 2009 18:57:35 -0500, Jameson Graef Rollins
jroll...@finestructure.net wrote:
This also removes the Makefile.config from the repository, since it
shouldn't be kept in the repository and should be created by the
configure script.
Hi Jamie,
Handling --prefix will be a nice addition to our configure script. So,
thanks!
Your commit message has that flag word of also in it, and as it turns
out, the removal of Makefile.config from the repository has actually
happened already. But that was easy enough to fix.
+# option parsing
+for option; do
+if [ ${option%=*} = '--prefix' ] ; then
+ PREFIX=${option#*=}
+fi
+done
I've gone ahead and committed that now. Then I noticed that we should
really use ${option%%=*} to support the case of an option value
containing an '=' character. So I fixed that.
Then, since I was in the area, I added support to configure for
capturing CFLAGS from the environment, I fixed this (and also make
CFLAGS=) to also influence C++ compilation (still can be separately
overridden with CXXFLAGS), and I fixed our quiet-compilation mode to
actually print the (user-specified) CFLAGS.
Finally, I documented things by adding a configure --help to document
CC, CFLAGS, and --prefix; and by making make tell the user about
./configure and ./configure --help when make runs configure
implicitly.
Our configuration system certainly isn't as full-featured yet as a
standard autoconf-based configure script, but I'm quite happy with how
clean it is for both users and developers.
-Carl
pgp653MkE239C.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config
On Fri, Dec 04, 2009 at 04:12:47PM -0800, Carl Worth wrote:
Handling --prefix will be a nice addition to our configure script. So,
thanks!
Yeah, it's definitely needed for the Debian packaging as well.
Your commit message has that flag word of also in it, and as it turns
out, the removal of Makefile.config from the repository has actually
happened already. But that was easy enough to fix.
I was thinking that the removal of the Makefile.config from the repo
went together with the new auto-generation of that file from configure
script. Do you think they still should have been separate patches?
+# option parsing
+for option; do
+if [ ${option%=*} = '--prefix' ] ; then
+ PREFIX=${option#*=}
+fi
+done
I've gone ahead and committed that now. Then I noticed that we should
really use ${option%%=*} to support the case of an option value
containing an '=' character. So I fixed that.
Ah, good catch. Sorry about that.
Our configuration system certainly isn't as full-featured yet as a
standard autoconf-based configure script, but I'm quite happy with how
clean it is for both users and developers.
Autoconf terrifies me, so I agree I'm quite happy with the simple
configure script we have right now. If it gets the job done without
having to deal with autoconf then that's great in my book.
jamie.
signature.asc
Description: Digital signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly create Makefile.config
On Fri, 4 Dec 2009 19:20:50 -0500, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Your commit message has that flag word of also in it, and as it turns
out, the removal of Makefile.config from the repository has actually
happened already. But that was easy enough to fix.
I was thinking that the removal of the Makefile.config from the repo
went together with the new auto-generation of that file from configure
script. Do you think they still should have been separate patches?
No, it was fine. It's just funny to me how often that word also in a
commit message seems to end up being a predictor for things later, (like
this case where half of a patch is already implemented, or much worse,
how often a bisect lands on a commit that makes multiple changes).
So I was really just expressing amusement at seeing it again.
+# option parsing
+for option; do
+if [ ${option%=*} = '--prefix' ] ; then
+ PREFIX=${option#*=}
+fi
+done
I've gone ahead and committed that now. Then I noticed that we should
really use ${option%%=*} to support the case of an option value
containing an '=' character. So I fixed that.
Ah, good catch. Sorry about that.
No worries. I was just impressed at the tiny amount of code needed for
the parsing here, so ended up looking closer to understand it.
Autoconf terrifies me, so I agree I'm quite happy with the simple
configure script we have right now. If it gets the job done without
having to deal with autoconf then that's great in my book.
Cool. At least not everyone thinks I'm crazy then. That's
encouraging. :-)
-Carl
pgplDoLzToHyz.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
