Re: [Nouveau] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

2017-04-30 0:28 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 6:09 PM, Karol Herbst wrote: >> helps two alien isolation shaders >> >> shader-db: >> total instructions in shared programs : 4251497 -> 4251494 (-0.00%) >> total gprs used in shared programs

[Nouveau] [PATCH v2] nv50/ir: optimize shl(a, 0) to a

38960264 -> 38960232 (-0.00%) localgpr inst bytes helped 0 0 2 2 hurt 0 0 0 0 v2: handle potential mods on src0 Signed-off-by: Karol Herbst Reviewed-by: Samuel Pitoiset Revie

Re: [Nouveau] [PATCH] nv50/ir: optimmize shl(a, 0) to a

2017-04-29 21:03 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 12:46 PM, Karol Herbst wrote: >> helps two alien isolation shaders >> >> shader-db: >> total instructions in shared programs : 4251497 -> 4251494 (-0.00%) >> total gprs used in shared

[Nouveau] [PATCH] nv50/ir: optimmize shl(a, 0) to a

38960264 -> 38960232 (-0.00%) localgpr inst bytes helped 0 0 2 2 hurt 0 0 0 0 Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 5 +

Re: [Nouveau] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

2017-04-29 17:18 GMT+02:00 Ilia Mirkin : > On Sat, Apr 29, 2017 at 10:41 AM, Karol Herbst wrote: >> fixes a crash in Alien Isolation > > What crash? assertion, because shladd requires an immediate, there can't be a reg at src1 "shladd u32 $r0 $r0 $r63 $r36" is inv

[Nouveau] [PATCH] nv50/ir: we can't replace 0x0 with the zero reg for SHLADD

fixes a crash in Alien Isolation Signed-off-by: Karol Herbst Cc: 13.0 17.0 17.1 --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium

[Nouveau] [PATCH] nv50/ir: we can't replace 0x0 with zero reg for SHLADD

fixes a crash in Alien Isolation Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp b/src/gallium/drivers/nouveau/codegen

Re: [Nouveau] [PATCH] drm/nouveau/fb/gf100-: Fix 32 bit wraparound in new ram detection

good catch Reviewed-by: Karol Herbst 2017-04-29 6:11 GMT+02:00 Mario Kleiner : > A missing u64 cast causes a 32-Bit wraparound from > 4096 MiB to 0 MiB and therefore total 0 MiB VRAM detected > if card has 4096 Mib per FBP. > > Signed-off-by: Mario Kleiner > --- > drivers

Re: [Nouveau] [PATCH] drm/nouveau: Add support for clockgating on Fermi+

2017-04-26 20:31 GMT+02:00 Lyude Paul : > On Wed, 2017-04-26 at 00:49 +0200, Karol Herbst wrote: >> Hi Lyude, >> >> thanks for the great work. Just a view comments inline. >> >> 2017-04-25 20:38 GMT+02:00 Lyude : >> > This adds support for enabling aut

Re: [Nouveau] [PATCH] drm/nouveau: Add support for clockgating on Fermi+

Hi Lyude, thanks for the great work. Just a view comments inline. 2017-04-25 20:38 GMT+02:00 Lyude : > This adds support for enabling automatic clockgating on nvidia GPUs for > Fermi and later generations. This saves a little bit of power, bringing > my fermi GPU's power consumption from ~28.3W o

[Nouveau] [PATCH v3] bios/iccsense: rails for power sensors have a mask of 0xf8 for version 0x10

I only saw those values inside the vbios: 0xff, 0xfd, 0xfc, 0xfa for valid rails. No idea what the lower value does, but at least we get power readings on a lot of Fermi GPUs with that. v2: add missing parentheses Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/iccsense.c | 5

[Nouveau] [PATCH v2] bios/iccsense: rails for power sensors have a mask of 0xf8 for version 0x10

I only saw those values inside the vbios: 0xff, 0xfd, 0xfc, 0xfa for valid rails. No idea what the lower value does, but at least we get power readings on a lot of Fermi GPUs with that. v2: add missing parentheses Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/iccsense.c | 5

[Nouveau] [PATCH] bios/iccsense: rails for power sensors have a mask of 0xf8 for version 0x10

I only saw those values inside the vbios: 0xff, 0xfd, 0xfc, 0xfa for valid rails. No idea what the lower value does, but at least we get power readings on a lot of Fermi GPUs with that. Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/iccsense.c | 5 - 1 file changed, 4

[Nouveau] [PATCH] bios/volt: Parse min and max for Version 0x40

This is according to what we have in nvbios. Fixes "ERROR: Can't get value of subfeature in0_min: Can't read" errors in sensors for some GPUs. Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/volt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

Re: [Nouveau] [PATCH v4 2/5] nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string

2017-04-22 11:24 GMT+02:00 Oscar Salvador : > This patch introduces the nouveau_hwmon_ops structure, sets up > .is_visible and .read_string operations and adds all the functions > for these operations. > This is also a preparation for the next patches, where most of the > work is being done. > This

Re: [Nouveau] [PATCH] volt: Improve min/max deteaction of range based volting

2017-04-22 16:46 GMT+02:00 Roy Spliet : > Response in-line: > > > Op 22-04-17 om 13:22 schreef Karol Herbst: >> >> info.min and info.max doesn't always represent the actual voltage range we >> can use. Do the same as with the entry based volting. >> >&

[Nouveau] [PATCH] volt: Improve min/max deteaction of range based volting

info.min and info.max doesn't always represent the actual voltage range we can use. Do the same as with the entry based volting. Fixes "ERROR: Can't get value of subfeature in0_min: Can't read" errors in sensors. Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/

Re: [Nouveau] [PATCH v2 2/5] nouveau_hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string

2017-04-17 9:47 GMT+02:00 Oscar Salvador : > This patch introduces the nouveau_hwmon_ops structure, sets up > .is_visible and .read_string operations and adds all the functions > for these operations. > This is also a preparation for the next patches, where most of the > work is being done. > This

Re: [Nouveau] [PATCH 1/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

2017-04-13 11:08 GMT+02:00 Oscar Salvador : > This patch introduces the structure "struct hwmon_ops" and sets up the > ".visible" operation. > Is also a preparation for the next patch where all work is being done. > > --- linux/drivers/gpu/drm/nouveau/nouveau_hwmon.c.orig 2017-04-12 > 19:22:29

Re: [Nouveau] [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

Also your series got a little messed up, there are two 1/4 patches, and both are different. 2017-04-13 11:07 GMT+02:00 Oscar Salvador : > Hi again, > > I've split the patches as Karol Herbst suggested. > I hope now it's fine. > > This series

Re: [Nouveau] [PATCH 0/4] nouveau_hwmon: migrate to hwmon_device_register_with_info

Hi Oscar, this is a cover letter, there should be no patch attached to it, but a stat of the following patches and an explenation what the series is doing. 2017-04-13 11:07 GMT+02:00 Oscar Salvador : > Hi again, > > I've split the patches as Karol Herbst suggested. > I h

Re: [Nouveau] [PATCH 1/1] nouveau_hwmon: migrate to hwmon_device_register_with_info

thanks for the work, but could you please split that patch? It looks like you are doing several things at once and it isn't really easy to review like this. And it isn't bisectable. If there are clean ups here, please do it in a seperate patch. I highly doubt that it all has to be done within one

[Nouveau] [PATCH v2] bios/perf: Parse PCIe speeds correctly for ver 0x40

v2: 0x21 also means 2.5 GT/s Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/perf.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/bios/perf.c b/drm/nouveau/nvkm/subdev/bios/perf.c index c3068358..3bbb7fed 100644 --- a

[Nouveau] [PATCH] bios/perf: Correctly parse PCIe speeds for ver 0x40

Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/bios/perf.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drm/nouveau/nvkm/subdev/bios/perf.c b/drm/nouveau/nvkm/subdev/bios/perf.c index c3068358..9fdf3736 100644 --- a/drm/nouveau/nvkm/subdev/bios

[Nouveau] [PATCH v2 3/3] nv50/ir: run some passes multiple times

igned-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp| 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp inde

[Nouveau] [PATCH v2 2/3] nv50/ir: handle logops with NOT in AlgebraicOpt

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index bd60a84998..0de84fe9fc

[Nouveau] [PATCH v2 1/3] nv50/ir: fix AlgebraicOpt for slcts with mods

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index 4c92a1efb5

[Nouveau] [PATCH v2 0/3] nv50/ir: Preapre for running Opts inside a loop

Slowly we are getting to the point, that we miss enough optimization opportunities as the result of our own passes. For this we need to fix AlgebraicOpt to be able to handle mods on sources without creating new issues. The last patch enables looping opts. v2: update commit author Karol Herbst

[Nouveau] [PATCH 1/3] nv50/ir: fix AlgebraicOpt for slcts with mods

From: Karol Herbst Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen

[Nouveau] [PATCH 3/3] nv50/ir: run some passes multiple times

From: Karol Herbst With the shader cache, compilation time matters less. As a side effect we can write more optimizations to produce better optimized code. total instructions in shared programs : 3931743 -> 3917512 (-0.36%) total gprs used in shared programs: 481460 -> 481680 (0.05%)

[Nouveau] [PATCH 2/3] nv50/ir: handle logops with NOT in AlgebraicOpt

Signed-off-by: Karol Herbst --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp index bd60a84998..0de84fe9fc

[Nouveau] [PATCH 0/3] nv50/ir: Preapre for running Opts inside a loop

Slowly we are getting to the point, that we miss enough optimization opportunities as the result of our own passes. For this we need to fix AlgebraicOpt to be able to handle mods on sources without creating new issues. The last patch enables looping opts. Karol Herbst (3): nv50/ir: fix

[Nouveau] [PATCH v5 1/5] nv50/ir: restructure and rename postraconstantfolding pass

we might want to add more folding passes here, so make it a bit more generic v2: leave the comment and reword commit message v4: rename it to PostRaLoadPropagation Signed-off-by: Karol Herbst Reviewed-by: Samuel Pitoiset --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 121

[Nouveau] [PATCH v5 4/5] gm107/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) v3: reordered modifiers again v5: no rounding bit for limms Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 34 -- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp

[Nouveau] [PATCH v5 0/5] nvc0/ir: add support for MAD/FMA PostRALoadPropagation

was "nv50/ir: PostRaConstantFolding improvements" before. nothing really changed from the last version, just minor things. Karol Herbst (5): nv50/ir: restructure and rename postraconstantfolding pass nv50/ir: implement mad post ra folding for nvc0+ gk110/ir: add LIMM form of mad

[Nouveau] [PATCH v5 3/5] gk110/ir: add LIMM form of mad

v2: renamed commit reordered modifiers add assert(dst == src2) v3: removed wrong neg mod emission Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 50 ++ .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +- 2 files changed

[Nouveau] [PATCH v5 2/5] nv50/ir: implement mad post ra folding for nvc0+

0 0 0 v2: removed TODO reorderd to show changes without RA modification removed stale debugging print() call v3: remove predicate checks enable only for gf100 ISA Signed-off-by: Karol Herbst --- .../drivers/nouveau/codegen/nv50_ir_peephole.cpp | 51 ++

[Nouveau] [PATCH v5 5/5] nv50/ir: also do PostRaLoadPropagation for FMA

in shared programs : 36061888 -> 36056504 (-0.01%) localgpr inst bytes helped 0 0 228 228 hurt 0 0 0 0 Signed-off-by: Karol Herbst --- src/gallium/drivers/nou

[Nouveau] [PATCH 4/9] clk: Hold information about the current cstate status

Later we will have situations where the expected and the current state isn't the same. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/include/nvkm/subdev/clk.h | 2 ++ drm/nouveau/nvkm/subdev/clk/base.c| 32 +--- 2 files change

[Nouveau] [PATCH 3/9] clk: Make pstate a pointer to nvkm_pstate

We will access the current set cstate at least every second and this safes us some CPU cycles looking them up every second. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/include/nvkm/subdev/clk.h | 4 +++- drm/nouveau/nvkm/engine/device/ctrl.c | 5 - drm/nouveau

[Nouveau] [PATCH 9/9] clk: Check pm_runtime status before reclocking

We don't want to change anything on the GPU if it's suspended. Also we need to increase the refcount on the pm_runtime counter so that the GPU won't be suspended while reclocking. Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/subdev/clk/base.c | 10 +- 1 file change

[Nouveau] [PATCH 1/9] clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it

This function will be used to update the current clock state. This will happen for various reasons: * Temperature changes * User changes clocking state * Load changes Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/clk.h | 1 + drm/nouveau/nvkm/subdev/clk/base.c| 26

[Nouveau] [PATCH 2/9] clk: Remove dstate

We won't need it now, because we will adjust the clocks depending on engine loads later on anyway or a static lockup table. It also simplifies the clocking logic. This code was nowhere used anyway and just a mock up. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/no

[Nouveau] [PATCH 7/9] clk: Only do partial reclocks as required

also for dynamic reclocking. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/nvkm/subdev/clk/base.c | 11 +-- drm/nouveau/nvkm/subdev/clk/gf100.c | 64 - drm/nouveau/nvkm/subdev/clk/gk104.c | 2 +- drm/nouveau/nvkm/subdev/clk/p

[Nouveau] [PATCH 8/9] clk: Set clocks to pre suspend state after suspend

The idea is to clear out the saved state, because after a resume we can't know what the GPU is clocked to. The reclock is triggered by the call to nvkm_clk_update later in nvkm_clk_init. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/nvkm/subdev/clk/base.

[Nouveau] [PATCH 0/9] clk subdev updates

reclocking series I sent months ago, some things have changed though. This is also preparation work of changing the clock state due to temperature changes and dynamic reclocking. Karol Herbst (9): clk: Rename nvkm_pstate_calc to nvkm_clk_update and export it clk: Remove dstate clk: Make pstate a

[Nouveau] [PATCH 6/9] clk: Split out update code to nv40

This code will change for gf100 and newer for partial reclocks. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/nvkm/subdev/clk/base.c | 15 ++- drm/nouveau/nvkm/subdev/clk/g84.c | 1 + drm/nouveau/nvkm/subdev/clk/gf100.c | 1 + drm/nouveau/nvkm/subdev

[Nouveau] [PATCH 5/9] clk: We should pass the pstate id around not the index in the list

This makes the code easier, because we can compare the id with pstate->pstate and safe us the trouble iterating over the entire pstate list to match the index. Signed-off-by: Karol Herbst Reviewed-by: Martin Peres --- drm/nouveau/nouveau_debugfs.c | 6 +-- drm/nouveau/nvkm/subdev/

[Nouveau] [PATCH] pci/g92: Fix rearm

704a6c008b7942bb7f30bb43d2a6bcad7f543662 broke pci msi rearm for g92 GPUs. g92 needs the nv46_pci_msi_rearm, where g94+ gpus used nv40_pci_msi_rearm. Reported-by: Andrew Randrianasulu Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/pci.h | 1 + drm/nouveau/nvkm/engine/device

[Nouveau] [PATCH v4 3/3] hwmon: expose power_max and power_crit

Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_hwmon.c | 44 1 file changed, 44 insertions(+) diff --git a/drm/nouveau/nouveau_hwmon.c b/drm/nouveau/nouveau_hwmon.c index d762b8af..23b1670c 100644 --- a/drm/nouveau/nouveau_hwmon.c +++ b/drm

[Nouveau] [PATCH v4 2/3] subdev/iccsense: Parse max and crit power level

Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c| 20 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev

[Nouveau] [PATCH v4 0/3] Expose power budget cap via hwmon

cap field set in the vbios. This series keeps things really simple for now until we figure out more about the power budget table and are able to parse the power cap for vbios without that field set. v3: big rework of the actual vbios parsing to prevent memory leakage and silly memory handling v4:

[Nouveau] [PATCH v4 1/3] nvbios/power_budget: Add basic power budget parsing

v2: Set entry to 0xff if not found Add cap entry for ver 0x30 tables Rework to fix memory leak v3: More error checks Simplify check for invalid entries v4: disable for ver 0x10 for now move assignments after the second last return Signed-off-by: Karol Herbst --- .../include/nvkm

Re: [Nouveau] GSOC project

Hi, I think a nice project would be to write an application to figure out those latencies automatically maybe even based on envydis. It could generate latency information based on thread count, register usage, instruction/instruction class, hw unit used. Or even tries to figure out what kind o

Re: [Nouveau] Erros and warning using kernel 4.10-rc2

could you grab the vbios from /sys/kernel/debug/dri/1/vbios.rom and maybe also do a mmiotrace with the nvidia driver (using bumblebee or second X server by hand or so)? thanks 2017-01-08 19:22 GMT+01:00 Marcos Paulo de Souza : > Hi guys, > > I don't know if it is useful to just post some random k

[Nouveau] Fwd: [PATCH 0/2] Enable changing PCIe link on G92

ping on that series -- Forwarded message -- From: Karol Herbst Date: 2016-11-20 0:43 GMT+01:00 Subject: [PATCH 0/2] Enable changing PCIe link on G92 To: nouveau@lists.freedesktop.org one rename and one enable patch. Tested on hardware and confirmed with traces Karol Herbst (2

Re: [Nouveau] [PATCH] drm/nouveau: fix unknown chipset for GTX 1060

we already have that included in 4.10 2016-12-12 12:26 GMT+01:00 Chris Chiu : > Nouveau driver shows unknown chipset (136000a1) for GTX 1060, so it > only gives VGA resolution on screen. Use the same chipset as nv134 > then it shows FullHD. This commit copies fields from nv134_chipset > to nv136_c

[Nouveau] Fosdem 2017

Hi everybody, I try to get off from 2nd to 7th February to attend Fosdem. Anybody planning to come as well? Greetings ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] GM108GLM?

glmark2 shows aver 100% improvement to ~550 FPS. > > Interestingly, it's still nowhere near a match for the built-in > Broadwell-U with i915, which runs at ~1400 - ~1900 FPS. > > Thank you very much - I'll keep a look-out for future improvements :-) > > Best regards,

Re: [Nouveau] GM108GLM?

ges, but I still get a soft cpu lockup. > > What info would you need from me to get it working? > > Best regards, > > Sune Mølgaard > > > On 2016-12-08 08:10, Karol Herbst wrote: >> hi, >> >> give the drm-next kernel tree a try. Sadly the reclocking improvements

Re: [Nouveau] GM108GLM?

hi, give the drm-next kernel tree a try. Sadly the reclocking improvements didn't land with 4.9, so 4.10 is required. Greetings. On 7 December 2016 10:26:44 a.m. GMT+01:00, "Sune Mølgaard" wrote: >Hi again, > >It works :-) > >Reclocking, however, is another kettle of fish. > >Trying #echo 0f

Re: [Nouveau] [PATCH v3 1/3] nvbios/power_budget: Add basic power budget parsing

2016-12-01 0:15 GMT+01:00 Ben Skeggs : > On 12/01/2016 08:56 AM, Karol Herbst wrote: >> 2016-11-30 23:48 GMT+01:00 Ben Skeggs : >>> On 12/01/2016 05:48 AM, Karol Herbst wrote: >>>> v2: Set entry to 0xff if not found >>>> Add cap entry for ver 0x30

Re: [Nouveau] [PATCH v3 1/3] nvbios/power_budget: Add basic power budget parsing

2016-11-30 23:56 GMT+01:00 Karol Herbst : > 2016-11-30 23:48 GMT+01:00 Ben Skeggs : >> On 12/01/2016 05:48 AM, Karol Herbst wrote: >>> v2: Set entry to 0xff if not found >>> Add cap entry for ver 0x30 tables >>> Rework to fix memory leak >>> v3:

Re: [Nouveau] [PATCH v3 1/3] nvbios/power_budget: Add basic power budget parsing

2016-11-30 23:48 GMT+01:00 Ben Skeggs : > On 12/01/2016 05:48 AM, Karol Herbst wrote: >> v2: Set entry to 0xff if not found >> Add cap entry for ver 0x30 tables >> Rework to fix memory leak >> v3: More error checks >> Simplify check for invalid entries

[Nouveau] [PATCH v3 2/3] subdev/iccsense: Parse max and crit power level

Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c| 20 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev

[Nouveau] [PATCH v3 0/3] Expose power budget cap via hwmon

power cap field set in the vbios. This series keeps things really simple for now until we figure out more about the power budget table. v3: big rework of the actual vbios parsing to prevent memory leakage and silly memory handling Karol Herbst (3): nvbios/power_budget: Add basic power budget

[Nouveau] [PATCH v3 1/3] nvbios/power_budget: Add basic power budget parsing

v2: Set entry to 0xff if not found Add cap entry for ver 0x30 tables Rework to fix memory leak v3: More error checks Simplify check for invalid entries Signed-off-by: Karol Herbst --- .../include/nvkm/subdev/bios/power_budget.h| 25 + drm/nouveau/nvkm/subdev/bios/Kbuild

[Nouveau] [PATCH v3 3/3] hwmon: expose power_max and power_crit

Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_hwmon.c | 44 1 file changed, 44 insertions(+) diff --git a/drm/nouveau/nouveau_hwmon.c b/drm/nouveau/nouveau_hwmon.c index 71f764bf..3d4672ae 100644 --- a/drm/nouveau/nouveau_hwmon.c +++ b/drm

[Nouveau] [PATCH 2/2] pci/g92: Enable changing pcie link speeds

Tested on a G92, seems to work. Confirmed by 8 mmiotraces. Signed-off-by: Karol Herbst --- drm/nouveau/nvkm/engine/device/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drm/nouveau/nvkm/engine/device/base.c b/drm/nouveau/nvkm/engine/device/base.c index 7307ee1f

[Nouveau] [PATCH 0/2] Enable changing PCIe link on G92

one rename and one enable patch. Tested on hardware and confirmed with traces Karol Herbst (2): pci: Rename g94 to g92 pci/g92: Enable changing pcie link speeds drm/nouveau/include/nvkm/subdev/pci.h| 2 +- drm/nouveau/nvkm/engine/device/base.c| 22

[Nouveau] [PATCH 1/2] pci: Rename g94 to g92

Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/pci.h| 2 +- drm/nouveau/nvkm/engine/device/base.c| 20 ++-- drm/nouveau/nvkm/subdev/pci/Kbuild | 2 +- drm/nouveau/nvkm/subdev/pci/{g94.c => g92.c} | 10 +- drm/nouveau/n

Re: [Nouveau] [PATCH 1/3] nvbios/power_budget: Add basic power budget parsing

2016-11-12 12:58 GMT+01:00 Pierre Moreau : > On 11:55 am - Nov 12 2016, Karol Herbst wrote: >> v2: Set entry to 0xff if not found >> Add cap entry for ver 0x30 tables >> Rework to fix memory leak >> >> Signed-off-by: Karol Herbst >> --- >>

[Nouveau] [PATCH 3/3] hwmon: expose power_max and power_crit

Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_hwmon.c | 44 1 file changed, 44 insertions(+) diff --git a/drm/nouveau/nouveau_hwmon.c b/drm/nouveau/nouveau_hwmon.c index 71f764b..3d4672a 100644 --- a/drm/nouveau/nouveau_hwmon.c +++ b/drm

[Nouveau] [PATCH 2/3] subdev/iccsense: Parse max and crit power level

Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c| 20 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev

[Nouveau] [PATCH 0/3] Expose power budget cap via hwmon

power cap field set in the vbios. This series keeps things really simple for now until we figure out more about the power budget table. Karol Herbst (3): nvbios/power_budget: Add basic power budget parsing subdev/iccsense: Parse max and crit power level hwmon: expose power_max and power_crit

[Nouveau] [PATCH 1/3] nvbios/power_budget: Add basic power budget parsing

v2: Set entry to 0xff if not found Add cap entry for ver 0x30 tables Rework to fix memory leak Signed-off-by: Karol Herbst --- .../include/nvkm/subdev/bios/power_budget.h| 24 drm/nouveau/nvkm/subdev/bios/Kbuild| 1 + drm/nouveau/nvkm/subdev/bios

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 17:12 GMT+01:00 Arnd Bergmann : > On Tuesday, November 8, 2016 5:07:01 PM CET Lukas Wunner wrote: >> On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: >> > The underlying problem is that we already have a number of other >> > symbols that either have "depends on LEDS_CLASS"

Re: [Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 16:46 GMT+01:00 Ilia Mirkin : > On Tue, Nov 8, 2016 at 8:56 AM, Arnd Bergmann wrote: >> The newly introduced LED handling for nouveau fails to link when the >> driver is built-in but the LED subsystem is a loadable module: >> >> drivers/gpu/drm/nouveau/nouveau.o: In function `nouveau_do

Re: [Nouveau] Atomic modesetting + DisplayPort MST

another issue: whenever I stop X with your patches, the display becomes black and the display disabled. Works with 4.8.4 2016-11-04 10:41 GMT+01:00 Ben Skeggs : > Hey all, > > I've just pushed out the initial Nouveau support for $subject \o/ > > As the atomic modesetting transition is basically a

Re: [Nouveau] Atomic modesetting + DisplayPort MST

okay, I managed to bisect this issue and it comes down to this commit: https://github.com/skeggsb/linux/commit/f6795bda9c2ee8173398533cab355fe259a9c1f1 with that commit, a 00ed EDID is read out and using that display fails. It's a display connected with a miniDP to DVI listed as "DP-1" in xrandr

Re: [Nouveau] Atomic modesetting + DisplayPort MST

Hi Ben, with your 4.10 tree on my NVAC nouveau can't find the EDID with a passive miniDP to DVI adapter. It used to work before. miniDVI to VGA works. 2016-11-04 10:41 GMT+01:00 Ben Skeggs : > Hey all, > > I've just pushed out the initial Nouveau support for $subject \o/ > > As the atomic modeset

[Nouveau] [PATCH] nouveau: remove unused variables

I am a little unsure about the change in nouveau_fence, maybe somebody with more knowledge about the code can look into it? Signed-off-by: Karol Herbst --- drm/nouveau/dispnv04/arb.c| 6 ++ drm/nouveau/nouveau_fence.c | 2 -- drm/nouveau/nvkm/subdev/fb/ramgk104.c | 4

Re: [Nouveau] [PATCH 2/3] fb/gk20a: use regular gf100's functions

looks good Reviewed-By: Karol Herbst 2016-10-27 9:55 GMT+02:00 Alexandre Courbot : > gk20a's FB is not special compared to other Kepler chips, besides the > fact it does not have VRAM. Use the regular gf100 hooks instead of the > incomplete versions we rewrote. > > Sign

Re: [Nouveau] [PATCH 3/3] fb: add gm20b device

Reviewed-By: Karol Herbst 2016-10-27 9:55 GMT+02:00 Alexandre Courbot : > gm20b's FB has the same capabilities as gm200, minus the ability to > allocate RAM. Create a device that reflects this instead of re-using the > gk20a device which may be incorrect. > > Signed-off-b

Re: [Nouveau] noveau: emergency shutdown handling is overcomplex and broken

Thanks for the pointer. But I don't like this patch. If you find a bug, make a bug report or just fix it if you know the fix already. Or write something in IRC. Or write on the Mailing list as a general question or something else But I really don't agree on doing it this way. You would have neede

Re: [Nouveau] [PATCH 3/3] hwmon: expose power_max and power_crit

On 25 October 2016 7:33:08 a.m. GMT+02:00, Martin Peres wrote: >On 25/10/16 00:11, Karol Herbst wrote: >> Signed-off-by: Karol Herbst >> --- >> drm/nouveau/nouveau_hwmon.c | 44 > >> 1 file changed, 44 insertions(+)

Re: [Nouveau] [PATCH 2/3] subdev/iccsense: Parse max and crit power level

On 25 October 2016 7:28:10 a.m. GMT+02:00, Martin Peres wrote: >On 25/10/16 00:11, Karol Herbst wrote: >> Signed-off-by: Karol Herbst >> --- >> drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ >> drm/nouveau/nvkm/subdev/iccsense/base.c| 13 ++

Re: [Nouveau] [PATCH 1/3] nvbios/power_budget: Add basic power budget parsing

On 25 October 2016 7:25:46 a.m. GMT+02:00, Martin Peres wrote: >On 25/10/16 00:11, Karol Herbst wrote: >> Signed-off-by: Karol Herbst >> --- >> .../include/nvkm/subdev/bios/power_budget.h| 20 >> drm/nouveau/nvkm/subdev/bios/Kbuild|

[Nouveau] [PATCH 2/3] subdev/iccsense: Parse max and crit power level

Signed-off-by: Karol Herbst --- drm/nouveau/include/nvkm/subdev/iccsense.h | 3 +++ drm/nouveau/nvkm/subdev/iccsense/base.c| 13 - 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drm/nouveau/include/nvkm/subdev/iccsense.h b/drm/nouveau/include/nvkm/subdev

[Nouveau] [PATCH 3/3] hwmon: expose power_max and power_crit

Signed-off-by: Karol Herbst --- drm/nouveau/nouveau_hwmon.c | 44 1 file changed, 44 insertions(+) diff --git a/drm/nouveau/nouveau_hwmon.c b/drm/nouveau/nouveau_hwmon.c index 71f764b..3d4672a 100644 --- a/drm/nouveau/nouveau_hwmon.c +++ b/drm

[Nouveau] RFC [PATCH 0/3] Expose power budget cap via hwmon

GPUs, but first, just export those values through hwmon. First design, will change stuff, want comments. Thanks. Karol Herbst (3): nvbios/power_budget: Add basic power budget parsing subdev/iccsense: Parse max and crit power level hwmon: expose power_max and power_crit .../include/nvkm/s

[Nouveau] [PATCH 1/3] nvbios/power_budget: Add basic power budget parsing

Signed-off-by: Karol Herbst --- .../include/nvkm/subdev/bios/power_budget.h| 20 drm/nouveau/nvkm/subdev/bios/Kbuild| 1 + drm/nouveau/nvkm/subdev/bios/power_budget.c| 108 + 3 files changed, 129 insertions(+) create mode 100644 drm

Re: [Nouveau] [PATCH] nouveau: hide gcc-4.9 -Wmaybe-uninitialized

uhh, that function looks so odd, ... yeah. Change looks fine. Reviewed-By: Karol Herbst 2016-10-24 17:30 GMT+02:00 Arnd Bergmann : > gcc-4.9 notices that the validate_init() function returns unintialized > data when called with a zero 'nr_buffers' argument, when called wi

Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

2016-10-24 9:13 GMT+02:00 Baoyou Xie : > > > On 23 October 2016 at 01:32, Karol Herbst wrote: >> >> I think it would be better to squash those commits: >> 1. for the includes >> 2. for static declerations >> > OK, I have resent new patch that squash tho

Re: [Nouveau] [PATCH 01/17] drm/nouveau/core: add missing header dependencies

I think it would be better to squash those commits: 1. for the includes 2. for static declerations 2016-10-22 11:41 GMT+02:00 Baoyou Xie : > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:34:1: warning: no previous > prototype for 'nvkm_firmware_ge

Re: [Nouveau] NVAC "No Signal"

2016-10-19 16:47 GMT+02:00 poma : > On 18.10.2016 16:02, Karol Herbst wrote: >> well, I just don't want that this fix breaks the same thing for other >> users, that's why I am asking. >> > > Affected device ID: > https://github.com/skeggsb/nouveau/blob/mas

Re: [Nouveau] NVAC "No Signal"

well, I just don't want that this fix breaks the same thing for other users, that's why I am asking. 2016-10-18 13:56 GMT+02:00 poma : > On 18.10.2016 09:35, Karol Herbst wrote: >> how sure are you, that this is needed for _every_ nvac? >> > > Thank you for

Re: [Nouveau] NVAC "No Signal"

how sure are you, that this is needed for _every_ nvac? 2016-10-18 5:55 GMT+02:00 poma : > Fixes "No Signal" via HDMI from NVIDIA Corporation ION VGA (rev b1) > > Ref. > "drm/nouveau/disp/g94: implement workaround for dvi issue on fx380" > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linu

Re: [Nouveau] Nouveau on a Jetson TK1 problems

2016-10-17 5:48 GMT+02:00 Ilia Mirkin : > On Sun, Oct 16, 2016 at 11:39 PM, C Bergström > wrote: >> Is there any particular reason you're not using the open source NVIDIA >> Tegra drivers? >> >> This is what is being used for the TX1 (Sorry I don't know if it's the >> same for the TK1) >> http://

Re: [Nouveau] [PATCH v5 0/3] drm/nouveau: set DMA mask before mapping scratch page

Hi Ard, the official nouveau tree is here: https://github.com/skeggsb/nouveau But ben usually takes care of everything if you post the patches on the ML. No idea what you discussed internally though, but alex also posts his suff here. On 16 Oct 2016 22:12, "Ard Biesheuvel" wrote: On 7 October

<    3   4   5   6   7   8   9   10   11   12   >